status-im/eth2.0-specs
2
0
Fork 0
mirror of https://github.com/status-im/eth2.0-specs.git synced 2025-02-17 21:16:52 +00:00
Code Issues Projects Releases Wiki Activity

Reduce GENESIS_SLOT to 2**32

Browse Source 
* Address the slot/epoch underflow problem, even for Java implementers! 🎉
* Squash a bug with `get_previous_epoch`
* Fix #642
* Address #626 (Vitalik, Danny, myself agree that avoiding signed integers is probably best)
This commit is contained in:
Justin 2019-02-19 21:08:10 +00:00 committed by GitHub
parent a3d85c8405
commit 9b7b35bc9d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
specs/core/0_beacon-chain.md
View File

@ -212,7 +212,7 @@ Code snippets appearing in `this style` are to be interpreted as Python code.
| Name | Value | | Name | Value |
| - | - | | - | - |
| `GENESIS_FORK_VERSION` | `0` | | `GENESIS_FORK_VERSION` | `0` |
| `GENESIS_SLOT` | `2**63` | | `GENESIS_SLOT` | `2**32` |
| `GENESIS_EPOCH` | `slot_to_epoch(GENESIS_SLOT)` | | `GENESIS_EPOCH` | `slot_to_epoch(GENESIS_SLOT)` |
| `GENESIS_START_SHARD` | `0` | | `GENESIS_START_SHARD` | `0` |
| `FAR_FUTURE_EPOCH` | `2**64 - 1` | | `FAR_FUTURE_EPOCH` | `2**64 - 1` |
@ -688,12 +688,8 @@ def slot_to_epoch(slot: Slot) -> Epoch:
def get_previous_epoch(state: BeaconState) -> Epoch: def get_previous_epoch(state: BeaconState) -> Epoch:
"""` """`
Return the previous epoch of the given ``state``. Return the previous epoch of the given ``state``.
If the current epoch is ``GENESIS_EPOCH``, return ``GENESIS_EPOCH``.
""" """
current_epoch = get_current_epoch(state) return get_current_epoch(state) - 1
if current_epoch == GENESIS_EPOCH:
return GENESIS_EPOCH
return current_epoch - 1
``` ```
### `get_current_epoch` ### `get_current_epoch`