status-im
/
eth2.0-specs
mirror of https://github.com/status-im/eth2.0-specs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Apply suggestions from code review 

Co-authored-by: Alex Stokes <r.alex.stokes@gmail.com>
This commit is contained in:
Hsiao-Wei Wang 2024-05-07 18:30:28 +08:00 committed by GitHub
parent 9c1acbb5e5
commit 950136c50d
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
specs/_features/eip7594/das-core.md
View File

@ -106,19 +106,19 @@ def get_custody_columns(node_id: NodeID, custody_subnet_count: uint64) -> Sequen
assert custody_subnet_count <= DATA_COLUMN_SIDECAR_SUBNET_COUNT assert custody_subnet_count <= DATA_COLUMN_SIDECAR_SUBNET_COUNT
subnet_ids: List[uint64] = [] subnet_ids: List[uint64] = []
tmp_id = uint256(node_id) i = uint256(node_id)
while len(subnet_ids) < custody_subnet_count: while len(subnet_ids) < custody_subnet_count:
# Overflow prevention # Overflow prevention
if tmp_id == UINT256_MAX: if i == UINT256_MAX:
tmp_id = NodeID(0) i = NodeID(0)
subnet_id = ( subnet_id = (
bytes_to_uint64(hash(uint_to_bytes(uint256(tmp_id)))[0:8]) bytes_to_uint64(hash(uint_to_bytes(uint256(i)))[0:8])
% DATA_COLUMN_SIDECAR_SUBNET_COUNT % DATA_COLUMN_SIDECAR_SUBNET_COUNT
) )
if subnet_id not in subnet_ids: if subnet_id not in subnet_ids:
subnet_ids.append(subnet_id) subnet_ids.append(subnet_id)
tmp_id += 1 i += 1
assert len(subnet_ids) == len(set(subnet_ids)) assert len(subnet_ids) == len(set(subnet_ids))