mirror of
https://github.com/status-im/eth2.0-specs.git
synced 2025-02-16 12:36:25 +00:00
Apply suggestions from code review
Co-Authored-By: djrtwo <dannyjryan@gmail.com>
This commit is contained in:
parent
53eb2d0368
commit
7f720133fa
@ -77,7 +77,7 @@ def test_finality_from_genesis_rule_4(state):
|
|||||||
test_state = deepcopy(state)
|
test_state = deepcopy(state)
|
||||||
|
|
||||||
blocks = []
|
blocks = []
|
||||||
for epoch in range(6):
|
for epoch in range(4):
|
||||||
prev_state, new_blocks, test_state = next_epoch_with_attestations(test_state, True, False)
|
prev_state, new_blocks, test_state = next_epoch_with_attestations(test_state, True, False)
|
||||||
blocks += new_blocks
|
blocks += new_blocks
|
||||||
|
|
||||||
@ -88,7 +88,7 @@ def test_finality_from_genesis_rule_4(state):
|
|||||||
elif epoch == 2:
|
elif epoch == 2:
|
||||||
check_finality(test_state, prev_state, True, False, False)
|
check_finality(test_state, prev_state, True, False, False)
|
||||||
elif epoch >= 3:
|
elif epoch >= 3:
|
||||||
# rule 4 of finaliy
|
# rule 4 of finality
|
||||||
check_finality(test_state, prev_state, True, True, True)
|
check_finality(test_state, prev_state, True, True, True)
|
||||||
assert test_state.finalized_epoch == prev_state.current_justified_epoch
|
assert test_state.finalized_epoch == prev_state.current_justified_epoch
|
||||||
assert test_state.finalized_root == prev_state.current_justified_root
|
assert test_state.finalized_root == prev_state.current_justified_root
|
||||||
@ -137,10 +137,10 @@ def test_finality_rule_2(state):
|
|||||||
if epoch == 0:
|
if epoch == 0:
|
||||||
prev_state, new_blocks, test_state = next_epoch_with_attestations(test_state, True, False)
|
prev_state, new_blocks, test_state = next_epoch_with_attestations(test_state, True, False)
|
||||||
check_finality(test_state, prev_state, True, False, False)
|
check_finality(test_state, prev_state, True, False, False)
|
||||||
if epoch == 1:
|
elif epoch == 1:
|
||||||
prev_state, new_blocks, test_state = next_epoch_with_attestations(test_state, False, False)
|
prev_state, new_blocks, test_state = next_epoch_with_attestations(test_state, False, False)
|
||||||
check_finality(test_state, prev_state, False, True, False)
|
check_finality(test_state, prev_state, False, True, False)
|
||||||
if epoch == 2:
|
elif epoch == 2:
|
||||||
prev_state, new_blocks, test_state = next_epoch_with_attestations(test_state, False, True)
|
prev_state, new_blocks, test_state = next_epoch_with_attestations(test_state, False, True)
|
||||||
# finalized by rule 2
|
# finalized by rule 2
|
||||||
check_finality(test_state, prev_state, True, False, True)
|
check_finality(test_state, prev_state, True, False, True)
|
||||||
|
Loading…
x
Reference in New Issue
Block a user