PR feedback

This commit is contained in:
Danny Ryan 2019-11-05 09:00:04 -07:00
parent 600265a311
commit 40a21dc3ad
No known key found for this signature in database
GPG Key ID: 2765A792E42CE07A
2 changed files with 2 additions and 9 deletions

View File

@ -62,7 +62,6 @@ The following are the broad design goals for Ethereum 2.0:
## For spec contributors ## For spec contributors
Documentation on the different components used during spec writing can be found here: Documentation on the different components used during spec writing can be found here:
* [YAML Test Generators](test_generators/README.md) * [YAML Test Generators](test_generators/README.md)
* [Executable Python Spec, with Py-tests](test_libs/pyspec/README.md) * [Executable Python Spec, with Py-tests](test_libs/pyspec/README.md)

View File

@ -54,7 +54,6 @@
- [`hash_tree_root`](#hash_tree_root) - [`hash_tree_root`](#hash_tree_root)
- [`signing_root`](#signing_root) - [`signing_root`](#signing_root)
- [`bls_verify`](#bls_verify) - [`bls_verify`](#bls_verify)
- [`bls_verify_multiple`](#bls_verify_multiple)
- [`bls_aggregate_pubkeys`](#bls_aggregate_pubkeys) - [`bls_aggregate_pubkeys`](#bls_aggregate_pubkeys)
- [Predicates](#predicates) - [Predicates](#predicates)
- [`is_active_validator`](#is_active_validator) - [`is_active_validator`](#is_active_validator)
@ -542,10 +541,6 @@ def bytes_to_int(data: bytes) -> uint64:
`bls_verify` is a function for verifying a BLS signature, as defined in the [BLS Signature spec](../bls_signature.md#bls_verify). `bls_verify` is a function for verifying a BLS signature, as defined in the [BLS Signature spec](../bls_signature.md#bls_verify).
#### `bls_verify_multiple`
`bls_verify_multiple` is a function for verifying a BLS signature constructed from multiple messages, as defined in the [BLS Signature spec](../bls_signature.md#bls_verify_multiple).
#### `bls_aggregate_pubkeys` #### `bls_aggregate_pubkeys`
`bls_aggregate_pubkeys` is a function for aggregating multiple BLS public keys into a single aggregate key, as defined in the [BLS Signature spec](../bls_signature.md#bls_aggregate_pubkeys). `bls_aggregate_pubkeys` is a function for aggregating multiple BLS public keys into a single aggregate key, as defined in the [BLS Signature spec](../bls_signature.md#bls_aggregate_pubkeys).
@ -1432,9 +1427,8 @@ def process_attester_slashing(state: BeaconState, attester_slashing: AttesterSla
assert is_valid_indexed_attestation(state, attestation_2) assert is_valid_indexed_attestation(state, attestation_2)
slashed_any = False slashed_any = False
attesting_indices_1 = attestation_1.attesting_indices indices = set(attestation_1.attesting_indices).intersection(attestation_2.attesting_indices)
attesting_indices_2 = attestation_2.attesting_indices for index in sorted(indices):
for index in sorted(set(attesting_indices_1).intersection(attesting_indices_2)):
if is_slashable_validator(state.validators[index], get_current_epoch(state)): if is_slashable_validator(state.validators[index], get_current_epoch(state)):
slash_validator(state, index) slash_validator(state, index)
slashed_any = True slashed_any = True