status-im/eth2.0-specs
2
0
Fork 0
mirror of https://github.com/status-im/eth2.0-specs.git synced 2025-02-17 21:16:52 +00:00
Code Issues Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source
This commit is contained in:
Danny Ryan 2021-09-24 06:23:59 -06:00 committed by GitHub
parent c9c7ab7289
commit 35a42c9d45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
specs/merge/client-settings.md
View File

@ -22,7 +22,7 @@ Except under exceptional scenarios, this setting is expected to not be used. Suf
### Override terminal block hash ### Override terminal block hash
To allow for fork coordination around a specific PoW block, clients must also provide `--terminal-block-hash-override` as a configurable setting. To allow for transition coordination around a specific PoW block, clients must also provide `--terminal-block-hash-override` as a configurable setting.
The value provided by this setting takes precedence over the pre-configured `TERMINAL_BLOCK_HASH` parameter. The value provided by this setting takes precedence over the pre-configured `TERMINAL_BLOCK_HASH` parameter.
Except under exceptional scenarios, this setting is expected to not be used. Sufficient warning to the user about this exceptional configurable setting should be provided. Except under exceptional scenarios, this setting is expected to not be used. Sufficient warning to the user about this exceptional configurable setting should be provided.

2
specs/merge/validator.md
View File

@ -76,7 +76,7 @@ def get_pow_block_at_terminal_total_difficulty(pow_chain: Sequence[PowBlock]) ->
def get_terminal_pow_block(pow_chain: Sequence[PowBlock]) -> Optional[PowBlock]: def get_terminal_pow_block(pow_chain: Sequence[PowBlock]) -> Optional[PowBlock]:
if TERMINAL_BLOCK_HASH != Hash32(): if TERMINAL_BLOCK_HASH != Hash32():
# Check block hash override prior to total difficulty # Terminal lock hash override takes precedence over terminal total difficulty
pow_block_overrides = [pow_block for pow_block in pow_chain if pow_block.block_hash == TERMINAL_BLOCK_HASH] pow_block_overrides = [pow_block for pow_block in pow_chain if pow_block.block_hash == TERMINAL_BLOCK_HASH]
if len(pow_block_overrides) != 0: if len(pow_block_overrides) != 0:
return pow_block_overrides[0] return pow_block_overrides[0]