status-im
/
eth2.0-specs
mirror of https://github.com/status-im/eth2.0-specs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

add REWARD_OVERFLOW_INCREMENT to avoid overflow in rewards calculation

This commit is contained in:
Danny Ryan 2020-03-03 09:29:59 -07:00
parent a14708afcb
commit 2d4ec7d52f
No known key found for this signature in database
GPG Key ID: 2765A792E42CE07A
2 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
specs/phase0/beacon-chain.md
View File

@ -194,6 +194,7 @@ The following values are (non-configurable) constants used throughout the specif
| `MAX_EFFECTIVE_BALANCE` | `Gwei(2**5 * 10**9)` (= 32,000,000,000) | | `MAX_EFFECTIVE_BALANCE` | `Gwei(2**5 * 10**9)` (= 32,000,000,000) |
| `EJECTION_BALANCE` | `Gwei(2**4 * 10**9)` (= 16,000,000,000) | | `EJECTION_BALANCE` | `Gwei(2**4 * 10**9)` (= 16,000,000,000) |
| `EFFECTIVE_BALANCE_INCREMENT` | `Gwei(2**0 * 10**9)` (= 1,000,000,000) | | `EFFECTIVE_BALANCE_INCREMENT` | `Gwei(2**0 * 10**9)` (= 1,000,000,000) |
| `REWARD_OVERFLOW_INCREMENT` | `Gwei(2**6)` (= 64) |
### Initial values ### Initial values
@ -1313,7 +1314,9 @@ def get_attestation_deltas(state: BeaconState) -> Tuple[Sequence[Gwei], Sequence
attesting_balance = get_total_balance(state, unslashed_attesting_indices) attesting_balance = get_total_balance(state, unslashed_attesting_indices)
for index in eligible_validator_indices: for index in eligible_validator_indices:
if index in unslashed_attesting_indices: if index in unslashed_attesting_indices:
rewards[index] += get_base_reward(state, index) * attesting_balance // total_balance increment = REWARD_OVERFLOW_INCREMENT # Factored out from reward numerator to avoid uint64 overflow
reward_numerator = get_base_reward(state, index) // increment * attesting_balance
rewards[index] = reward_numerator // total_balance * increment
else: else:
penalties[index] += get_base_reward(state, index) penalties[index] += get_base_reward(state, index)

7
tests/core/pyspec/eth2spec/test/phase_0/epoch_processing/test_process_rewards_and_penalties.py
View File

@ -1,7 +1,10 @@
from copy import deepcopy from copy import deepcopy
from eth2spec.test.context import spec_state_test, with_all_phases, spec_test, \ from eth2spec.test.context import (
misc_balances, with_custom_state, default_activation_threshold, single_phase spec_state_test, with_all_phases, spec_test,
misc_balances, with_custom_state, default_activation_threshold,
single_phase,
)
from eth2spec.test.helpers.state import ( from eth2spec.test.helpers.state import (
next_epoch, next_epoch,
next_slot, next_slot,