status-im/eth2.0-specs
2
0
Fork 0
mirror of https://github.com/status-im/eth2.0-specs.git synced 2025-01-29 11:54:51 +00:00
Code Issues Projects Releases Wiki Activity

Resolve the commented out code in test_new_finalized_slot_is_not_justified_checkpoint_ancestor

Browse Source
This commit is contained in:
Hsiao-Wei Wang 2021-11-18 11:02:12 +08:00
parent 3d4ece44df
commit 2c865e3627
No known key found for this signature in database
GPG Key ID: 1111A8A81778319E
1 changed files with 10 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
tests/core/pyspec/eth2spec/test/phase0/fork_choice/test_on_block.py
View File

@ -618,20 +618,19 @@ def test_new_finalized_slot_is_not_justified_checkpoint_ancestor(spec, state):
assert state.finalized_checkpoint != another_state.finalized_checkpoint assert state.finalized_checkpoint != another_state.finalized_checkpoint
assert state.current_justified_checkpoint != another_state.current_justified_checkpoint assert state.current_justified_checkpoint != another_state.current_justified_checkpoint
# pre_store_justified_checkpoint_root = store.justified_checkpoint.root pre_store_justified_checkpoint_root = store.justified_checkpoint.root
# FIXME: pending on the `on_block`, `on_attestation` fix # Apply blocks of `another_state` to `store`
# # Apply blocks of `another_state` to `store` for block in all_blocks:
# for block in all_blocks: # NOTE: Do not call `on_tick` here
# # NOTE: Do not call `on_tick` here yield from add_block(spec, store, block, test_steps)
# yield from add_block(spec, store, block, test_steps)
# finalized_slot = spec.compute_start_slot_at_epoch(store.finalized_checkpoint.epoch) finalized_slot = spec.compute_start_slot_at_epoch(store.finalized_checkpoint.epoch)
# ancestor_at_finalized_slot = spec.get_ancestor(store, pre_store_justified_checkpoint_root, finalized_slot) ancestor_at_finalized_slot = spec.get_ancestor(store, pre_store_justified_checkpoint_root, finalized_slot)
# assert ancestor_at_finalized_slot != store.finalized_checkpoint.root assert ancestor_at_finalized_slot != store.finalized_checkpoint.root
# assert store.finalized_checkpoint == another_state.finalized_checkpoint assert store.finalized_checkpoint == another_state.finalized_checkpoint
# assert store.justified_checkpoint == another_state.current_justified_checkpoint assert store.justified_checkpoint == another_state.current_justified_checkpoint
yield 'steps', test_steps yield 'steps', test_steps