status-im
/
eth2.0-specs
mirror of https://github.com/status-im/eth2.0-specs.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

Apply suggestions from code review 

Co-Authored-By: djrtwo <dannyjryan@gmail.com>
This commit is contained in:
Hsiao-Wei Wang 2019-03-07 10:03:25 -07:00 committed by GitHub
parent 987c741bea
commit 250455a67e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
specs/core/0_beacon-chain.md
View File

@ -1899,7 +1899,7 @@ def process_attestation(state: BeaconState, attestation: Attestation) -> None:
data=attestation.data, data=attestation.data,
aggregation_bitfield=attestation.aggregation_bitfield, aggregation_bitfield=attestation.aggregation_bitfield,
custody_bitfield=attestation.custody_bitfield, custody_bitfield=attestation.custody_bitfield,
inclusion_slot=state.slot inclusion_slot=state.slot,
) )
if slot_to_epoch(attestation.data.slot) == get_current_epoch(state): if slot_to_epoch(attestation.data.slot) == get_current_epoch(state):
state.current_epoch_attestations.append(pending_attestation) state.current_epoch_attestations.append(pending_attestation)
@ -2057,7 +2057,7 @@ def get_winning_root_and_participants(state: BeaconState, shard: Shard) -> Tuple
if len(all_roots) == 0: if len(all_roots) == 0:
return ZERO_HASH, [] return ZERO_HASH, []
def get_attestations_for(root) -> List[PendingAttestation]: def get_attestations_for(root: Bytes32) -> List[PendingAttestation]:
return [a for a in valid_attestations if a.data.crosslink_data_root == root] return [a for a in valid_attestations if a.data.crosslink_data_root == root]
# Winning crosslink root is the root with the most votes for it, ties broken in favor of # Winning crosslink root is the root with the most votes for it, ties broken in favor of
@ -2134,7 +2134,7 @@ Run the following function:
```python ```python
def process_crosslinks(state: BeaconState) -> None: def process_crosslinks(state: BeaconState) -> None:
current_epoch = get_current_epoch(state) current_epoch = get_current_epoch(state)
previous_epoch = current_epoch - 1 previous_epoch = get_previous_epoch(state)
next_epoch = current_epoch + 1 next_epoch = current_epoch + 1
for slot in range(get_epoch_start_slot(previous_epoch), get_epoch_start_slot(next_epoch)): for slot in range(get_epoch_start_slot(previous_epoch), get_epoch_start_slot(next_epoch)):
for crosslink_committee, shard in get_crosslink_committees_at_slot(state, slot): for crosslink_committee, shard in get_crosslink_committees_at_slot(state, slot):
@ -2144,7 +2144,7 @@ def process_crosslinks(state: BeaconState) -> None:
if 3 * participating_balance >= 2 * total_balance: if 3 * participating_balance >= 2 * total_balance:
state.latest_crosslinks[shard] = Crosslink( state.latest_crosslinks[shard] = Crosslink(
epoch=slot_to_epoch(slot), epoch=slot_to_epoch(slot),
crosslink_data_root=winning_root crosslink_data_root=winning_root,
) )
``` ```