Apply suggestions from @djrtwo code review

Co-authored-by: Danny Ryan <dannyjryan@gmail.com>
This commit is contained in:
Hsiao-Wei Wang 2021-03-12 20:40:29 +08:00 committed by GitHub
parent 9254f1bf8c
commit 23b28b62d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 7 deletions

View File

@ -13,11 +13,11 @@ bls_setting: int -- see general test-format spec.
### `anchor_state.ssz_snappy` ### `anchor_state.ssz_snappy`
A YAML-encoded `BeaconState`, the state to initialize store with `get_forkchoice_store(anchor_state: BeaconState, anchor_block: BeaconBlock)` helper. An SSZ-snappy encoded `BeaconState`, the state to initialize store with `get_forkchoice_store(anchor_state: BeaconState, anchor_block: BeaconBlock)` helper.
### `anchor_block.ssz_snappy` ### `anchor_block.ssz_snappy`
A YAML-encoded `BeaconBlock`, the block to initialize store with `get_forkchoice_store(anchor_state: BeaconState, anchor_block: BeaconBlock)` helper. An SSZ-snappy encoded `BeaconBlock`, the block to initialize store with `get_forkchoice_store(anchor_state: BeaconState, anchor_block: BeaconBlock)` helper.
### `steps.yaml` ### `steps.yaml`
@ -85,17 +85,17 @@ For example:
`<32-byte-root>` is the hash tree root of the given attestation. `<32-byte-root>` is the hash tree root of the given attestation.
Each file is a YAML-encoded `Attestation`. Each file is an SSZ-snappy encoded `Attestation`.
### `block_<32-byte-root>.ssz_snappy` ### `block_<32-byte-root>.ssz_snappy`
`<32-byte-root>` is the hash tree root of the given block. `<32-byte-root>` is the hash tree root of the given block.
Each file is a YAML-encoded `SignedBeaconBlock`. Each file is an SSZ-snappy encoded `SignedBeaconBlock`.
## Condition ## Condition
1. Deserialize `anchor_state.ssz_snappy` and `anchor_block.ssz_snappy` to initialize the local store object by with `get_forkchoice_store(anchor_state, anchor_block)` helper. 1. Deserialize `anchor_state.ssz_snappy` and `anchor_block.ssz_snappy` to initialize the local store object by with `get_forkchoice_store(anchor_state, anchor_block)` helper.
2. Go through `steps.yaml` 2. Iterate sequentially through `steps.yaml`
- For each execution, look up the corresponding ssz_snappy file. Execute the corresponding helper function on your store. - For each execution, look up the corresponding ssz_snappy file. Execute the corresponding helper function on the current store.
- For each `checks` step, the assertions must be satisfied. - For each `checks` step, the assertions on the current store must be satisfied.