Merge pull request #1980 from ethereum/hwwhww/use-hash-tree-root-for-shard-body

Use `hash_tree_root` to generate shard block body root

configs/mainnet/phase1.yaml

@@ -69,8 +69,6 @@ EARLY_DERIVED_SECRET_PENALTY_MAX_FUTURE_EPOCHS: 32768
 EPOCHS_PER_CUSTODY_PERIOD: 16384
 # 2**11 (= 2,048) epochs, ~9 days
 CUSTODY_PERIOD_TO_RANDAO_PADDING: 2048
-# 2**14 (= 16,384) epochs
-CUSTODY_RESPONSE_DEADLINE: 16384
 # 2**15 (= 32,768) epochs, ~146 days
 MAX_CHUNK_CHALLENGE_DELAY: 32768
 

configs/minimal/phase1.yaml

@@ -66,15 +66,13 @@ DOMAIN_LIGHT_AGGREGATE_AND_PROOF: 0x85000000
 # 2**1 (= 2) epochs
 RANDAO_PENALTY_EPOCHS: 2
 # [customized] quicker for testing
-EARLY_DERIVED_SECRET_PENALTY_MAX_FUTURE_EPOCHS: 128
+EARLY_DERIVED_SECRET_PENALTY_MAX_FUTURE_EPOCHS: 64
 # [customized] quicker for testing
-EPOCHS_PER_CUSTODY_PERIOD: 64
+EPOCHS_PER_CUSTODY_PERIOD: 32
 # [customized] quicker for testing
 CUSTODY_PERIOD_TO_RANDAO_PADDING: 8
-# [customized] quicker for testing
-CUSTODY_RESPONSE_DEADLINE: 128
 # [customize for faster testing]
-MAX_CHUNK_CHALLENGE_DELAY: 128
+MAX_CHUNK_CHALLENGE_DELAY: 64
 
 
 # Misc parameters

setup.py

@@ -225,12 +225,6 @@ get_attesting_indices = cache_this(
 
 PHASE1_SUNDRY_FUNCTIONS = '''
 
-def get_block_data_merkle_root(data: ByteList) -> Root:
-    # To get the Merkle root of the block data, we need the Merkle root without the length mix-in
-    # The below implements this in the Remerkleable framework
-    return Root(data.get_backing().get_left().merkle_root())
-
-
 _get_start_shard = get_start_shard
 get_start_shard = cache_this(
     lambda state, slot: (state.validators.hash_tree_root(), slot),

specs/phase1/custody-game.md

@@ -25,7 +25,6 @@
     - [`CustodyKeyReveal`](#custodykeyreveal)
     - [`EarlyDerivedSecretReveal`](#earlyderivedsecretreveal)
 - [Helpers](#helpers)
-  - [`get_block_data_merkle_root`](#get_block_data_merkle_root)
   - [`replace_empty_or_append`](#replace_empty_or_append)
   - [`legendre_bit`](#legendre_bit)
   - [`get_custody_atoms`](#get_custody_atoms)
@@ -73,7 +72,6 @@ This document details the beacon chain additions and changes in Phase 1 of Ether
 | `EPOCHS_PER_CUSTODY_PERIOD` | `2**14` (= 16,384) | epochs | ~73 days |
 | `CUSTODY_PERIOD_TO_RANDAO_PADDING` | `2**11` (= 2,048) | epochs | ~9 days |
 | `MAX_CHUNK_CHALLENGE_DELAY` | `2**15` (= 32,768) | epochs | ~146 days |
-| `CHUNK_RESPONSE_DEADLINE` | `2**14` (= 16,384) | epochs | ~73 days |
 
 ### Max operations per block
 
@@ -127,7 +125,7 @@ class CustodyChunkResponse(Container):
     challenge_index: uint64
     chunk_index: uint64
     chunk: ByteVector[BYTES_PER_CUSTODY_CHUNK]
-    branch: Vector[Root, CUSTODY_RESPONSE_DEPTH]
+    branch: Vector[Root, CUSTODY_RESPONSE_DEPTH + 1]
 ```
 
 #### `CustodySlashing`
@@ -180,13 +178,8 @@ class EarlyDerivedSecretReveal(Container):
     mask: Bytes32
 ```
 
-
 ## Helpers
 
-### `get_block_data_merkle_root`
-
-`get_block_data_merkle_root(data: ByteList) -> Root` is the function that returns the Merkle root of the block data without the length mix-in.
-
 ### `replace_empty_or_append`
 
 ```python
@@ -381,7 +374,7 @@ def process_chunk_challenge_response(state: BeaconState,
     assert is_valid_merkle_branch(
         leaf=hash_tree_root(response.chunk),
         branch=response.branch,
-        depth=CUSTODY_RESPONSE_DEPTH,
+        depth=CUSTODY_RESPONSE_DEPTH + 1,  # Add 1 for the List length mix-in
         index=response.chunk_index,
         root=challenge.data_root,
     )
@@ -522,12 +515,8 @@ def process_custody_slashing(state: BeaconState, signed_custody_slashing: Signed
     shard_transition = custody_slashing.shard_transition
     assert hash_tree_root(shard_transition) == attestation.data.shard_transition_root
     # Verify that the provided data matches the shard-transition
-    assert (
-        get_block_data_merkle_root(custody_slashing.data)
-        == shard_transition.shard_data_roots[custody_slashing.data_index]
-    )
     assert len(custody_slashing.data) == shard_transition.shard_block_lengths[custody_slashing.data_index]
-
+    assert hash_tree_root(custody_slashing.data) == shard_transition.shard_data_roots[custody_slashing.data_index]
     # Verify existence and participation of claimed malefactor
     attesters = get_attesting_indices(state, attestation.data, attestation.aggregation_bits)
     assert custody_slashing.malefactor_index in attesters

specs/phase1/validator.md

@@ -294,7 +294,7 @@ def get_shard_transition_fields(
     for slot in offset_slots:
         if slot in shard_block_slots:
             shard_block = shard_blocks[shard_block_slots.index(slot)]
-            shard_data_roots.append(get_block_data_merkle_root(shard_block.message.body))
+            shard_data_roots.append(hash_tree_root(shard_block.message.body))
         else:
             shard_block = SignedShardBlock(message=ShardBlock(slot=slot, shard=shard))
             shard_data_roots.append(Root())

tests/core/pyspec/eth2spec/test/helpers/custody.py

@@ -113,7 +113,7 @@ def get_valid_chunk_challenge(spec, state, attestation, shard_transition, data_i
 def custody_chunkify(spec, x):
     chunks = [bytes(x[i:i + spec.BYTES_PER_CUSTODY_CHUNK]) for i in range(0, len(x), spec.BYTES_PER_CUSTODY_CHUNK)]
     chunks[-1] = chunks[-1].ljust(spec.BYTES_PER_CUSTODY_CHUNK, b"\0")
-    return chunks
+    return [ByteVector[spec.BYTES_PER_CUSTODY_CHUNK](c) for c in chunks]
 
 
 def build_proof(anchor, leaf_index):
@@ -149,12 +149,14 @@ def get_valid_custody_chunk_response(spec, state, chunk_challenge, challenge_ind
 
     chunk_index = chunk_challenge.chunk_index
 
-    data_branch = build_proof(custody_data_block.get_backing().get_left(), chunk_index + 2**spec.CUSTODY_RESPONSE_DEPTH)
+    leaf_index = chunk_index + 2**spec.CUSTODY_RESPONSE_DEPTH
+    serialized_length = len(custody_data_block).to_bytes(32, 'little')
+    data_branch = build_proof(custody_data_block.get_backing().get_left(), leaf_index) + [serialized_length]
 
     return spec.CustodyChunkResponse(
         challenge_index=challenge_index,
         chunk_index=chunk_index,
-        chunk=ByteVector[spec.BYTES_PER_CUSTODY_CHUNK](chunks[chunk_index]),
+        chunk=chunks[chunk_index],
         branch=data_branch,
     )
 
@@ -165,7 +167,7 @@ def get_custody_test_vector(bytelength, offset=0):
 
 
 def get_sample_shard_transition(spec, start_slot, block_lengths):
-    b = [spec.get_block_data_merkle_root(ByteList[spec.MAX_SHARD_BLOCK_SIZE](get_custody_test_vector(x)))
+    b = [spec.hash_tree_root(ByteList[spec.MAX_SHARD_BLOCK_SIZE](get_custody_test_vector(x)))
          for x in block_lengths]
     shard_transition = spec.ShardTransition(
         start_slot=start_slot,
@@ -200,5 +202,5 @@ def get_custody_slashable_shard_transition(spec, start_slot, block_lengths, cust
     slashable_test_vector = get_custody_slashable_test_vector(spec, custody_secret,
                                                               block_lengths[0], slashable=slashable)
     block_data = ByteList[spec.MAX_SHARD_BLOCK_SIZE](slashable_test_vector)
-    shard_transition.shard_data_roots[0] = spec.get_block_data_merkle_root(block_data)
+    shard_transition.shard_data_roots[0] = spec.hash_tree_root(block_data)
     return shard_transition, slashable_test_vector

tests/core/pyspec/eth2spec/test/phase1/block_processing/test_process_chunk_challenge.py

@@ -248,6 +248,35 @@ def test_custody_response(spec, state):
     yield from run_custody_chunk_response_processing(spec, state, custody_response)
 
 
+@with_all_phases_except([PHASE0])
+@spec_state_test
+def test_custody_response_chunk_index_2(spec, state):
+    transition_to(spec, state, state.slot + spec.SLOTS_PER_EPOCH)
+
+    shard = 0
+    offset_slots = spec.get_offset_slots(state, shard)
+    shard_transition = get_sample_shard_transition(spec, state.slot, [2**15 // 3] * len(offset_slots))
+    attestation = get_valid_on_time_attestation(spec, state, index=shard, signed=True,
+                                                shard_transition=shard_transition)
+
+    transition_to(spec, state, state.slot + spec.MIN_ATTESTATION_INCLUSION_DELAY)
+
+    _, _, _ = run_attestation_processing(spec, state, attestation)
+
+    transition_to(spec, state, state.slot + spec.SLOTS_PER_EPOCH * (spec.EPOCHS_PER_CUSTODY_PERIOD - 1))
+
+    challenge = get_valid_chunk_challenge(spec, state, attestation, shard_transition, chunk_index=2)
+
+    _, _, _ = run_chunk_challenge_processing(spec, state, challenge)
+
+    chunk_challenge_index = state.custody_chunk_challenge_index - 1
+
+    custody_response = get_valid_custody_chunk_response(
+        spec, state, challenge, chunk_challenge_index, block_length_or_custody_data=2**15 // 3)
+
+    yield from run_custody_chunk_response_processing(spec, state, custody_response)
+
+
 @with_all_phases_except([PHASE0])
 @spec_state_test
 def test_custody_response_multiple_epochs(spec, state):

tests/core/pyspec/eth2spec/test/phase1/block_processing/test_process_custody_slashing.py

@@ -124,7 +124,7 @@ def test_multiple_epochs_custody(spec, state):
 @with_all_phases_except([PHASE0])
 @spec_state_test
 def test_many_epochs_custody(spec, state):
-    yield from run_standard_custody_slashing_test(spec, state, shard_lateness=spec.SLOTS_PER_EPOCH * 10)
+    yield from run_standard_custody_slashing_test(spec, state, shard_lateness=spec.SLOTS_PER_EPOCH * 5)
 
 
 @with_all_phases_except([PHASE0])