c83b6dde60
Handle geth process exit via crash/kill and also via killing `embark blockchain`
...
First case - run `embark run` which starts a blockchain node, then manually kill the `geth` process. Would throw `{ [Error: connect ECONNREFUSED 127.0.0.1:8543] message: 'connect ECONNREFUSED 127.0.0.1:8543', code: -32603 }` error and ruins the dashboard.
Second case, 1) run `embark blockchain` 2) run `embark run` 3) kill `embark blockchain` throws the error `{ [Error: connect ECONNREFUSED 127.0.0.1:8543] message: 'connect ECONNREFUSED 127.0.0.1:8543', code: -32603 }` and ruins the dashboard.
The first case was solved by having the child blockchain process that spawns geth listen for geth exit, then kill itself.
The second case required updating of `eth-block-tracker` to v4.0.1 inside of the `embark-web3-provider-engine`. v4.0.1 was a major version update and introduced breaking changes. Those changes were handled inside of `embark-web3-provider-engine`, covered in **blocker** PR https://github.com/jrainville/provider-engine/pull/1 .
2018-10-23 09:01:13 +02:00
8db33705c2
hotfix: rename event to blockchain:ready
2018-10-22 20:50:58 +02:00
b6d89d9001
hotfix: fix empty assets array
2018-10-22 20:26:01 +02:00
559c7152f7
Return early when error
2018-10-22 19:54:50 +02:00
178115de18
Removed `mineWhenNeeded` condition
...
Removed a condition that detects if `mineWhenNeeded === true`. While reaslistically, the `defaultAccount` will only be populated when `mineWhenNeeded` is set, there is no need to check for this when falling back to the blockchain account.
2018-10-22 19:54:50 +02:00
294e14446f
Auto set swarm account to account controlled by the node
...
When there is no account/password specified for swarm, there was an error shown in the logs (asking for address/password), and the swarm process would quit.
This PR changes the behaviour so that if a swarm address/password are not specified in the config, it attempts to use the blockchain address/password specified in `config/blockchain > account`. If `config/blockchain > account > address` doesn’t exist, the first account controlled by the node is used (provided by `web3.eth.getAccounts`, along with the password from `config/blockchain > account > password`.
2018-10-22 19:54:50 +02:00
3437f80a89
Return early if no modified assets
2018-10-22 19:54:50 +02:00
5b1a226885
Update null check for `modifiedAssets` array.
...
Co-Authored-By: emizzle <ericmastro@status.im>
2018-10-22 19:54:49 +02:00
7c9d90090a
Replaced async.queue with async.cargo
...
Cargo in fact, bundles up subsequent tasks in to an array, so any tasks that are not immediately run get bundled in to another run later. This helps when lots of changes have been made in a short period of time.
2018-10-22 19:54:49 +02:00
e788b7d3d4
Reduce async.queue concurrency to 3
...
Due to a process being spawned for every pipeline run, concurrency should remain around 3 to keep number of child processes from running away and allowing the CPU to stay on top.
2018-10-22 19:54:49 +02:00
6eae7a9a31
use a customized require/.resolve instead of relying on NODE_PATH
...
# Conflicts:
# cmd/cmd.js
2018-10-22 19:54:49 +02:00
64fdc691c4
Clean up
2018-10-22 19:54:49 +02:00
91e5e9c990
Do not run webpack for file changes that do not need webpack
...
For file changes that do not require a webpack run, ie HTML, the assets will still be copied to the output directory, but webpack will not run (as it’s too slow).
2018-10-22 19:54:48 +02:00
7e75b1eee7
Add support for ES6 plugins
2018-10-22 19:54:48 +02:00
2d19d12e39
Support for embark-status plugin
...
Added request to update cors from a plugin (affects blockchain client and storage client).
2018-10-22 19:54:48 +02:00
870d9a814a
[f] Fixes #965 - "Console doesnt have contract objects for contracts with pre-defined addresses configured".
...
[f] Fix for sometimes incorrect empty code detection in contract_deployer.js ("0x" vs "0x0").
2018-10-22 19:54:48 +02:00
985358b088
fix web3 being reseted every test and fix ens failing on web3 reset
2018-10-22 19:54:48 +02:00
ce3f9bdf25
fix a couple of bugs caused by bounties
2018-10-22 19:54:48 +02:00
7a70f5df26
use constants instead of magic numbers
2018-10-22 19:54:47 +02:00
fe0b84349a
update noserver and nobrowser and fix noserver
2018-10-22 19:54:47 +02:00
75d9998c57
refactor to not use the blockchain_connector directly
2018-10-22 19:54:47 +02:00
e450c0484a
fix error in solc-tests
2018-10-22 19:54:46 +02:00
c6aa19a772
use this instead of self
2018-10-22 19:54:46 +02:00
ac9dbdd1d6
conflict in test
2018-10-22 19:54:46 +02:00
ac155ddb86
conflict in specialconfigs
2018-10-22 19:54:46 +02:00
f4d7636b7a
make code coverage work with refactored tests
2018-10-22 19:54:45 +02:00
7516bad619
use blockchain_connector's provider for nodes
2018-10-22 19:54:45 +02:00
5a5485d447
get rid of dependency on web3
2018-10-22 19:54:45 +02:00
ddc8b36329
make tests work by using events
2018-10-22 19:54:45 +02:00
ca3aea7923
BROKEN: solc doesnt load
2018-10-22 19:54:45 +02:00
3c0bcb18b8
rename events to use a tests prefix
2018-10-22 19:54:44 +02:00
e8574f33eb
conflict in run_tests
2018-10-22 19:54:44 +02:00
e6cad1675a
move test files to a module folder
2018-10-22 19:54:44 +02:00
7104c18b83
Only disable optimizations with coverage.
...
This means that any test runs without coverage will run optimized
Solidity code instead.
2018-10-22 19:54:44 +02:00
27973461b1
In case of ws, use the connected attribute
...
Instead of relying on non reliable source, directly
check the ws status
2018-10-22 19:54:44 +02:00
47dcb1552c
console, dashboard: Add persistent, automatically loaded history.
...
Add persistent automatically loaded history file for repl console
and Embark dashboard.
Default location of the history file is stored in DEFAULT_CMD_HISTORY_PATH
pointing to DAPP_PATH/.embark/cmd_history.
The history is automatically saved and loaded on startup.
test/console: Pass Embark object to constructor.
Update console test to pass Embark object to constructor.
Refs: https://github.com/embark-framework/embark/issues/939
2018-10-22 19:54:43 +02:00
5fe746df51
Add message warning user a password is needed to unlock
...
When `mineWhenNeeded` is true (occurs in zero-config) and an account on the node exists, a password is required to be specified `config/blockchain.js > account > password` so that the existing account can be unlocked by geth (the `—unlock` cli option).
2018-10-22 19:54:43 +02:00
898ecfe293
Accept standard Ether units and update/add tests
2018-10-22 19:54:43 +02:00
4812a0d1a2
additional warning re: potential version incompatibility
2018-10-22 19:53:50 +02:00
f686fec74a
ens resolve
2018-10-22 19:53:50 +02:00
0f6e84bca3
return in the catch branch so the control flow is more clear
2018-10-22 19:53:49 +02:00
b9e592ae2e
color retry message yellow
2018-10-22 19:53:49 +02:00
1f47b163e4
auto-retry download with master branch
...
a fallback download of the master branch is attempted only for unqualified
template names
2018-10-22 19:53:49 +02:00
81e798c89c
Add support for Parity
...
Addons
- New chain initialization and genesis management
- Option to choose client to use
- Option to "ping forever" for Geth
- Creation and unlock of accounts at client's start
- Utility to fund accounts with ethers
- Miner settings inside the ethereum client
- Workaround to CORS problem: origin is now http://embark
- Several double callback's checks
Updates
- Boilerplate, templates, configuration files and demo stuff
- Messages and i18n strings
- Tests
Fixes
- Geth client now uses miner.gastarget instead of the deprecated targetGasLimit
- Workaround for shh_version with Parity
Reworks of other PRs into the new code
- Included delayed proxy
- Send ready only when the proxy is started
- Start HTTP and WS proxies individually
- Async setupProxy
- Fixed datadir for GethMiner
2018-10-22 19:53:49 +02:00
cc08a16ae3
calc a <major>.<minor> branch for unqualified template names
...
doesn't calc a branch if a url/shortcut is supplied that hostedGitInfo knows
how to parse
only does this for unqualified names if a committish isn't supplied, i.e.
doesn't override '#develop' in 'typescript#develop'
2018-10-22 19:43:16 +02:00
d7cd3a72c9
add message at the end of the first ouput
2018-10-22 19:43:15 +02:00
9c0bff4515
remove console dir that I forgot to remove
2018-10-22 19:40:52 +02:00
80c80e9beb
fix(commands/build): don't start blockchain node when `--contracts` is used
...
Prior to this commit `$ embark build --contracts` spinned up a blockchain node
which is not necessary as `--contracts` can be seen as a "compile only" option.
This commit ensures we don't start any web3 services with `--contracts` is used.
2018-10-22 19:40:52 +02:00
fd856f8163
PKG_PATH, pkgPath
2018-10-22 19:39:26 +02:00
f41bcd55d6
[f] Fix for #971 - "Fatal error when Ethereum node going offline".
...
[a] Added .once() into Events.
2018-10-22 19:39:26 +02:00
08c140b035
added webserver logging
2018-10-22 19:39:25 +02:00
51b2cce0ea
adds dashboard logging for: geth, ipfs, swarm
2018-10-22 19:39:25 +02:00
ee77ac7f7f
Adds solc option to tests. Runs smart contract tests using remix-tests
...
Ref: #817
2018-10-22 19:39:24 +02:00
f71c158164
change 70000 for a constant
2018-10-22 19:35:59 +02:00
d34428a129
refactor(modules/pipeline/webpackProcess): load pipeline config in Config class
...
to configure pipeline specific options like TypeScript support.
At the time this has been added, `core/config` didn't handle the loading
of configuration files for pipeline related tasks yet.
This commit ensures a dapp's `pipeline.json` will be loaded and used to
configure Embark's webpack process as part of Embark's `Config` initialization.
2018-10-22 19:35:59 +02:00
71e92358a8
feat(modules/watcher): introduce watcher plugin module
...
As part of a bigger refactoring to make Embark's build pipeline pluggable,
this commit moves the watcher into its own plugin module so it can be
consumed via Embark's event bus.
It also introduces new command handlers for all watcher related APIs respectively:
- watcher:start
- watcher:stop
- watcher:restart
2018-10-22 19:35:58 +02:00
081b7eee89
chore(blockchainProcess): improve error message when blockchain client exits early
...
In cases a blockchain client exits before Embark is done doing its work,
the current error message doesn't provide any pointers to why this
happened.
Running `$ embark blockchain` separately could yield more information by
the underlying process.
2018-10-22 19:35:58 +02:00
5f8ad923c7
use an event to get web3 instead of global
2018-10-22 19:35:58 +02:00
a0ef234fea
feat(modules/pipeline): move pipeline into its own module plugin
...
This is the first step of refactoring Embark's pipeline abstraction into
dedicated plugin modules that take advantage of Embark's event system.
With this commit we're moving `Pipeline` into `lib/modules/pipeline` and
introduce a new command handler `pipeline:build`. Embark's engine now
requests builds via this command handler.
Notice that `Watch` still lives in `lib/pipeline` as this is a step-by-step
refactoring to reduce chances of introducing regressions.
2018-10-22 19:35:58 +02:00
6b4321874b
add helpful messages when ens register is rejected
2018-10-22 19:35:58 +02:00
623bdc50ae
make on deploy manual
2018-10-22 19:35:57 +02:00
bcc1711061
contract_deployer: Redeploy if track field is set to false.
...
Always deploy the contract regardless if already deployed
when 'track' field in the contract configuration is specified
and set to false.
In line with #938 requirements:
* If a contract has the track field set to false, that contract
will always deploy.
* If the track field is set to true, then the existing deployment
tracking mechanism will be active for that contract.
* If the field is not set, it should be assumed to true by default
Refs: https://github.com/embark-framework/embark/issues/938
2018-10-22 19:35:57 +02:00
115bf1387d
fix chunking problem related to dynamic import and bug re: umd
2018-10-22 19:35:57 +02:00
0c60d2e1b4
per latest babel-preset-react-app exclue transform-typeof-symbol
2018-10-22 19:35:57 +02:00
b971f5bcec
in comments provide links to relevant tag not a commit
2018-10-22 19:35:57 +02:00
e7aa9de8f3
TODO comment re: pipeline config
2018-10-22 19:35:56 +02:00
a898bbdf18
don't waste time gzip'ing contents of babel-loader's cache
2018-10-22 19:35:56 +02:00
09734d7879
call path.basename w/ extension name to avoid e.g. `.js.1.js`
2018-10-22 19:35:56 +02:00
882271dc60
rev file name to better reflect its purpose
2018-10-22 19:35:56 +02:00
ae878fd7c8
extract copy/preserve logic into a helper in lib/core/fs
...
preserved files should end with <number>.<ext> vs. <ext>.<number>
2018-10-22 19:35:55 +02:00
67347ae08e
babel-loader should process .ts, .tsx files when typescript is enabled
2018-10-22 19:35:55 +02:00
059635979d
pipeline.js dapp config to allow easy toggling of typescript
2018-10-22 19:35:55 +02:00
6534c30200
rev comment to provide more context/clarity
2018-10-22 19:35:55 +02:00
7e7b050ae7
raise exception if both Flow and TypeScript are enabled
2018-10-22 19:35:54 +02:00
4aedeeee9b
TypeScript support -- disabled by default
2018-10-22 19:35:54 +02:00
8c6b26f311
babel plugins, presets and their configs per babel-preset-react-app
2018-10-22 19:35:54 +02:00
6986d33da9
don't need quotes
2018-10-22 19:35:54 +02:00
6181808381
customize babel-loader behavior -- don't try to cache babel macros
2018-10-22 19:35:53 +02:00
b09e702403
enabel babel-loader's default cache directory
2018-10-22 19:35:53 +02:00
aa90a2c870
can use use: shortcuts for .css
2018-10-22 19:35:53 +02:00
34a3d75542
proper loader for sass (scss)
2018-10-22 19:35:53 +02:00
d14f1a80a2
comment re: adaptation from babel-preset-react-app
2018-10-22 19:35:53 +02:00
39821d2617
explain babel plugin, preset order
2018-10-22 19:35:52 +02:00
e2c18e6338
default webpack-overrides.js
2018-10-22 19:35:52 +02:00
eaafa9bed2
add default account if set in config
2018-10-22 19:35:04 +02:00
0fb0fa0648
remove process.exits
2018-10-22 19:35:03 +02:00
eae7784a87
fix rebase problems and now works
2018-10-22 19:35:03 +02:00
c0d32e3581
use known addresses for ENSRegistrery
2018-10-22 19:35:03 +02:00
3245a65100
conflict in ens index
2018-10-22 19:35:03 +02:00
0c0624e463
conflict in ens index
2018-10-22 19:35:03 +02:00
302da3f263
conflict in ens index
2018-10-22 19:35:03 +02:00
3e9abdcdd2
fix rebase
2018-10-22 19:33:40 +02:00
9aa3217331
After upload message regarding CORS and public gateways
2018-10-22 19:30:13 +02:00
967703a333
restore ws functionality to webserver
2018-10-22 19:30:12 +02:00
5917e0cb5a
Add browser reload on file change/rebuild
...
Add browser reload on file change/rebuild
2018-10-22 19:30:12 +02:00
f378ea55da
fix rebase #2
2018-10-22 19:30:12 +02:00
58ba0549c4
Fix rebase
2018-10-22 19:30:12 +02:00
381cdaa57a
fixed windows paths
2018-10-22 19:25:20 +02:00
743c4fa8cb
Update “no account” message and hide for infura
...
The “no account” message was appearing when using infura as the contract deploy target. This has been changed so that this message will only show when the user has configured their environment to have a `networkType` of `testnet`, `rinkeby`, or `mainnet` and a missing `account` address and/or password.
Additionally, the warning message has been updated to help the user resolve the issue.
A flag has also been added to prevent the message from appearing multiple times.
2018-10-22 19:25:20 +02:00
58a75f5080
restore ws functionality to webserver
2018-10-22 19:25:19 +02:00
3dbf0d3742
Add browser reload on file change/rebuild
...
Add browser reload on file change/rebuild
2018-10-22 19:25:19 +02:00
109152730f
Add remapping when parse file to support embark-solc
2018-10-22 19:25:19 +02:00
bdd5852b6c
Fix git merging badly
2018-10-22 19:25:19 +02:00
e13c0b3724
[a] Added applyArgumentPlugins before _determineArguments in ContractDeployer for plugins that calculate arguments dynamically.
...
[m] Made possible for deploy:contract:beforeDeploy plugin to modify arguments list.
2018-10-22 19:25:18 +02:00
10bf3e4412
cmd, cmd_controller, graph: Add --output option to graph.
...
Add optional --output argument to graph generator. The argument allows
to specify a filepath for graph output. Default filepath is ./diagram.svg
if the argument is not specified.
Refs: https://github.com/embark-framework/embark/issues/944
2018-10-22 19:25:18 +02:00
0483920421
cmd, run_tests: Add --nobrowser option for runCoverage.
...
Do not start browser during coverage run when --nobrowser option is passed.
Refs: https://github.com/embark-framework/embark/issues/941
2018-10-22 19:25:18 +02:00
3d089a7a53
Fix linting
2018-10-22 19:25:18 +02:00
bf7f4db179
Account for empty initialization in loops
2018-10-22 19:25:18 +02:00
f79834a30d
extracted hardcoded string in constant
2018-10-22 19:25:17 +02:00
517365353b
improved error message when there is issue communicating with node
2018-10-22 19:25:17 +02:00
34cafc77e8
webserver: Emit websocket outputError and show error on the landing page.
...
Whenever outputError is emitted by Ember, display error message on the landing page
and stop the page from refreshing every four seconds.
Refs: https://github.com/embark-framework/embark/issues/946
2018-10-22 19:25:17 +02:00
78c5055902
contracts_manager, deployment: Emit outputError whenever build error or deployment error happens.
...
Emit outputError when:
* contracts cannot be built
* contracts cannot be deployed
Refs: https://github.com/embark-framework/embark/issues/946
2018-10-22 19:25:17 +02:00
64c6f58497
add ENS console commands
2018-10-22 19:25:17 +02:00
7e12f80eda
Address PR feedback
2018-10-22 19:25:16 +02:00
dd8c6b9a35
Add missing config
...
The configuration for test is not passed via the engine
2018-10-22 19:25:16 +02:00
850a80c90c
ENS config use the actual network ID
...
Instead of relying on the name of network.
Fetch the real network id and configure ENS
based on that value
2018-10-22 19:25:16 +02:00
684839b5aa
Use broadcast to avoid useless send
2018-10-22 19:25:16 +02:00
aa87614a98
don't log "Next steps" messages until `npm install` has finished
2018-10-22 19:25:15 +02:00
585e286adb
exit w/ error code if `npm install` fails
2018-10-22 19:25:15 +02:00
97f22a3543
consistent use of utils.errorMessage
2018-10-22 19:25:15 +02:00
5d4ac32a2a
Boolean() -> !!
2018-10-22 19:25:14 +02:00
1c27c3465b
Handle case when socket not opened
...
If the socket is not already opened, listen for ‘open’ event before sending the `outputDone` data.
2018-10-22 19:24:41 +02:00
91d1e5a85e
Fix websocket not open
...
Make sure the connection is open before
sending the event
2018-10-22 19:24:41 +02:00
4b81968482
restore ws functionality to webserver
2018-10-22 19:24:41 +02:00
3aad35209a
Add browser reload on file change/rebuild
...
Add browser reload on file change/rebuild
2018-10-22 19:13:50 +02:00
a7a6a03bfe
make linter happy
2018-09-28 16:38:42 -04:00
24d661a65e
fix blockchain defaults for config-less dapps
2018-09-28 16:32:37 -04:00
a41bdf1b4a
output contracts json even if the pipeline is empty
2018-09-28 13:22:03 -04:00
69894d2e06
Merge pull request #916 from embark-framework/infura_fix
...
Infura fix
2018-09-26 19:04:26 -04:00
05962a288d
lint is mother; lint is father
2018-09-26 18:57:55 -04:00
44dad44ef4
increase estimated gas slightly & randomly
2018-09-26 18:45:06 -04:00
2374cb1641
limit deployment to 1 for now
2018-09-26 18:44:36 -04:00
c81deb9a2d
Don't log that we don't know how to handle node
2018-09-26 18:36:56 -04:00
3ae5157e47
Revert "Delay contract deploiement if share bytecode"
...
This reverts commit 527dbcca8b
2018-09-26 17:39:11 -04:00
8d13cd8e9d
Merge pull request #905 from embark-framework/bugfix/infura-simultaneous-tx
...
Bugfix/infura simultaneous tx
2018-09-26 14:21:30 -04:00
767687b297
Simplify concat
2018-09-26 11:47:02 -04:00
b1f9097824
Update function complexity
2018-09-26 11:23:52 -04:00
fa8f4b4e41
Support if statements without a list of statements
2018-09-26 11:13:14 -04:00
0848d81b3e
Merge pull request #906 from embark-framework/bugfix/ens-require-default-account
...
Warning if no default account for ens
2018-09-26 09:28:41 -04:00
06c0171c39
Merge pull request #908 from embark-framework/bugfix/warn-about-ethereum-node-going-away
...
Warn about Ethereum node going away
2018-09-26 09:25:35 -04:00
b4dc48dc32
Merge pull request #904 from embark-framework/bug_fix/ipfs-own-cors
...
add CORS URL for local ipfs' own server
2018-09-26 08:58:07 -04:00
c06f39d53e
Merge pull request #899 from embark-framework/bugfix/filter-interface-contracts-from-coverage
...
Filter out interfaces from the coverage report
2018-09-26 08:53:12 -04:00
ad2eb9ad9f
Warn, don't trace
2018-09-25 12:41:22 -04:00
23d6b07467
Warning if no default account for ens
2018-09-25 15:30:46 +01:00
36eabda506
rev error handling so error msg from hosted-git-info would be logged
2018-09-25 09:20:59 -05:00
b8d3f3cd11
Fix warning
2018-09-25 14:59:08 +01:00
527dbcca8b
Delay contract deploiement if share bytecode
2018-09-25 14:58:19 +01:00
16246b1d43
rm unneeded param/arg
2018-09-24 21:07:02 -05:00
cad7843c78
add CORS URL for local ipfs' own server (default: localhost:8080)
2018-09-24 20:51:31 -05:00
999d65bda0
whitespace
2018-09-24 20:50:27 -05:00
cf67bd0332
rename var
2018-09-24 19:26:51 -05:00
d945f8f2f4
don't log complete/ready messages until after `npm install`
2018-09-24 17:44:53 -05:00
67f57217d5
log re: installing pkgs for built-in boilerplate not just demo
2018-09-24 17:44:53 -05:00
c8a9ac6048
tweak log messages
2018-09-24 17:44:53 -05:00
c2d92b19f3
log browsable url from info gen'd by hosted-git-info
2018-09-24 17:44:53 -05:00
1b7935678c
use hosted-git-info pkg to process --template name/url
2018-09-24 17:44:53 -05:00
e744a24557
Merge pull request #897 from embark-framework/bug_fix/template-downloader-branch-names
...
allow for '/' in branch name when handling github shortcuts
2018-09-24 16:45:31 -04:00
099e398bf4
Filter out interfaces from the coverage report
2018-09-23 19:08:06 -04:00
e952bbc41a
Fix contract matching
2018-09-23 18:40:51 -04:00
82de81015b
allow for / in branch name when handling github shortcuts
2018-09-23 12:34:23 -05:00
9ed08f234d
Merge pull request #895 from embark-framework/bugfix/race-condition-deploy-tracker
...
Fix race condition on deploy tracker
2018-09-22 10:36:15 -04:00
8d506971e8
BN.js udpated need toString
2018-09-22 15:34:54 +01:00
1dfd2e980f
Reduce coupling by using action for event
2018-09-22 15:08:50 +01:00
e20d7bfc6a
Fix race condition on deploy tracker
2018-09-22 14:43:10 +01:00
c569dc9d21
add missing semi-colon
2018-09-22 09:21:30 -04:00
fe3e4690f6
Remove useless try on ws connect
2018-09-22 13:59:19 +01:00
7e710745ce
always add ens contracts source so abi definition is always available in environments the contract is already deployed
2018-09-21 19:02:44 -04:00
681dddbbf2
Merge pull request #889 from embark-framework/bugfix/ipfs-hash-fetch
...
Fetch IPFS dir hash deterministically
2018-09-21 18:29:24 -04:00
2586b0dc14
Merge pull request #888 from embark-framework/bugfix/resolve-private-key-path
...
Resolve private key path instead of forcing inside dApp root
2018-09-21 18:29:02 -04:00
50effc0a6c
revert change made on ens module
2018-09-21 18:26:18 -04:00
cafe472727
add missing space
2018-09-21 18:16:47 -04:00
78814dc9d6
only add & deploy fifs register if it's actually a non live env
2018-09-21 17:53:42 -04:00
3b6251eeb1
improve some deployment error messages
2018-09-21 17:52:32 -04:00
4af9114681
fix blockchain node not found msg so it actually shows red
2018-09-21 17:51:53 -04:00
0bdafc273f
Fetch IPFS dir hash deterministically
2018-09-21 16:52:39 -04:00
12c495502d
Resolve private key path instead of forcing inside dApp root
2018-09-21 14:04:04 -04:00
1b649d0e3a
Merge pull request #885 from embark-framework/bugfix/blockchain-not-done
...
Bugfix/blockchain not done
2018-09-21 15:11:20 +01:00
71cbb07ad8
Merge pull request #878 from embark-framework/bug_fix/minewhenneeded-fixes-3
...
Fix datadir for miner (PR for next branch)
2018-09-21 09:36:06 -04:00
9a914d0b5a
Merge pull request #877 from embark-framework/bug_fix/proxy-setup-awaits-blockchain
...
proxy should try to wait on target endpoint
2018-09-21 09:31:48 -04:00
d5d0aa1600
EmbarkJS blockchain must be done
2018-09-20 11:15:48 +01:00
907b486531
Send ready only when the proxy is started
2018-09-20 10:16:48 +01:00
4a321e3c0c
coerce boolean value using more commmon !!
2018-09-20 15:33:33 +10:00
ab7784c1e9
Fix datadir for miner
...
The datadir path was not being passed to the miner, was resolving as `undefined`, and therefore, was not setting up an ipc connection correctly and no communication was happening.
The fix passes the `datadir` from the blockchain config to the miner in the constructor.
2018-09-20 15:30:06 +10:00
c477445896
Start HTTP and WS proxies individually
...
As geth is starting up, the output is monitored for endpoint info. Once the HTTP or WS endpoints are opened, the corresponding proxies are started.
This is more maintainable in the long run in case the geth process being started does not allow for rpc or websockets, or geth modifies the order in which endpoint are opened.
2018-09-20 15:08:02 +10:00
eba9ce361e
setupProxy should not be conditional on isDev
2018-09-19 22:31:54 -05:00
917757b04c
outer function doesn't need to be async
2018-09-19 21:13:19 -05:00
e19b3b2f51
simplify syntax
2018-09-19 21:13:06 -05:00
2b816af9a8
eslint doesn't like `void 0` here
2018-09-19 21:12:37 -05:00
1408abf8d9
supply radix
2018-09-19 21:12:20 -05:00
fa274675a5
timer function doesn't need to be async, since it returns a promise
2018-09-19 21:11:55 -05:00
4fc9827080
need parent contract's realRuntimeBytecode
2018-09-19 20:55:00 -05:00
aae7954020
await proxy just before createFundAndUnlockAccounts
2018-09-19 20:11:36 -05:00
35c772d727
async setupProxy
2018-09-19 20:10:46 -05:00
b9975668b8
proxy should attempt to wait on target
2018-09-19 20:10:15 -05:00
3846db79f7
make sure port is an integer, port var should hold offset port value
2018-09-19 20:10:15 -05:00
ae8a59cf9b
timer utility
2018-09-19 19:47:38 -05:00
c6d7bec9d7
Do not request legacyAST from solc to speed up compilation
2018-09-19 15:51:11 -04:00
b817c0f012
Merge pull request #872 from embark-framework/feature/warning-for-gas
...
Display warning for gas price
2018-09-19 13:57:17 -04:00
b1df72be3f
Update text
2018-09-19 13:46:39 +01:00
2a61857990
Display warning for gas price
2018-09-19 12:02:33 +01:00
9151466a75
Simplify code
2018-09-18 16:36:21 -04:00
f54d572b3d
Handle cases where deploy address isn't set
2018-09-18 16:30:32 -04:00
904c716d89
Merge pull request #856 from embark-framework/features/config-browser-open
...
cli and config options for browser auto-open
2018-09-18 13:11:55 -04:00
7f66e24b2f
Merge pull request #863 from embark-framework/bug_fix/minewhenneeded-fixes-2
...
Geth creates new account - add password warning
2018-09-18 13:02:01 -04:00
ce8f5f7dc0
Merge pull request #861 from embark-framework/feature/webserver-coverage
...
Add coverage to webserver
2018-09-18 12:45:01 -04:00
0504d12739
Merge pull request #860 from embark-framework/bugfix/proxy-not-ready
...
Delay the start of the proxy
2018-09-18 12:44:32 -04:00
d9c5369c20
Merge pull request #859 from embark-framework/bugfix/runcode-type
...
Fix typo
2018-09-18 12:42:59 -04:00
bdcefbe269
Add coverage to webserver
2018-09-18 14:28:17 +01:00
4c0b4c2410
Delay the start of the proxy
2018-09-18 12:12:17 +01:00
6fe3db4235
Fix typo
2018-09-18 09:42:46 +01:00
d965ba6db9
Geth creates new account - add password warning
...
When `isDev` is false, and `mineWhenNeeded` is true, embark attempts to create a new account using `geth account new`, and uses the password file specified in `blockchain/config > accounts > password`. This warning informs the user that the create account command may fail if the password is missing.
2018-09-18 16:28:23 +10:00
8acab6ef5b
disable browser auto-open when webserver first starts, not the `open browser` console cmd
2018-09-17 18:47:19 -05:00
d03cfebbdf
supply radix -- make the linter happy
2018-09-17 18:13:21 -05:00
ebcbc1efe6
if port === 0 (per cli or config), auto-assign a port
2018-09-17 17:59:52 -05:00
c6232de878
host from config (config has been merge w/ cli by core/config)
2018-09-17 17:59:52 -05:00
c685432ea2
pass port number through parseInt
2018-09-17 17:59:52 -05:00
1b7aed8b80
openBrowser config option
2018-09-17 17:59:52 -05:00
c360975e8f
webServer svc doesn't need to handle cli opts (handled in core/config)
2018-09-17 17:59:52 -05:00
7746404905
Match coverage path
2018-09-17 15:25:07 -04:00
7ce92211f9
Merge pull request #842 from embark-framework/fix_cb_issue
...
take into account when event does not trigger a callback
2018-09-17 14:56:40 -04:00
fade54fca4
Merge pull request #852 from embark-framework/improve-coverage-ux
...
Improve coverage UX
2018-09-17 14:18:27 -04:00
11828c3086
Merge pull request #851 from embark-framework/bugfix/gasPrice-with-coverage
...
Gas Price not modified by coverage
2018-09-17 14:17:28 -04:00
cc8649aa95
Merge pull request #850 from embark-framework/bug_fix/re-add-dev_funds-calling-code
...
Adding back calling code block for dev_funds
2018-09-17 14:12:25 -04:00
d6f1925cec
Merge pull request #849 from embark-framework/bugfix/better-support-for-await
...
Better support for await
2018-09-17 14:11:20 -04:00
c02bd6c444
make linter happy
2018-09-17 13:58:13 -04:00
fc98b1ccef
Merge pull request #848 from embark-framework/bug_fix/embark-console-kills-embark
...
Fix for embark run crashing after console connects to it
2018-09-17 13:39:05 -04:00
1296545fa3
make function defaul arg instead
2018-09-17 13:36:20 -04:00
b021d99bab
Improve coverage UX
2018-09-17 10:37:24 -04:00
18a9349d77
Gas Price not modified by coverage
2018-09-17 14:12:20 +01:00
472b87f4cd
Adding back calling code block for dev_funds
...
This may have been removed in the rebase, adding it back in.
2018-09-17 22:48:24 +10:00
3a210f602b
Better support for await
2018-09-17 09:57:51 +01:00
31d3125baf
Fix for embark run crashing after console connects to it
...
The providerUrl being provided to the console VM was looking for a WebsocketProvider-specific property which did not exist on the HttpProvider.
Type checking was added to provide the necessary type-dependent property.
2018-09-17 13:03:55 +10:00
7d6809b57f
take into account when event does not trigger a cb
2018-09-15 12:52:11 -04:00
32a1ba0f32
fix dashboard state so it doesn't show pending for contracts that were not deployed due to deployIf directive
2018-09-15 12:20:20 -04:00
e3273b7867
Merge pull request #835 from embark-framework/fix-coverage-timing
...
Update coverage report after suite
2018-09-14 18:18:24 -04:00
b53eb11285
Merge pull request #833 from embark-framework/bug_fix/http-inception
...
Fix contracts with http import inceptions
2018-09-14 18:15:52 -04:00
3c167b197c
Merge pull request #823 from embark-framework/features/embark-help-addition
...
`embark test —node` help, plus fix for vm option
2018-09-14 18:13:07 -04:00
9b2fa9402b
Merge pull request #822 from embark-framework/bugfix/circular-json
...
Fix circular JSON and swarm api require
2018-09-14 18:11:34 -04:00
8b28bb9691
Merge pull request #830 from embark-framework/feature/process-wrapper-options
...
Better manage default options
2018-09-14 18:09:41 -04:00
286e1d2c95
Merge pull request #824 from embark-framework/feature/swarm-use-local-datadir
...
Swarm use local data dir
2018-09-14 18:07:54 -04:00
103262f435
Write coverage report asynchronously
2018-09-14 16:43:58 -04:00
a8a9f3e9a8
Setup coverage to listen to the test embark events
...
This allows us to catch an event to know when the tests are done running. In turn, this will tell us when to save the coverage file and run the report.
2018-09-14 16:31:40 -04:00
d8becfe54f
Lint lyfe
2018-09-14 13:21:47 -04:00
cd8980151b
Update coverage report after each step
2018-09-14 13:16:02 -04:00
fc0825aeca
set downloaded flag at the very end
2018-09-14 11:50:24 -04:00
2c30271d29
please linter
2018-09-14 10:30:20 +01:00
ab859d4ef5
Better manage default options
2018-09-14 10:17:01 +01:00
9887a2204d
Merge pull request #826 from embark-framework/feature/clean-pipeline
...
Clean build dir before starting
2018-09-13 19:47:14 -04:00
6d54a40bb2
Merge pull request #827 from embark-framework/bug_fix/prepend-embark-plugin-install
...
Prepend "embark-" to plugin names and little fixes
2018-09-13 19:46:49 -04:00
293fce63a9
add thens to catch errors
2018-09-13 15:56:36 -04:00
43a9640297
add option to generate the coverage
2018-09-13 14:30:15 -04:00
3e1db81d5b
preprend embark to plugin name
2018-09-13 10:29:03 -04:00
70763fc717
restructure plugin_cmd
2018-09-13 10:08:15 -04:00
0cb12e0591
Clean build dir before starting
2018-09-13 14:07:14 +01:00
8ffc9b89e2
Swarm use local data dir
2018-09-13 13:37:44 +01:00
583318169a
Fix loading swarm-api in node or browser
2018-09-13 12:29:44 +01:00
60703b86c5
`embark test —node` help, plus fix for vm option
...
Add better help info for `embark test —node`.
Fixed issue with `embark test —node vm` where the `vm` was attempted to be parsed as a URL instead of running the simulator.
2018-09-13 20:34:58 +10:00
c22901ab95
Fix circular JSON and swarm api require
2018-09-13 11:21:17 +01:00
1b242baefd
No webserver and no ipc server on console
2018-09-13 09:19:57 +01:00
53e3136ac6
Merge pull request #821 from embark-framework/bug_fix/double-import
...
Fix double http import
2018-09-12 18:53:54 -04:00
edd9ece585
Merge pull request #820 from embark-framework/bug_fix/error-deploy-pending
...
Don't stop everything on contract deploy fail
2018-09-12 18:50:56 -04:00
e7ae3fbc76
Merge pull request #809 from embark-framework/bug_fix/bad-redeploy
...
fix redeploy of contracts on spaces
2018-09-12 18:37:29 -04:00
cdf5a37ac4
Merge pull request #808 from embark-framework/eth_call_coverage
...
Add call coverage to pure functions
2018-09-12 18:31:22 -04:00
dfe49291be
Merge pull request #797 from subramanianv/pluginCmd
...
Plugin cmd
2018-09-12 17:57:18 -04:00
a4400a303d
fix double import by using newContent
2018-09-12 14:08:00 -04:00
4c912b8ecf
stop on error
2018-09-12 12:04:33 -04:00
9f7a932252
don't stop on contract fail
2018-09-12 11:55:29 -04:00
da0b2f4e66
Merge pull request #806 from embark-framework/feature/new-repl-command
...
Adding new repl options
2018-09-12 15:07:45 +01:00
52a99ee4ef
Merge pull request #815 from embark-framework/fix-invalid-account-param-error
...
Show an error message on account parameters
2018-09-12 10:01:55 -04:00
b34174738c
Merge pull request #814 from embark-framework/bugfix/ens-without-config-no-crash
...
Prevent embark to crash when there is no config for ens
2018-09-12 10:01:26 -04:00
e08892664f
Adding new repl options
2018-09-12 15:00:55 +01:00
4e3e27df6c
Merge pull request #810 from embark-framework/bug_fix/fix-log-ipns
...
Make sure the string is an IPFS hash and some linting
2018-09-12 09:59:38 -04:00
c8eec064b1
log the error
2018-09-12 19:27:19 +05:30
1bbd8beef8
Merge pull request #802 from embark-framework/swarm-support-latest
...
Switch to SwarmJS which supports latest version of Swarm
2018-09-12 09:57:19 -04:00
f427980cfe
Merge pull request #800 from embark-framework/bugfix/ens-test-app
...
Better trace register ens
2018-09-12 09:56:35 -04:00
0f635f8a33
Merge pull request #799 from embark-framework/feature/trace-console-log
...
Use trace logger for code runner error
2018-09-12 09:55:47 -04:00
5f90b4516c
Ens disabled by default
2018-09-12 14:01:21 +01:00
4a947d4783
Show an error message on account parameters
2018-09-12 09:00:20 -04:00
1ce8474824
Prevent embark to crash when there is no config for ens
2018-09-12 12:05:31 +01:00
b2d6421ea6
fix code formatting
2018-09-12 11:50:20 +05:30
1a756e8a05
Added better error logging, dashboard doesnt break in run mode
2018-09-12 11:27:28 +05:30
5021d39cae
Add console help for swarm command
2018-09-12 12:57:46 +10:00
680db4d575
Change over to published swarm-api library
2018-09-12 12:43:10 +10:00
a9865eedc5
provide helpful messages when template download fails
2018-09-11 15:44:54 -05:00
a4af0d8f5b
assume cb is always supplied
2018-09-11 15:44:37 -05:00
803b3f5050
should return after callback w/ error
2018-09-11 15:22:35 -05:00
a44be3740b
template generator should report err msg and exit if download fails
2018-09-11 15:19:15 -05:00
ed48599aa9
downloadFile should callback w/ err msg if response code is not 200
2018-09-11 15:18:32 -05:00
742936efc3
make sure the string is an IPFS hash and some linting
2018-09-11 16:09:46 -04:00
47ec2f2d8a
fix redeploy of contracts on spaces
2018-09-11 15:20:57 -04:00
29c1ea39f8
Address feedback
2018-09-11 14:50:43 -04:00
799a87f35e
Clean up; Lint
2018-09-11 14:32:40 -04:00
4f50229beb
temp/poc for eth_call coverage
2018-09-11 14:32:40 -04:00
b3eedc4ba2
embark config
2018-09-10 23:12:04 +05:30
fe0bbc3559
changes from the code review
2018-09-10 22:38:17 +05:30
6ad9c0dc5a
Update error with or
2018-09-10 17:08:09 +01:00
32a6b53c6a
Add missing callback
2018-09-10 17:05:11 +01:00
16c870ac34
Use error logger
2018-09-10 13:57:54 +01:00
2782acf438
fix plugin command
2018-09-10 18:25:17 +05:30
1d03f01531
Update warnings in embark after upload
...
warn user that they need to run a blockchain node and swarm for the dapp to work correctly.
2018-09-10 22:47:31 +10:00
b759e9eed7
Add ‘defaultpath’ for upload
...
Hardcode to ‘index.html’
2018-09-10 22:42:10 +10:00
9d39fa39ac
Swarm updates for embark
...
Change __embarkSwarm to use new SwarmJS and change over from promises.
Add note after upload that blockchain nodes needs to be running to access the swarm uploaded dapp.
Fix typo with swarm “on” available.
Linting / cleanup
2018-09-10 22:42:10 +10:00
e44b62d550
SwarmJS browser support
2018-09-10 22:42:10 +10:00
3f5fe21b90
change to ‘uploadDirectory’
2018-09-10 22:42:10 +10:00
2dc8d8c276
Fix issue with swarm isAvailable
2018-09-10 22:42:10 +10:00
fcb75dee11
Move to swarmjs and await geth ready
...
Move to swarmjs library (in embark-framework).
Wait for geth to start before start of swarm check.
2018-09-10 22:42:10 +10:00
b5e8546ebd
Converted upload procedure to local SwarmGW lib
...
# Conflicts:
# package-lock.json
2018-09-10 22:42:00 +10:00
68ef5454e0
Avoid multiple connect to IPC
2018-09-10 11:52:06 +01:00
53de6dcb19
Fixes to npm command parsing
2018-09-10 16:19:37 +05:30
613921169a
Better trace register ens
2018-09-10 10:12:02 +01:00
78bc27ad95
fix runCmd
2018-09-10 14:16:02 +05:30
f20934ac8c
Use Object.assign
2018-09-10 14:11:40 +05:30
4823d2312e
remove console.log
2018-09-10 14:07:02 +05:30
cb751b5213
install npm package using shell.js
2018-09-10 14:01:36 +05:30
b41bcbbe17
Use trace logger for code runner error
2018-09-10 09:26:37 +01:00
c8e812e638
Plugin Command Module
2018-09-09 23:22:57 +05:30
74f0d05ca0
Plugin Command
2018-09-09 23:07:55 +05:30
833fcef22a
Merge pull request #795 from embark-framework/bug_fix/webserver-config-change
...
Watch webserver config and restart it
2018-09-07 19:04:17 -04:00
4128a96997
Merge pull request #796 from embark-framework/bug_fix/web3-location
...
getWeb3Location should use require.resolve()
2018-09-07 19:03:59 -04:00
7549c1f8e6
require.resolve() should start by looking in embark's own node_modules
2018-09-07 16:28:03 -05:00
13e21702d2
getWeb3Location should use require.resolve() for "version:get:web3" event
2018-09-07 15:52:30 -05:00
3d37fe6362
catch webserver config and restart it
2018-09-07 14:54:15 -04:00
4c580dd54d
Pr feedback using once
2018-09-07 14:57:49 +01:00
4481e6eb99
Ens config is run only once
2018-09-07 11:18:43 +01:00
18ab1ce101
Merge pull request #790 from embark-framework/bugfix/solc-die
...
Avoid Solc to die because of compilation
2018-09-06 13:31:39 -04:00
bee3aa1fde
Merge pull request #789 from eiselems/extendTemplateGenerator
...
Extend template_generator to support git urls and branches
2018-09-06 09:33:07 -04:00
5957be9571
Avoid Solc to die because of compilation
2018-09-06 11:24:29 +01:00
c99d75c9f1
Extend template_generator to support git urls and branches
...
This change will also:
* upgrade calls from HTTP to HTTPS
* update / add some tests
See: #765
2018-09-06 02:09:46 +02:00
10035fe46b
Merge pull request #786 from embark-framework/bug_fix/upload-simple
...
Fix uploading a simple app
2018-09-05 18:23:27 -04:00
48a3d70df2
Merge pull request #785 from embark-framework/bug_fix/no-warning-dev
...
No accounts warning in development
2018-09-05 18:22:09 -04:00
428820f2c6
Merge pull request #781 from embark-framework/bug_fix/no-webserver-if-false
...
Do not start webserver if set to false in embark.json
2018-09-05 18:20:31 -04:00
7d29e53048
remove stray `?` in webpack.config.js
2018-09-05 16:49:26 -05:00
55bb028a13
add test too
2018-09-05 12:35:45 -04:00
56147ba200
fix order and remove ?
2018-09-05 11:47:53 -04:00
047286b46d
skip webpack if no js files
2018-09-05 11:38:09 -04:00
3991880b44
no warning in development
2018-09-05 09:45:34 -04:00
c92f6f8865
Fix dynamic IPC
2018-09-05 10:40:37 +01:00
e925200592
disable webserver if false
2018-09-04 16:44:42 -04:00
0f1f3a782a
Merge pull request #779 from embark-framework/chore/add-embarkjs-to-help
...
Add embarkJS to help
2018-09-04 15:26:31 -04:00
9351a12444
add embarkJS to help
2018-09-04 14:12:12 -04:00
bf8183cf76
Merge pull request #778 from embark-framework/fix_deploy
...
Fix issue with changes in config file not causing a proper reload
2018-09-04 14:02:54 -04:00
7ee02525a7
Merge pull request #770 from embark-framework/features/open-browser
...
open browser when Embark's webserver starts
2018-09-04 13:51:57 -04:00
d4be16ba3c
move reporting to final callback
2018-09-04 08:20:58 -05:00
b67aa8cc2d
best practice re: early return w/ callback invocation
2018-09-04 08:20:27 -05:00
c02199db0f
rev comment
2018-09-04 07:36:21 -05:00
7d65c2b0cd
rename placeholder event: 'build-placeholder'
2018-09-04 07:35:53 -05:00
57b2c5c4e4
'browser open' console command
2018-09-04 07:35:02 -05:00
68c6d1549a
'open-browser' event
2018-09-04 07:34:37 -05:00
103bb43a05
consistent naming, quotes-style
2018-09-04 07:32:31 -05:00
5ad17be140
Fix Gas Price
2018-09-04 08:21:31 +01:00
emizzle
Jonathan Rainville
Michael Bradley, Jr
hodlbank
Andre Medeiros
Anthony Laibe
Cryptomental
Dan Lipert
Subramanian Venkatesan
Giuseppe Bertone
Pascal Precht
Moksh Jain
Iuri Matias
StevenJNPearce
bakaoh
Evgeniy Filatov
eiselems