status-im/embark-area-51
2
0
Fork 0
mirror of https://github.com/status-im/embark-area-51.git synced 2025-01-11 14:34:40 +00:00
Code Issues Projects Releases Wiki Activity

best practice re: early return w/ callback invocation

Browse Source
This commit is contained in:
Michael Bradley, Jr 2018-09-04 08:20:27 -05:00
parent c02199db0f
commit b67aa8cc2d
2 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
lib/modules/webserver/server.js
View File

@ -32,11 +32,11 @@ class Server {
async.waterfall([
function createPlaceholderPage(next) {
if (self.isFirstStart) {
self.isFirstStart = false;
return self.events.request('build-placeholder', next);
if (!self.isFirstStart) {
return next();
}
next();
self.isFirstStart = false;
self.events.request('build-placeholder', next);
},
function listen(next) {
self.server.listen(self.port, self.hostname, () => {
@ -45,12 +45,9 @@ class Server {
});
},
function openBrowser(next) {
if (!self.opened) {
self.opened = true;
return self.events.request('open-browser', next);
if (self.opened) {
return next();
}
next();
},
function reportAvailable(next) {
next(null, __("webserver available at") +
" " +

8
lib/pipeline/pipeline.js
View File

@ -29,11 +29,11 @@ class Pipeline {
async.waterfall([
function createPlaceholderPage(next){
if (!self.isFirstBuild) {
return self.events.request('build-placeholder', next);
if (self.isFirstBuild) {
self.isFirstBuild = false;
return next();
}
self.isFirstBuild = false;
next();
self.events.request('build-placeholder', next);
},
function buildTheContracts(next) {
self.buildContracts(next);