Merge branch 'master' into feature/waku-plugin

# Conflicts:
#	Framework/KubernetesWorkflow/Recipe/ContainerRecipeFactory.cs
#	cs-codex-dist-testing.sln

.dockerignore

@@ -1,30 +0,0 @@
-**/.classpath
-**/.dockerignore
-**/.env
-**/.git
-**/.gitignore
-**/.project
-**/.settings
-**/.toolstarget
-**/.vs
-**/.vscode
-**/*.*proj.user
-**/*.dbmdl
-**/*.jfm
-**/azds.yaml
-**/bin
-**/charts
-**/docker-compose*
-**/Dockerfile*
-**/node_modules
-**/npm-debug.log
-**/obj
-**/secrets.dev.yaml
-**/values.dev.yaml
-LICENSE
-README.md
-!**/.gitignore
-!.git/HEAD
-!.git/config
-!.git/packed-refs
-!.git/refs/heads/**

.github/workflows/docker-autoclient.yml

@@ -1,26 +0,0 @@
-name: Docker - AutoClient
-
-on:
-  push:
-    branches:
-      - master
-    tags:
-      - 'v*.*.*'
-    paths:
-      - 'Tools/AutoClient/**'
-      - '!Tools/AutoClient/docker/docker-compose.yaml'
-      - 'Framework/**'
-      - 'ProjectPlugins/**'
-      - .github/workflows/docker-autoclient.yml
-      - .github/workflows/docker-reusable.yml
-  workflow_dispatch:
-
-jobs:
-  build-and-push:
-    name: Build and Push
-    uses: ./.github/workflows/docker-reusable.yml
-    with:
-      docker_file: Tools/AutoClient/docker/Dockerfile
-      docker_repo: codexstorage/codex-autoclient
-    secrets: inherit
-

.github/workflows/docker-keymaker.yml

@@ -1,27 +0,0 @@
-name: Docker - KeyMaker
-
-
-on:
-  push:
-    branches:
-      - master
-    tags:
-      - 'v*.*.*'
-    paths:
-      - 'Tools/KeyMaker/**'
-      - 'Framework/**'
-      - 'ProjectPlugins/**'
-      - .github/workflows/docker-KeyMaker.yml
-      - .github/workflows/docker-reusable.yml
-  workflow_dispatch:
-
-
-jobs:
-  build-and-push:
-    name: Build and Push
-    uses: ./.github/workflows/docker-reusable.yml
-    with:
-      docker_file: Tools/KeyMaker/docker/Dockerfile
-      docker_repo: codexstorage/codex-keymaker
-    secrets: inherit
-

.github/workflows/docker-marketinsights.yml

@@ -1,27 +0,0 @@
-name: Docker - MarketInsights API
-
-
-on:
-  push:
-    branches:
-      - master
-    tags:
-      - 'v*.*.*'
-    paths:
-      - 'Tools/MarketInsights/**'
-      - 'Framework/**'
-      - 'ProjectPlugins/**'
-      - .github/workflows/docker-marketinsights.yml
-      - .github/workflows/docker-reusable.yml
-  workflow_dispatch:
-
-
-jobs:
-  build-and-push:
-    name: Build and Push
-    uses: ./.github/workflows/docker-reusable.yml
-    with:
-      docker_file: Tools/MarketInsights/Dockerfile
-      docker_repo: codexstorage/codex-marketinsights
-    secrets: inherit
-

.gitignore

@@ -1,5 +1,4 @@
 .vs
 obj
 bin
-.vscode
-Tools/AutoClient/datapath
+.vscode

Framework/ArgsUniform/ArgsUniform.cs

@@ -4,8 +4,9 @@ namespace ArgsUniform
 {
     public class ArgsUniform<T>
     {
-        private readonly Assigner<T> assigner;
         private readonly Action printAppInfo;
+        private readonly object? defaultsProvider;
+        private readonly IEnv.IEnv env;
         private readonly string[] args;
         private const int cliStart = 8;
         private const int shortStart = 38;
@@ -30,9 +31,9 @@ namespace ArgsUniform
         public ArgsUniform(Action printAppInfo, object defaultsProvider, IEnv.IEnv env, params string[] args)
         {
             this.printAppInfo = printAppInfo;
+            this.defaultsProvider = defaultsProvider;
+            this.env = env;
             this.args = args;
-
-            assigner = new Assigner<T>(env, args, defaultsProvider);
         }
 
         public T Parse(bool printResult = false)
@@ -41,7 +42,7 @@ namespace ArgsUniform
             {
                 printAppInfo();
                 PrintHelp();
-                Environment.Exit(0);
+                throw new Exception();
             }
 
             var result = Activator.CreateInstance<T>();
@@ -52,16 +53,18 @@ namespace ArgsUniform
                 var attr = uniformProperty.GetCustomAttribute<UniformAttribute>();
                 if (attr != null)
                 {
-                    if (!assigner.UniformAssign(result, attr, uniformProperty) && attr.Required)
+                    if (!UniformAssign(result, attr, uniformProperty) && attr.Required)
                     {
-                        missingRequired.Add(uniformProperty);
+                        {
+                            missingRequired.Add(uniformProperty);
+                        }
                     }
                 }
             }
 
             if (missingRequired.Any())
             {
-                PrintResults(printResult,result, uniformProperties);
+                PrintResults(result, uniformProperties);
                 Print("");
                 foreach (var missing in missingRequired)
                 {
@@ -72,39 +75,37 @@ namespace ArgsUniform
                 }
 
                 PrintHelp();
-                Environment.Exit(1);
+                throw new ArgumentException("Unable to assemble all required arguments");
             }
 
-            PrintResults(printResult, result, uniformProperties);
+            if (printResult)
+            {
+                PrintResults(result, uniformProperties);
+            }
 
             return result;
         }
 
+        private void PrintResults(T result, PropertyInfo[] uniformProperties)
+        {
+            Print("");
+            foreach (var p in uniformProperties)
+            {
+                Print($"\t{p.Name} = {p.GetValue(result)}");
+            }
+            Print("");
+        }
+
         public void PrintHelp()
         {
             Print("");
-            PrintAligned("CLI option:", "(short)", "Environment variable:", "Description", "(default)");
-            var props = typeof(T).GetProperties().Where(m => m.GetCustomAttributes(typeof(UniformAttribute), false).Length == 1).ToArray();
-            foreach (var prop in props)
+            PrintAligned("CLI option:", "(short)", "Environment variable:", "Description");
+            var attrs = typeof(T).GetProperties().Where(m => m.GetCustomAttributes(typeof(UniformAttribute), false).Length == 1).Select(p => p.GetCustomAttribute<UniformAttribute>()).Where(a => a != null).ToArray();
+            foreach (var attr in attrs)
             {
-                var a = prop.GetCustomAttribute<UniformAttribute>();
-                if (a != null)
-                {
-                    var optional = !a.Required ? " (optional)" : "";
-                    var def = assigner.DescribeDefaultFor(prop);
-                    PrintAligned($"--{a.Arg}=...", $"({a.ArgShort})", a.EnvVar, a.Description + optional, $"({def})");
-                }
-            }
-            Print("");
-        }
-
-        private void PrintResults(bool printResult, T result, PropertyInfo[] uniformProperties)
-        {
-            if (!printResult) return;
-            Print("");
-            foreach (var p in uniformProperties)
-            {
-                Print($"\t{p.Name} = {p.GetValue(result)}");
+                var a = attr!;
+                var optional = !a.Required ? " *" : "";
+                PrintAligned($"--{a.Arg}=...", $"({a.ArgShort})", a.EnvVar, a.Description + optional);
             }
             Print("");
         }
@@ -114,7 +115,7 @@ namespace ArgsUniform
             Console.WriteLine(msg);
         }
 
-        private void PrintAligned(string cli, string s, string env, string desc, string def)
+        private void PrintAligned(string cli, string s, string env, string desc)
         {
             Console.CursorLeft = cliStart;
             Console.Write(cli);
@@ -123,8 +124,132 @@ namespace ArgsUniform
             Console.CursorLeft = envStart;
             Console.Write(env);
             Console.CursorLeft = descStart;
-            Console.Write(desc + " ");
-            Console.Write(def + Environment.NewLine);
+            Console.Write(desc + Environment.NewLine);
+        }
+
+        private object GetDefaultValue(Type t)
+        {
+            if (t.IsValueType) return Activator.CreateInstance(t)!;
+            return null!;
+        }
+
+        private bool UniformAssign(T result, UniformAttribute attr, PropertyInfo uniformProperty)
+        {
+            if (AssignFromArgsIfAble(result, attr, uniformProperty)) return true;
+            if (AssignFromEnvVarIfAble(result, attr, uniformProperty)) return true;
+            if (AssignFromDefaultsIfAble(result, uniformProperty)) return true;
+            return false;
+        }
+
+        private bool AssignFromDefaultsIfAble(T result, PropertyInfo uniformProperty)
+        {
+            var currentValue = uniformProperty.GetValue(result);
+            var isEmptryString = (currentValue as string) == string.Empty;
+            if (currentValue != GetDefaultValue(uniformProperty.PropertyType) && !isEmptryString) return true;
+
+            if (defaultsProvider == null) return false;
+
+            var defaultProperty = defaultsProvider.GetType().GetProperties().SingleOrDefault(p => p.Name == uniformProperty.Name);
+            if (defaultProperty == null) return false;
+
+            var value = defaultProperty.GetValue(defaultsProvider);
+            if (value != null)
+            {
+                return Assign(result, uniformProperty, value);
+            }
+            return false;
+        }
+
+        private bool AssignFromEnvVarIfAble(T result, UniformAttribute attr, PropertyInfo uniformProperty)
+        {
+            var e = env.GetEnvVarOrDefault(attr.EnvVar, string.Empty);
+            if (!string.IsNullOrEmpty(e))
+            {
+                return Assign(result, uniformProperty, e);
+            }
+            return false;
+        }
+
+        private bool AssignFromArgsIfAble(T result, UniformAttribute attr, PropertyInfo uniformProperty)
+        {
+            var fromArg = GetFromArgs(attr.Arg);
+            if (fromArg != null)
+            {
+                return Assign(result, uniformProperty, fromArg);
+            }
+            var fromShort = GetFromArgs(attr.ArgShort);
+            if (fromShort != null)
+            {
+                return Assign(result, uniformProperty, fromShort);
+            }
+            return false;
+        }
+
+        private bool Assign(T result, PropertyInfo uniformProperty, object value)
+        {
+            if (uniformProperty.PropertyType == value.GetType())
+            {
+                uniformProperty.SetValue(result, value);
+                return true;
+            }
+            else
+            {
+                if (uniformProperty.PropertyType == typeof(string) || uniformProperty.PropertyType == typeof(int))
+                {
+                    uniformProperty.SetValue(result, Convert.ChangeType(value, uniformProperty.PropertyType));
+                    return true;
+                }
+                else
+                {
+                    if (uniformProperty.PropertyType == typeof(int?)) return AssignOptionalInt(result, uniformProperty, value);
+                    if (uniformProperty.PropertyType.IsEnum) return AssignEnum(result, uniformProperty, value);
+                    if (uniformProperty.PropertyType == typeof(bool)) return AssignBool(result, uniformProperty, value);
+                    
+                    throw new NotSupportedException();
+                }
+            }
+        }
+
+        private static bool AssignEnum(T result, PropertyInfo uniformProperty, object value)
+        {
+            var s = value.ToString();
+            if (Enum.TryParse(uniformProperty.PropertyType, s, out var e))
+            {
+                uniformProperty.SetValue(result, e);
+                return true;
+            }
+            return false;
+        }
+
+        private static bool AssignOptionalInt(T result, PropertyInfo uniformProperty, object value)
+        {
+            if (int.TryParse(value.ToString(), out int i))
+            {
+                uniformProperty.SetValue(result, i);
+                return true;
+            }
+            return false;
+        }
+
+        private static bool AssignBool(T result, PropertyInfo uniformProperty, object value)
+        {
+            var s = value.ToString();
+            if (s == "1" || (s != null && s.ToLowerInvariant() == "true"))
+            {
+                uniformProperty.SetValue(result, true);
+            }
+            return true;
+        }
+
+        private string? GetFromArgs(string key)
+        {
+            var argKey = $"--{key}=";
+            var arg = args.FirstOrDefault(a => a.StartsWith(argKey));
+            if (arg != null)
+            {
+                return arg.Substring(argKey.Length);
+            }
+            return null;
         }
     }
 }

Framework/ArgsUniform/ArgsUniform.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

Framework/ArgsUniform/Assigner.cs

@@ -1,186 +0,0 @@
-using System.Globalization;
-using System.Numerics;
-using System.Reflection;
-
-namespace ArgsUniform
-{
-    public class Assigner<T>
-    {
-        private readonly IEnv.IEnv env;
-        private readonly string[] args;
-        private readonly object? defaultsProvider;
-
-        public Assigner(IEnv.IEnv env, string[] args, object? defaultsProvider)
-        {
-            this.env = env;
-            this.args = args;
-            this.defaultsProvider = defaultsProvider;
-        }
-
-        public bool UniformAssign(T result, UniformAttribute attr, PropertyInfo uniformProperty)
-        {
-            if (AssignFromArgsIfAble(result, attr, uniformProperty)) return true;
-            if (AssignFromEnvVarIfAble(result, attr, uniformProperty)) return true;
-            if (AssignFromDefaultsIfAble(result, uniformProperty)) return true;
-            return false;
-        }
-
-        public string DescribeDefaultFor(PropertyInfo property)
-        {
-            var obj = Activator.CreateInstance<T>();
-            var defaultValue = GetDefaultValue(obj, property);
-            if (defaultValue == null) return "";
-            if (defaultValue is string str)
-            {
-                return "\"" + str + "\"";
-            }
-            return defaultValue.ToString() ?? string.Empty;
-        }
-
-        private object? GetDefaultValue(T result, PropertyInfo uniformProperty)
-        {
-            // Get value from object's static initializer if it's there.
-            var currentValue = uniformProperty.GetValue(result);
-            if (currentValue != null) return currentValue;
-
-            // Get value from defaults-provider object if it's there.
-            if (defaultsProvider == null) return null;
-            var defaultProperty = defaultsProvider.GetType().GetProperties().SingleOrDefault(p => p.Name == uniformProperty.Name);
-            if (defaultProperty == null) return null;
-            return defaultProperty.GetValue(defaultsProvider);
-        }
-
-        private bool AssignFromDefaultsIfAble(T result, PropertyInfo uniformProperty)
-        {
-            var defaultValue = GetDefaultValue(result, uniformProperty);
-            var isEmptryString = (defaultValue as string) == string.Empty;
-            if (defaultValue != null && defaultValue != GetDefaultValueForType(uniformProperty.PropertyType) && !isEmptryString)
-            {
-                return Assign(result, uniformProperty, defaultValue);
-            }
-            return false;
-        }
-
-        private bool AssignFromEnvVarIfAble(T result, UniformAttribute attr, PropertyInfo uniformProperty)
-        {
-            var e = env.GetEnvVarOrDefault(attr.EnvVar, string.Empty);
-            if (!string.IsNullOrEmpty(e))
-            {
-                return Assign(result, uniformProperty, e);
-            }
-            return false;
-        }
-
-        private bool AssignFromArgsIfAble(T result, UniformAttribute attr, PropertyInfo uniformProperty)
-        {
-            var fromArg = GetFromArgs(attr.Arg);
-            if (fromArg != null)
-            {
-                return Assign(result, uniformProperty, fromArg);
-            }
-            var fromShort = GetFromArgs(attr.ArgShort);
-            if (fromShort != null)
-            {
-                return Assign(result, uniformProperty, fromShort);
-            }
-            return false;
-        }
-
-        private bool Assign(T result, PropertyInfo uniformProperty, object value)
-        {
-            if (uniformProperty.PropertyType == value.GetType())
-            {
-                uniformProperty.SetValue(result, value);
-                return true;
-            }
-            else
-            {
-                if (uniformProperty.PropertyType == typeof(string) || uniformProperty.PropertyType == typeof(int))
-                {
-                    uniformProperty.SetValue(result, Convert.ChangeType(value, uniformProperty.PropertyType));
-                    return true;
-                }
-                else
-                {
-                    if (uniformProperty.PropertyType == typeof(int?)) return AssignOptionalInt(result, uniformProperty, value);
-                    if (uniformProperty.PropertyType.IsEnum) return AssignEnum(result, uniformProperty, value);
-                    if (uniformProperty.PropertyType == typeof(bool)) return AssignBool(result, uniformProperty, value);
-                    if (uniformProperty.PropertyType == typeof(ulong)) return AssignUlong(result, uniformProperty, value);
-                    if (uniformProperty.PropertyType == typeof(BigInteger)) return AssignBigInt(result, uniformProperty, value);
-
-                    throw new NotSupportedException(
-                        $"Unsupported property type '${uniformProperty.PropertyType}' " +
-                        $"for property '${uniformProperty.Name}'.");
-                }
-            }
-        }
-
-        private static bool AssignEnum(T result, PropertyInfo uniformProperty, object value)
-        {
-            var s = value.ToString();
-            if (Enum.TryParse(uniformProperty.PropertyType, s, out var e))
-            {
-                uniformProperty.SetValue(result, e);
-                return true;
-            }
-            return false;
-        }
-
-        private static bool AssignOptionalInt(T result, PropertyInfo uniformProperty, object value)
-        {
-            if (int.TryParse(value.ToString(), CultureInfo.InvariantCulture, out int i))
-            {
-                uniformProperty.SetValue(result, i);
-                return true;
-            }
-            return false;
-        }
-
-        private bool AssignUlong(T? result, PropertyInfo uniformProperty, object value)
-        {
-            if (ulong.TryParse(value.ToString(), CultureInfo.InvariantCulture, out ulong i))
-            {
-                uniformProperty.SetValue(result, i);
-                return true;
-            }
-            return false;
-        }
-
-        private bool AssignBigInt(T result, PropertyInfo uniformProperty, object value)
-        {
-            if (BigInteger.TryParse(value.ToString(), CultureInfo.InvariantCulture, out BigInteger i))
-            {
-                uniformProperty.SetValue(result, i);
-                return true;
-            }
-            return false;
-        }
-
-        private static bool AssignBool(T result, PropertyInfo uniformProperty, object value)
-        {
-            var s = value.ToString();
-            if (s == "1" || (s != null && s.ToLowerInvariant() == "true"))
-            {
-                uniformProperty.SetValue(result, true);
-            }
-            return true;
-        }
-
-        private string? GetFromArgs(string key)
-        {
-            var argKey = $"--{key}=";
-            var arg = args.FirstOrDefault(a => a.StartsWith(argKey));
-            if (arg != null)
-            {
-                return arg.Substring(argKey.Length);
-            }
-            return null;
-        }
-
-        private static object GetDefaultValueForType(Type t)
-        {
-            if (t.IsValueType) return Activator.CreateInstance(t)!;
-            return null!;
-        }
-    }
-}

Framework/Core/Core.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

Framework/Core/CoreInterface.cs

@@ -30,7 +30,11 @@ namespace Core
         public IDownloadedLog DownloadLog(RunningContainer container, int? tailLines = null)
         {
             var workflow = entryPoint.Tools.CreateWorkflow();
-            return workflow.DownloadContainerLog(container, tailLines);
+            var file = entryPoint.Tools.GetLog().CreateSubfile();
+            entryPoint.Tools.GetLog().Log($"Downloading container log for '{container.Name}' to file '{file.FullFilename}'...");
+            var logHandler = new LogDownloadHandler(container.Name, file);
+            workflow.DownloadContainerLog(container, logHandler, tailLines);
+            return logHandler.DownloadLog();
         }
 
         public string ExecuteContainerCommand(IHasContainer containerSource, string command, params string[] args)

Framework/Core/DownloadedLog.cs

@@ -1,15 +1,11 @@
 using Logging;
 
-namespace KubernetesWorkflow
+namespace Core
 {
     public interface IDownloadedLog
     {
-        string ContainerName { get; }
-
-        void IterateLines(Action<string> action, params string[] thatContain);
         string[] GetLinesContaining(string expectedString);
         string[] FindLinesThatContain(params string[] tags);
-        string GetFilepath();
         void DeleteFile();
     }
 
@@ -17,28 +13,9 @@ namespace KubernetesWorkflow
     {
         private readonly LogFile logFile;
 
-        internal DownloadedLog(WriteToFileLogHandler logHandler, string containerName)
+        internal DownloadedLog(LogFile logFile)
         {
-            logFile = logHandler.LogFile;
-            ContainerName = containerName;
-        }
-
-        public string ContainerName { get; }
-
-        public void IterateLines(Action<string> action, params string[] thatContain)
-        {
-            using var file = File.OpenRead(logFile.FullFilename);
-            using var streamReader = new StreamReader(file);
-
-            var line = streamReader.ReadLine();
-            while (line != null)
-            {
-                if (thatContain.All(line.Contains))
-                {
-                    action(line);
-                }
-                line = streamReader.ReadLine();
-            }
+            this.logFile = logFile;
         }
 
         public string[] GetLinesContaining(string expectedString)
@@ -80,11 +57,6 @@ namespace KubernetesWorkflow
             return result.ToArray();
         }
 
-        public string GetFilepath()
-        {
-            return logFile.FullFilename;
-        }
-
         public void DeleteFile()
         {
             File.Delete(logFile.FullFilename);

Framework/Core/EntryPoint.cs

@@ -38,14 +38,10 @@ namespace Core
             return new CoreInterface(this);
         }
 
-        /// <summary>
-        /// Deletes kubernetes and tracked file resources.
-        /// when `waitTillDone` is true, this function will block until resources are deleted.
-        /// </summary>
-        public void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles, bool waitTillDone)
+        public void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles)
         {
-            manager.DecommissionPlugins(deleteKubernetesResources, deleteTrackedFiles, waitTillDone);
-            Tools.Decommission(deleteKubernetesResources, deleteTrackedFiles, waitTillDone);
+            manager.DecommissionPlugins(deleteKubernetesResources, deleteTrackedFiles);
+            Tools.Decommission(deleteKubernetesResources, deleteTrackedFiles);
         }
 
         internal T GetPlugin<T>() where T : IProjectPlugin

Framework/Core/Http.cs

@@ -7,27 +7,23 @@ namespace Core
     {
         T OnClient<T>(Func<HttpClient, T> action);
         T OnClient<T>(Func<HttpClient, T> action, string description);
-        T OnClient<T>(Func<HttpClient, T> action, Retry retry);
         IEndpoint CreateEndpoint(Address address, string baseUrl, string? logAlias = null);
     }
 
     internal class Http : IHttp
     {
-        private static object lockLock = new object();
-        private static readonly Dictionary<string, object> httpLocks = new Dictionary<string, object>();
+        private static readonly object httpLock = new object();
         private readonly ILog log;
         private readonly ITimeSet timeSet;
         private readonly Action<HttpClient> onClientCreated;
-        private readonly string id;
 
-        internal Http(string id, ILog log, ITimeSet timeSet)
-            : this(id, log, timeSet, DoNothing)
+        internal Http(ILog log, ITimeSet timeSet)
+            : this(log, timeSet, DoNothing)
         {
         }
 
-        internal Http(string id, ILog log, ITimeSet timeSet, Action<HttpClient> onClientCreated)
+        internal Http(ILog log, ITimeSet timeSet, Action<HttpClient> onClientCreated)
         {
-            this.id = id;
             this.log = log;
             this.timeSet = timeSet;
             this.onClientCreated = onClientCreated;
@@ -39,19 +35,13 @@ namespace Core
         }
 
         public T OnClient<T>(Func<HttpClient, T> action, string description)
-        {
-            var retry = new Retry(description, timeSet.HttpRetryTimeout(), timeSet.HttpCallRetryDelay(), f => { });
-            return OnClient(action, retry);
-        }
-
-        public T OnClient<T>(Func<HttpClient, T> action, Retry retry)
         {
             var client = GetClient();
 
             return LockRetry(() =>
             {
                 return action(client);
-            }, retry);
+            }, description);
         }
 
         public IEndpoint CreateEndpoint(Address address, string baseUrl, string? logAlias = null)
@@ -64,21 +54,11 @@ namespace Core
             return DebugStack.GetCallerName(skipFrames: 2);
         }
 
-        private T LockRetry<T>(Func<T> operation, Retry retry)
+        private T LockRetry<T>(Func<T> operation, string description)
         {
-            var httpLock = GetLock();
             lock (httpLock)
             {
-                return retry.Run(operation);
-            }
-        }
-
-        private object GetLock()
-        {
-            lock (lockLock) // I had to.
-            {
-                if (!httpLocks.ContainsKey(id)) httpLocks.Add(id, new object());
-                return httpLocks[id];
+                return Time.Retry(operation, timeSet.HttpMaxNumberOfRetries(), timeSet.HttpCallRetryDelay(), description);
             }
         }
 

Framework/Core/LogDownloadHandler.cs

@@ -0,0 +1,28 @@
+using KubernetesWorkflow;
+using Logging;
+
+namespace Core
+{
+    internal class LogDownloadHandler : LogHandler, ILogHandler
+    {
+        private readonly LogFile log;
+
+        internal LogDownloadHandler(string description, LogFile log)
+        {
+            this.log = log;
+
+            log.Write($"{description} -->> {log.FullFilename}");
+            log.WriteRaw(description);
+        }
+
+        internal IDownloadedLog DownloadLog()
+        {
+            return new DownloadedLog(log);
+        }
+
+        protected override void ProcessLine(string line)
+        {
+            log.WriteRaw(line);
+        }
+    }
+}

Framework/Core/PluginManager.cs

@@ -34,12 +34,12 @@
             return metadata;
         }
 
-        internal void DecommissionPlugins(bool deleteKubernetesResources, bool deleteTrackedFiles, bool waitTillDone)
+        internal void DecommissionPlugins(bool deleteKubernetesResources, bool deleteTrackedFiles)
         {
             foreach (var pair in pairs)
             {
                 pair.Plugin.Decommission();
-                pair.Tools.Decommission(deleteKubernetesResources, deleteTrackedFiles, waitTillDone);
+                pair.Tools.Decommission(deleteKubernetesResources, deleteTrackedFiles);
             }
         }
 

Framework/Core/PluginTools.cs

@@ -6,13 +6,7 @@ namespace Core
 {
     public interface IPluginTools : IWorkflowTool, ILogTool, IHttpFactoryTool, IFileTool
     {
-        ITimeSet TimeSet { get; }
-
-        /// <summary>
-        /// Deletes kubernetes and tracked file resources.
-        /// when `waitTillDone` is true, this function will block until resources are deleted.
-        /// </summary>
-        void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles, bool waitTillDone);
+        void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles);
     }
 
     public interface IWorkflowTool
@@ -27,9 +21,9 @@ namespace Core
 
     public interface IHttpFactoryTool
     {
-        IHttp CreateHttp(string id, Action<HttpClient> onClientCreated);
-        IHttp CreateHttp(string id, Action<HttpClient> onClientCreated, ITimeSet timeSet);
-        IHttp CreateHttp(string id);
+        IHttp CreateHttp(Action<HttpClient> onClientCreated);
+        IHttp CreateHttp(Action<HttpClient> onClientCreated, ITimeSet timeSet);
+        IHttp CreateHttp();
     }
 
     public interface IFileTool
@@ -39,6 +33,7 @@ namespace Core
 
     internal class PluginTools : IPluginTools
     {
+        private readonly ITimeSet timeSet;
         private readonly WorkflowCreator workflowCreator;
         private readonly IFileManager fileManager;
         private readonly LogPrefixer log;
@@ -47,30 +42,28 @@ namespace Core
         {
             this.log = new LogPrefixer(log);
             this.workflowCreator = workflowCreator;
-            TimeSet = timeSet;
+            this.timeSet = timeSet;
             fileManager = new FileManager(log, fileManagerRootFolder);
         }
 
-        public ITimeSet TimeSet { get; }
-
         public void ApplyLogPrefix(string prefix)
         {
             log.Prefix = prefix;
         }
 
-        public IHttp CreateHttp(string id, Action<HttpClient> onClientCreated)
+        public IHttp CreateHttp(Action<HttpClient> onClientCreated)
         {
-            return CreateHttp(id, onClientCreated, TimeSet);
+            return CreateHttp(onClientCreated, timeSet);
         }
 
-        public IHttp CreateHttp(string id, Action<HttpClient> onClientCreated, ITimeSet ts)
+        public IHttp CreateHttp(Action<HttpClient> onClientCreated, ITimeSet ts)
         {
-            return new Http(id, log, ts, onClientCreated);
+            return new Http(log, ts, onClientCreated);
         }
 
-        public IHttp CreateHttp(string id)
+        public IHttp CreateHttp()
         {
-            return new Http(id, log, TimeSet);
+            return new Http(log, timeSet);
         }
 
         public IStartupWorkflow CreateWorkflow(string? namespaceOverride = null)
@@ -78,9 +71,9 @@ namespace Core
             return workflowCreator.CreateWorkflow(namespaceOverride);
         }
 
-        public void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles, bool waitTillDone)
+        public void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles)
         {
-            if (deleteKubernetesResources) CreateWorkflow().DeleteNamespace(waitTillDone);
+            if (deleteKubernetesResources) CreateWorkflow().DeleteNamespace();
             if (deleteTrackedFiles) fileManager.DeleteAllFiles();
         }
 

Framework/Core/TimeSet.cs

@@ -2,31 +2,10 @@
 {
     public interface ITimeSet
     {
-        /// <summary>
-        /// Timeout for a single HTTP call.
-        /// </summary>
         TimeSpan HttpCallTimeout();
-
-        /// <summary>
-        /// Maximum total time to attempt to make a successful HTTP call to a service.
-        /// When HTTP calls time out during this timespan, retries will be made.
-        /// </summary>
-        TimeSpan HttpRetryTimeout();
-
-        /// <summary>
-        /// After a failed HTTP call, wait this long before trying again.
-        /// </summary>
+        int HttpMaxNumberOfRetries();
         TimeSpan HttpCallRetryDelay();
-
-        /// <summary>
-        /// After a failed K8s operation, wait this long before trying again.
-        /// </summary>
-        TimeSpan K8sOperationRetryDelay();
-
-        /// <summary>
-        /// Maximum total time to attempt to perform a successful k8s operation.
-        /// If k8s operations fail during this timespan, retries will be made.
-        /// </summary>
+        TimeSpan WaitForK8sServiceDelay();
         TimeSpan K8sOperationTimeout();
     }
 
@@ -34,12 +13,12 @@
     {
         public TimeSpan HttpCallTimeout()
         {
-            return TimeSpan.FromMinutes(2);
+            return TimeSpan.FromMinutes(3);
         }
 
-        public TimeSpan HttpRetryTimeout()
+        public int HttpMaxNumberOfRetries()
         {
-            return TimeSpan.FromMinutes(5);
+            return 3;
         }
 
         public TimeSpan HttpCallRetryDelay()
@@ -47,7 +26,7 @@
             return TimeSpan.FromSeconds(1);
         }
 
-        public TimeSpan K8sOperationRetryDelay()
+        public TimeSpan WaitForK8sServiceDelay()
         {
             return TimeSpan.FromSeconds(10);
         }
@@ -62,27 +41,27 @@
     {
         public TimeSpan HttpCallTimeout()
         {
-            return TimeSpan.FromMinutes(30);
+            return TimeSpan.FromHours(2);
         }
 
-        public TimeSpan HttpRetryTimeout()
+        public int HttpMaxNumberOfRetries()
         {
-            return TimeSpan.FromHours(2.2);
+            return 1;
         }
 
         public TimeSpan HttpCallRetryDelay()
         {
-            return TimeSpan.FromSeconds(20);
+            return TimeSpan.FromSeconds(2);
         }
 
-        public TimeSpan K8sOperationRetryDelay()
+        public TimeSpan WaitForK8sServiceDelay()
         {
-            return TimeSpan.FromSeconds(30);
+            return TimeSpan.FromSeconds(10);
         }
 
         public TimeSpan K8sOperationTimeout()
         {
-            return TimeSpan.FromHours(1);
+            return TimeSpan.FromMinutes(15);
         }
     }
 }

Framework/DiscordRewards/CheckConfig.cs

@@ -13,9 +13,9 @@ namespace DiscordRewards
     public enum CheckType
     {
         Uninitialized,
-        HostFilledSlot,
-        HostFinishedSlot,
-        ClientPostedContract,
-        ClientStartedContract,
+        FilledSlot,
+        FinishedSlot,
+        PostedContract,
+        StartedContract,
     }
 }

Framework/DiscordRewards/DiscordRewards.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

Framework/DiscordRewards/GiveRewardsCommand.cs

@@ -3,12 +3,8 @@
     public class GiveRewardsCommand
     {
         public RewardUsersCommand[] Rewards { get; set; } = Array.Empty<RewardUsersCommand>();
+        public MarketAverage[] Averages { get; set; } = Array.Empty<MarketAverage>();
         public string[] EventsOverview { get; set; } = Array.Empty<string>();
-
-        public bool HasAny()
-        {
-            return Rewards.Any() || EventsOverview.Any();
-        }
     }
 
     public class RewardUsersCommand
@@ -16,4 +12,15 @@
         public ulong RewardId { get; set; }
         public string[] UserAddresses { get; set; } = Array.Empty<string>();
     }
+
+    public class MarketAverage
+    {
+        public int NumberOfFinished { get; set; }
+        public TimeSpan TimeRange { get; set; }
+        public float Price { get; set; }
+        public float Size { get; set; }
+        public float Duration { get; set; }
+        public float Collateral { get; set; }
+        public float ProofProbability { get; set; }
+    }
 }

Framework/DiscordRewards/RewardRepo.cs

@@ -1,53 +1,53 @@
-namespace DiscordRewards
+using Utils;
+
+namespace DiscordRewards
 {
     public class RewardRepo
     {
         private static string Tag => RewardConfig.UsernameTag;
 
-        public RewardConfig[] Rewards { get; } = new RewardConfig[0];
+        public RewardConfig[] Rewards { get; } = new RewardConfig[]
+        {
+            // Filled any slot
+            new RewardConfig(1187039439558541498, $"{Tag} successfully filled their first slot!", new CheckConfig
+            {
+                Type = CheckType.FilledSlot
+            }),
 
-        // Example configuration, from test server:
-        //{
-        //    // Filled any slot
-        //    new RewardConfig(1187039439558541498, $"{Tag} successfully filled their first slot!", new CheckConfig
-        //    {
-        //        Type = CheckType.HostFilledSlot
-        //    }),
+            // Finished any slot
+            new RewardConfig(1202286165630390339, $"{Tag} successfully finished their first slot!", new CheckConfig
+            {
+                Type = CheckType.FinishedSlot
+            }),
 
-        //    // Finished any slot
-        //    new RewardConfig(1202286165630390339, $"{Tag} successfully finished their first slot!", new CheckConfig
-        //    {
-        //        Type = CheckType.HostFinishedSlot
-        //    }),
+            // Finished a sizable slot
+            new RewardConfig(1202286218738405418, $"{Tag} finished their first 1GB-24h slot! (10mb/5mins for test)", new CheckConfig
+            {
+                Type = CheckType.FinishedSlot,
+                MinSlotSize = 10.MB(),
+                MinDuration = TimeSpan.FromMinutes(5.0),
+            }),
 
-        //    // Finished a sizable slot
-        //    new RewardConfig(1202286218738405418, $"{Tag} finished their first 1GB-24h slot! (10mb/5mins for test)", new CheckConfig
-        //    {
-        //        Type = CheckType.HostFinishedSlot,
-        //        MinSlotSize = 10.MB(),
-        //        MinDuration = TimeSpan.FromMinutes(5.0),
-        //    }),
+            // Posted any contract
+            new RewardConfig(1202286258370383913, $"{Tag} posted their first contract!", new CheckConfig
+            {
+                Type = CheckType.PostedContract
+            }),
 
-        //    // Posted any contract
-        //    new RewardConfig(1202286258370383913, $"{Tag} posted their first contract!", new CheckConfig
-        //    {
-        //        Type = CheckType.ClientPostedContract
-        //    }),
+            // Started any contract
+            new RewardConfig(1202286330873126992, $"A contract created by {Tag} reached Started state for the first time!", new CheckConfig
+            {
+                Type = CheckType.StartedContract
+            }),
 
-        //    // Started any contract
-        //    new RewardConfig(1202286330873126992, $"A contract created by {Tag} reached Started state for the first time!", new CheckConfig
-        //    {
-        //        Type = CheckType.ClientStartedContract
-        //    }),
-
-        //    // Started a sizable contract
-        //    new RewardConfig(1202286381670608909, $"A large contract created by {Tag} reached Started state for the first time! (10mb/5mins for test)", new CheckConfig
-        //    {
-        //        Type = CheckType.ClientStartedContract,
-        //        MinNumberOfHosts = 4,
-        //        MinSlotSize = 10.MB(),
-        //        MinDuration = TimeSpan.FromMinutes(5.0),
-        //    })
-        //};
+            // Started a sizable contract
+            new RewardConfig(1202286381670608909, $"A large contract created by {Tag} reached Started state for the first time! (10mb/5mins for test)", new CheckConfig
+            {
+                Type = CheckType.StartedContract,
+                MinNumberOfHosts = 4,
+                MinSlotSize = 10.MB(),
+                MinDuration = TimeSpan.FromMinutes(5.0),
+            })
+        };
     }
 }

Framework/FileUtils/FileManager.cs

@@ -7,35 +7,27 @@ namespace FileUtils
     {
         TrackedFile CreateEmptyFile(string label = "");
         TrackedFile GenerateFile(ByteSize size, string label = "");
-        TrackedFile GenerateFile(Action<IGenerateOption> options, string label = "");
         void DeleteAllFiles();
         void ScopedFiles(Action action);
         T ScopedFiles<T>(Func<T> action);
     }
 
-    public interface IGenerateOption
-    {
-        IGenerateOption Random(ByteSize size);
-        IGenerateOption StringRepeat(string str, ByteSize size);
-        IGenerateOption StringRepeat(string str, int times);
-        IGenerateOption ByteRepeat(byte[] bytes, ByteSize size);
-        IGenerateOption ByteRepeat(byte[] bytes, int times);
-    }
-
     public class FileManager : IFileManager
     {
-        private static readonly NumberSource folderNumberSource = new NumberSource(0);
+        public const int ChunkSize = 1024 * 1024 * 100;
+        private static NumberSource folderNumberSource = new NumberSource(0);
+        private readonly Random random = new Random();
         private readonly ILog log;
+        private readonly string rootFolder;
         private readonly string folder;
         private readonly List<List<TrackedFile>> fileSetStack = new List<List<TrackedFile>>();
 
-        public const int ChunkSize = 1024 * 1024 * 100;
-
         public FileManager(ILog log, string rootFolder)
         {
             folder = Path.Combine(rootFolder, folderNumberSource.GetNextNumber().ToString("D5"));
 
             this.log = log;
+            this.rootFolder = rootFolder;
         }
 
         public TrackedFile CreateEmptyFile(string label = "")
@@ -49,15 +41,10 @@ namespace FileUtils
             return result;
         }
 
-        public TrackedFile GenerateFile(ByteSize size, string label = "")
-        {
-            return GenerateFile(o => o.Random(size), label);
-        }
-
-        public TrackedFile GenerateFile(Action<IGenerateOption> options, string label = "")
+        public TrackedFile GenerateFile(ByteSize size, string label)
         {
             var sw = Stopwatch.Begin(log);
-            var result = RunGenerators(options, label);
+            var result = GenerateRandomFile(size, label);
             sw.End($"Generated file {result.Describe()}.");
             return result;
         }
@@ -70,27 +57,16 @@ namespace FileUtils
         public void ScopedFiles(Action action)
         {
             PushFileSet();
-            try
-            {
-                action();
-            }
-            finally
-            {
-                PopFileSet();
-            }
+            action();
+            PopFileSet();
         }
 
         public T ScopedFiles<T>(Func<T> action)
         {
             PushFileSet();
-            try
-            {
-                return action();
-            }
-            finally
-            {
-                PopFileSet();
-            }
+            var result = action();
+            PopFileSet();
+            return result;
         }
 
         private void PushFileSet()
@@ -113,35 +89,26 @@ namespace FileUtils
             if (!Directory.GetFiles(folder).Any()) DeleteDirectory();
         }
 
-        private TrackedFile RunGenerators(Action<IGenerateOption> options, string label)
+        private TrackedFile GenerateRandomFile(ByteSize size, string label)
         {
             var result = CreateEmptyFile(label);
-            var generators = GetGenerators(options);
-            CheckSpaceAvailable(result, generators.GetRequiredSpace());
+            CheckSpaceAvailable(result, size);
 
-            using var stream = new FileStream(result.Filename, FileMode.Append);
-            generators.Run(stream);
+            GenerateFileBytes(result, size);
             return result;
         }
 
-        private GeneratorCollection GetGenerators(Action<IGenerateOption> options)
-        {
-            var result = new GeneratorCollection();
-            options(result);
-            return result;
-        }
-
-        private void CheckSpaceAvailable(TrackedFile testFile, long requiredSize)
+        private void CheckSpaceAvailable(TrackedFile testFile, ByteSize size)
         {
             var file = new FileInfo(testFile.Filename);
             var drive = new DriveInfo(file.Directory!.Root.FullName);
 
             var spaceAvailable = drive.TotalFreeSpace;
 
-            if (spaceAvailable < requiredSize)
+            if (spaceAvailable < size.SizeInBytes)
             {
                 var msg = $"Not enough disk space. " +
-                    $"{Formatter.FormatByteSize(requiredSize)} required. " +
+                    $"{Formatter.FormatByteSize(size.SizeInBytes)} required. " +
                     $"{Formatter.FormatByteSize(spaceAvailable)} available.";
 
                 log.Log(msg);
@@ -149,6 +116,34 @@ namespace FileUtils
             }
         }
 
+        private void GenerateFileBytes(TrackedFile result, ByteSize size)
+        {
+            long bytesLeft = size.SizeInBytes;
+            int chunkSize = ChunkSize;
+            while (bytesLeft > 0)
+            {
+                try
+                {
+                    var length = Math.Min(bytesLeft, chunkSize);
+                    AppendRandomBytesToFile(result, length);
+                    bytesLeft -= length;
+                }
+                catch
+                {
+                    chunkSize = chunkSize / 2;
+                    if (chunkSize < 1024) throw;
+                }
+            }
+        }
+
+        private void AppendRandomBytesToFile(TrackedFile result, long length)
+        {
+            var bytes = new byte[length];
+            random.NextBytes(bytes);
+            using var stream = new FileStream(result.Filename, FileMode.Append);
+            stream.Write(bytes, 0, bytes.Length);
+        }
+
         private void EnsureDirectory()
         {
             Directory.CreateDirectory(folder);

Framework/FileUtils/FileUtils.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

Framework/FileUtils/Generators.cs

@@ -1,141 +0,0 @@
-using System.Text;
-using Utils;
-
-namespace FileUtils
-{
-    public class GeneratorCollection : IGenerateOption
-    {
-        private readonly List<IGenerator> generators = new List<IGenerator>();
-
-        public IGenerateOption ByteRepeat(byte[] bytes, ByteSize size)
-        {
-            var times = size.SizeInBytes / bytes.Length;
-            generators.Add(new ByteRepeater(bytes, times));
-            return this;
-        }
-
-        public IGenerateOption ByteRepeat(byte[] bytes, int times)
-        {
-            generators.Add(new ByteRepeater(bytes, times));
-            return this;
-        }
-
-        public IGenerateOption Random(ByteSize size)
-        {
-            generators.Add(new RandomGenerator(size));
-            return this;
-        }
-
-        public IGenerateOption StringRepeat(string str, ByteSize size)
-        {
-            var times = size.SizeInBytes / str.Length;
-            generators.Add(new StringRepeater(str, times));
-            return this;
-        }
-
-        public IGenerateOption StringRepeat(string str, int times)
-        {
-            generators.Add(new StringRepeater(str, times));
-            return this;
-        }
-
-        public void Run(FileStream file)
-        {
-            foreach (var generator in generators)
-            {
-                generator.Generate(file);
-            }
-        }
-
-        public long GetRequiredSpace()
-        {
-            return generators.Sum(g => g.GetRequiredSpace());
-        }
-    }
-
-    public interface IGenerator
-    {
-        void Generate(FileStream file);
-        long GetRequiredSpace();
-    }
-
-    public class ByteRepeater : IGenerator
-    {
-        private readonly byte[] bytes;
-        private readonly long times;
-
-        public ByteRepeater(byte[] bytes, long times)
-        {
-            this.bytes = bytes;
-            this.times = times;
-        }
-
-        public void Generate(FileStream file)
-        {
-            for (var i = 0; i < times; i++)
-            {
-                file.Write(bytes, 0, bytes.Length);
-            }
-        }
-
-        public long GetRequiredSpace()
-        {
-            return bytes.Length * times;
-        }
-    }
-
-    public class StringRepeater : IGenerator
-    {
-        private readonly string str;
-        private readonly long times;
-
-        public StringRepeater(string str, long times)
-        {
-            this.str = str;
-            this.times = times;
-        }
-
-        public void Generate(FileStream file)
-        {
-            using var writer = new StreamWriter(file);
-            for (var i = 0; i < times; i++)
-            {
-                writer.Write(str);
-            }
-        }
-
-        public long GetRequiredSpace()
-        {
-            return Encoding.ASCII.GetBytes(str).Length * times;
-        }
-    }
-
-    public class RandomGenerator : IGenerator
-    {
-        private readonly Random random = new Random();
-        private readonly ByteSize size;
-
-        public RandomGenerator(ByteSize size)
-        {
-            this.size = size;
-        }
-
-        public void Generate(FileStream file)
-        {
-            var bytesLeft = size.SizeInBytes;
-            while (bytesLeft > 0)
-            {
-                var size = Math.Min(bytesLeft, FileManager.ChunkSize);
-                var bytes = new byte[size];
-                random.NextBytes(bytes);
-                file.Write(bytes, 0, bytes.Length);
-                bytesLeft -= size;
-            }
-        }
-
-        public long GetRequiredSpace()
-        {
-            return size.SizeInBytes;
-        }
-    }
-}

Framework/FileUtils/TrackedFile.cs

@@ -65,7 +65,7 @@ namespace FileUtils
 
                 if (readExpected == 0 && readActual == 0)
                 {
-                    log.Log($"OK: {Describe()} is equal to {actual.Describe()}.");
+                    log.Log($"OK: '{Describe()}' is equal to '{actual.Describe()}'.");
                     return;
                 }
 

Framework/GethConnector/GethConnector.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

Framework/KubernetesWorkflow/ByteSizeExtensions.cs

@@ -0,0 +1,41 @@
+using Utils;
+
+namespace KubernetesWorkflow
+{
+    public static class ByteSizeExtensions
+    {
+        public static string ToSuffixNotation(this ByteSize b)
+        {
+            long x = 1024;
+            var map = new Dictionary<long, string>
+            {
+                { Pow(x, 4), "Ti" },
+                { Pow(x, 3), "Gi" },
+                { Pow(x, 2), "Mi" },
+                { (x), "Ki" },
+            };
+
+            var bytes = b.SizeInBytes;
+            foreach (var pair in map)
+            {
+                if (bytes > pair.Key)
+                {
+                    double bytesD = bytes;
+                    double divD = pair.Key;
+                    double numD = Math.Ceiling(bytesD / divD);
+                    var v = Convert.ToInt64(numD);
+                    return $"{v}{pair.Value}";
+                }
+            }
+
+            return $"{bytes}";
+        }
+
+        private static long Pow(long x, int v)
+        {
+            long result = 1;
+            for (var i = 0; i < v; i++) result *= x;
+            return result;
+        }
+    }
+}

Framework/KubernetesWorkflow/Configuration.cs

@@ -21,8 +21,5 @@ namespace KubernetesWorkflow
 
         [JsonIgnore]
         public IK8sHooks Hooks { get; set; } = new DoNothingK8sHooks();
-
-        [JsonIgnore]
-        public Func<string?, string?> Replacer { get; set; } = s => s;
     }
 }

Framework/KubernetesWorkflow/CrashWatcher.cs

@@ -11,13 +11,12 @@ namespace KubernetesWorkflow
         private readonly string podName;
         private readonly string recipeName;
         private readonly string k8sNamespace;
-        private readonly Func<string?, string?> replacer;
+        private ILogHandler? logHandler;
         private CancellationTokenSource cts;
         private Task? worker;
         private Exception? workerException;
 
-        public CrashWatcher(ILog log, KubernetesClientConfiguration config, string containerName, string podName, string recipeName, string k8sNamespace,
-            Func<string?, string?> replacer)
+        public CrashWatcher(ILog log, KubernetesClientConfiguration config, string containerName, string podName, string recipeName, string k8sNamespace)
         {
             this.log = log;
             this.config = config;
@@ -25,14 +24,14 @@ namespace KubernetesWorkflow
             this.podName = podName;
             this.recipeName = recipeName;
             this.k8sNamespace = k8sNamespace;
-            this.replacer = replacer;
             cts = new CancellationTokenSource();
         }
 
-        public void Start()
+        public void Start(ILogHandler logHandler)
         {
             if (worker != null) throw new InvalidOperationException();
 
+            this.logHandler = logHandler;
             cts = new CancellationTokenSource();
             worker = Task.Run(Worker);
         }
@@ -51,9 +50,7 @@ namespace KubernetesWorkflow
         public bool HasContainerCrashed()
         {
             using var client = new Kubernetes(config);
-            var result = HasContainerBeenRestarted(client);
-            if (result) DownloadCrashedContainerLogs(client);
-            return result;
+            return HasContainerBeenRestarted(client);
         }
 
         private void Worker()
@@ -86,16 +83,14 @@ namespace KubernetesWorkflow
         private bool HasContainerBeenRestarted(Kubernetes client)
         {
             var podInfo = client.ReadNamespacedPod(podName, k8sNamespace);
-            var result = podInfo.Status.ContainerStatuses.Any(c => c.RestartCount > 0);
-            if (result) log.Log("Pod crash detected for " + containerName);
-            return result;
+            return podInfo.Status.ContainerStatuses.Any(c => c.RestartCount > 0);
         }
 
         private void DownloadCrashedContainerLogs(Kubernetes client)
         {
+            log.Log("Pod crash detected for " + containerName);
             using var stream = client.ReadNamespacedPodLog(podName, k8sNamespace, recipeName, previous: true);
-            var handler = new WriteToFileLogHandler(log, "Crash detected for " + containerName);
-            handler.Log(stream, replacer);
+            logHandler!.Log(stream);
         }
     }
 }

Framework/KubernetesWorkflow/K8sCluster.cs

@@ -16,7 +16,6 @@ namespace KubernetesWorkflow
         {
             var config = GetConfig();
             UpdateHostAddress(config);
-            config.SkipTlsVerify = true; // Required for operation on Wings cluster.
             return config;
         }
 

Framework/KubernetesWorkflow/K8sController.cs

@@ -12,11 +12,10 @@ namespace KubernetesWorkflow
         private readonly ILog log;
         private readonly K8sCluster cluster;
         private readonly WorkflowNumberSource workflowNumberSource;
-        private readonly Func<string?, string?> replacer;
         private readonly K8sClient client;
         public const string PodLabelKey = "pod-uuid";
 
-        public K8sController(ILog log, K8sCluster cluster, WorkflowNumberSource workflowNumberSource, string k8sNamespace, Func<string?, string?> replacer)
+        public K8sController(ILog log, K8sCluster cluster, WorkflowNumberSource workflowNumberSource, string k8sNamespace)
         {
             this.log = log;
             this.cluster = cluster;
@@ -24,7 +23,6 @@ namespace KubernetesWorkflow
             client = new K8sClient(cluster.GetK8sClientConfig());
 
             K8sNamespace = k8sNamespace;
-            this.replacer = replacer;
         }
 
         public void Dispose()
@@ -45,11 +43,6 @@ namespace KubernetesWorkflow
             return new StartResult(cluster, containerRecipes, deployment, internalService, externalService);
         }
 
-        public void WaitUntilOnline(RunningContainer container)
-        {
-            WaitUntilDeploymentOnline(container);
-        }
-
         public PodInfo GetPodInfo(RunningDeployment deployment)
         {
             var pod = GetPodForDeployment(deployment);
@@ -66,15 +59,15 @@ namespace KubernetesWorkflow
             if (waitTillStopped) WaitUntilPodsForDeploymentAreOffline(startResult.Deployment);
         }
 
-        public void DownloadPodLog(RunningContainer container, ILogHandler logHandler, int? tailLines, bool? previous, Func<string?, string?> replacer)
+        public void DownloadPodLog(RunningContainer container, ILogHandler logHandler, int? tailLines)
         {
             log.Debug();
 
             var podName = GetPodName(container);
             var recipeName = container.Recipe.Name;
 
-            using var stream = client.Run(c => c.ReadNamespacedPodLog(podName, K8sNamespace, recipeName, tailLines: tailLines, previous: previous));
-            logHandler.Log(stream, replacer);
+            using var stream = client.Run(c => c.ReadNamespacedPodLog(podName, K8sNamespace, recipeName, tailLines: tailLines));
+            logHandler.Log(stream);
         }
 
         public string ExecuteCommand(RunningContainer container, string command, params string[] args)
@@ -117,7 +110,7 @@ namespace KubernetesWorkflow
             });
         }
 
-        public void DeleteAllNamespacesStartingWith(string prefix, bool wait)
+        public void DeleteAllNamespacesStartingWith(string prefix)
         {
             log.Debug();
 
@@ -126,28 +119,25 @@ namespace KubernetesWorkflow
 
             foreach (var ns in namespaces)
             {
-                DeleteNamespace(ns, wait);
+                DeleteNamespace(ns);
             }
         }
 
-        public void DeleteNamespace(bool wait)
+        public void DeleteNamespace()
         {
             log.Debug();
             if (IsNamespaceOnline(K8sNamespace))
             {
                 client.Run(c => c.DeleteNamespace(K8sNamespace, null, null, gracePeriodSeconds: 0));
-
-                if (wait) WaitUntilNamespaceDeleted(K8sNamespace);
             }
         }
 
-        public void DeleteNamespace(string ns, bool wait)
+        public void DeleteNamespace(string ns)
         {
             log.Debug();
             if (IsNamespaceOnline(ns))
             {
                 client.Run(c => c.DeleteNamespace(ns, null, null, gracePeriodSeconds: 0));
-                if (wait) WaitUntilNamespaceDeleted(ns);
             }
         }
 
@@ -382,6 +372,7 @@ namespace KubernetesWorkflow
             };
 
             client.Run(c => c.CreateNamespacedDeployment(deploymentSpec, K8sNamespace));
+            WaitUntilDeploymentOnline(deploymentSpec.Metadata.Name);
 
             var name = deploymentSpec.Metadata.Name;
             return new RunningDeployment(name, podLabel);
@@ -537,7 +528,7 @@ namespace KubernetesWorkflow
             }
             if (set.Memory.SizeInBytes != 0)
             {
-                result.Add("memory", new ResourceQuantity(set.Memory.SizeInBytes.ToString()));
+                result.Add("memory", new ResourceQuantity(set.Memory.ToSuffixNotation()));
             }
             return result;
         }
@@ -710,14 +701,14 @@ namespace KubernetesWorkflow
 
         private string GetPodName(RunningContainer container)
         {
-            return GetPodForDeployment(container.RunningPod.StartResult.Deployment).Metadata.Name;
+            return GetPodForDeployment(container.RunningContainers.StartResult.Deployment).Metadata.Name;
         }
 
         private V1Pod GetPodForDeployment(RunningDeployment deployment)
         {
             return Time.Retry(() => GetPodForDeplomentInternal(deployment),
                 // We will wait up to 1 minute, k8s might be moving pods around.
-                maxTimeout: TimeSpan.FromMinutes(1),
+                maxRetries: 6,
                 retryTime: TimeSpan.FromSeconds(10),
                 description: "Find pod by label for deployment.");
         }
@@ -873,45 +864,16 @@ namespace KubernetesWorkflow
 
         private void WaitUntilNamespaceCreated() 
         {
-            WaitUntil(() => IsNamespaceOnline(K8sNamespace), nameof(WaitUntilNamespaceCreated));
+            WaitUntil(() => IsNamespaceOnline(K8sNamespace));
         }
 
-        private void WaitUntilNamespaceDeleted(string @namespace)
-        {
-            WaitUntil(() => !IsNamespaceOnline(@namespace), nameof(WaitUntilNamespaceDeleted));
-        }
-
-        private void WaitUntilDeploymentOnline(RunningContainer container)
+        private void WaitUntilDeploymentOnline(string deploymentName)
         {
             WaitUntil(() =>
             {
-                CheckForCrash(container);
-
-                var deployment = client.Run(c => c.ReadNamespacedDeployment(container.Recipe.Name, K8sNamespace));
+                var deployment = client.Run(c => c.ReadNamespacedDeployment(deploymentName, K8sNamespace));
                 return deployment?.Status.AvailableReplicas != null && deployment.Status.AvailableReplicas > 0;
-            }, nameof(WaitUntilDeploymentOnline));
-        }
-
-        private void CheckForCrash(RunningContainer container)
-        {
-            var deploymentName = container.Recipe.Name;
-            var podName = GetPodName(container);
-
-            var podInfo = client.Run(c => c.ReadNamespacedPod(podName, K8sNamespace));
-            if (podInfo == null) return;
-            if (podInfo.Status == null) return;
-            if (podInfo.Status.ContainerStatuses == null) return;
-
-            var result = podInfo.Status.ContainerStatuses.Any(c => c.RestartCount > 0);
-            if (result)
-            {
-                var msg = $"Pod crash detected for deployment {deploymentName} (pod:{podName})";
-                log.Error(msg);
-
-                DownloadPodLog(container, new WriteToFileLogHandler(log, msg), tailLines: null, previous: true, replacer);
-
-                throw new Exception(msg);
-            }
+            });
         }
 
         private void WaitUntilDeploymentOffline(string deploymentName)
@@ -921,7 +883,7 @@ namespace KubernetesWorkflow
                 var deployments = client.Run(c => c.ListNamespacedDeployment(K8sNamespace));
                 var deployment = deployments.Items.SingleOrDefault(d => d.Metadata.Name == deploymentName);
                 return deployment == null || deployment.Status.AvailableReplicas == 0;
-            }, nameof(WaitUntilDeploymentOffline));
+            });
         }
 
         private void WaitUntilPodsForDeploymentAreOffline(RunningDeployment deployment)
@@ -930,19 +892,19 @@ namespace KubernetesWorkflow
             {
                 var pods = FindPodsByLabel(deployment.PodLabel);
                 return !pods.Any();
-            }, nameof(WaitUntilPodsForDeploymentAreOffline));
+            });
         }
 
-        private void WaitUntil(Func<bool> predicate, string msg)
+        private void WaitUntil(Func<bool> predicate)
         {
             var sw = Stopwatch.Begin(log, true);
             try
             {
-                Time.WaitUntil(predicate, cluster.K8sOperationTimeout(), cluster.K8sOperationRetryDelay(), msg);
+                Time.WaitUntil(predicate, cluster.K8sOperationTimeout(), cluster.K8sOperationRetryDelay());
             }
             finally
             {
-                sw.End(msg, 1);
+                sw.End("", 1);
             }
         }
 
@@ -954,7 +916,7 @@ namespace KubernetesWorkflow
             var podName = GetPodName(container);
             var recipeName = container.Recipe.Name;
 
-            return new CrashWatcher(log, cluster.GetK8sClientConfig(), containerName, podName, recipeName, K8sNamespace, replacer);
+            return new CrashWatcher(log, cluster.GetK8sClientConfig(), containerName, podName, recipeName, K8sNamespace);
         }
 
         private V1Pod[] FindPodsByLabel(string podLabel)

Framework/KubernetesWorkflow/K8sHooks.cs

@@ -5,18 +5,18 @@ namespace KubernetesWorkflow
 {
     public interface IK8sHooks
     {
-        void OnContainersStarted(RunningPod runningPod);
-        void OnContainersStopped(RunningPod runningPod);
+        void OnContainersStarted(RunningContainers runningContainers);
+        void OnContainersStopped(RunningContainers runningContainers);
         void OnContainerRecipeCreated(ContainerRecipe recipe);
     }
 
     public class DoNothingK8sHooks : IK8sHooks
     {
-        public void OnContainersStarted(RunningPod runningPod)
+        public void OnContainersStarted(RunningContainers runningContainers)
         {
         }
 
-        public void OnContainersStopped(RunningPod runningPod)
+        public void OnContainersStopped(RunningContainers runningContainers)
         {
         }
 

Framework/KubernetesWorkflow/K8sNameUtils.cs

@@ -24,8 +24,8 @@
                 .Replace("]", "-")
                 .Replace(",", "-");
 
-            if (result.Length > maxLength) result = result.Substring(0, maxLength);
             result = result.Trim('-');
+            if (result.Length > maxLength) result = result.Substring(0, maxLength);
 
             return result;
         }

Framework/KubernetesWorkflow/KubernetesWorkflow.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
 	  <RootNamespace>KubernetesWorkflow</RootNamespace>
 	  <ImplicitUsings>enable</ImplicitUsings>
 	  <Nullable>enable</Nullable>

Framework/KubernetesWorkflow/LogHandler.cs

@@ -1,46 +1,23 @@
-using Logging;
-
-namespace KubernetesWorkflow
+namespace KubernetesWorkflow
 {
     public interface ILogHandler
     {
-        void Log(Stream log, Func<string?, string?> replacer);
+        void Log(Stream log);
     }
 
     public abstract class LogHandler : ILogHandler
     {
-        public void Log(Stream log, Func<string?, string?> replacer)
+        public void Log(Stream log)
         {
             using var reader = new StreamReader(log);
             var line = reader.ReadLine();
             while (line != null)
             {
-                line = replacer(reader.ReadLine());
-                if (line != null) ProcessLine(line);
+                ProcessLine(line);
+                line = reader.ReadLine();
             }
         }
 
         protected abstract void ProcessLine(string line);
     }
-
-    public class WriteToFileLogHandler : LogHandler, ILogHandler
-    {
-        public WriteToFileLogHandler(ILog sourceLog, string description)
-        {
-            LogFile = sourceLog.CreateSubfile();
-
-            var msg = $"{description} -->> {LogFile.FullFilename}";
-            sourceLog.Log(msg);
-
-            LogFile.Write(msg);
-            LogFile.WriteRaw(description);
-        }
-
-        public LogFile LogFile { get; }
-
-        protected override void ProcessLine(string line)
-        {
-            LogFile.WriteRaw(line);
-        }
-    }
 }

Framework/KubernetesWorkflow/Recipe/ContainerAdditionals.cs

@@ -1,5 +1,4 @@
-using Newtonsoft.Json;
-using Newtonsoft.Json.Linq;
+using Newtonsoft.Json.Linq;
 
 namespace KubernetesWorkflow.Recipe
 {
@@ -22,13 +21,14 @@ namespace KubernetesWorkflow.Recipe
             var typeName = GetTypeName(typeof(T));
             var userData = Additionals.SingleOrDefault(a => a.Type == typeName);
             if (userData == null) return default;
-            return JsonConvert.DeserializeObject<T>(userData.UserData);
+            var jobject = (JObject)userData.UserData;
+            return jobject.ToObject<T>();
         }
 
         private static Additional ConvertToAdditional(object userData)
         {
             var typeName = GetTypeName(userData.GetType());
-            return new Additional(typeName, JsonConvert.SerializeObject(userData));
+            return new Additional(typeName, userData);
         }
 
         private static string GetTypeName(Type type)
@@ -41,13 +41,13 @@ namespace KubernetesWorkflow.Recipe
 
     public class Additional
     {
-        public Additional(string type, string userData)
+        public Additional(string type, object userData)
         {
             Type = type;
             UserData = userData;
         }
 
         public string Type { get; }
-        public string UserData { get; }
+        public object UserData { get; }
     }
 }

Framework/KubernetesWorkflow/Recipe/ContainerRecipe.cs

@@ -2,9 +2,8 @@
 {
     public class ContainerRecipe
     {
-        public ContainerRecipe(DateTime recipeCreatedUtc, int number, string? nameOverride, string image, ContainerResources resources, SchedulingAffinity schedulingAffinity, CommandOverride commandOverride, bool setCriticalPriority, Port[] exposedPorts, Port[] internalPorts, EnvVar[] envVars, PodLabels podLabels, PodAnnotations podAnnotations, VolumeMount[] volumes, ContainerAdditionals additionals)
+        public ContainerRecipe(int number, string? nameOverride, string image, ContainerResources resources, SchedulingAffinity schedulingAffinity, CommandOverride commandOverride, bool setCriticalPriority, Port[] exposedPorts, Port[] internalPorts, EnvVar[] envVars, PodLabels podLabels, PodAnnotations podAnnotations, VolumeMount[] volumes, ContainerAdditionals additionals)
         {
-            RecipeCreatedUtc = recipeCreatedUtc;
             Number = number;
             NameOverride = nameOverride;
             Image = image;
@@ -32,7 +31,6 @@
             if (exposedPorts.Any(p => string.IsNullOrEmpty(p.Tag))) throw new Exception("Port tags are required for all exposed ports.");
         }
 
-        public DateTime RecipeCreatedUtc { get; }
         public string Name { get; }
         public int Number { get; }
         public string? NameOverride { get; }

Framework/KubernetesWorkflow/Recipe/ContainerRecipeFactory.cs

@@ -25,7 +25,7 @@ namespace KubernetesWorkflow.Recipe
 
             Initialize(config);
 
-            var recipe = new ContainerRecipe(DateTime.UtcNow, containerNumber, config.NameOverride, Image, resources, schedulingAffinity, commandOverride, setCriticalPriority,
+            var recipe = new ContainerRecipe(containerNumber, config.NameOverride, Image, resources, schedulingAffinity, commandOverride, setCriticalPriority,
                 exposedPorts.ToArray(),
                 internalPorts.ToArray(),
                 envVars.ToArray(),
@@ -73,6 +73,13 @@ namespace KubernetesWorkflow.Recipe
             return p;
         }
 
+        protected Port AddInternalPort(int number, string tag = "", PortProtocol protocol = PortProtocol.TCP)
+        {
+            var p = factory.CreateInternalPort(number, tag, protocol);
+            internalPorts.Add(p);
+            return p;
+        }
+
         protected void AddExposedPortAndVar(string name, string tag, PortProtocol protocol = PortProtocol.TCP)
         {
             AddEnvVar(name, AddExposedPort(tag, protocol));
@@ -105,7 +112,7 @@ namespace KubernetesWorkflow.Recipe
 
         protected void AddVolume(string name, string mountPath, string? subPath = null, string? secret = null, string? hostPath = null)
         {
-            var size = 10.MB().SizeInBytes.ToString();
+            var size = 10.MB().ToSuffixNotation();
             volumeMounts.Add(new VolumeMount(name, mountPath, subPath, size, secret, hostPath));
         }
 
@@ -114,7 +121,7 @@ namespace KubernetesWorkflow.Recipe
             volumeMounts.Add(new VolumeMount(
                 $"autovolume-{Guid.NewGuid().ToString().ToLowerInvariant()}",
                 mountPath,
-                resourceQuantity: volumeSize.SizeInBytes.ToString()));
+                resourceQuantity: volumeSize.ToSuffixNotation()));
         }
 
         protected void Additional(object userData)

Framework/KubernetesWorkflow/Recipe/RecipeComponentFactory.cs

@@ -16,7 +16,12 @@ namespace KubernetesWorkflow.Recipe
 
         public Port CreateInternalPort(string tag, PortProtocol protocol)
         {
-            return new Port(internalNumberSource.GetNextNumber(), tag, protocol);
+            return CreateInternalPort(internalNumberSource.GetNextNumber(), tag, protocol);
+        }
+
+        public Port CreateInternalPort(int number, string tag, PortProtocol protocol)
+        {
+            return new Port(number, tag, protocol);
         }
 
         public Port CreateExternalPort(int number, string tag, PortProtocol protocol)

Framework/KubernetesWorkflow/RunningPod.cs

@@ -1,5 +1,8 @@
-using KubernetesWorkflow.Recipe;
+using k8s;
+using k8s.Models;
+using KubernetesWorkflow.Recipe;
 using KubernetesWorkflow.Types;
+using Newtonsoft.Json;
 
 namespace KubernetesWorkflow
 {

Framework/KubernetesWorkflow/StartupWorkflow.cs

@@ -9,17 +9,16 @@ namespace KubernetesWorkflow
     public interface IStartupWorkflow
     {
         IKnownLocations GetAvailableLocations();
-        FutureContainers Start(int numberOfContainers, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig);
-        FutureContainers Start(int numberOfContainers, ILocation location, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig);
+        RunningContainers Start(int numberOfContainers, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig);
+        RunningContainers Start(int numberOfContainers, ILocation location, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig);
         PodInfo GetPodInfo(RunningContainer container);
-        PodInfo GetPodInfo(RunningPod pod);
+        PodInfo GetPodInfo(RunningContainers containers);
         CrashWatcher CreateCrashWatcher(RunningContainer container);
-        void Stop(RunningPod pod, bool waitTillStopped);
-        void DownloadContainerLog(RunningContainer container, ILogHandler logHandler, int? tailLines = null, bool? previous = null);
-        IDownloadedLog DownloadContainerLog(RunningContainer container, int? tailLines = null, bool? previous = null);
+        void Stop(RunningContainers containers, bool waitTillStopped);
+        void DownloadContainerLog(RunningContainer container, ILogHandler logHandler, int? tailLines = null);
         string ExecuteCommand(RunningContainer container, string command, params string[] args);
-        void DeleteNamespace(bool wait);
-        void DeleteNamespacesStartingWith(string namespacePrefix, bool wait);
+        void DeleteNamespace();
+        void DeleteNamespacesStartingWith(string namespacePrefix);
     }
 
     public class StartupWorkflow : IStartupWorkflow
@@ -28,17 +27,16 @@ namespace KubernetesWorkflow
         private readonly WorkflowNumberSource numberSource;
         private readonly K8sCluster cluster;
         private readonly string k8sNamespace;
-        private readonly Func<string?, string?> replacer;
         private readonly RecipeComponentFactory componentFactory = new RecipeComponentFactory();
         private readonly LocationProvider locationProvider;
 
-        internal StartupWorkflow(ILog log, WorkflowNumberSource numberSource, K8sCluster cluster, string k8sNamespace, Func<string?, string?> replacer)
+        internal StartupWorkflow(ILog log, WorkflowNumberSource numberSource, K8sCluster cluster, string k8sNamespace)
         {
             this.log = log;
             this.numberSource = numberSource;
             this.cluster = cluster;
             this.k8sNamespace = k8sNamespace;
-            this.replacer = replacer;
+
             locationProvider = new LocationProvider(log, K8s);
         }
 
@@ -47,12 +45,12 @@ namespace KubernetesWorkflow
             return locationProvider.GetAvailableLocations();
         }
 
-        public FutureContainers Start(int numberOfContainers, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig)
+        public RunningContainers Start(int numberOfContainers, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig)
         {
             return Start(numberOfContainers, KnownLocations.UnspecifiedLocation, recipeFactory, startupConfig);
         }
 
-        public FutureContainers Start(int numberOfContainers, ILocation location, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig)
+        public RunningContainers Start(int numberOfContainers, ILocation location, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig)
         {
             return K8s(controller =>
             {
@@ -62,36 +60,25 @@ namespace KubernetesWorkflow
                 var startResult = controller.BringOnline(recipes, location);
                 var containers = CreateContainers(startResult, recipes, startupConfig);
 
-                var rc = new RunningPod(Guid.NewGuid().ToString(), startupConfig, startResult, containers);
+                var rc = new RunningContainers(startupConfig, startResult, containers);
                 cluster.Configuration.Hooks.OnContainersStarted(rc);
 
                 if (startResult.ExternalService != null)
                 {
                     componentFactory.Update(controller);
                 }
-                return new FutureContainers(rc, this);
-            });
-        }
-
-        public void WaitUntilOnline(RunningPod rc)
-        {
-            K8s(controller =>
-            {
-                foreach (var c in rc.Containers)
-                {
-                    controller.WaitUntilOnline(c);
-                }
+                return rc;
             });
         }
 
         public PodInfo GetPodInfo(RunningContainer container)
         {
-            return K8s(c => c.GetPodInfo(container.RunningPod.StartResult.Deployment));
+            return K8s(c => c.GetPodInfo(container.RunningContainers.StartResult.Deployment));
         }
 
-        public PodInfo GetPodInfo(RunningPod pod)
+        public PodInfo GetPodInfo(RunningContainers containers)
         {
-            return K8s(c => c.GetPodInfo(pod.StartResult.Deployment));
+            return K8s(c => c.GetPodInfo(containers.StartResult.Deployment));
         }
 
         public CrashWatcher CreateCrashWatcher(RunningContainer container)
@@ -99,43 +86,21 @@ namespace KubernetesWorkflow
             return K8s(c => c.CreateCrashWatcher(container));
         }
 
-        public void Stop(RunningPod runningPod, bool waitTillStopped)
-        {
-            if (runningPod.IsStopped) return;
-            foreach (var c in runningPod.Containers)
-            {
-                c.StopLog = DownloadContainerLog(c);
-            }
-            runningPod.IsStopped = true;
-
-            K8s(controller =>
-            {
-                controller.Stop(runningPod.StartResult, waitTillStopped);
-            });
-
-            cluster.Configuration.Hooks.OnContainersStopped(runningPod);
-        }
-
-        public void DownloadContainerLog(RunningContainer container, ILogHandler logHandler, int? tailLines = null, bool? previous = null)
+        public void Stop(RunningContainers runningContainers, bool waitTillStopped)
         {
             K8s(controller =>
             {
-                controller.DownloadPodLog(container, logHandler, tailLines, previous, replacer);
+                controller.Stop(runningContainers.StartResult, waitTillStopped);
+                cluster.Configuration.Hooks.OnContainersStopped(runningContainers);
             });
         }
 
-        public IDownloadedLog DownloadContainerLog(RunningContainer container, int? tailLines = null, bool? previous = null)
+        public void DownloadContainerLog(RunningContainer container, ILogHandler logHandler, int? tailLines = null)
         {
-            var msg = $"Downloading container log for '{container.Name}'";
-            log.Log(msg);
-            var logHandler = new WriteToFileLogHandler(log, msg);
-
             K8s(controller =>
             {
-                controller.DownloadPodLog(container, logHandler, tailLines, previous, replacer);
+                controller.DownloadPodLog(container, logHandler, tailLines);
             });
-
-            return new DownloadedLog(logHandler, container.Name);
         }
 
         public string ExecuteCommand(RunningContainer container, string command, params string[] args)
@@ -146,19 +111,19 @@ namespace KubernetesWorkflow
             });
         }
 
-        public void DeleteNamespace(bool wait)
+        public void DeleteNamespace()
         {
             K8s(controller =>
             {
-                controller.DeleteNamespace(wait);
+                controller.DeleteNamespace();
             });
         }
 
-        public void DeleteNamespacesStartingWith(string namespacePrefix, bool wait)
+        public void DeleteNamespacesStartingWith(string namespacePrefix)
         {
             K8s(controller =>
             {
-                controller.DeleteAllNamespacesStartingWith(namespacePrefix, wait);
+                controller.DeleteAllNamespacesStartingWith(namespacePrefix);
             });
         }
 
@@ -171,7 +136,7 @@ namespace KubernetesWorkflow
                 var addresses = CreateContainerAddresses(startResult, r);
                 log.Debug($"{r}={name} -> container addresses: {string.Join(Environment.NewLine, addresses.Select(a => a.ToString()))}");
 
-                return new RunningContainer(Guid.NewGuid().ToString(), name, r, addresses);
+                return new RunningContainer(name, r, addresses);
 
             }).ToArray();
         }
@@ -258,7 +223,7 @@ namespace KubernetesWorkflow
         {
             try
             {
-                var controller = new K8sController(log, cluster, numberSource, k8sNamespace, replacer);
+                var controller = new K8sController(log, cluster, numberSource, k8sNamespace);
                 action(controller);
                 controller.Dispose();
             }
@@ -273,7 +238,7 @@ namespace KubernetesWorkflow
         {
             try
             {
-                var controller = new K8sController(log, cluster, numberSource, k8sNamespace, replacer);
+                var controller = new K8sController(log, cluster, numberSource, k8sNamespace);
                 var result = action(controller);
                 controller.Dispose();
                 return result;

Framework/KubernetesWorkflow/Types/FutureContainers.cs

@@ -1,20 +0,0 @@
-namespace KubernetesWorkflow.Types
-{
-    public class FutureContainers
-    {
-        private readonly RunningPod runningPod;
-        private readonly StartupWorkflow workflow;
-
-        public FutureContainers(RunningPod runningPod, StartupWorkflow workflow)
-        {
-            this.runningPod = runningPod;
-            this.workflow = workflow;
-        }
-
-        public RunningPod WaitForOnline()
-        {
-            workflow.WaitUntilOnline(runningPod);
-            return runningPod;
-        }
-    }
-}

Framework/KubernetesWorkflow/Types/RunningContainer.cs

@@ -7,29 +7,27 @@ namespace KubernetesWorkflow.Types
 {
     public class RunningContainer
     {
-        public RunningContainer(string id, string name, ContainerRecipe recipe, ContainerAddress[] addresses)
+        public RunningContainer(string name, ContainerRecipe recipe, ContainerAddress[] addresses)
         {
-            Id = id;
             Name = name;
             Recipe = recipe;
             Addresses = addresses;
         }
 
-        public string Id { get; }
         public string Name { get; }
         public ContainerRecipe Recipe { get; }
         public ContainerAddress[] Addresses { get; }
-        public IDownloadedLog? StopLog { get; internal set; }
 
         [JsonIgnore]
-        public RunningPod RunningPod { get; internal set; } = null!;
+        public RunningContainers RunningContainers { get; internal set; } = null!;
 
-        public Address GetAddress(string portTag)
+        public Address GetAddress(ILog log, string portTag)
         {
             var addresses = Addresses.Where(a => a.PortTag == portTag).ToArray();
             if (!addresses.Any()) throw new Exception("No addresses found for portTag: " + portTag);
 
             var select = SelectAddress(addresses);
+            log.Debug($"Container '{Name}' selected for tag '{portTag}' address: '{select}'");
             return select.Address;
         }
 
@@ -52,21 +50,5 @@ namespace KubernetesWorkflow.Types
             }
             throw new Exception("Running location not known.");
         }
-
-        public override string ToString()
-        {
-            return Name;
-        }
-
-        public override bool Equals(object? obj)
-        {
-            return obj is RunningContainer container &&
-                   Id == container.Id;
-        }
-
-        public override int GetHashCode()
-        {
-            return HashCode.Combine(Id);
-        }
     }
 }

Framework/KubernetesWorkflow/Types/RunningContainers.cs

@@ -0,0 +1,44 @@
+using Newtonsoft.Json;
+
+namespace KubernetesWorkflow.Types
+{
+    public class RunningContainers
+    {
+        public RunningContainers(StartupConfig startupConfig, StartResult startResult, RunningContainer[] containers)
+        {
+            StartupConfig = startupConfig;
+            StartResult = startResult;
+            Containers = containers;
+
+            foreach (var c in containers) c.RunningContainers = this;
+        }
+
+        public StartupConfig StartupConfig { get; }
+        public StartResult StartResult { get; }
+        public RunningContainer[] Containers { get; }
+
+        [JsonIgnore]
+        public string Name
+        {
+            get { return $"{Containers.Length}x '{Containers.First().Name}'"; }
+        }
+
+        public string Describe()
+        {
+            return string.Join(",", Containers.Select(c => c.Name));
+        }
+    }
+
+    public static class RunningContainersExtensions
+    {
+        public static RunningContainer[] Containers(this RunningContainers[] runningContainers)
+        {
+            return runningContainers.SelectMany(c => c.Containers).ToArray();
+        }
+
+        public static string Describe(this RunningContainers[] runningContainers)
+        {
+            return string.Join(",", runningContainers.Select(c => c.Describe()));
+        }
+    }
+}

Framework/KubernetesWorkflow/Types/RunningPod.cs

@@ -1,61 +0,0 @@
-using Newtonsoft.Json;
-
-namespace KubernetesWorkflow.Types
-{
-    public class RunningPod
-    {
-        public RunningPod(string id, StartupConfig startupConfig, StartResult startResult, RunningContainer[] containers)
-        {
-            Id = id;
-            StartupConfig = startupConfig;
-            StartResult = startResult;
-            Containers = containers;
-
-            foreach (var c in containers) c.RunningPod = this;
-        }
-
-        public string Id { get; }
-        public StartupConfig StartupConfig { get; }
-        public StartResult StartResult { get; }
-        public RunningContainer[] Containers { get; }
-
-        [JsonIgnore]
-        public string Name
-        {
-            get { return $"'{string.Join("&", Containers.Select(c => c.Name).ToArray())}'"; }
-        }
-
-        [JsonIgnore]
-        public bool IsStopped { get; internal set; }
-
-        public string Describe()
-        {
-            return string.Join(",", Containers.Select(c => c.Name));
-        }
-
-        public override bool Equals(object? obj)
-        {
-            return obj is RunningPod pod &&
-                   Id == pod.Id;
-        }
-
-        public override int GetHashCode()
-        {
-            return HashCode.Combine(Id);
-        }
-
-        public override string ToString()
-        {
-            if (IsStopped) return Name + " (*)";
-            return Name;
-        }
-    }
-
-    public static class RunningContainersExtensions
-    {
-        public static string Describe(this RunningPod[] runningContainers)
-        {
-            return string.Join(",", runningContainers.Select(c => c.Describe()));
-        }
-    }
-}

Framework/KubernetesWorkflow/WorkflowCreator.cs

@@ -25,7 +25,7 @@ namespace KubernetesWorkflow
             var workflowNumberSource = new WorkflowNumberSource(numberSource.GetNextNumber(),
                                                                     containerNumberSource);
 
-            return new StartupWorkflow(log, workflowNumberSource, cluster, GetNamespace(namespaceOverride), configuration.Replacer);
+            return new StartupWorkflow(log, workflowNumberSource, cluster, GetNamespace(namespaceOverride));
         }
 
         private string GetNamespace(string? namespaceOverride)

Framework/Logging/BaseLog.cs

@@ -77,7 +77,7 @@ namespace Logging
             return new LogFile($"{GetFullName()}_{GetSubfileNumber()}", ext);
         }
 
-        protected string ApplyReplacements(string str)
+        private string ApplyReplacements(string str)
         {
             if (IsDebug) return str;
             foreach (var replacement in replacements)

Framework/Logging/ConsoleLog.cs

@@ -9,7 +9,7 @@
 
         public override void Log(string message)
         {
-            Console.WriteLine(ApplyReplacements(message));
+            Console.WriteLine(message);
         }
     }
 }

Framework/Logging/Logging.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
 	  <RootNamespace>Logging</RootNamespace>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>

Framework/NethereumWorkflow/BlockUtils/BlockTimeFinder.cs

@@ -18,14 +18,6 @@ namespace NethereumWorkflow.BlockUtils
             bounds = new BlockchainBounds(cache, web3);
         }
 
-        public BlockTimeEntry Get(ulong blockNumber)
-        {
-            bounds.Initialize();
-            var b = cache.Get(blockNumber);
-            if (b != null) return b;
-            return GetBlock(blockNumber);
-        }
-
         public ulong? GetHighestBlockNumberBefore(DateTime moment)
         {
             bounds.Initialize();
@@ -46,7 +38,7 @@ namespace NethereumWorkflow.BlockUtils
 
         private ulong Log(Func<ulong> operation)
         {
-            var sw = Stopwatch.Begin(log, nameof(BlockTimeFinder), true);
+            var sw = Stopwatch.Begin(log, nameof(BlockTimeFinder));
             var result = operation();
             sw.End($"(Bounds: [{bounds.Genesis.BlockNumber}-{bounds.Current.BlockNumber}] Cache: {cache.Size})");
 

Framework/NethereumWorkflow/NethereumInteraction.cs

@@ -117,17 +117,9 @@ namespace NethereumWorkflow
             }
 
             return new BlockInterval(
-                timeRange: timeRange,
                 from: fromBlock.Value,
                 to: toBlock.Value
             );
         }
-
-        public BlockTimeEntry GetBlockForNumber(ulong number)
-        {
-            var wrapper = new Web3Wrapper(web3, log);
-            var blockTimeFinder = new BlockTimeFinder(blockCache, wrapper, log);
-            return blockTimeFinder.Get(number);
-        }
     }
 }

Framework/NethereumWorkflow/NethereumWorkflow.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
 	<RootNamespace>NethereumWorkflow</RootNamespace>
 	<ImplicitUsings>enable</ImplicitUsings>
 	<Nullable>enable</Nullable>

Framework/OverwatchTranscript/ActionQueue.cs

@@ -1,61 +0,0 @@
-namespace OverwatchTranscript
-{
-    public class ActionQueue
-    {
-        // Using ConcurrentQueue<> here would make this process slower.
-        private readonly object queueLock = new object();
-        private readonly AutoResetEvent signal = new AutoResetEvent(false);
-        private List<Action> queue = new List<Action>();
-        private Task queueWorker = null!;
-        private bool stopping = false;
-
-        public void Start()
-        {
-            queueWorker = Task.Run(QueueWorker);
-        }
-
-        public int Count { get; private set; }
-
-        public void StopAndJoin()
-        {
-            stopping = true;
-            queueWorker.Wait();
-            if (queue.Count > 0) throw new Exception("not all acions handled");
-            queueWorker.Dispose();
-        }
-
-        public void Add(Action action)
-        {
-            if (stopping) throw new Exception("queue stopping");
-
-            lock (queueLock)
-            {
-                queue.Add(action);
-                Count = queue.Count;
-            }
-            signal.Set();
-        }
-
-        private void QueueWorker()
-        {
-            while (true)
-            {
-                signal.WaitOne(10);
-
-                List<Action> work = null!;
-                lock (queueLock)
-                {
-                    work = queue;
-                    queue = new List<Action>();
-                    Count = 0;
-                }
-                if (stopping && !work.Any()) return;
-                
-                foreach (var action in work)
-                {
-                    action();
-                }
-            }
-        }
-    }
-}

Framework/OverwatchTranscript/BucketSet.cs

@@ -1,110 +0,0 @@
-using Logging;
-using System.Collections.Concurrent;
-
-namespace OverwatchTranscript
-{
-    public class BucketSet
-    {
-        private const int numberOfActiveBuckets = 10;
-        private readonly ILog log;
-        private readonly string workingDir;
-        private readonly object _bucketLock = new object();
-        private readonly List<EventBucketWriter> fullBuckets = new List<EventBucketWriter>();
-        private readonly List<EventBucketWriter> activeBuckets = new List<EventBucketWriter>();
-        private readonly ActionQueue queue = new ActionQueue();
-        private int activeBucketIndex = 0;
-        private bool closed = false;
-        private string internalErrors = string.Empty;
-        
-        public BucketSet(ILog log, string workingDir)
-        {
-            this.log = log;
-            this.workingDir = workingDir;
-
-            for (var i = 0; i < numberOfActiveBuckets;i++)
-            {
-                AddNewBucket();
-            }
-
-            queue.Start();
-        }
-
-        public void Add(DateTime utc, object payload)
-        {
-            if (closed) throw new Exception("Buckets already closed!");
-            queue.Add(() => AddInternal(utc, payload));
-            
-            if (queue.Count > 1000)
-            {
-                Thread.Sleep(1);
-            }
-        }
-
-        public IFinalizedBucket[] FinalizeBuckets()
-        {
-            closed = true;
-            queue.StopAndJoin();
-
-            if (IsEmpty()) throw new Exception("No entries have been added.");
-            if (!string.IsNullOrEmpty(internalErrors)) throw new Exception(internalErrors);
-
-            var buckets = fullBuckets.Concat(activeBuckets).ToArray();
-            log.Debug($"Finalizing {buckets.Length} buckets...");
-
-            var finalized = new ConcurrentBag<IFinalizedBucket>();
-            var tasks = Parallel.ForEach(buckets, b => finalized.Add(b.FinalizeBucket()));
-            if (!tasks.IsCompleted) throw new Exception("Failed to finalize buckets: " + tasks);
-
-            return finalized.ToArray();
-        }
-
-        private bool IsEmpty()
-        {
-            return fullBuckets.All(b => b.Count == 0) && activeBuckets.All(b => b.Count == 0);
-        }
-
-        private void AddInternal(DateTime utc, object payload)
-        {
-            try
-            {
-                lock (_bucketLock)
-                {
-                    var current = activeBuckets[activeBucketIndex];
-                    current.Add(utc, payload);
-                    activeBucketIndex = (activeBucketIndex + 1) % numberOfActiveBuckets;
-
-                    if (current.IsFull)
-                    {
-                        log.Debug("Bucket is full. New bucket...");
-                        fullBuckets.Add(current);
-                        activeBuckets.Remove(current);
-                        AddNewBucket();
-                    }
-                }
-            }
-            catch (Exception ex)
-            {
-                internalErrors += ex.ToString();
-                log.Error(ex.ToString());
-            }
-        }
-
-        private static int bucketSizeIndex = 0;
-        private static int[] bucketSizes = new[]
-        {
-            10000,
-            15000,
-            20000,
-        };
-
-        private void AddNewBucket()
-        {
-            lock (_bucketLock)
-            {
-                var size = bucketSizes[bucketSizeIndex];
-                bucketSizeIndex = (bucketSizeIndex + 1) % bucketSizes.Length;
-                activeBuckets.Add(new EventBucketWriter(log, Path.Combine(workingDir, Guid.NewGuid().ToString()), size));
-            }
-        }
-    }
-}

Framework/OverwatchTranscript/EventBucketReader.cs

@@ -1,143 +0,0 @@
-using Logging;
-using Newtonsoft.Json;
-using System.Collections.Concurrent;
-
-namespace OverwatchTranscript
-{
-    public interface IFinalizedBucket
-    {
-        bool IsEmpty { get; }
-        DateTime? SeeTopUtc();
-        BucketTop? TakeTop();
-    }
-
-    public class BucketTop
-    {
-        public BucketTop(DateTime utc, OverwatchEvent[] events)
-        {
-            Utc = utc;
-            Events = events;
-        }
-
-        public DateTime Utc { get; }
-        public OverwatchEvent[] Events { get; }
-    }
-
-    public class EventBucketReader : IFinalizedBucket
-    {
-        private readonly string bucketFile;
-        private readonly ConcurrentQueue<BucketTop> topQueue = new ConcurrentQueue<BucketTop>();
-        private readonly AutoResetEvent itemDequeued = new AutoResetEvent(false);
-        private bool stopping;
-
-        public EventBucketReader(ILog log, string bucketFile)
-        {
-            this.bucketFile = bucketFile;
-            if (!File.Exists(bucketFile)) throw new Exception("Doesn't exist: " + bucketFile);
-
-            log.Debug("Read Bucket open: " + bucketFile);
-
-            Task.Run(ReadBucket);
-        }
-        
-        public bool IsEmpty { get; private set; }
-
-        public DateTime? SeeTopUtc()
-        {
-            if (IsEmpty) return null;
-            while (true)
-            {
-                UpdateIsEmpty();
-                if (IsEmpty) return null;
-                if (topQueue.TryPeek(out BucketTop? top))
-                {
-                    return top.Utc;
-                }
-            }
-        }
-
-        public BucketTop? TakeTop()
-        {
-            if (IsEmpty) return null;
-
-            while (true)
-            {
-                UpdateIsEmpty();
-                if (IsEmpty) return null;
-                if (topQueue.TryDequeue(out BucketTop? top))
-                {
-                    itemDequeued.Set();
-                    return top;
-                }
-            }
-        }
-
-        private void ReadBucket()
-        {
-            using var file = File.OpenRead(bucketFile);
-            using var reader = new StreamReader(file);
-
-            while (true)
-            {
-                while (topQueue.Count < 5)
-                {
-                    var top = CreateNewTop(reader);
-                    if (top != null)
-                    {
-                        topQueue.Enqueue(top);
-                    }
-                    else
-                    {
-                        stopping = true;
-                        return;
-                    }
-                }
-
-                itemDequeued.Reset();
-                itemDequeued.WaitOne();
-            }
-        }
-
-        private void UpdateIsEmpty()
-        {
-            var empty = stopping && topQueue.IsEmpty;
-            if (!IsEmpty && empty)
-            {
-                File.Delete(bucketFile);
-                IsEmpty = true;
-            }
-        }
-
-        private EventBucketEntry? nextEntry = null;
-        private BucketTop? CreateNewTop(StreamReader reader)
-        {
-            if (nextEntry == null)
-            {
-                nextEntry = ReadEntry(reader);
-                if (nextEntry == null) return null;
-            }
-
-            var topEntry = nextEntry;
-            var entries = new List<EventBucketEntry>
-            {
-                topEntry
-            };
-
-            nextEntry = ReadEntry(reader);
-            while (nextEntry != null && nextEntry.Utc == topEntry.Utc)
-            {
-                entries.Add(nextEntry);
-                nextEntry = ReadEntry(reader);
-            }
-
-            return new BucketTop(topEntry.Utc, entries.Select(e => e.Event).ToArray());
-        }
-
-        private EventBucketEntry? ReadEntry(StreamReader reader)
-        {
-            var line = reader.ReadLine();
-            if (string.IsNullOrEmpty(line)) return null;
-            return JsonConvert.DeserializeObject<EventBucketEntry>(line);
-        }
-    }
-}

Framework/OverwatchTranscript/EventBucketWriter.cs

@@ -1,113 +0,0 @@
-using Logging;
-using Newtonsoft.Json;
-
-namespace OverwatchTranscript
-{
-    public class EventBucketWriter
-    {
-        private const int MaxBuffer = 1000;
-
-        private readonly object _lock = new object();
-        private bool closed = false;
-        private readonly ILog log;
-        private readonly string bucketFile;
-        private readonly int maxCount;
-        private readonly List<EventBucketEntry> buffer = new List<EventBucketEntry>();
-
-        public EventBucketWriter(ILog log, string bucketFile, int maxCount)
-        {
-            this.log = log;
-            this.bucketFile = bucketFile;
-            this.maxCount = maxCount;
-            if (File.Exists(bucketFile)) throw new Exception("Already exists");
-
-            log.Debug("Write Bucket open: " + bucketFile);
-        }
-
-        public int Count { get; private set; }
-        public bool IsFull { get; private set; }
-
-        public void Add(DateTime utc, object payload)
-        {
-            lock (_lock)
-            {
-                if (closed) throw new Exception("Already closed");
-                AddToBuffer(utc, payload);
-                BufferToFile(emptyBuffer: false);
-            }
-        }
-
-        public IFinalizedBucket FinalizeBucket()
-        {
-            lock (_lock)
-            {
-                closed = true;
-                BufferToFile(emptyBuffer: true);
-                SortFileByTimestamps();
-            }
-            log.Debug($"Finalized bucket with {Count} entries");
-            return new EventBucketReader(log, bucketFile);
-        }
-
-        public override string ToString()
-        {
-            return $"EventBucket: " + Count;
-        }
-
-        private void AddToBuffer(DateTime utc, object payload)
-        {  
-            var typeName = payload.GetType().FullName;
-            if (string.IsNullOrEmpty(typeName)) throw new Exception("Empty typename for payload");
-            if (utc == default) throw new Exception("DateTimeUtc not set");
-
-            var entry = new EventBucketEntry
-            {
-                Utc = utc,
-                Event = new OverwatchEvent
-                {
-                    Type = typeName,
-                    Payload = Json.Serialize(payload)
-                }
-            };
-
-            Count++;
-            IsFull = Count > maxCount;
-
-            buffer.Add(entry);
-        }
-
-        private void BufferToFile(bool emptyBuffer)
-        {
-            if (emptyBuffer || buffer.Count > MaxBuffer)
-            {
-                using var file = File.Open(bucketFile, FileMode.Append);
-                using var writer = new StreamWriter(file);
-                foreach (var entry in buffer)
-                {
-                    writer.WriteLine(Json.Serialize(entry));
-                }
-                log.Debug($"Bucket wrote {buffer.Count} entries to file.");
-                buffer.Clear();
-            }
-        }
-
-        private void SortFileByTimestamps()
-        {
-            var lines = File.ReadAllLines(bucketFile);
-            var entries = lines.Select(Json.Deserialize<EventBucketEntry>)
-                .Cast<EventBucketEntry>()
-                .OrderBy(e => e.Utc)
-                .ToArray();
-
-            File.Delete(bucketFile);
-            File.WriteAllLines(bucketFile, entries.Select(e => Json.Serialize(e)));
-        }
-    }
-
-    [Serializable]
-    public class EventBucketEntry
-    {
-        public DateTime Utc { get; set; }
-        public OverwatchEvent Event { get; set; } = new();
-    }
-}

Framework/OverwatchTranscript/Json.cs

@@ -1,27 +0,0 @@
-using Newtonsoft.Json;
-using System.Globalization;
-
-namespace OverwatchTranscript
-{
-    public static class Json
-    {
-        private static JsonSerializerSettings settings = new JsonSerializerSettings
-        {
-            Formatting = Formatting.None,
-            NullValueHandling = NullValueHandling.Ignore,
-            Culture = CultureInfo.InvariantCulture,
-            DateFormatHandling = DateFormatHandling.IsoDateFormat,
-            FloatFormatHandling = FloatFormatHandling.Symbol
-        };
-
-        public static string Serialize(object obj, Formatting formatting = Formatting.None)
-        {
-            return JsonConvert.SerializeObject(obj, formatting, settings);
-        }
-
-        public static T Deserialize<T>(string json)
-        {
-            return JsonConvert.DeserializeObject<T>(json)!;
-        }
-    }
-}

Framework/OverwatchTranscript/Model.cs

@@ -1,56 +0,0 @@
-namespace OverwatchTranscript
-{
-    [Serializable]
-    public class OverwatchTranscript
-    {
-        public OverwatchHeader Header { get; set; } = new();
-        public OverwatchMomentReference[] MomentReferences { get; set; } = Array.Empty<OverwatchMomentReference>();
-    }
-
-    [Serializable]
-    public class OverwatchMomentReference
-    {
-        public string MomentsFile { get; set; } = string.Empty;
-        public int NumberOfMoments { get; set; }
-        public int NumberOfEvents { get; set; }
-        public DateTime EarliestUtc { get; set; }
-        public DateTime LatestUtc { get; set; }
-    }
-
-    [Serializable]
-    public class OverwatchHeader
-    {
-        public OverwatchCommonHeader Common { get; set; } = new();
-        public OverwatchHeaderEntry[] Entries { get; set; } = Array.Empty<OverwatchHeaderEntry>();
-    }
-
-    [Serializable]
-    public class OverwatchCommonHeader
-    {
-        public long NumberOfMoments { get; set; }
-        public long NumberOfEvents { get; set; }
-        public DateTime EarliestUtc { get; set; }
-        public DateTime LatestUtc { get; set; }
-    }
-
-    [Serializable]
-    public class OverwatchHeaderEntry
-    {
-        public string Key { get; set; } = string.Empty;
-        public string Value { get; set; } = string.Empty;
-    }
-
-    [Serializable]
-    public class OverwatchMoment
-    {
-        public DateTime Utc { get; set; }
-        public OverwatchEvent[] Events { get; set; } = Array.Empty<OverwatchEvent>();
-    }
-
-    [Serializable]
-    public class OverwatchEvent
-    {
-        public string Type { get; set; } = string.Empty;
-        public string Payload { get; set; } = string.Empty;
-    }
-}

Framework/OverwatchTranscript/MomentReader.cs

@@ -1,104 +0,0 @@
-using Newtonsoft.Json;
-
-namespace OverwatchTranscript
-{
-    public class MomentReader
-    {
-        private readonly OverwatchTranscript model;
-        private readonly string workingDir;
-        private int referenceIndex = 0;
-        private int momentsRead = 0;
-        private OpenReference currentRef;
-
-        public MomentReader(OverwatchTranscript model, string workingDir)
-        {
-            this.model = model;
-            this.workingDir = workingDir;
-
-            currentRef = CreateOpenReference();
-        }
-
-        public OverwatchMoment? Next()
-        {
-            if (referenceIndex >= model.MomentReferences.Length) return null;
-
-            var moment = currentRef.ReadNext();
-            if (moment == null)
-            {
-                Close();
-
-                // This reference file ran out.
-                // The number of moments read should match exactly the number of moments
-                // describe in the reference. If not, error:
-                var expected = model.MomentReferences[referenceIndex].NumberOfMoments;
-                if (momentsRead != expected)
-                {
-                    throw new Exception("Number of moments read from referenced file does not match number of moments value in model. " +
-                        $"Reads: { momentsRead} - model.MomentReferences[{referenceIndex}].NumberOfMoment: {expected}"); 
-                }
-
-                referenceIndex++;
-                if (referenceIndex < model.MomentReferences.Length)
-                {
-                    // Proceed to next reference file.
-                    currentRef = CreateOpenReference();
-                    momentsRead = 0;
-                    return Next();
-                }
-                else
-                {
-                    // That was the last one.
-                    return null;
-                }
-            }
-            else
-            {
-                momentsRead++;
-                return moment;
-            }
-        }
-
-        public void Close()
-        {
-            if (currentRef != null)
-            {
-                currentRef.Close();
-                currentRef = null!;
-            }
-        }
-
-        private OpenReference CreateOpenReference()
-        {
-            var filepath = Path.Combine(workingDir, model.MomentReferences[referenceIndex].MomentsFile);
-            return new OpenReference(filepath);
-        }
-
-        private class OpenReference
-        {
-            private readonly FileStream file;
-            private readonly StreamReader reader;
-
-            public OpenReference(string filePath)
-            {
-                file = File.OpenRead(filePath);
-                reader = new StreamReader(file);
-            }
-
-            public OverwatchMoment? ReadNext()
-            {
-                var line = reader.ReadLine();
-                if (string.IsNullOrEmpty(line)) return null;
-                return JsonConvert.DeserializeObject<OverwatchMoment>(line);
-            }
-
-            public void Close()
-            {
-                reader.Close();
-                file.Close();
-
-                reader.Dispose();
-                file.Dispose();
-            }
-        }
-    }
-}

Framework/OverwatchTranscript/MomentReferenceBuilder.cs

@@ -1,151 +0,0 @@
-using Logging;
-using Newtonsoft.Json;
-
-namespace OverwatchTranscript
-{
-    public class MomentReferenceBuilder
-    {
-        private const int MaxMomentsPerReference = 10000;
-        private readonly ILog log;
-        private readonly string workingDir;
-
-        public MomentReferenceBuilder(ILog log, string workingDir)
-        {
-            this.log = log;
-            this.workingDir = workingDir;
-        }
-
-        public OverwatchMomentReference[] Build(IFinalizedBucket[] finalizedBuckets)
-        {
-            var result = new List<OverwatchMomentReference>();
-            var currentBuilder = new Builder(log, workingDir);
-
-            var buckets = finalizedBuckets.ToList();
-            log.Debug($"Building references for {buckets.Count} buckets.");
-            while (buckets.Any())
-            {
-                buckets.RemoveAll(b => b.IsEmpty);
-                if (!buckets.Any()) break;
-
-                var earliestUtc = GetEarliestUtc(buckets);
-                if (earliestUtc == null) continue;
-                
-                var tops = CollectAllTopsForUtc(earliestUtc.Value, buckets);
-                var moment = ConvertTopsToMoment(tops);
-                currentBuilder.Add(moment);
-                if (currentBuilder.NumberOfMoments == MaxMomentsPerReference)
-                {
-                    result.Add(currentBuilder.Build());
-                    currentBuilder = new Builder(log, workingDir);
-                }
-            }
-
-            if (currentBuilder.NumberOfMoments > 0)
-            {
-                result.Add(currentBuilder.Build());
-            }
-
-            return result.ToArray();
-        }
-
-        private OverwatchMoment ConvertTopsToMoment(List<BucketTop> tops)
-        {
-            var discintUtc = tops.Select(e => e.Utc).Distinct().ToArray();
-            if (discintUtc.Length != 1) throw new Exception("UTC mixing in moment construction.");
-
-            return new OverwatchMoment
-            {
-                Utc = tops[0].Utc,
-                Events = tops.SelectMany(e => e.Events).ToArray()
-            };
-        }
-
-        private List<BucketTop> CollectAllTopsForUtc(DateTime earliestUtc, List<IFinalizedBucket> buckets)
-        {
-            var result = new List<BucketTop>();
-
-            foreach (var bucket in buckets)
-            {
-                if (bucket.IsEmpty) continue;
-
-                var utc = bucket.SeeTopUtc();
-                if (utc == null) continue;
-
-                if (utc.Value == earliestUtc)
-                {
-                    var top = bucket.TakeTop();
-                    if (top == null) throw new Exception("top was null after top utc was not");
-                    result.Add(top);
-                }
-            }
-
-            return result;
-        }
-
-        private DateTime? GetEarliestUtc(List<IFinalizedBucket> buckets)
-        {
-            var earliest = DateTime.MaxValue;
-            foreach (var bucket in buckets)
-            {
-                var utc = bucket.SeeTopUtc();
-                if (utc == null) return null;
-
-                if (utc.Value < earliest) earliest = utc.Value;
-            }
-            return earliest;
-        }
-
-        public class Builder
-        {
-            private readonly ILog log;
-            private readonly string workingDir;
-            private OverwatchMomentReference reference;
-            private readonly ActionQueue queue = new ActionQueue();
-
-            public Builder(ILog log, string workingDir)
-            {
-                reference = new OverwatchMomentReference
-                {
-                    MomentsFile = Guid.NewGuid().ToString(),
-                    EarliestUtc = DateTime.MaxValue,
-                    LatestUtc = DateTime.MinValue,
-                    NumberOfEvents = 0,
-                    NumberOfMoments = 0,
-                };
-                this.log = log;
-                this.workingDir = workingDir;
-                queue.Start();
-            }
-
-            public int NumberOfMoments => reference.NumberOfMoments;
-
-            public void Add(OverwatchMoment moment)
-            {
-                if (moment.Utc < reference.EarliestUtc) reference.EarliestUtc = moment.Utc;
-                if (moment.Utc > reference.LatestUtc) reference.LatestUtc = moment.Utc;
-                reference.NumberOfMoments++;
-                reference.NumberOfEvents += moment.Events.Length;
-
-                var filePath = Path.Combine(workingDir, reference.MomentsFile);
-
-                queue.Add(() =>
-                {
-                    File.AppendAllLines(filePath, new[]
-                    {
-                        Json.Serialize(moment)
-                    });
-                });
-            }
-
-            public OverwatchMomentReference Build()
-            {
-                queue.StopAndJoin();
-
-                log.Debug($"Created reference with {reference.NumberOfMoments} moments and {reference.NumberOfEvents} events...");
-                var result = reference;
-                reference = null!;
-                return result;
-            }
-        }
-    }
-}

Framework/OverwatchTranscript/OverwatchTranscript.csproj

@@ -1,17 +0,0 @@
-<Project Sdk="Microsoft.NET.Sdk">
-
-  <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
-    <ImplicitUsings>enable</ImplicitUsings>
-    <Nullable>enable</Nullable>
-  </PropertyGroup>
-
-  <ItemGroup>
-    <PackageReference Include="Newtonsoft.Json" Version="13.0.3" />
-  </ItemGroup>
-
-  <ItemGroup>
-    <ProjectReference Include="..\Logging\Logging.csproj" />
-  </ItemGroup>
-
-</Project>

Framework/OverwatchTranscript/Transcript.cs

@@ -1,23 +0,0 @@
-using Logging;
-
-namespace OverwatchTranscript
-{
-    public static class Transcript
-    {
-        public static ITranscriptWriter NewWriter(ILog log)
-        {
-            log = new LogPrefixer(log, "(TranscriptWriter) ");
-            return new TranscriptWriter(log, NewWorkDir());
-        }
-
-        public static ITranscriptReader NewReader(string transcriptFile)
-        {
-            return new TranscriptReader(NewWorkDir(), transcriptFile);
-        }
-
-        private static string NewWorkDir()
-        {
-            return Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString());
-        }
-    }
-}

Framework/OverwatchTranscript/TranscriptConstants.cs

@@ -1,8 +0,0 @@
-namespace OverwatchTranscript
-{
-    public static class TranscriptConstants
-    {
-        public const string TranscriptFilename = "transcript.json";
-        public const string ArtifactFolderName = "artifacts";
-    }
-}

Framework/OverwatchTranscript/TranscriptReader.cs

@@ -1,264 +0,0 @@
-using Newtonsoft.Json;
-using System.IO;
-using System;
-using System.IO.Compression;
-using System.Linq;
-using System.Collections.Generic;
-using System.Collections.Concurrent;
-
-namespace OverwatchTranscript
-{
-    public interface ITranscriptReader
-    {
-        OverwatchCommonHeader Header { get; }
-        T GetHeader<T>(string key);
-        void AddMomentHandler(Action<ActivateMoment> handler);
-        void AddEventHandler<T>(Action<ActivateEvent<T>> handler);
-        bool Next();
-        void Close();
-    }
-
-    public class TranscriptReader : ITranscriptReader
-    {
-        private readonly object handlersLock = new object();
-        private readonly string transcriptFile;
-        private readonly string artifactsFolder;
-        private readonly List<Action<ActivateMoment>> momentHandlers = new List<Action<ActivateMoment>>();
-        private readonly Dictionary<string, List<Action<ActivateMoment, string>>> eventHandlers = new Dictionary<string, List<Action<ActivateMoment, string>>>();
-        private readonly string workingDir;
-        private readonly OverwatchTranscript model;
-        private bool closed;
-        private long momentCounter;
-        private readonly ConcurrentQueue<OverwatchMoment> queue = new ConcurrentQueue<OverwatchMoment>();
-        private readonly Task queueFiller;
-
-        public TranscriptReader(string workingDir, string inputFilename)
-        {
-            closed = false;
-            this.workingDir = workingDir;
-            transcriptFile = Path.Combine(workingDir, TranscriptConstants.TranscriptFilename);
-            artifactsFolder = Path.Combine(workingDir, TranscriptConstants.ArtifactFolderName);
-
-            if (!Directory.Exists(workingDir)) Directory.CreateDirectory(workingDir);
-            if (File.Exists(transcriptFile) || Directory.Exists(artifactsFolder)) throw new Exception("workingdir not clean");
-
-            model = LoadModel(inputFilename);
-
-            queueFiller = Task.Run(() => FillQueue(model, workingDir));
-        }
-
-        public OverwatchCommonHeader Header
-        {
-            get
-            {
-                CheckClosed();
-                return model.Header.Common;
-            }
-        }
-
-        public T GetHeader<T>(string key)
-        {
-            CheckClosed();
-            var value = model.Header.Entries.First(e => e.Key == key).Value;
-            return JsonConvert.DeserializeObject<T>(value)!;
-        }
-
-        public void AddMomentHandler(Action<ActivateMoment> handler)
-        {
-            CheckClosed();
-            lock (handlersLock)
-            {
-                momentHandlers.Add(handler);
-            }
-        }
-
-        public void AddEventHandler<T>(Action<ActivateEvent<T>> handler)
-        {
-            CheckClosed();
-
-            var typeName = typeof(T).FullName;
-            if (string.IsNullOrEmpty(typeName)) throw new Exception("Empty typename for payload");
-
-            lock (handlersLock)
-            {
-                if (eventHandlers.ContainsKey(typeName))
-                {
-                    eventHandlers[typeName].Add(CreateEventAction(handler));
-                }
-                else
-                {
-                    eventHandlers.Add(typeName, new List<Action<ActivateMoment, string>>
-                    {
-                        CreateEventAction(handler)
-                    });
-                }
-            }
-        }
-
-        private readonly object nextLock = new object();
-        private OverwatchMoment? moment = null;
-        private OverwatchMoment? next = null;
-
-        public bool Next()
-        {
-            CheckClosed();
-
-            OverwatchMoment? m = null;
-            TimeSpan? duration = null;
-            lock (nextLock)
-            {
-                if (next == null)
-                {
-                    if (!queue.TryDequeue(out moment)) return false;
-                    queue.TryDequeue(out next);
-                }
-                else
-                {
-                    moment = next;
-                    next = null;
-                    queue.TryDequeue(out next);
-                }
-
-                m = moment;
-                duration = GetMomentDuration();
-            }
-
-            ActivateMoment(moment, duration);
-
-            return true;
-        }
-
-        public void Close()
-        {
-            CheckClosed();
-            closed = true;
-
-            queueFiller.Wait();
-
-            Directory.Delete(workingDir, true);
-        }
-
-        private Action<ActivateMoment, string> CreateEventAction<T>(Action<ActivateEvent<T>> handler)
-        {
-            return (m, s) =>
-            {
-                handler(new ActivateEvent<T>(m, JsonConvert.DeserializeObject<T>(s)!));
-            };
-        }
-
-        private void FillQueue(OverwatchTranscript model, string workingDir)
-        {
-            var reader = new MomentReader(model, workingDir);
-
-            while (true)
-            {
-                if (closed)
-                {
-                    reader.Close();
-                    return;
-                }
-
-                while (queue.Count < 10)
-                {
-                    var moment = reader.Next();
-                    if (moment == null)
-                    {
-                        reader.Close();
-                        return;
-                    }
-                    queue.Enqueue(moment);
-                }
-
-                Thread.Sleep(1);
-            }
-        }
-
-        private TimeSpan? GetMomentDuration()
-        {
-            if (moment == null) return null;
-            if (next == null) return null;
-
-            return next.Utc - moment.Utc;
-        }
-
-        private void ActivateMoment(OverwatchMoment moment, TimeSpan? duration)
-        {
-            var m = new ActivateMoment(moment.Utc, duration, momentCounter);
-
-            lock (handlersLock)
-            {
-                ActivateMomentHandlers(m);
-
-                foreach (var @event in moment.Events)
-                {
-                    ActivateEventHandlers(m, @event);
-                }
-            }
-
-            momentCounter++;
-        }
-
-        private void ActivateMomentHandlers(ActivateMoment m)
-        {
-            foreach (var handler in momentHandlers)
-            {
-                handler(m);
-            }
-        }
-
-        private void ActivateEventHandlers(ActivateMoment m, OverwatchEvent @event)
-        {
-            if (!eventHandlers.ContainsKey(@event.Type)) return;
-            var handlers = eventHandlers[@event.Type];
-
-            foreach (var handler in handlers)
-            {
-                handler(m, @event.Payload);
-            }
-        }
-
-        private OverwatchTranscript LoadModel(string inputFilename)
-        {
-            ZipFile.ExtractToDirectory(inputFilename, workingDir);
-
-            if (!File.Exists(transcriptFile))
-            {
-                closed = true;
-                throw new Exception("Is not a transcript file. Unzipped to: " + workingDir);
-            }
-
-            return JsonConvert.DeserializeObject<OverwatchTranscript>(File.ReadAllText(transcriptFile))!;
-        }
-
-        private void CheckClosed()
-        {
-            if (closed) throw new Exception("Transcript has already been closed.");
-        }
-    }
-
-    public class ActivateMoment
-    {
-        public ActivateMoment(DateTime utc, TimeSpan? duration, long index)
-        {
-            Utc = utc;
-            Duration = duration;
-            Index = index;
-        }
-
-        public DateTime Utc { get; }
-        public TimeSpan? Duration { get; }
-        public long Index { get; }
-    }
-
-    public class ActivateEvent<T>
-    {
-        public ActivateEvent(ActivateMoment moment, T payload)
-        {
-            Moment = moment;
-            Payload = payload;
-        }
-
-        public ActivateMoment Moment { get; }
-        public T Payload { get; }
-    }
-}

Framework/OverwatchTranscript/TranscriptWriter.cs

@@ -1,130 +0,0 @@
-using Logging;
-using Newtonsoft.Json;
-using System.IO.Compression;
-
-namespace OverwatchTranscript
-{
-    public interface ITranscriptWriter
-    {
-        void AddHeader(string key, object value);
-        void Add(DateTime utc, object payload);
-        void IncludeArtifact(string filePath);
-        void Write(string outputFilename);
-    }
-
-    public class TranscriptWriter : ITranscriptWriter
-    {
-        private readonly object _lock = new object();
-        private readonly MomentReferenceBuilder builder;
-        private readonly string transcriptFile;
-        private readonly string artifactsFolder;
-        private readonly Dictionary<string, string> header = new Dictionary<string, string>();
-        private readonly BucketSet bucketSet;
-        private readonly ILog log;
-        private readonly string workingDir;
-        private bool closed;
-
-        public TranscriptWriter(ILog log, string workingDir)
-        {
-            closed = false;
-            this.log = log;
-            this.workingDir = workingDir;
-            bucketSet = new BucketSet(log, workingDir);
-            builder = new MomentReferenceBuilder(log, workingDir);
-            transcriptFile = Path.Combine(workingDir, TranscriptConstants.TranscriptFilename);
-            artifactsFolder = Path.Combine(workingDir, TranscriptConstants.ArtifactFolderName);
-
-            if (!Directory.Exists(workingDir)) Directory.CreateDirectory(workingDir);
-            if (File.Exists(transcriptFile) || Directory.Exists(artifactsFolder)) throw new Exception("workingdir not clean");
-        }
-
-        public void Add(DateTime utc, object payload)
-        {
-            CheckClosed();
-            bucketSet.Add(utc, payload);
-        }
-
-        public void AddHeader(string key, object value)
-        {
-            CheckClosed();
-            lock (_lock)
-            {
-                header.Add(key, Json.Serialize(value));
-            }
-        }
-
-        public void IncludeArtifact(string filePath)
-        {
-            CheckClosed();
-            if (!File.Exists(filePath)) throw new Exception("File not found: " + filePath);
-            if (!Directory.Exists(artifactsFolder)) Directory.CreateDirectory(artifactsFolder);
-            var name = Path.GetFileName(filePath);
-            File.Copy(filePath, Path.Combine(artifactsFolder, name), overwrite: false);
-        }
-
-        public void Write(string outputFilename)
-        {
-            CheckClosed();
-            closed = true;
-
-            var momentReferences = builder.Build(bucketSet.FinalizeBuckets());
-            var model = CreateModel(momentReferences);
-
-            File.WriteAllText(transcriptFile, Json.Serialize(model, Formatting.Indented));
-
-            ZipFile.CreateFromDirectory(workingDir, outputFilename);
-            log.Debug($"Transcript written to {outputFilename}");
-            log.Debug($"Common header: {Json.Serialize(model.Header.Common, Formatting.Indented)}");
-
-            Directory.Delete(workingDir, true);
-            log.Debug($"Workdir {workingDir} deleted");
-        }
-
-        private OverwatchTranscript CreateModel(OverwatchMomentReference[] momentReferences)
-        {
-            lock (_lock)
-            {
-                var model = new OverwatchTranscript
-                {
-                    Header = new OverwatchHeader
-                    {
-                        Common = CreateCommonHeader(momentReferences),
-                        Entries = header.Select(h =>
-                        {
-                            return new OverwatchHeaderEntry
-                            {
-                                Key = h.Key,
-                                Value = h.Value
-                            };
-                        }).ToArray()
-                    },
-                    MomentReferences = momentReferences
-                };
-
-                header.Clear();
-                return model;
-            }
-        }
-
-        private OverwatchCommonHeader CreateCommonHeader(OverwatchMomentReference[] momentReferences)
-        {
-            var moments = momentReferences.Sum(m => m.NumberOfMoments);
-            var events = momentReferences.Sum(m => m.NumberOfEvents);
-            var earliest = momentReferences.Min(m => m.EarliestUtc);
-            var latest = momentReferences.Max(m => m.LatestUtc);
-
-            return new OverwatchCommonHeader
-            {
-                NumberOfMoments = moments,
-                NumberOfEvents = events,
-                EarliestUtc = earliest,
-                LatestUtc = latest
-            };
-        }
-
-        private void CheckClosed()
-        {
-            if (closed) throw new Exception("Transcript has already been written. Cannot modify or write again.");
-        }
-    }
-}

Framework/Utils/BlockInterval.cs

@@ -2,7 +2,7 @@
 {
     public class BlockInterval
     {
-        public BlockInterval(TimeRange timeRange, ulong from, ulong to)
+        public BlockInterval(ulong from, ulong to)
         {
             if (from < to)
             {
@@ -14,13 +14,10 @@
                 From = to;
                 To = from;
             }
-            TimeRange = timeRange;
         }
 
         public ulong From { get; }
         public ulong To { get; }
-        public TimeRange TimeRange { get; }
-        public ulong NumberOfBlocks => To - From;
 
         public override string ToString()
         {

Framework/Utils/ByteSize.cs

@@ -13,6 +13,7 @@
 
         public long SizeInBytes { get; }
 
+
         public long ToMB()
         {
             return SizeInBytes / (1024 * 1024);

Framework/Utils/Formatter.cs

@@ -1,6 +1,4 @@
-using System.Globalization;
-
-namespace Utils
+namespace Utils
 {
     public static class Formatter
     {
@@ -12,7 +10,7 @@ namespace Utils
 
             var sizeOrder = Convert.ToInt32(Math.Floor(Math.Log(bytes, 1024)));
             var digit = Math.Round(bytes / Math.Pow(1024, sizeOrder), 1);
-            return digit.ToString(CultureInfo.InvariantCulture) + sizeSuffixes[sizeOrder];
+            return digit.ToString() + sizeSuffixes[sizeOrder];
         }
     }
 }

Framework/Utils/NumberSource.cs

@@ -2,7 +2,6 @@
 {
     public class NumberSource
     {
-        private readonly object @lock = new object();
         private int number;
 
         public NumberSource(int start)
@@ -12,12 +11,8 @@
 
         public int GetNextNumber()
         {
-            var n = -1;
-            lock (@lock)
-            {
-                n = number;
-                number++;
-            }
+            var n = number;
+            number++;
             return n;
         }
     }

Framework/Utils/RandomUtils.cs

@@ -3,31 +3,13 @@
     public static class RandomUtils
     {
         private static readonly Random random = new Random();
-        private static readonly object @lock = new object();
 
         public static T PickOneRandom<T>(this List<T> remainingItems)
         {
-            lock (@lock)
-            {
-                var i = random.Next(0, remainingItems.Count);
-                var result = remainingItems[i];
-                remainingItems.RemoveAt(i);
-                return result;
-            }
-        }
-
-        public static T[] Shuffled<T>(T[] items)
-        {
-            lock (@lock)
-            {
-                var result = new List<T>();
-                var source = items.ToList();
-                while (source.Any())
-                {
-                    result.Add(RandomUtils.PickOneRandom(source));
-                }
-                return result.ToArray();
-            }
+            var i = random.Next(0, remainingItems.Count);
+            var result = remainingItems[i];
+            remainingItems.RemoveAt(i);
+            return result;
         }
     }
 }

Framework/Utils/Retry.cs

@@ -1,131 +0,0 @@
-namespace Utils
-{
-    public class Retry
-    {
-        private readonly string description;
-        private readonly TimeSpan maxTimeout;
-        private readonly TimeSpan sleepAfterFail;
-        private readonly Action<Failure> onFail;
-
-        public Retry(string description, TimeSpan maxTimeout, TimeSpan sleepAfterFail, Action<Failure> onFail)
-        {
-            this.description = description;
-            this.maxTimeout = maxTimeout;
-            this.sleepAfterFail = sleepAfterFail;
-            this.onFail = onFail;
-        }
-
-        public void Run(Action task)
-        {
-            var run = new RetryRun(description, task, maxTimeout, sleepAfterFail, onFail);
-            run.Run();
-        }
-
-        public T Run<T>(Func<T> task)
-        {
-            T? result = default;
-
-            var run = new RetryRun(description, () =>
-            {
-                result = task();
-            }, maxTimeout, sleepAfterFail, onFail);
-            run.Run();
-
-            return result!;
-        }
-
-        private class RetryRun
-        {
-            private readonly string description;
-            private readonly Action task;
-            private readonly TimeSpan maxTimeout;
-            private readonly TimeSpan sleepAfterFail;
-            private readonly Action<Failure> onFail;
-            private readonly DateTime start = DateTime.UtcNow;
-            private readonly List<Failure> failures = new List<Failure>();
-            private int tryNumber;
-            private DateTime tryStart;
-
-            public RetryRun(string description, Action task, TimeSpan maxTimeout, TimeSpan sleepAfterFail, Action<Failure> onFail)
-            {
-                this.description = description;
-                this.task = task;
-                this.maxTimeout = maxTimeout;
-                this.sleepAfterFail = sleepAfterFail;
-                this.onFail = onFail;
-
-                tryNumber = 0;
-                tryStart = DateTime.UtcNow;
-            }
-
-            public void Run()
-            {
-                while (true)
-                {
-                    CheckMaximums();
-
-                    tryNumber++;
-                    tryStart = DateTime.UtcNow;
-                    try
-                    {
-                        task();
-                        return;
-                    }
-                    catch (Exception ex)
-                    {
-                        var failure = CaptureFailure(ex);
-                        onFail(failure);
-                        Time.Sleep(sleepAfterFail);
-                    }
-                }
-            }
-
-            private Failure CaptureFailure(Exception ex)
-            {
-                var f = new Failure(ex, DateTime.UtcNow - tryStart, tryNumber);
-                failures.Add(f);
-                return f;
-            }
-
-            private void CheckMaximums()
-            {
-                if (Duration() > maxTimeout) Fail();
-            }
-
-            private void Fail()
-            {
-                throw new TimeoutException($"Retry '{description}' timed out after {tryNumber} tries over {Time.FormatDuration(Duration())}: {GetFailureReport}",
-                        new AggregateException(failures.Select(f => f.Exception)));
-            }
-
-            private string GetFailureReport()
-            {
-                return Environment.NewLine + string.Join(Environment.NewLine, failures.Select(f => f.Describe()));
-            }
-
-            private TimeSpan Duration()
-            {
-                return DateTime.UtcNow - start;
-            }
-        }
-    }
-
-    public class Failure
-    {
-        public Failure(Exception exception, TimeSpan duration, int tryNumber)
-        {
-            Exception = exception;
-            Duration = duration;
-            TryNumber = tryNumber;
-        }
-
-        public Exception Exception { get; }
-        public TimeSpan Duration { get; }
-        public int TryNumber { get; }
-
-        public string Describe()
-        {
-            return $"Try {TryNumber} failed after {Time.FormatDuration(Duration)} with exception '{Exception}'";
-        }
-    }
-}

Framework/Utils/RollingAverage.cs

@@ -1,28 +0,0 @@
-namespace Utils
-{
-    public static class RollingAverage
-    {
-        /// <param name="currentAverage">Value of average before new value is added.</param>
-        /// <param name="newNumberOfValues">Number of values in average after new value is added.</param>
-        /// <param name="newValue">New value to be added.</param>
-        /// <returns>New average value.</returns>
-        /// <exception cref="Exception">newNumberOfValues must be 1 or greater.</exception>
-        public static float GetNewAverage(float currentAverage, int newNumberOfValues, float newValue)
-        {
-            if (newNumberOfValues < 1) throw new Exception("Should be at least 1 value.");
-
-            float n = newNumberOfValues;
-            var originalValue = currentAverage;
-            var originalValueWeight = ((n - 1.0f) / n);
-            var newValueWeight = (1.0f / n);
-            return GetWeightedAverage(originalValue, originalValueWeight, newValue, newValueWeight);
-        }
-
-        public static float GetWeightedAverage(float value1, float weight1, float value2, float weight2)
-        {
-            float totalWeight = weight1 + weight2;
-            if (totalWeight == 0.0f) return 0.0f;
-            return ((value1 * weight1) + (value2 * weight2)) / totalWeight;
-        }
-    }
-}

Framework/Utils/Str.cs

@@ -1,13 +0,0 @@
-namespace Utils
-{
-    public static class Str
-    {
-        public static string Between(string input, string open, string close)
-        {
-            var openIndex = input.IndexOf(open) + open.Length;
-            var closeIndex = input.LastIndexOf(close);
-
-            return input.Substring(openIndex, closeIndex - openIndex);
-        }
-    }
-}

Framework/Utils/Time.cs

@@ -18,12 +18,6 @@
             task.Wait();
         }
 
-        public static string FormatDuration(TimeSpan? d)
-        {
-            if (d == null) return "[NULL]";
-            return FormatDuration(d.Value);
-        }
-
         public static string FormatDuration(TimeSpan d)
         {
             var result = "";
@@ -63,70 +57,100 @@
             return result;
         }
 
-        public static void WaitUntil(Func<bool> predicate, string msg)
+        public static void WaitUntil(Func<bool> predicate)
         {
-            WaitUntil(predicate, TimeSpan.FromMinutes(1), TimeSpan.FromSeconds(1), msg);
+            WaitUntil(predicate, TimeSpan.FromMinutes(1), TimeSpan.FromSeconds(1));
         }
 
-        public static void WaitUntil(Func<bool> predicate, TimeSpan timeout, TimeSpan retryDelay, string msg)
+        public static void WaitUntil(Func<bool> predicate, TimeSpan timeout, TimeSpan retryDelay)
         {
             var start = DateTime.UtcNow;
-            var tries = 1;
             var state = predicate();
             while (!state)
             {
-                var duration = DateTime.UtcNow - start;
-                if (duration > timeout)
+                if (DateTime.UtcNow - start > timeout)
                 {
-                    throw new TimeoutException($"Operation timed out after {tries} tries over (total) {FormatDuration(duration)}. '{msg}'");
+                    throw new TimeoutException("Operation timed out.");
                 }
 
                 Sleep(retryDelay);
                 state = predicate();
-                tries++;
             }
         }
 
         public static void Retry(Action action, string description)
         {
-            Retry(action, TimeSpan.FromSeconds(30), description);
+            Retry(action, 1, description);
         }
 
         public static T Retry<T>(Func<T> action, string description)
         {
-            return Retry(action, TimeSpan.FromSeconds(30), description);
+            return Retry(action, 1, description);
         }
 
-        public static void Retry(Action action, TimeSpan maxTimeout, string description)
+        public static void Retry(Action action, int maxRetries, string description)
         {
-            Retry(action, maxTimeout, TimeSpan.FromSeconds(5), description);
+            Retry(action, maxRetries, TimeSpan.FromSeconds(5), description);
         }
 
-        public static T Retry<T>(Func<T> action, TimeSpan maxTimeout, string description)
+        public static T Retry<T>(Func<T> action, int maxRetries, string description)
         {
-            return Retry(action, maxTimeout, TimeSpan.FromSeconds(5), description);
+            return Retry(action, maxRetries, TimeSpan.FromSeconds(5), description);
         }
 
-        public static void Retry(Action action, TimeSpan maxTimeout, TimeSpan retryTime, string description)
+        public static void Retry(Action action, int maxRetries, TimeSpan retryTime, string description)
         {
-            Retry(action, maxTimeout, retryTime, description, f => { });
+            var start = DateTime.UtcNow;
+            var retries = 0;
+            var exceptions = new List<Exception>();
+            while (true)
+            {
+                if (retries > maxRetries)
+                {
+                    var duration = DateTime.UtcNow - start;
+                    throw new TimeoutException($"Retry '{description}' timed out after {maxRetries} tries over {Time.FormatDuration(duration)}.", new AggregateException(exceptions));
+                }
+
+                try
+                {
+                    action();
+                    return;
+                }
+                catch (Exception ex)
+                {
+                    exceptions.Add(ex);
+                    retries++;
+                }
+
+                Sleep(retryTime);
+            }
         }
 
-        public static T Retry<T>(Func<T> action, TimeSpan maxTimeout, TimeSpan retryTime, string description)
+        public static T Retry<T>(Func<T> action, int maxRetries, TimeSpan retryTime, string description)
         {
-            return Retry(action, maxTimeout, retryTime, description, f => { });
-        }
+            var start = DateTime.UtcNow;
+            var retries = 0;
+            var exceptions = new List<Exception>();
+            while (true)
+            {
+                if (retries > maxRetries)
+                {
+                    var duration = DateTime.UtcNow - start;
+                    throw new TimeoutException($"Retry '{description}' timed out after {maxRetries} tries over {Time.FormatDuration(duration)}.", new AggregateException(exceptions));
+                }
 
-        public static void Retry(Action action, TimeSpan maxTimeout, TimeSpan retryTime, string description, Action<Failure> onFail)
-        {
-            var r = new Retry(description, maxTimeout, retryTime, onFail);
-            r.Run(action);
-        }
+                try
+                {
+                    return action();
+                }
+                catch (Exception ex)
+                {
+                    exceptions.Add(ex);
+                    retries++;
+                }
 
-        public static T Retry<T>(Func<T> action, TimeSpan maxTimeout, TimeSpan retryTime, string description, Action<Failure> onFail)
-        {
-            var r = new Retry(description, maxTimeout, retryTime, onFail);
-            return r.Run(action);
+                Sleep(retryTime);
+            }
         }
     }
 }

Framework/Utils/Utils.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
 	  <RootNamespace>Utils</RootNamespace>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>

ProjectPlugins/CodexContractsPlugin/ChainMonitor/ChainEvents.cs

@@ -1,73 +0,0 @@
-using CodexContractsPlugin.Marketplace;
-using Utils;
-
-namespace CodexContractsPlugin.ChainMonitor
-{
-    public class ChainEvents
-    {
-        private ChainEvents(
-            BlockInterval blockInterval,
-            Request[] requests,
-            RequestFulfilledEventDTO[] fulfilled,
-            RequestCancelledEventDTO[] cancelled,
-            RequestFailedEventDTO[] failed,
-            SlotFilledEventDTO[] slotFilled,
-            SlotFreedEventDTO[] slotFreed
-            )
-        {
-            BlockInterval = blockInterval;
-            Requests = requests;
-            Fulfilled = fulfilled;
-            Cancelled = cancelled;
-            Failed = failed;
-            SlotFilled = slotFilled;
-            SlotFreed = slotFreed;
-        }
-
-        public BlockInterval BlockInterval { get; }
-        public Request[] Requests { get; }
-        public RequestFulfilledEventDTO[] Fulfilled { get; }
-        public RequestCancelledEventDTO[] Cancelled { get; }
-        public RequestFailedEventDTO[] Failed { get; }
-        public SlotFilledEventDTO[] SlotFilled { get; }
-        public SlotFreedEventDTO[] SlotFreed { get; }
-
-        public IHasBlock[] All
-        {
-            get
-            {
-                var all = new List<IHasBlock>();
-                all.AddRange(Requests);
-                all.AddRange(Fulfilled);
-                all.AddRange(Cancelled);
-                all.AddRange(Failed);
-                all.AddRange(SlotFilled);
-                all.AddRange(SlotFreed);
-                return all.ToArray();
-            }
-        }
-
-        public static ChainEvents FromBlockInterval(ICodexContracts contracts, BlockInterval blockInterval)
-        {
-            return FromContractEvents(contracts.GetEvents(blockInterval));
-        }
-
-        public static ChainEvents FromTimeRange(ICodexContracts contracts, TimeRange timeRange)
-        {
-            return FromContractEvents(contracts.GetEvents(timeRange));
-        }
-
-        public static ChainEvents FromContractEvents(ICodexContractsEvents events)
-        {
-            return new ChainEvents(
-                events.BlockInterval,
-                events.GetStorageRequests(),
-                events.GetRequestFulfilledEvents(),
-                events.GetRequestCancelledEvents(),
-                events.GetRequestFailedEvents(),
-                events.GetSlotFilledEvents(),
-                events.GetSlotFreedEvents()
-            );
-        }
-    }
-}

ProjectPlugins/CodexContractsPlugin/ChainMonitor/ChainState.cs

@@ -1,177 +0,0 @@
-using CodexContractsPlugin.Marketplace;
-using GethPlugin;
-using Logging;
-using NethereumWorkflow.BlockUtils;
-using System.Numerics;
-using Utils;
-
-namespace CodexContractsPlugin.ChainMonitor
-{
-    public interface IChainStateChangeHandler
-    {
-        void OnNewRequest(RequestEvent requestEvent);
-        void OnRequestFinished(RequestEvent requestEvent);
-        void OnRequestFulfilled(RequestEvent requestEvent);
-        void OnRequestCancelled(RequestEvent requestEvent);
-        void OnRequestFailed(RequestEvent requestEvent);
-        void OnSlotFilled(RequestEvent requestEvent, EthAddress host, BigInteger slotIndex);
-        void OnSlotFreed(RequestEvent requestEvent, BigInteger slotIndex);
-    }
-
-    public class RequestEvent
-    {
-        public RequestEvent(BlockTimeEntry block, IChainStateRequest request)
-        {
-            Block = block;
-            Request = request;
-        }
-
-        public BlockTimeEntry Block { get; }
-        public IChainStateRequest Request { get; }
-    }
-
-    public class ChainState
-    {
-        private readonly List<ChainStateRequest> requests = new List<ChainStateRequest>();
-        private readonly ILog log;
-        private readonly ICodexContracts contracts;
-        private readonly IChainStateChangeHandler handler;
-
-        public ChainState(ILog log, ICodexContracts contracts, IChainStateChangeHandler changeHandler, DateTime startUtc)
-        {
-            this.log = new LogPrefixer(log, "(ChainState) ");
-            this.contracts = contracts;
-            handler = changeHandler;
-            TotalSpan = new TimeRange(startUtc, startUtc);
-        }
-
-        public TimeRange TotalSpan { get; private set; }
-        public IChainStateRequest[] Requests => requests.ToArray();
-
-        public int Update()
-        {
-            return Update(DateTime.UtcNow);
-        }
-
-        public int Update(DateTime toUtc)
-        {
-            var span = new TimeRange(TotalSpan.To, toUtc);
-            var events = ChainEvents.FromTimeRange(contracts, span);
-            Apply(events);
-
-            TotalSpan = new TimeRange(TotalSpan.From, span.To);
-            return events.All.Length;
-        }
-
-        private void Apply(ChainEvents events)
-        {
-            if (events.BlockInterval.TimeRange.From < TotalSpan.From)
-                throw new Exception("Attempt to update ChainState with set of events from before its current record.");
-
-            log.Log($"ChainState updating: {events.BlockInterval}");
-
-            // Run through each block and apply the events to the state in order.
-            var span = events.BlockInterval.TimeRange.Duration;
-            var numBlocks = events.BlockInterval.NumberOfBlocks;
-            var spanPerBlock = span / numBlocks;
-
-            var eventUtc = events.BlockInterval.TimeRange.From;
-            for (var b = events.BlockInterval.From; b <= events.BlockInterval.To; b++)
-            {
-                var blockEvents = events.All.Where(e => e.Block.BlockNumber == b).ToArray();
-                ApplyEvents(b, blockEvents, eventUtc);
-
-                eventUtc += spanPerBlock;
-            }
-        }
-
-        private void ApplyEvents(ulong blockNumber, IHasBlock[] blockEvents, DateTime eventsUtc)
-        {
-            foreach (var e in blockEvents)
-            {
-                dynamic d = e;
-                ApplyEvent(d);
-            }
-
-            ApplyTimeImplicitEvents(blockNumber, eventsUtc);
-        }
-
-        private void ApplyEvent(Request request)
-        {
-            if (requests.Any(r => Equal(r.Request.RequestId, request.RequestId)))
-                throw new Exception("Received NewRequest event for id that already exists.");
-
-            var newRequest = new ChainStateRequest(log, request, RequestState.New);
-            requests.Add(newRequest);
-
-            handler.OnNewRequest(new RequestEvent(request.Block, newRequest));
-        }
-
-        private void ApplyEvent(RequestFulfilledEventDTO @event)
-        {
-            var r = FindRequest(@event.RequestId);
-            if (r == null) return;
-            r.UpdateState(@event.Block.BlockNumber, RequestState.Started);
-            handler.OnRequestFulfilled(new RequestEvent(@event.Block, r));
-        }
-
-        private void ApplyEvent(RequestCancelledEventDTO @event)
-        {
-            var r = FindRequest(@event.RequestId);
-            if (r == null) return;
-            r.UpdateState(@event.Block.BlockNumber, RequestState.Cancelled);
-            handler.OnRequestCancelled(new RequestEvent(@event.Block, r));
-        }
-
-        private void ApplyEvent(RequestFailedEventDTO @event)
-        {
-            var r = FindRequest(@event.RequestId);
-            if (r == null) return;
-            r.UpdateState(@event.Block.BlockNumber, RequestState.Failed);
-            handler.OnRequestFailed(new RequestEvent(@event.Block, r));
-        }
-
-        private void ApplyEvent(SlotFilledEventDTO @event)
-        {
-            var r = FindRequest(@event.RequestId);
-            if (r == null) return;
-            r.Hosts.Add(@event.Host, (int)@event.SlotIndex);
-            r.Log($"[{@event.Block.BlockNumber}] SlotFilled (host:'{@event.Host}', slotIndex:{@event.SlotIndex})");
-            handler.OnSlotFilled(new RequestEvent(@event.Block, r), @event.Host, @event.SlotIndex);
-        }
-
-        private void ApplyEvent(SlotFreedEventDTO @event)
-        {
-            var r = FindRequest(@event.RequestId);
-            if (r == null) return;
-            r.Hosts.RemoveHost((int)@event.SlotIndex);
-            r.Log($"[{@event.Block.BlockNumber}] SlotFreed (slotIndex:{@event.SlotIndex})");
-            handler.OnSlotFreed(new RequestEvent(@event.Block, r), @event.SlotIndex);
-        }
-
-        private void ApplyTimeImplicitEvents(ulong blockNumber, DateTime eventsUtc)
-        {
-            foreach (var r in requests)
-            {
-                if (r.State == RequestState.Started
-                    && r.FinishedUtc < eventsUtc)
-                {
-                    r.UpdateState(blockNumber, RequestState.Finished);
-                    handler.OnRequestFinished(new RequestEvent(new BlockTimeEntry(blockNumber, eventsUtc), r));
-                }
-            }
-        }
-
-        private ChainStateRequest? FindRequest(byte[] requestId)
-        {
-            var r = requests.SingleOrDefault(r => Equal(r.Request.RequestId, requestId));
-            if (r == null) log.Log("Unable to find request by ID!");
-            return r;
-        }
-
-        private bool Equal(byte[] a, byte[] b)
-        {
-            return a.SequenceEqual(b);
-        }
-    }
-}

ProjectPlugins/CodexContractsPlugin/ChainMonitor/ChainStateChangeHandlerMux.cs

@@ -1,55 +0,0 @@
-using GethPlugin;
-using System;
-using System.Collections.Generic;
-using System.Linq;
-using System.Numerics;
-using System.Text;
-using System.Threading.Tasks;
-
-namespace CodexContractsPlugin.ChainMonitor
-{
-    public class ChainStateChangeHandlerMux : IChainStateChangeHandler
-    {
-        public ChainStateChangeHandlerMux(params IChainStateChangeHandler[] handlers)
-        {
-            Handlers = handlers.ToList();
-        }
-
-        public List<IChainStateChangeHandler> Handlers { get; } = new List<IChainStateChangeHandler>();
-
-        public void OnNewRequest(RequestEvent requestEvent)
-        {
-            foreach (var handler in Handlers) handler.OnNewRequest(requestEvent);
-        }
-
-        public void OnRequestCancelled(RequestEvent requestEvent)
-        {
-            foreach (var handler in Handlers) handler.OnRequestCancelled(requestEvent);
-        }
-
-        public void OnRequestFailed(RequestEvent requestEvent)
-        {
-            foreach (var handler in Handlers) handler.OnRequestFailed(requestEvent);
-        }
-
-        public void OnRequestFinished(RequestEvent requestEvent)
-        {
-            foreach (var handler in Handlers) handler.OnRequestFinished(requestEvent);
-        }
-
-        public void OnRequestFulfilled(RequestEvent requestEvent)
-        {
-            foreach (var handler in Handlers) handler.OnRequestFulfilled(requestEvent);
-        }
-
-        public void OnSlotFilled(RequestEvent requestEvent, EthAddress host, BigInteger slotIndex)
-        {
-            foreach (var handler in Handlers) handler.OnSlotFilled(requestEvent, host, slotIndex);
-        }
-
-        public void OnSlotFreed(RequestEvent requestEvent, BigInteger slotIndex)
-        {
-            foreach (var handler in Handlers) handler.OnSlotFreed(requestEvent, slotIndex);
-        }
-    }
-}

ProjectPlugins/CodexContractsPlugin/ChainMonitor/ChainStateRequest.cs

@@ -1,80 +0,0 @@
-using CodexContractsPlugin.Marketplace;
-using GethPlugin;
-using Logging;
-
-namespace CodexContractsPlugin.ChainMonitor
-{
-    public interface IChainStateRequest
-    {
-        Request Request { get; }
-        RequestState State { get; }
-        DateTime ExpiryUtc { get; }
-        DateTime FinishedUtc { get; }
-        EthAddress Client { get; }
-        RequestHosts Hosts { get; }
-    }
-
-    public class ChainStateRequest : IChainStateRequest
-    {
-        private readonly ILog log;
-
-        public ChainStateRequest(ILog log, Request request, RequestState state)
-        {
-            this.log = log;
-            Request = request;
-            State = state;
-
-            ExpiryUtc = request.Block.Utc + TimeSpan.FromSeconds((double)request.Expiry);
-            FinishedUtc = request.Block.Utc + TimeSpan.FromSeconds((double)request.Ask.Duration);
-
-            Log($"[{request.Block.BlockNumber}] Created as {State}.");
-
-            Client = new EthAddress(request.Client);
-            Hosts = new RequestHosts();
-        }
-
-        public Request Request { get; }
-        public RequestState State { get; private set; }
-        public DateTime ExpiryUtc { get; }
-        public DateTime FinishedUtc { get; }
-        public EthAddress Client { get; }
-        public RequestHosts Hosts { get; }
-
-        public void UpdateState(ulong blockNumber, RequestState newState)
-        {
-            Log($"[{blockNumber}] Transit: {State} -> {newState}");
-            State = newState;
-        }
-
-        public void Log(string msg)
-        {
-            log.Log($"Request '{Request.Id}': {msg}");
-        }
-    }
-
-    public class RequestHosts
-    {
-        private readonly Dictionary<int, EthAddress> hosts = new Dictionary<int, EthAddress>();
-
-        public void Add(EthAddress host, int index)
-        {
-            hosts.Add(index, host);
-        }
-        
-        public void RemoveHost(int index)
-        {
-            hosts.Remove(index);
-        }
-
-        public EthAddress? GetHost(int index)
-        {
-            if (!hosts.ContainsKey(index)) return null;
-            return hosts[index];
-        }
-
-        public EthAddress[] GetHosts()
-        {
-            return hosts.Values.ToArray();
-        }
-    }
-}

ProjectPlugins/CodexContractsPlugin/ChainMonitor/DoNothingChainEventHandler.cs

@@ -1,36 +0,0 @@
-using GethPlugin;
-using System.Numerics;
-
-namespace CodexContractsPlugin.ChainMonitor
-{
-    public class DoNothingChainEventHandler : IChainStateChangeHandler
-    {
-        public void OnNewRequest(RequestEvent requestEvent)
-        {
-        }
-
-        public void OnRequestCancelled(RequestEvent requestEvent)
-        {
-        }
-
-        public void OnRequestFailed(RequestEvent requestEvent)
-        {
-        }
-
-        public void OnRequestFinished(RequestEvent requestEvent)
-        {
-        }
-
-        public void OnRequestFulfilled(RequestEvent requestEvent)
-        {
-        }
-
-        public void OnSlotFilled(RequestEvent requestEvent, EthAddress host, BigInteger slotIndex)
-        {
-        }
-
-        public void OnSlotFreed(RequestEvent requestEvent, BigInteger slotIndex)
-        {
-        }
-    }
-}

ProjectPlugins/CodexContractsPlugin/CodexContractsAccess.cs

@@ -2,10 +2,9 @@
 using GethPlugin;
 using Logging;
 using Nethereum.ABI;
+using Nethereum.Hex.HexTypes;
 using Nethereum.Util;
 using NethereumWorkflow;
-using Newtonsoft.Json;
-using Newtonsoft.Json.Converters;
 using Utils;
 
 namespace CodexContractsPlugin
@@ -20,13 +19,15 @@ namespace CodexContractsPlugin
         TestToken GetTestTokenBalance(IHasEthAddress owner);
         TestToken GetTestTokenBalance(EthAddress ethAddress);
 
-        ICodexContractsEvents GetEvents(TimeRange timeRange);
-        ICodexContractsEvents GetEvents(BlockInterval blockInterval);
+        Request[] GetStorageRequests(BlockInterval blockRange);
         EthAddress? GetSlotHost(Request storageRequest, decimal slotIndex);
         RequestState GetRequestState(Request request);
+        RequestFulfilledEventDTO[] GetRequestFulfilledEvents(BlockInterval blockRange);
+        RequestCancelledEventDTO[] GetRequestCancelledEvents(BlockInterval blockRange);
+        SlotFilledEventDTO[] GetSlotFilledEvents(BlockInterval blockRange);
+        SlotFreedEventDTO[] GetSlotFreedEvents(BlockInterval blockRange);
     }
 
-    [JsonConverter(typeof(StringEnumConverter))]
     public enum RequestState
     {
         New,
@@ -62,7 +63,7 @@ namespace CodexContractsPlugin
 
         public string MintTestTokens(EthAddress ethAddress, TestToken testTokens)
         {
-            return StartInteraction().MintTestTokens(ethAddress, testTokens.TstWei, Deployment.TokenAddress);
+            return StartInteraction().MintTestTokens(ethAddress, testTokens.Amount, Deployment.TokenAddress);
         }
 
         public TestToken GetTestTokenBalance(IHasEthAddress owner)
@@ -73,17 +74,68 @@ namespace CodexContractsPlugin
         public TestToken GetTestTokenBalance(EthAddress ethAddress)
         {
             var balance = StartInteraction().GetBalance(Deployment.TokenAddress, ethAddress.Address);
-            return balance.TstWei();
+            return balance.TestTokens();
         }
 
-        public ICodexContractsEvents GetEvents(TimeRange timeRange)
+        public Request[] GetStorageRequests(BlockInterval blockRange)
         {
-            return GetEvents(gethNode.ConvertTimeRangeToBlockRange(timeRange));
+            var events = gethNode.GetEvents<StorageRequestedEventDTO>(Deployment.MarketplaceAddress, blockRange);
+            var i = StartInteraction();
+            return events
+                    .Select(e =>
+                    {
+                        var requestEvent = i.GetRequest(Deployment.MarketplaceAddress, e.Event.RequestId);
+                        var result = requestEvent.ReturnValue1;
+                        result.BlockNumber = e.Log.BlockNumber.ToUlong();
+                        result.RequestId = e.Event.RequestId;
+                        return result;
+                    })
+                    .ToArray();
         }
 
-        public ICodexContractsEvents GetEvents(BlockInterval blockInterval)
+        public RequestFulfilledEventDTO[] GetRequestFulfilledEvents(BlockInterval blockRange)
         {
-            return new CodexContractsEvents(log, gethNode, Deployment, blockInterval);
+            var events = gethNode.GetEvents<RequestFulfilledEventDTO>(Deployment.MarketplaceAddress, blockRange);
+            return events.Select(e =>
+            {
+                var result = e.Event;
+                result.BlockNumber = e.Log.BlockNumber.ToUlong();
+                return result;
+            }).ToArray();
+        }
+
+        public RequestCancelledEventDTO[] GetRequestCancelledEvents(BlockInterval blockRange)
+        {
+            var events = gethNode.GetEvents<RequestCancelledEventDTO>(Deployment.MarketplaceAddress, blockRange);
+            return events.Select(e =>
+            {
+                var result = e.Event;
+                result.BlockNumber = e.Log.BlockNumber.ToUlong();
+                return result;
+            }).ToArray();
+        }
+
+        public SlotFilledEventDTO[] GetSlotFilledEvents(BlockInterval blockRange)
+        {
+            var events = gethNode.GetEvents<SlotFilledEventDTO>(Deployment.MarketplaceAddress, blockRange);
+            return events.Select(e =>
+            {
+                var result = e.Event;
+                result.BlockNumber = e.Log.BlockNumber.ToUlong();
+                result.Host = GetEthAddressFromTransaction(e.Log.TransactionHash);
+                return result;
+            }).ToArray();
+        }
+
+        public SlotFreedEventDTO[] GetSlotFreedEvents(BlockInterval blockRange)
+        {
+            var events = gethNode.GetEvents<SlotFreedEventDTO>(Deployment.MarketplaceAddress, blockRange);
+            return events.Select(e =>
+            {
+                var result = e.Event;
+                result.BlockNumber = e.Log.BlockNumber.ToUlong();
+                return result;
+            }).ToArray();
         }
 
         public EthAddress? GetSlotHost(Request storageRequest, decimal slotIndex)
@@ -114,6 +166,12 @@ namespace CodexContractsPlugin
             return gethNode.Call<RequestStateFunction, RequestState>(Deployment.MarketplaceAddress, func);
         }
 
+        private EthAddress GetEthAddressFromTransaction(string transactionHash)
+        {
+            var transaction = gethNode.GetTransaction(transactionHash);
+            return new EthAddress(transaction.From);
+        }
+
         private ContractInteractions StartInteraction()
         {
             return new ContractInteractions(log, gethNode);

ProjectPlugins/CodexContractsPlugin/CodexContractsContainerRecipe.cs

@@ -19,7 +19,7 @@ namespace CodexContractsPlugin
         {
             var config = startupConfig.Get<CodexContractsContainerConfig>();
 
-            var address = config.GethNode.StartResult.Container.GetAddress(GethContainerRecipe.HttpPortTag);
+            var address = config.GethNode.StartResult.Container.GetAddress(new NullLog(), GethContainerRecipe.HttpPortTag);
 
             SetSchedulingAffinity(notIn: "false");
 

ProjectPlugins/CodexContractsPlugin/CodexContractsEvents.cs

@@ -1,120 +0,0 @@
-using CodexContractsPlugin.Marketplace;
-using GethPlugin;
-using Logging;
-using Nethereum.Hex.HexTypes;
-using NethereumWorkflow.BlockUtils;
-using Utils;
-
-namespace CodexContractsPlugin
-{
-    public interface ICodexContractsEvents
-    {
-        BlockInterval BlockInterval { get; }
-        Request[] GetStorageRequests();
-        RequestFulfilledEventDTO[] GetRequestFulfilledEvents();
-        RequestCancelledEventDTO[] GetRequestCancelledEvents();
-        RequestFailedEventDTO[] GetRequestFailedEvents();
-        SlotFilledEventDTO[] GetSlotFilledEvents();
-        SlotFreedEventDTO[] GetSlotFreedEvents();
-    }
-
-    public class CodexContractsEvents : ICodexContractsEvents
-    {
-        private readonly ILog log;
-        private readonly IGethNode gethNode;
-        private readonly CodexContractsDeployment deployment;
-
-        public CodexContractsEvents(ILog log, IGethNode gethNode, CodexContractsDeployment deployment, BlockInterval blockInterval)
-        {
-            this.log = log;
-            this.gethNode = gethNode;
-            this.deployment = deployment;
-            BlockInterval = blockInterval;
-        }
-        
-        public BlockInterval BlockInterval { get; }
-
-        public Request[] GetStorageRequests()
-        {
-            var events = gethNode.GetEvents<StorageRequestedEventDTO>(deployment.MarketplaceAddress, BlockInterval);
-            var i = new ContractInteractions(log, gethNode);
-            return events
-            .Select(e =>
-            {
-                        var requestEvent = i.GetRequest(deployment.MarketplaceAddress, e.Event.RequestId);
-                        var result = requestEvent.ReturnValue1;
-                        result.Block = GetBlock(e.Log.BlockNumber.ToUlong());
-                        result.RequestId = e.Event.RequestId;
-                        return result;
-                    })
-                    .ToArray();
-        }
-
-        public RequestFulfilledEventDTO[] GetRequestFulfilledEvents()
-        {
-            var events = gethNode.GetEvents<RequestFulfilledEventDTO>(deployment.MarketplaceAddress, BlockInterval);
-            return events.Select(e =>
-            {
-                var result = e.Event;
-                result.Block = GetBlock(e.Log.BlockNumber.ToUlong());
-                return result;
-            }).ToArray();
-        }
-
-        public RequestCancelledEventDTO[] GetRequestCancelledEvents()
-        {
-            var events = gethNode.GetEvents<RequestCancelledEventDTO>(deployment.MarketplaceAddress, BlockInterval);
-            return events.Select(e =>
-            {
-                var result = e.Event;
-                result.Block = GetBlock(e.Log.BlockNumber.ToUlong());
-                return result;
-            }).ToArray();
-        }
-
-        public RequestFailedEventDTO[] GetRequestFailedEvents()
-        {
-            var events = gethNode.GetEvents<RequestFailedEventDTO>(deployment.MarketplaceAddress, BlockInterval);
-            return events.Select(e =>
-            {
-                var result = e.Event;
-                result.Block = GetBlock(e.Log.BlockNumber.ToUlong());
-                return result;
-            }).ToArray();
-        }
-
-        public SlotFilledEventDTO[] GetSlotFilledEvents()
-        {
-            var events = gethNode.GetEvents<SlotFilledEventDTO>(deployment.MarketplaceAddress, BlockInterval);
-            return events.Select(e =>
-            {
-                var result = e.Event;
-                result.Block = GetBlock(e.Log.BlockNumber.ToUlong());
-                result.Host = GetEthAddressFromTransaction(e.Log.TransactionHash);
-                return result;
-            }).ToArray();
-        }
-
-        public SlotFreedEventDTO[] GetSlotFreedEvents()
-        {
-            var events = gethNode.GetEvents<SlotFreedEventDTO>(deployment.MarketplaceAddress, BlockInterval);
-            return events.Select(e =>
-            {
-                var result = e.Event;
-                result.Block = GetBlock(e.Log.BlockNumber.ToUlong());
-                return result;
-            }).ToArray();
-        }
-
-        private BlockTimeEntry GetBlock(ulong number)
-        {
-            return gethNode.GetBlockForNumber(number);
-        }
-
-        private EthAddress GetEthAddressFromTransaction(string transactionHash)
-        {
-            var transaction = gethNode.GetTransaction(transactionHash);
-            return new EthAddress(transaction.From);
-        }
-    }
-}

ProjectPlugins/CodexContractsPlugin/CodexContractsPlugin.csproj

@@ -1,16 +1,11 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Nethereum.Generators" Version="4.21.4" />
-    <PackageReference Include="Nethereum.Generators.Net" Version="4.21.4" />
-  </ItemGroup>
-
   <ItemGroup>
     <ProjectReference Include="..\..\Framework\Core\Core.csproj" />
     <ProjectReference Include="..\GethPlugin\GethPlugin.csproj" />

ProjectPlugins/CodexContractsPlugin/CodexContractsStarter.cs

@@ -1,5 +1,4 @@
-using CodexContractsPlugin.Marketplace;
-using Core;
+using Core;
 using GethPlugin;
 using KubernetesWorkflow;
 using KubernetesWorkflow.Types;
@@ -25,7 +24,7 @@ namespace CodexContractsPlugin
             var startupConfig = CreateStartupConfig(gethNode);
             startupConfig.NameOverride = "codex-contracts";
 
-            var containers = workflow.Start(1, new CodexContractsContainerRecipe(), startupConfig).WaitForOnline();
+            var containers = workflow.Start(1, new CodexContractsContainerRecipe(), startupConfig);
             if (containers.Containers.Length != 1) throw new InvalidOperationException("Expected 1 Codex contracts container to be created. Test infra failure.");
             var container = containers.Containers[0];
 
@@ -60,46 +59,33 @@ namespace CodexContractsPlugin
                 var logHandler = new ContractsReadyLogHandler(tools.GetLog());
                 workflow.DownloadContainerLog(container, logHandler, 100);
                 return logHandler.Found;
-            }, nameof(DeployContract));
+            });
             Log("Contracts deployed. Extracting addresses...");
 
             var extractor = new ContractsContainerInfoExtractor(tools.GetLog(), workflow, container);
             var marketplaceAddress = extractor.ExtractMarketplaceAddress();
-            var (abi, bytecode) = extractor.ExtractMarketplaceAbiAndByteCode();
-            EnsureCompatbility(abi, bytecode);
+            var abi = extractor.ExtractMarketplaceAbi();
 
             var interaction = new ContractInteractions(tools.GetLog(), gethNode);
             var tokenAddress = interaction.GetTokenAddress(marketplaceAddress);
 
             Log("Extract completed. Checking sync...");
 
-            Time.WaitUntil(() => interaction.IsSynced(marketplaceAddress, abi), nameof(DeployContract));
+            Time.WaitUntil(() => interaction.IsSynced(marketplaceAddress, abi));
 
             Log("Synced. Codex SmartContracts deployed.");
 
             return new CodexContractsDeployment(marketplaceAddress, abi, tokenAddress);
         }
 
-        private void EnsureCompatbility(string abi, string bytecode)
-        {
-            var expectedByteCode = MarketplaceDeploymentBase.BYTECODE.ToLowerInvariant();
-
-            if (bytecode != expectedByteCode)
-            {
-                Log("Deployed contract is incompatible with current build of CodexContracts plugin. Running self-updater...");
-                var selfUpdater = new SelfUpdater();
-                selfUpdater.Update(abi, bytecode);
-            }
-        }
-
         private void Log(string msg)
         {
             tools.GetLog().Log(msg);
         }
 
-        private void WaitUntil(Func<bool> predicate, string msg)
+        private void WaitUntil(Func<bool> predicate)
         {
-            Time.WaitUntil(predicate, TimeSpan.FromMinutes(5), TimeSpan.FromSeconds(2), msg);
+            Time.WaitUntil(predicate, TimeSpan.FromMinutes(5), TimeSpan.FromSeconds(2));
         }
 
         private StartupConfig CreateStartupConfig(IGethNode gethNode)

ProjectPlugins/CodexContractsPlugin/ContractInteractions.cs

@@ -44,7 +44,7 @@ namespace CodexContractsPlugin
             }
         }
 
-        public string MintTestTokens(EthAddress address, BigInteger amount, string tokenAddress)
+        public string MintTestTokens(EthAddress address, decimal amount, string tokenAddress)
         {
             log.Debug($"{amount} -> {address} (token: {tokenAddress})");
             return MintTokens(address.Address, amount, tokenAddress);
@@ -85,7 +85,7 @@ namespace CodexContractsPlugin
             }
         }
 
-        private string MintTokens(string account, BigInteger amount, string tokenAddress)
+        private string MintTokens(string account, decimal amount, string tokenAddress)
         {
             log.Debug($"({tokenAddress}) {amount} --> {account}");
             if (string.IsNullOrEmpty(account)) throw new ArgumentException("Invalid arguments for MintTestTokens");
@@ -93,7 +93,7 @@ namespace CodexContractsPlugin
             var function = new MintTokensFunction
             {
                 Holder = account,
-                Amount = amount
+                Amount = amount.ToBig()
             };
 
             return gethNode.SendTransaction(tokenAddress, function);

ProjectPlugins/CodexContractsPlugin/ContractsContainerInfoExtractor.cs

@@ -1,5 +1,4 @@
-using CodexContractsPlugin.Marketplace;
-using KubernetesWorkflow;
+using KubernetesWorkflow;
 using KubernetesWorkflow.Types;
 using Logging;
 using Newtonsoft.Json;
@@ -31,14 +30,14 @@ namespace CodexContractsPlugin
             return marketplaceAddress;
         }
 
-        public (string, string) ExtractMarketplaceAbiAndByteCode()
+        public string ExtractMarketplaceAbi()
         {
             log.Debug();
-            var (abi, bytecode) = Retry(FetchMarketplaceAbiAndByteCode);
-            if (string.IsNullOrEmpty(abi)) throw new InvalidOperationException("Unable to fetch marketplace artifacts from codex-contracts node. Test infra failure.");
+            var marketplaceAbi = Retry(FetchMarketplaceAbi);
+            if (string.IsNullOrEmpty(marketplaceAbi)) throw new InvalidOperationException("Unable to fetch marketplace artifacts from codex-contracts node. Test infra failure.");
 
-            log.Debug("Got Marketplace ABI: " + abi);
-            return (abi, bytecode);
+            log.Debug("Got Marketplace ABI: " + marketplaceAbi);
+            return marketplaceAbi;
         }
 
         private string FetchMarketplaceAddress()
@@ -48,20 +47,16 @@ namespace CodexContractsPlugin
             return marketplace!.address;
         }
 
-        private (string, string) FetchMarketplaceAbiAndByteCode()
+        private string FetchMarketplaceAbi()
         {
             var json = workflow.ExecuteCommand(container, "cat", CodexContractsContainerRecipe.MarketplaceArtifactFilename);
 
             var artifact = JObject.Parse(json);
             var abi = artifact["abi"];
-            var byteCode = artifact["bytecode"];
-            var abiResult = abi!.ToString(Formatting.None);
-            var byteCodeResult = byteCode!.ToString(Formatting.None).ToLowerInvariant().Replace("\"", "");
-          
-            return (abiResult, byteCodeResult);
+            return abi!.ToString(Formatting.None);
         }
 
-        private static T Retry<T>(Func<T> fetch)
+        private static string Retry(Func<string> fetch)
         {
             return Time.Retry(fetch, nameof(ContractsContainerInfoExtractor));
         }

ProjectPlugins/CodexContractsPlugin/Marketplace/Customizations.cs

@@ -1,62 +1,41 @@
 #pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.
 using GethPlugin;
-using NethereumWorkflow.BlockUtils;
 using Newtonsoft.Json;
 
 namespace CodexContractsPlugin.Marketplace
 {
-    public interface IHasBlock
-    {
-        BlockTimeEntry Block { get; set; }
-    }
-
-    public partial class Request : RequestBase, IHasBlock
+    public partial class Request : RequestBase
     {
         [JsonIgnore]
-        public BlockTimeEntry Block { get; set; }
+        public ulong BlockNumber { get; set; }
         public byte[] RequestId { get; set; }
 
         public EthAddress ClientAddress { get { return new EthAddress(Client); } }
-
-        [JsonIgnore]
-        public string Id
-        {
-            get
-            {
-                return BitConverter.ToString(RequestId).Replace("-", "").ToLowerInvariant();
-            }
-        }
     }
 
-    public partial class RequestFulfilledEventDTO : IHasBlock
+    public partial class RequestFulfilledEventDTO
     {
         [JsonIgnore]
-        public BlockTimeEntry Block { get; set; }
+        public ulong BlockNumber { get; set; }
     }
 
-    public partial class RequestCancelledEventDTO : IHasBlock
+    public partial class RequestCancelledEventDTO
     {
         [JsonIgnore]
-        public BlockTimeEntry Block { get; set; }
+        public ulong BlockNumber { get; set; }
     }
 
-    public partial class RequestFailedEventDTO : IHasBlock
+    public partial class SlotFilledEventDTO
     {
         [JsonIgnore]
-        public BlockTimeEntry Block { get; set; }
-    }
-
-    public partial class SlotFilledEventDTO : IHasBlock
-    {
-        [JsonIgnore]
-        public BlockTimeEntry Block { get; set; }
+        public ulong BlockNumber { get; set; }
         public EthAddress Host { get; set; }
     }
 
-    public partial class SlotFreedEventDTO : IHasBlock
+    public partial class SlotFreedEventDTO
     {
         [JsonIgnore]
-        public BlockTimeEntry Block { get; set; }
+        public ulong BlockNumber { get; set; }
     }
 }
 #pragma warning restore CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.

ProjectPlugins/CodexContractsPlugin/Marketplace/README.md

@@ -1,14 +1 @@
 This code was generated using the Nethereum code generator, here: http://playground.nethereum.com
-
-1. Go to site -> Abi Code Gen.
-1. Contract name = "Marketplace".
-1. In container, get "/hardhat/artifacts/contracts/Marketplace.sol/Marketplace.json".
-1. Save only ABI section as new JSON. (top-level is a json array.)
-1. From original JSON get byte code.
-1. Put ABI JSON and byte code into site.
-1. Generate.
-1. From site generated code, copy `public partial class MarketplaceDeployment` and everything after it. (be considerate of namespace brackets!)
-1. In Marketplace/Marketplace.cs, replace content of 'namespace CodexContractsPlugin.Marketplace'.
-
-
-

ProjectPlugins/CodexContractsPlugin/SelfUpdater.cs

@@ -1,108 +0,0 @@
-namespace CodexContractsPlugin
-{
-    public class SelfUpdater
-    {
-        public void Update(string abi, string bytecode)
-        {
-            var filePath = GetMarketplaceFilePath();
-            var content = GenerateContent(abi, bytecode);
-            var contentLines = content.Split("\r\n");
-
-            var beginWith = new string[]
-            {
-                "using Nethereum.ABI.FunctionEncoding.Attributes;",
-                "using Nethereum.Contracts;",
-                "using System.Numerics;",
-                "",
-                "// Generated code, do not modify.",
-                "",
-                "#pragma warning disable CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable.",
-                "namespace CodexContractsPlugin.Marketplace",
-                "{"
-            };
-
-            var endWith = new string[]
-            {
-                "}",
-                "#pragma warning restore CS8618 // Non-nullable field must contain a non-null value when exiting constructor. Consider declaring as nullable."
-            };
-
-            File.Delete(filePath);
-            File.WriteAllLines(filePath,
-                beginWith.Concat(
-                contentLines.Concat(
-                endWith))
-            );
-
-            throw new Exception("Oh no! CodexContracts were updated. Current build of CodexContractsPlugin is incompatible. " +
-                "But fear not! SelfUpdater.cs has automatically updated the plugin. Just rebuild and rerun and it should work. " +
-                "Just in case, manual update instructions are found here: 'CodexContractsPlugin/Marketplace/README.md'.");
-        }
-
-        private string GetMarketplaceFilePath()
-        {
-            var here = Directory.GetCurrentDirectory();
-            while (true)
-            {
-                var path = GetMarketplaceFile(here);
-                if (path != null) return path;
-
-                var parent = Directory.GetParent(here);
-                var up = parent?.FullName;
-                if (up == null || up == here) throw new Exception("Unable to locate ProjectPlugins folder. Unable to update contracts.");
-                here = up;
-            }
-        }
-
-        private string? GetMarketplaceFile(string root)
-        {
-            var path = Path.Combine(root, "ProjectPlugins", "CodexContractsPlugin", "Marketplace", "Marketplace.cs");
-            if (File.Exists(path)) return path;
-            return null;
-        }
-
-        private string GenerateContent(string abi, string bytecode)
-        {
-            var deserializer = new Nethereum.Generators.Net.GeneratorModelABIDeserialiser();
-            var abiModel = deserializer.DeserialiseABI(abi);
-            var abiCtor = abiModel.Constructor;
-            var c = new Nethereum.Generators.CQS.ContractDeploymentCQSMessageGenerator(abiCtor, "namespace", bytecode, "Marketplace", Nethereum.Generators.Core.CodeGenLanguage.CSharp);
-            var lines = "";
-            lines += c.GenerateClass();
-            lines += "\r\n";
-
-            foreach (var eventAbi in abiModel.Events)
-            {
-                var d = new Nethereum.Generators.DTOs.EventDTOGenerator(eventAbi, "namespace", Nethereum.Generators.Core.CodeGenLanguage.CSharp);
-                lines += d.GenerateClass();
-                lines += "\r\n";
-            }
-
-            foreach (var errorAbi in abiModel.Errors)
-            {
-                var e = new Nethereum.Generators.DTOs.ErrorDTOGenerator(errorAbi, "namespace", Nethereum.Generators.Core.CodeGenLanguage.CSharp);
-                lines += e.GenerateClass();
-                lines += "\r\n";
-            }
-
-            foreach (var funcAbi in abiModel.Functions)
-            {
-                var f = new Nethereum.Generators.DTOs.FunctionOutputDTOGenerator(funcAbi, "namespace", Nethereum.Generators.Core.CodeGenLanguage.CSharp);
-                var ff = new Nethereum.Generators.CQS.FunctionCQSMessageGenerator(funcAbi, "namespace", "funcoutput", Nethereum.Generators.Core.CodeGenLanguage.CSharp);
-                lines += f.GenerateClass();
-                lines += "\r\n";
-                lines += ff.GenerateClass();
-                lines += "\r\n";
-            }
-
-            foreach (var structAbi in abiModel.Structs)
-            {
-                var g = new Nethereum.Generators.DTOs.StructTypeGenerator(structAbi, "namespace", Nethereum.Generators.Core.CodeGenLanguage.CSharp);
-                lines += g.GenerateClass();
-                lines += "\r\n";
-            }
-
-            return lines;
-        }
-    }
-}

ProjectPlugins/CodexContractsPlugin/TestTokenExtensions.cs

@@ -1,102 +1,45 @@
-using System.Numerics;
-
-namespace CodexContractsPlugin
+namespace CodexContractsPlugin
 {
     public class TestToken : IComparable<TestToken>
     {
-        public static BigInteger WeiFactor = new BigInteger(1000000000000000000);
-
-        public TestToken(BigInteger tstWei)
+        public TestToken(decimal amount)
         {
-            TstWei = tstWei;
-            Tst = tstWei / WeiFactor;
+            Amount = amount;
         }
 
-        public BigInteger TstWei { get; }
-        public BigInteger Tst { get; }
+        public decimal Amount { get; }
 
         public int CompareTo(TestToken? other)
         {
-            return TstWei.CompareTo(other!.TstWei);
+            return Amount.CompareTo(other!.Amount);
         }
 
         public override bool Equals(object? obj)
         {
-            return obj is TestToken token && TstWei == token.TstWei;
+            return obj is TestToken token && Amount == token.Amount;
         }
 
         public override int GetHashCode()
         {
-            return HashCode.Combine(TstWei);
+            return HashCode.Combine(Amount);
         }
 
         public override string ToString()
         {
-            var weiOnly = TstWei % WeiFactor;
-
-            var tokens = new List<string>();
-            if (Tst > 0) tokens.Add($"{Tst} TST");
-            if (weiOnly > 0) tokens.Add($"{weiOnly} TSTWEI");
-
-            return string.Join(" + ", tokens);
-        }
-
-        public static TestToken operator +(TestToken a, TestToken b)
-        {
-            return new TestToken(a.TstWei + b.TstWei);
-        }
-
-        public static bool operator <(TestToken a, TestToken b)
-        {
-            return a.TstWei < b.TstWei;
-        }
-
-        public static bool operator >(TestToken a, TestToken b)
-        {
-            return a.TstWei > b.TstWei;
-        }
-
-        public static bool operator ==(TestToken a, TestToken b)
-        {
-            return a.TstWei == b.TstWei;
-        }
-
-        public static bool operator !=(TestToken a, TestToken b)
-        {
-            return a.TstWei != b.TstWei;
+            return $"{Amount} TestTokens";
         }
     }
 
-    public static class TestTokensExtensions
+    public static class TokensIntExtensions
     {
-        public static TestToken TstWei(this int i)
+        public static TestToken TestTokens(this int i)
         {
-            return TstWei(Convert.ToDecimal(i));
+            return TestTokens(Convert.ToDecimal(i));
         }
 
-        public static TestToken TstWei(this decimal i)
-        {
-            return new TestToken(new BigInteger(i));
-        }
-
-        public static TestToken TstWei(this BigInteger i)
+        public static TestToken TestTokens(this decimal i)
         {
             return new TestToken(i);
         }
-
-        public static TestToken Tst(this int i)
-        {
-            return Tst(Convert.ToDecimal(i));
-        }
-
-        public static TestToken Tst(this decimal i)
-        {
-            return new TestToken(new BigInteger(i) * TestToken.WeiFactor);
-        }
-
-        public static TestToken Tst(this BigInteger i)
-        {
-            return new TestToken(i * TestToken.WeiFactor);
-        }
     }
 }

ProjectPlugins/CodexDiscordBotPlugin/CodexDiscordBotPlugin.cs

@@ -1,13 +1,11 @@
 using Core;
 using KubernetesWorkflow;
 using KubernetesWorkflow.Types;
-using Utils;
 
 namespace CodexDiscordBotPlugin
 {
     public class CodexDiscordBotPlugin : IProjectPlugin, IHasLogPrefix, IHasMetadata
     {
-        private const string ExpectedStartupMessage = "Debug option is set. Discord connection disabled!";
         private readonly IPluginTools tools;
 
         public CodexDiscordBotPlugin(IPluginTools tools)
@@ -31,76 +29,31 @@ namespace CodexDiscordBotPlugin
         {
         }
 
-        public RunningPod Deploy(DiscordBotStartupConfig config)
+        public RunningContainers Deploy(DiscordBotStartupConfig config)
         {
             var workflow = tools.CreateWorkflow();
             return StartContainer(workflow, config);
         }
 
-        public RunningPod DeployRewarder(RewarderBotStartupConfig config)
+        public RunningContainers DeployRewarder(RewarderBotStartupConfig config)
         {
             var workflow = tools.CreateWorkflow();
             return StartRewarderContainer(workflow, config);
         }
 
-        private RunningPod StartContainer(IStartupWorkflow workflow, DiscordBotStartupConfig config)
+        private RunningContainers StartContainer(IStartupWorkflow workflow, DiscordBotStartupConfig config)
         {
             var startupConfig = new StartupConfig();
             startupConfig.NameOverride = config.Name;
             startupConfig.Add(config);
-            var pod = workflow.Start(1, new DiscordBotContainerRecipe(), startupConfig).WaitForOnline();
-            WaitForStartupMessage(workflow, pod);
-            workflow.CreateCrashWatcher(pod.Containers.Single()).Start();
-            return pod;
+            return workflow.Start(1, new DiscordBotContainerRecipe(), startupConfig);
         }
 
-        private RunningPod StartRewarderContainer(IStartupWorkflow workflow, RewarderBotStartupConfig config)
+        private RunningContainers StartRewarderContainer(IStartupWorkflow workflow, RewarderBotStartupConfig config)
         {
             var startupConfig = new StartupConfig();
-            startupConfig.NameOverride = config.Name;
             startupConfig.Add(config);
-            var pod = workflow.Start(1, new RewarderBotContainerRecipe(), startupConfig).WaitForOnline();
-            workflow.CreateCrashWatcher(pod.Containers.Single()).Start();
-            return pod;
-        }
-
-        private void WaitForStartupMessage(IStartupWorkflow workflow, RunningPod pod)
-        {
-            var finder = new LogLineFinder(ExpectedStartupMessage, workflow);
-            Time.WaitUntil(() =>
-            {
-                finder.FindLine(pod);
-                return finder.Found;
-            }, nameof(WaitForStartupMessage));
-        }
-
-        public class LogLineFinder : LogHandler
-        {
-            private readonly string message;
-            private readonly IStartupWorkflow workflow;
-
-            public LogLineFinder(string message, IStartupWorkflow workflow)
-            {
-                this.message = message;
-                this.workflow = workflow;
-            }
-
-            public void FindLine(RunningPod pod)
-            {
-                Found = false;
-                foreach (var c in pod.Containers)
-                {
-                    workflow.DownloadContainerLog(c, this);
-                    if (Found) return;
-                }
-            }
-
-            public bool Found { get; private set; }
-
-            protected override void ProcessLine(string line)
-            {
-                if (!Found && line.Contains(message)) Found = true;
-            }
+            return workflow.Start(1, new RewarderBotContainerRecipe(), startupConfig);
         }
     }
 }

ProjectPlugins/CodexDiscordBotPlugin/CodexDiscordBotPlugin.csproj

@@ -1,7 +1,7 @@
 <Project Sdk="Microsoft.NET.Sdk">
 
   <PropertyGroup>
-    <TargetFramework>net8.0</TargetFramework>
+    <TargetFramework>net7.0</TargetFramework>
     <ImplicitUsings>enable</ImplicitUsings>
     <Nullable>enable</Nullable>
   </PropertyGroup>

ProjectPlugins/CodexDiscordBotPlugin/CoreInterfaceExtensions.cs

@@ -5,12 +5,12 @@ namespace CodexDiscordBotPlugin
 {
     public static class CoreInterfaceExtensions
     {
-        public static RunningPod DeployCodexDiscordBot(this CoreInterface ci, DiscordBotStartupConfig config)
+        public static RunningContainers DeployCodexDiscordBot(this CoreInterface ci, DiscordBotStartupConfig config)
         {
             return Plugin(ci).Deploy(config);
         }
 
-        public static RunningPod DeployRewarderBot(this CoreInterface ci, RewarderBotStartupConfig config)
+        public static RunningContainers DeployRewarderBot(this CoreInterface ci, RewarderBotStartupConfig config)
         {
             return Plugin(ci).DeployRewarder(config);
         }

ProjectPlugins/CodexDiscordBotPlugin/DiscordBotContainerRecipe.cs

@@ -7,7 +7,7 @@ namespace CodexDiscordBotPlugin
     public class DiscordBotContainerRecipe : ContainerRecipeFactory
     {
         public override string AppName => "discordbot-bibliotech";
-        public override string Image => "codexstorage/codex-discordbot:sha-8033da1";
+        public override string Image => "codexstorage/codex-discordbot:sha-8c64352";
 
         public static string RewardsPort = "bot_rewards_port";
 
@@ -33,8 +33,6 @@ namespace CodexDiscordBotPlugin
             AddEnvVar("CODEXCONTRACTS_TOKENADDRESS", gethInfo.TokenAddress);
             AddEnvVar("CODEXCONTRACTS_ABI", gethInfo.Abi);
 
-            AddEnvVar("NODISCORD", "1");
-
             AddInternalPortAndVar("REWARDAPIPORT", RewardsPort);
 
             if (!string.IsNullOrEmpty(config.DataPath))

ProjectPlugins/CodexDiscordBotPlugin/DiscordBotStartupConfig.cs

@@ -27,9 +27,8 @@
 
     public class RewarderBotStartupConfig
     {
-        public RewarderBotStartupConfig(string name, string discordBotHost, int discordBotPort, int intervalMinutes, DateTime historyStartUtc, DiscordBotGethInfo gethInfo, string? dataPath)
+        public RewarderBotStartupConfig(string discordBotHost, int discordBotPort, string intervalMinutes, DateTime historyStartUtc, DiscordBotGethInfo gethInfo, string? dataPath)
         {
-            Name = name;
             DiscordBotHost = discordBotHost;
             DiscordBotPort = discordBotPort;
             IntervalMinutes = intervalMinutes;
@@ -38,10 +37,9 @@
             DataPath = dataPath;
         }
 
-        public string Name { get; }
         public string DiscordBotHost { get; }
         public int DiscordBotPort { get; }
-        public int IntervalMinutes { get; }
+        public string IntervalMinutes { get; }
         public DateTime HistoryStartUtc { get; }
         public DiscordBotGethInfo GethInfo { get; }
         public string? DataPath { get; set; }

ProjectPlugins/CodexDiscordBotPlugin/RewarderBotContainerRecipe.cs

@@ -7,7 +7,7 @@ namespace CodexDiscordBotPlugin
     public class RewarderBotContainerRecipe : ContainerRecipeFactory
     {
         public override string AppName => "discordbot-rewarder";
-        public override string Image => "codexstorage/codex-rewarderbot:sha-fb25372";
+        public override string Image => "codexstorage/codex-rewarderbot:sha-2ab84e2";
 
         protected override void Initialize(StartupConfig startupConfig)
         {
@@ -17,7 +17,7 @@ namespace CodexDiscordBotPlugin
 
             AddEnvVar("DISCORDBOTHOST", config.DiscordBotHost);
             AddEnvVar("DISCORDBOTPORT", config.DiscordBotPort.ToString());
-            AddEnvVar("INTERVALMINUTES", config.IntervalMinutes.ToString());
+            AddEnvVar("INTERVALMINUTES", config.IntervalMinutes);
             var offset = new DateTimeOffset(config.HistoryStartUtc);
             AddEnvVar("CHECKHISTORY", offset.ToUnixTimeSeconds().ToString());
 

ProjectPlugins/CodexPlugin/ApiChecker.cs

@@ -9,7 +9,7 @@ namespace CodexPlugin
     public class ApiChecker
     {
         // <INSERT-OPENAPI-YAML-HASH>
-        private const string OpenApiYamlHash = "6B-94-24-A4-D5-01-6F-12-E9-34-74-36-80-57-7A-3A-79-8C-E8-02-68-B7-05-DA-50-A0-5C-B1-02-B9-AE-C6";
+        private const string OpenApiYamlHash = "5A-B0-2A-AC-42-B1-A2-49-6F-9D-4E-D8-56-40-10-A6-67-F4-0D-2A-9F-E0-84-5C-EB-B8-2D-4F-D8-56-79-6C";
         private const string OpenApiFilePath = "/codex/openapi.yaml";
         private const string DisableEnvironmentVariable = "CODEXPLUGIN_DISABLE_APICHECK";
 
@@ -38,7 +38,7 @@ namespace CodexPlugin
             if (string.IsNullOrEmpty(OpenApiYamlHash)) throw new Exception("OpenAPI yaml hash was not inserted by pre-build trigger.");
         }
 
-        public void CheckCompatibility(RunningPod[] containers)
+        public void CheckCompatibility(RunningContainers[] containers)
         {
             if (checkPassed) return;
 

ProjectPlugins/CodexPlugin/CodexAccess.cs

@@ -2,29 +2,28 @@
 using Core;
 using KubernetesWorkflow;
 using KubernetesWorkflow.Types;
-using Logging;
 using Newtonsoft.Json;
 using Utils;
 
 namespace CodexPlugin
 {
-    public class CodexAccess
+    public class CodexAccess : ILogHandler
     {
-        private readonly ILog log;
         private readonly IPluginTools tools;
         private readonly Mapper mapper = new Mapper();
+        private bool hasContainerCrashed;
 
-        public CodexAccess(IPluginTools tools, RunningPod container, CrashWatcher crashWatcher)
+        public CodexAccess(IPluginTools tools, RunningContainer container, CrashWatcher crashWatcher)
         {
             this.tools = tools;
-            log = tools.GetLog();
             Container = container;
             CrashWatcher = crashWatcher;
+            hasContainerCrashed = false;
 
-            CrashWatcher.Start();
+            CrashWatcher.Start(this);
         }
 
-        public RunningPod Container { get; }
+        public RunningContainer Container { get; }
         public CrashWatcher CrashWatcher { get; }
 
         public DebugInfo GetDebugInfo()
@@ -35,23 +34,20 @@ namespace CodexPlugin
         public DebugPeer GetDebugPeer(string peerId)
         {
             // Cannot use openAPI: debug/peer endpoint is not specified there.
-            return CrashCheck(() =>
+            var endpoint = GetEndpoint();
+            var str = endpoint.HttpGetString($"debug/peer/{peerId}");
+
+            if (str.ToLowerInvariant() == "unable to find peer!")
             {
-                var endpoint = GetEndpoint();
-                var str = endpoint.HttpGetString($"debug/peer/{peerId}");
-
-                if (str.ToLowerInvariant() == "unable to find peer!")
+                return new DebugPeer
                 {
-                    return new DebugPeer
-                    {
-                        IsPeerFound = false
-                    };
-                }
+                    IsPeerFound = false
+                };
+            }
 
-                var result = endpoint.Deserialize<DebugPeer>(str);
-                result.IsPeerFound = true;
-                return result;
-            });
+            var result = endpoint.Deserialize<DebugPeer>(str);
+            result.IsPeerFound = true;
+            return result;
         }
 
         public void ConnectToPeer(string peerId, string[] peerMultiAddresses)
@@ -63,19 +59,14 @@ namespace CodexPlugin
             });
         }
 
-        public string UploadFile(FileStream fileStream, Action<Failure> onFailure)
+        public string UploadFile(FileStream fileStream)
         {
-            return OnCodex(
-                api => api.UploadAsync(fileStream),
-                CreateRetryConfig(nameof(UploadFile), onFailure));
+            return OnCodex(api => api.UploadAsync(fileStream));
         }
 
-        public Stream DownloadFile(string contentId, Action<Failure> onFailure)
+        public Stream DownloadFile(string contentId)
         {
-            var fileResponse = OnCodex(
-                api => api.DownloadNetworkAsync(contentId),
-                CreateRetryConfig(nameof(DownloadFile), onFailure));
-
+            var fileResponse = OnCodex(api => api.DownloadNetworkAsync(contentId));
             if (fileResponse.StatusCode != 200) throw new Exception("Download failed with StatusCode: " + fileResponse.StatusCode);
             return fileResponse.Stream;
         }
@@ -92,36 +83,21 @@ namespace CodexPlugin
             return mapper.Map(read);
         }
 
-        public StorageAvailability[] GetAvailabilities()
-        {
-            var collection = OnCodex<ICollection<SalesAvailabilityREAD>>(api => api.GetAvailabilitiesAsync());
-            return mapper.Map(collection);
-        }
-
         public string RequestStorage(StoragePurchaseRequest request)
         {
             var body = mapper.Map(request);
             return OnCodex<string>(api => api.CreateStorageRequestAsync(request.ContentId.Id, body));
         }
 
-        public CodexSpace Space()
-        {
-            var space = OnCodex<Space>(api => api.SpaceAsync());
-            return mapper.Map(space);
-        }
-
         public StoragePurchase GetPurchaseStatus(string purchaseId)
         {
-            return CrashCheck(() =>
+            var endpoint = GetEndpoint();
+            return Time.Retry(() =>
             {
-                var endpoint = GetEndpoint();
-                return Time.Retry(() =>
-                {
-                    var str = endpoint.HttpGetString($"storage/purchases/{purchaseId}");
-                    if (string.IsNullOrEmpty(str)) throw new Exception("Empty response.");
-                    return JsonConvert.DeserializeObject<StoragePurchase>(str)!;
-                }, nameof(GetPurchaseStatus));
-            });
+                var str = endpoint.HttpGetString($"storage/purchases/{purchaseId}");
+                if (string.IsNullOrEmpty(str)) throw new Exception("Empty response.");
+                return JsonConvert.DeserializeObject<StoragePurchase>(str)!;
+            }, nameof(GetPurchaseStatus));
 
             // TODO: current getpurchase api does not line up with its openapi spec.
             // return mapper.Map(OnCodex(api => api.GetPurchaseAsync(purchaseId)));
@@ -138,127 +114,53 @@ namespace CodexPlugin
             return workflow.GetPodInfo(Container);
         }
 
-        public void DeleteRepoFolder()
-        {
-            try
-            {
-                var containerNumber = Container.Containers.First().Recipe.Number;
-                var dataDir = $"datadir{containerNumber}";
-                var workflow = tools.CreateWorkflow();
-                workflow.ExecuteCommand(Container.Containers.First(), "rm", "-Rfv", $"/codex/{dataDir}/repo");
-                Log("Deleted repo folder.");
-            }
-            catch (Exception e)
-            {
-                Log("Unable to delete repo folder: " + e);
-            }
-        }
-
         private T OnCodex<T>(Func<CodexApi, Task<T>> action)
-        {
-            var result = tools.CreateHttp(GetHttpId(), CheckContainerCrashed).OnClient(client => CallCodex(client, action));
-            return result;
-        }
-
-        private T OnCodex<T>(Func<CodexApi, Task<T>> action, Retry retry)
-        {
-            var result = tools.CreateHttp(GetHttpId(), CheckContainerCrashed).OnClient(client => CallCodex(client, action), retry);
-            return result;
-        }
-
-        private T CallCodex<T>(HttpClient client, Func<CodexApi, Task<T>> action)
         {
             var address = GetAddress();
-            var api = new CodexApi(client);
-            api.BaseUrl = $"{address.Host}:{address.Port}/api/codex/v1";
-            return CrashCheck(() => Time.Wait(action(api)));
-        }
-
-        private T CrashCheck<T>(Func<T> action)
-        {
-            try
+            var result = tools.CreateHttp(CheckContainerCrashed)
+                .OnClient(client =>
             {
-                return action();
-            }
-            finally
-            {
-                CrashWatcher.HasContainerCrashed();
-            }
+                var api = new CodexApi(client);
+                api.BaseUrl = $"{address.Host}:{address.Port}/api/codex/v1";
+                return Time.Wait(action(api));
+            });
+            return result;
         }
 
         private IEndpoint GetEndpoint()
         {
             return tools
-                .CreateHttp(GetHttpId(), CheckContainerCrashed)
+                .CreateHttp(CheckContainerCrashed)
                 .CreateEndpoint(GetAddress(), "/api/codex/v1/", Container.Name);
         }
 
         private Address GetAddress()
         {
-            return Container.Containers.Single().GetAddress(CodexContainerRecipe.ApiPortTag);
-        }
-
-        private string GetHttpId()
-        {
-            return GetAddress().ToString();
+            return Container.GetAddress(tools.GetLog(), CodexContainerRecipe.ApiPortTag);
         }
 
         private void CheckContainerCrashed(HttpClient client)
         {
-            if (CrashWatcher.HasContainerCrashed()) throw new Exception($"Container {GetName()} has crashed.");
+            if (hasContainerCrashed) throw new Exception("Container has crashed.");
         }
 
-        private Retry CreateRetryConfig(string description, Action<Failure> onFailure)
+        public void Log(Stream crashLog)
         {
-            var timeSet = tools.TimeSet;
+            var log = tools.GetLog();
+            var file = log.CreateSubfile();
+            log.Log($"Container {Container.Name} has crashed. Downloading crash log to '{file.FullFilename}'...");
+            file.Write($"Container Crash Log for {Container.Name}.");
 
-            return new Retry(description, timeSet.HttpRetryTimeout(), timeSet.HttpCallRetryDelay(), failure =>
+            using var reader = new StreamReader(crashLog);
+            var line = reader.ReadLine();
+            while (line != null)
             {
-                onFailure(failure);
-                Investigate(failure, timeSet);
-            });
-        }
-
-        private void Investigate(Failure failure, ITimeSet timeSet)
-        {
-            Log($"Retry {failure.TryNumber} took {Time.FormatDuration(failure.Duration)} and failed with '{failure.Exception}'. " +
-                $"(HTTP timeout = {Time.FormatDuration(timeSet.HttpCallTimeout())}) " +
-                $"Checking if node responds to debug/info...");
-
-            try
-            {
-                var debugInfo = GetDebugInfo();
-                if (string.IsNullOrEmpty(debugInfo.Spr))
-                {
-                    Log("Did not get value debug/info response.");
-                    Throw(failure);
-                }
-                else
-                {
-                    Log("Got valid response from debug/info.");
-                }
-            }
-            catch (Exception ex)
-            {
-                Log("Got exception from debug/info call: " + ex);
-                Throw(failure);
+                file.Write(line);
+                line = reader.ReadLine();
             }
 
-            if (failure.Duration < timeSet.HttpCallTimeout())
-            {
-                Log("Retry failed within HTTP timeout duration.");
-                Throw(failure);
-            }
-        }
-
-        private void Throw(Failure failure)
-        {
-            throw failure.Exception;
-        }
-
-        private void Log(string msg)
-        {
-            log.Log($"{GetName()} {msg}");
+            log.Log("Crash log successfully downloaded.");
+            hasContainerCrashed = true;
         }
     }
 }