Updates market averages

.github/workflows/docker-keymaker.yml

@@ -1,27 +0,0 @@
-name: Docker - KeyMaker
-
-
-on:
-  push:
-    branches:
-      - master
-    tags:
-      - 'v*.*.*'
-    paths:
-      - 'Tools/KeyMaker/**'
-      - 'Framework/**'
-      - 'ProjectPlugins/**'
-      - .github/workflows/docker-KeyMaker.yml
-      - .github/workflows/docker-reusable.yml
-  workflow_dispatch:
-
-
-jobs:
-  build-and-push:
-    name: Build and Push
-    uses: ./.github/workflows/docker-reusable.yml
-    with:
-      docker_file: Tools/KeyMaker/docker/Dockerfile
-      docker_repo: codexstorage/codex-keymaker
-    secrets: inherit
-

Framework/ArgsUniform/ArgsUniform.cs

@@ -4,8 +4,9 @@ namespace ArgsUniform
 {
     public class ArgsUniform<T>
     {
-        private readonly Assigner<T> assigner;
         private readonly Action printAppInfo;
+        private readonly object? defaultsProvider;
+        private readonly IEnv.IEnv env;
         private readonly string[] args;
         private const int cliStart = 8;
         private const int shortStart = 38;
@@ -30,9 +31,9 @@ namespace ArgsUniform
         public ArgsUniform(Action printAppInfo, object defaultsProvider, IEnv.IEnv env, params string[] args)
         {
             this.printAppInfo = printAppInfo;
+            this.defaultsProvider = defaultsProvider;
+            this.env = env;
             this.args = args;
-
-            assigner = new Assigner<T>(env, args, defaultsProvider);
         }
 
         public T Parse(bool printResult = false)
@@ -41,7 +42,7 @@ namespace ArgsUniform
             {
                 printAppInfo();
                 PrintHelp();
-                Environment.Exit(0);
+                throw new Exception();
             }
 
             var result = Activator.CreateInstance<T>();
@@ -52,16 +53,18 @@ namespace ArgsUniform
                 var attr = uniformProperty.GetCustomAttribute<UniformAttribute>();
                 if (attr != null)
                 {
-                    if (!assigner.UniformAssign(result, attr, uniformProperty) && attr.Required)
+                    if (!UniformAssign(result, attr, uniformProperty) && attr.Required)
                     {
-                        missingRequired.Add(uniformProperty);
+                        {
+                            missingRequired.Add(uniformProperty);
+                        }
                     }
                 }
             }
 
             if (missingRequired.Any())
             {
-                PrintResults(printResult,result, uniformProperties);
+                PrintResults(result, uniformProperties);
                 Print("");
                 foreach (var missing in missingRequired)
                 {
@@ -72,39 +75,37 @@ namespace ArgsUniform
                 }
 
                 PrintHelp();
-                Environment.Exit(1);
+                throw new ArgumentException("Unable to assemble all required arguments");
             }
 
-            PrintResults(printResult, result, uniformProperties);
+            if (printResult)
+            {
+                PrintResults(result, uniformProperties);
+            }
 
             return result;
         }
 
+        private void PrintResults(T result, PropertyInfo[] uniformProperties)
+        {
+            Print("");
+            foreach (var p in uniformProperties)
+            {
+                Print($"\t{p.Name} = {p.GetValue(result)}");
+            }
+            Print("");
+        }
+
         public void PrintHelp()
         {
             Print("");
-            PrintAligned("CLI option:", "(short)", "Environment variable:", "Description", "(default)");
-            var props = typeof(T).GetProperties().Where(m => m.GetCustomAttributes(typeof(UniformAttribute), false).Length == 1).ToArray();
-            foreach (var prop in props)
+            PrintAligned("CLI option:", "(short)", "Environment variable:", "Description");
+            var attrs = typeof(T).GetProperties().Where(m => m.GetCustomAttributes(typeof(UniformAttribute), false).Length == 1).Select(p => p.GetCustomAttribute<UniformAttribute>()).Where(a => a != null).ToArray();
+            foreach (var attr in attrs)
             {
-                var a = prop.GetCustomAttribute<UniformAttribute>();
-                if (a != null)
-                {
-                    var optional = !a.Required ? " (optional)" : "";
-                    var def = assigner.DescribeDefaultFor(prop);
-                    PrintAligned($"--{a.Arg}=...", $"({a.ArgShort})", a.EnvVar, a.Description + optional, $"({def})");
-                }
-            }
-            Print("");
-        }
-
-        private void PrintResults(bool printResult, T result, PropertyInfo[] uniformProperties)
-        {
-            if (!printResult) return;
-            Print("");
-            foreach (var p in uniformProperties)
-            {
-                Print($"\t{p.Name} = {p.GetValue(result)}");
+                var a = attr!;
+                var optional = !a.Required ? " *" : "";
+                PrintAligned($"--{a.Arg}=...", $"({a.ArgShort})", a.EnvVar, a.Description + optional);
             }
             Print("");
         }
@@ -114,7 +115,7 @@ namespace ArgsUniform
             Console.WriteLine(msg);
         }
 
-        private void PrintAligned(string cli, string s, string env, string desc, string def)
+        private void PrintAligned(string cli, string s, string env, string desc)
         {
             Console.CursorLeft = cliStart;
             Console.Write(cli);
@@ -123,8 +124,132 @@ namespace ArgsUniform
             Console.CursorLeft = envStart;
             Console.Write(env);
             Console.CursorLeft = descStart;
-            Console.Write(desc + " ");
-            Console.Write(def + Environment.NewLine);
+            Console.Write(desc + Environment.NewLine);
+        }
+
+        private object GetDefaultValue(Type t)
+        {
+            if (t.IsValueType) return Activator.CreateInstance(t)!;
+            return null!;
+        }
+
+        private bool UniformAssign(T result, UniformAttribute attr, PropertyInfo uniformProperty)
+        {
+            if (AssignFromArgsIfAble(result, attr, uniformProperty)) return true;
+            if (AssignFromEnvVarIfAble(result, attr, uniformProperty)) return true;
+            if (AssignFromDefaultsIfAble(result, uniformProperty)) return true;
+            return false;
+        }
+
+        private bool AssignFromDefaultsIfAble(T result, PropertyInfo uniformProperty)
+        {
+            var currentValue = uniformProperty.GetValue(result);
+            var isEmptryString = (currentValue as string) == string.Empty;
+            if (currentValue != GetDefaultValue(uniformProperty.PropertyType) && !isEmptryString) return true;
+
+            if (defaultsProvider == null) return false;
+
+            var defaultProperty = defaultsProvider.GetType().GetProperties().SingleOrDefault(p => p.Name == uniformProperty.Name);
+            if (defaultProperty == null) return false;
+
+            var value = defaultProperty.GetValue(defaultsProvider);
+            if (value != null)
+            {
+                return Assign(result, uniformProperty, value);
+            }
+            return false;
+        }
+
+        private bool AssignFromEnvVarIfAble(T result, UniformAttribute attr, PropertyInfo uniformProperty)
+        {
+            var e = env.GetEnvVarOrDefault(attr.EnvVar, string.Empty);
+            if (!string.IsNullOrEmpty(e))
+            {
+                return Assign(result, uniformProperty, e);
+            }
+            return false;
+        }
+
+        private bool AssignFromArgsIfAble(T result, UniformAttribute attr, PropertyInfo uniformProperty)
+        {
+            var fromArg = GetFromArgs(attr.Arg);
+            if (fromArg != null)
+            {
+                return Assign(result, uniformProperty, fromArg);
+            }
+            var fromShort = GetFromArgs(attr.ArgShort);
+            if (fromShort != null)
+            {
+                return Assign(result, uniformProperty, fromShort);
+            }
+            return false;
+        }
+
+        private bool Assign(T result, PropertyInfo uniformProperty, object value)
+        {
+            if (uniformProperty.PropertyType == value.GetType())
+            {
+                uniformProperty.SetValue(result, value);
+                return true;
+            }
+            else
+            {
+                if (uniformProperty.PropertyType == typeof(string) || uniformProperty.PropertyType == typeof(int))
+                {
+                    uniformProperty.SetValue(result, Convert.ChangeType(value, uniformProperty.PropertyType));
+                    return true;
+                }
+                else
+                {
+                    if (uniformProperty.PropertyType == typeof(int?)) return AssignOptionalInt(result, uniformProperty, value);
+                    if (uniformProperty.PropertyType.IsEnum) return AssignEnum(result, uniformProperty, value);
+                    if (uniformProperty.PropertyType == typeof(bool)) return AssignBool(result, uniformProperty, value);
+                    
+                    throw new NotSupportedException();
+                }
+            }
+        }
+
+        private static bool AssignEnum(T result, PropertyInfo uniformProperty, object value)
+        {
+            var s = value.ToString();
+            if (Enum.TryParse(uniformProperty.PropertyType, s, out var e))
+            {
+                uniformProperty.SetValue(result, e);
+                return true;
+            }
+            return false;
+        }
+
+        private static bool AssignOptionalInt(T result, PropertyInfo uniformProperty, object value)
+        {
+            if (int.TryParse(value.ToString(), out int i))
+            {
+                uniformProperty.SetValue(result, i);
+                return true;
+            }
+            return false;
+        }
+
+        private static bool AssignBool(T result, PropertyInfo uniformProperty, object value)
+        {
+            var s = value.ToString();
+            if (s == "1" || (s != null && s.ToLowerInvariant() == "true"))
+            {
+                uniformProperty.SetValue(result, true);
+            }
+            return true;
+        }
+
+        private string? GetFromArgs(string key)
+        {
+            var argKey = $"--{key}=";
+            var arg = args.FirstOrDefault(a => a.StartsWith(argKey));
+            if (arg != null)
+            {
+                return arg.Substring(argKey.Length);
+            }
+            return null;
         }
     }
 }

Framework/ArgsUniform/Assigner.cs

@@ -1,186 +0,0 @@
-using System.Globalization;
-using System.Numerics;
-using System.Reflection;
-
-namespace ArgsUniform
-{
-    public class Assigner<T>
-    {
-        private readonly IEnv.IEnv env;
-        private readonly string[] args;
-        private readonly object? defaultsProvider;
-
-        public Assigner(IEnv.IEnv env, string[] args, object? defaultsProvider)
-        {
-            this.env = env;
-            this.args = args;
-            this.defaultsProvider = defaultsProvider;
-        }
-
-        public bool UniformAssign(T result, UniformAttribute attr, PropertyInfo uniformProperty)
-        {
-            if (AssignFromArgsIfAble(result, attr, uniformProperty)) return true;
-            if (AssignFromEnvVarIfAble(result, attr, uniformProperty)) return true;
-            if (AssignFromDefaultsIfAble(result, uniformProperty)) return true;
-            return false;
-        }
-
-        public string DescribeDefaultFor(PropertyInfo property)
-        {
-            var obj = Activator.CreateInstance<T>();
-            var defaultValue = GetDefaultValue(obj, property);
-            if (defaultValue == null) return "";
-            if (defaultValue is string str)
-            {
-                return "\"" + str + "\"";
-            }
-            return defaultValue.ToString() ?? string.Empty;
-        }
-
-        private object? GetDefaultValue(T result, PropertyInfo uniformProperty)
-        {
-            // Get value from object's static initializer if it's there.
-            var currentValue = uniformProperty.GetValue(result);
-            if (currentValue != null) return currentValue;
-
-            // Get value from defaults-provider object if it's there.
-            if (defaultsProvider == null) return null;
-            var defaultProperty = defaultsProvider.GetType().GetProperties().SingleOrDefault(p => p.Name == uniformProperty.Name);
-            if (defaultProperty == null) return null;
-            return defaultProperty.GetValue(defaultsProvider);
-        }
-
-        private bool AssignFromDefaultsIfAble(T result, PropertyInfo uniformProperty)
-        {
-            var defaultValue = GetDefaultValue(result, uniformProperty);
-            var isEmptryString = (defaultValue as string) == string.Empty;
-            if (defaultValue != null && defaultValue != GetDefaultValueForType(uniformProperty.PropertyType) && !isEmptryString)
-            {
-                return Assign(result, uniformProperty, defaultValue);
-            }
-            return false;
-        }
-
-        private bool AssignFromEnvVarIfAble(T result, UniformAttribute attr, PropertyInfo uniformProperty)
-        {
-            var e = env.GetEnvVarOrDefault(attr.EnvVar, string.Empty);
-            if (!string.IsNullOrEmpty(e))
-            {
-                return Assign(result, uniformProperty, e);
-            }
-            return false;
-        }
-
-        private bool AssignFromArgsIfAble(T result, UniformAttribute attr, PropertyInfo uniformProperty)
-        {
-            var fromArg = GetFromArgs(attr.Arg);
-            if (fromArg != null)
-            {
-                return Assign(result, uniformProperty, fromArg);
-            }
-            var fromShort = GetFromArgs(attr.ArgShort);
-            if (fromShort != null)
-            {
-                return Assign(result, uniformProperty, fromShort);
-            }
-            return false;
-        }
-
-        private bool Assign(T result, PropertyInfo uniformProperty, object value)
-        {
-            if (uniformProperty.PropertyType == value.GetType())
-            {
-                uniformProperty.SetValue(result, value);
-                return true;
-            }
-            else
-            {
-                if (uniformProperty.PropertyType == typeof(string) || uniformProperty.PropertyType == typeof(int))
-                {
-                    uniformProperty.SetValue(result, Convert.ChangeType(value, uniformProperty.PropertyType));
-                    return true;
-                }
-                else
-                {
-                    if (uniformProperty.PropertyType == typeof(int?)) return AssignOptionalInt(result, uniformProperty, value);
-                    if (uniformProperty.PropertyType.IsEnum) return AssignEnum(result, uniformProperty, value);
-                    if (uniformProperty.PropertyType == typeof(bool)) return AssignBool(result, uniformProperty, value);
-                    if (uniformProperty.PropertyType == typeof(ulong)) return AssignUlong(result, uniformProperty, value);
-                    if (uniformProperty.PropertyType == typeof(BigInteger)) return AssignBigInt(result, uniformProperty, value);
-
-                    throw new NotSupportedException(
-                        $"Unsupported property type '${uniformProperty.PropertyType}' " +
-                        $"for property '${uniformProperty.Name}'.");
-                }
-            }
-        }
-
-        private static bool AssignEnum(T result, PropertyInfo uniformProperty, object value)
-        {
-            var s = value.ToString();
-            if (Enum.TryParse(uniformProperty.PropertyType, s, out var e))
-            {
-                uniformProperty.SetValue(result, e);
-                return true;
-            }
-            return false;
-        }
-
-        private static bool AssignOptionalInt(T result, PropertyInfo uniformProperty, object value)
-        {
-            if (int.TryParse(value.ToString(), CultureInfo.InvariantCulture, out int i))
-            {
-                uniformProperty.SetValue(result, i);
-                return true;
-            }
-            return false;
-        }
-
-        private bool AssignUlong(T? result, PropertyInfo uniformProperty, object value)
-        {
-            if (ulong.TryParse(value.ToString(), CultureInfo.InvariantCulture, out ulong i))
-            {
-                uniformProperty.SetValue(result, i);
-                return true;
-            }
-            return false;
-        }
-
-        private bool AssignBigInt(T result, PropertyInfo uniformProperty, object value)
-        {
-            if (BigInteger.TryParse(value.ToString(), CultureInfo.InvariantCulture, out BigInteger i))
-            {
-                uniformProperty.SetValue(result, i);
-                return true;
-            }
-            return false;
-        }
-
-        private static bool AssignBool(T result, PropertyInfo uniformProperty, object value)
-        {
-            var s = value.ToString();
-            if (s == "1" || (s != null && s.ToLowerInvariant() == "true"))
-            {
-                uniformProperty.SetValue(result, true);
-            }
-            return true;
-        }
-
-        private string? GetFromArgs(string key)
-        {
-            var argKey = $"--{key}=";
-            var arg = args.FirstOrDefault(a => a.StartsWith(argKey));
-            if (arg != null)
-            {
-                return arg.Substring(argKey.Length);
-            }
-            return null;
-        }
-
-        private static object GetDefaultValueForType(Type t)
-        {
-            if (t.IsValueType) return Activator.CreateInstance(t)!;
-            return null!;
-        }
-    }
-}

Framework/Core/CoreInterface.cs

@@ -30,11 +30,11 @@ namespace Core
         public IDownloadedLog DownloadLog(RunningContainer container, int? tailLines = null)
         {
             var workflow = entryPoint.Tools.CreateWorkflow();
-            var msg = $"Downloading container log for '{container.Name}'";
-            entryPoint.Tools.GetLog().Log(msg);
-            var logHandler = new WriteToFileLogHandler(entryPoint.Tools.GetLog(), msg);
+            var file = entryPoint.Tools.GetLog().CreateSubfile();
+            entryPoint.Tools.GetLog().Log($"Downloading container log for '{container.Name}' to file '{file.FullFilename}'...");
+            var logHandler = new LogDownloadHandler(container.Name, file);
             workflow.DownloadContainerLog(container, logHandler, tailLines);
-            return new DownloadedLog(logHandler);
+            return logHandler.DownloadLog();
         }
 
         public string ExecuteContainerCommand(IHasContainer containerSource, string command, params string[] args)

Framework/Core/DownloadedLog.cs

@@ -1,11 +1,9 @@
-using KubernetesWorkflow;
-using Logging;
+using Logging;
 
 namespace Core
 {
     public interface IDownloadedLog
     {
-        void IterateLines(Action<string> action);
         string[] GetLinesContaining(string expectedString);
         string[] FindLinesThatContain(params string[] tags);
         void DeleteFile();
@@ -15,22 +13,9 @@ namespace Core
     {
         private readonly LogFile logFile;
 
-        internal DownloadedLog(WriteToFileLogHandler logHandler)
+        internal DownloadedLog(LogFile logFile)
         {
-            logFile = logHandler.LogFile;
-        }
-
-        public void IterateLines(Action<string> action)
-        {
-            using var file = File.OpenRead(logFile.FullFilename);
-            using var streamReader = new StreamReader(file);
-
-            var line = streamReader.ReadLine();
-            while (line != null)
-            {
-                action(line);
-                line = streamReader.ReadLine();
-            }
+            this.logFile = logFile;
         }
 
         public string[] GetLinesContaining(string expectedString)

Framework/Core/EntryPoint.cs

@@ -38,14 +38,10 @@ namespace Core
             return new CoreInterface(this);
         }
 
-        /// <summary>
-        /// Deletes kubernetes and tracked file resources.
-        /// when `waitTillDone` is true, this function will block until resources are deleted.
-        /// </summary>
-        public void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles, bool waitTillDone)
+        public void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles)
         {
-            manager.DecommissionPlugins(deleteKubernetesResources, deleteTrackedFiles, waitTillDone);
-            Tools.Decommission(deleteKubernetesResources, deleteTrackedFiles, waitTillDone);
+            manager.DecommissionPlugins(deleteKubernetesResources, deleteTrackedFiles);
+            Tools.Decommission(deleteKubernetesResources, deleteTrackedFiles);
         }
 
         internal T GetPlugin<T>() where T : IProjectPlugin

Framework/Core/Http.cs

@@ -7,7 +7,6 @@ namespace Core
     {
         T OnClient<T>(Func<HttpClient, T> action);
         T OnClient<T>(Func<HttpClient, T> action, string description);
-        T OnClient<T>(Func<HttpClient, T> action, Retry retry);
         IEndpoint CreateEndpoint(Address address, string baseUrl, string? logAlias = null);
     }
 
@@ -36,19 +35,13 @@ namespace Core
         }
 
         public T OnClient<T>(Func<HttpClient, T> action, string description)
-        {
-            var retry = new Retry(description, timeSet.HttpRetryTimeout(), timeSet.HttpCallRetryDelay(), f => { });
-            return OnClient(action, retry);
-        }
-
-        public T OnClient<T>(Func<HttpClient, T> action, Retry retry)
         {
             var client = GetClient();
 
             return LockRetry(() =>
             {
                 return action(client);
-            }, retry);
+            }, description);
         }
 
         public IEndpoint CreateEndpoint(Address address, string baseUrl, string? logAlias = null)
@@ -61,11 +54,11 @@ namespace Core
             return DebugStack.GetCallerName(skipFrames: 2);
         }
 
-        private T LockRetry<T>(Func<T> operation, Retry retry)
+        private T LockRetry<T>(Func<T> operation, string description)
         {
             lock (httpLock)
             {
-                return retry.Run(operation);
+                return Time.Retry(operation, timeSet.HttpMaxNumberOfRetries(), timeSet.HttpCallRetryDelay(), description);
             }
         }
 

Framework/Core/LogDownloadHandler.cs

@@ -0,0 +1,28 @@
+using KubernetesWorkflow;
+using Logging;
+
+namespace Core
+{
+    internal class LogDownloadHandler : LogHandler, ILogHandler
+    {
+        private readonly LogFile log;
+
+        internal LogDownloadHandler(string description, LogFile log)
+        {
+            this.log = log;
+
+            log.Write($"{description} -->> {log.FullFilename}");
+            log.WriteRaw(description);
+        }
+
+        internal IDownloadedLog DownloadLog()
+        {
+            return new DownloadedLog(log);
+        }
+
+        protected override void ProcessLine(string line)
+        {
+            log.WriteRaw(line);
+        }
+    }
+}

Framework/Core/PluginManager.cs

@@ -34,12 +34,12 @@
             return metadata;
         }
 
-        internal void DecommissionPlugins(bool deleteKubernetesResources, bool deleteTrackedFiles, bool waitTillDone)
+        internal void DecommissionPlugins(bool deleteKubernetesResources, bool deleteTrackedFiles)
         {
             foreach (var pair in pairs)
             {
                 pair.Plugin.Decommission();
-                pair.Tools.Decommission(deleteKubernetesResources, deleteTrackedFiles, waitTillDone);
+                pair.Tools.Decommission(deleteKubernetesResources, deleteTrackedFiles);
             }
         }
 

Framework/Core/PluginTools.cs

@@ -6,13 +6,7 @@ namespace Core
 {
     public interface IPluginTools : IWorkflowTool, ILogTool, IHttpFactoryTool, IFileTool
     {
-        ITimeSet TimeSet { get; }
-
-        /// <summary>
-        /// Deletes kubernetes and tracked file resources.
-        /// when `waitTillDone` is true, this function will block until resources are deleted.
-        /// </summary>
-        void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles, bool waitTillDone);
+        void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles);
     }
 
     public interface IWorkflowTool
@@ -39,6 +33,7 @@ namespace Core
 
     internal class PluginTools : IPluginTools
     {
+        private readonly ITimeSet timeSet;
         private readonly WorkflowCreator workflowCreator;
         private readonly IFileManager fileManager;
         private readonly LogPrefixer log;
@@ -47,12 +42,10 @@ namespace Core
         {
             this.log = new LogPrefixer(log);
             this.workflowCreator = workflowCreator;
-            TimeSet = timeSet;
+            this.timeSet = timeSet;
             fileManager = new FileManager(log, fileManagerRootFolder);
         }
 
-        public ITimeSet TimeSet { get; }
-
         public void ApplyLogPrefix(string prefix)
         {
             log.Prefix = prefix;
@@ -60,7 +53,7 @@ namespace Core
 
         public IHttp CreateHttp(Action<HttpClient> onClientCreated)
         {
-            return CreateHttp(onClientCreated, TimeSet);
+            return CreateHttp(onClientCreated, timeSet);
         }
 
         public IHttp CreateHttp(Action<HttpClient> onClientCreated, ITimeSet ts)
@@ -70,7 +63,7 @@ namespace Core
 
         public IHttp CreateHttp()
         {
-            return new Http(log, TimeSet);
+            return new Http(log, timeSet);
         }
 
         public IStartupWorkflow CreateWorkflow(string? namespaceOverride = null)
@@ -78,9 +71,9 @@ namespace Core
             return workflowCreator.CreateWorkflow(namespaceOverride);
         }
 
-        public void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles, bool waitTillDone)
+        public void Decommission(bool deleteKubernetesResources, bool deleteTrackedFiles)
         {
-            if (deleteKubernetesResources) CreateWorkflow().DeleteNamespace(waitTillDone);
+            if (deleteKubernetesResources) CreateWorkflow().DeleteNamespace();
             if (deleteTrackedFiles) fileManager.DeleteAllFiles();
         }
 

Framework/Core/TimeSet.cs

@@ -2,31 +2,10 @@
 {
     public interface ITimeSet
     {
-        /// <summary>
-        /// Timeout for a single HTTP call.
-        /// </summary>
         TimeSpan HttpCallTimeout();
-
-        /// <summary>
-        /// Maximum total time to attempt to make a successful HTTP call to a service.
-        /// When HTTP calls time out during this timespan, retries will be made.
-        /// </summary>
-        TimeSpan HttpRetryTimeout();
-
-        /// <summary>
-        /// After a failed HTTP call, wait this long before trying again.
-        /// </summary>
+        int HttpMaxNumberOfRetries();
         TimeSpan HttpCallRetryDelay();
-
-        /// <summary>
-        /// After a failed K8s operation, wait this long before trying again.
-        /// </summary>
-        TimeSpan K8sOperationRetryDelay();
-
-        /// <summary>
-        /// Maximum total time to attempt to perform a successful k8s operation.
-        /// If k8s operations fail during this timespan, retries will be made.
-        /// </summary>
+        TimeSpan WaitForK8sServiceDelay();
         TimeSpan K8sOperationTimeout();
     }
 
@@ -37,9 +16,9 @@
             return TimeSpan.FromMinutes(3);
         }
 
-        public TimeSpan HttpRetryTimeout()
+        public int HttpMaxNumberOfRetries()
         {
-            return TimeSpan.FromMinutes(10);
+            return 3;
         }
 
         public TimeSpan HttpCallRetryDelay()
@@ -47,7 +26,7 @@
             return TimeSpan.FromSeconds(1);
         }
 
-        public TimeSpan K8sOperationRetryDelay()
+        public TimeSpan WaitForK8sServiceDelay()
         {
             return TimeSpan.FromSeconds(10);
         }
@@ -62,27 +41,27 @@
     {
         public TimeSpan HttpCallTimeout()
         {
-            return TimeSpan.FromMinutes(30);
+            return TimeSpan.FromHours(2);
         }
 
-        public TimeSpan HttpRetryTimeout()
+        public int HttpMaxNumberOfRetries()
         {
-            return TimeSpan.FromHours(2.2);
+            return 1;
         }
 
         public TimeSpan HttpCallRetryDelay()
         {
-            return TimeSpan.FromSeconds(20);
+            return TimeSpan.FromSeconds(2);
         }
 
-        public TimeSpan K8sOperationRetryDelay()
+        public TimeSpan WaitForK8sServiceDelay()
         {
-            return TimeSpan.FromSeconds(30);
+            return TimeSpan.FromSeconds(10);
         }
 
         public TimeSpan K8sOperationTimeout()
         {
-            return TimeSpan.FromHours(1);
+            return TimeSpan.FromMinutes(15);
         }
     }
 }

Framework/DiscordRewards/GiveRewardsCommand.cs

@@ -15,8 +15,7 @@
 
     public class MarketAverage
     {
-        public int NumberOfFinished { get; set; }
-        public int TimeRangeSeconds { get; set; }
+        public string Title { get; set; } = string.Empty;
         public float Price { get; set; }
         public float Size { get; set; }
         public float Duration { get; set; }

Framework/FileUtils/TrackedFile.cs

@@ -65,7 +65,7 @@ namespace FileUtils
 
                 if (readExpected == 0 && readActual == 0)
                 {
-                    log.Log($"OK: {Describe()} is equal to {actual.Describe()}.");
+                    log.Log($"OK: '{Describe()}' is equal to '{actual.Describe()}'.");
                     return;
                 }
 

Framework/KubernetesWorkflow/ByteSizeExtensions.cs

@@ -0,0 +1,41 @@
+using Utils;
+
+namespace KubernetesWorkflow
+{
+    public static class ByteSizeExtensions
+    {
+        public static string ToSuffixNotation(this ByteSize b)
+        {
+            long x = 1024;
+            var map = new Dictionary<long, string>
+            {
+                { Pow(x, 4), "Ti" },
+                { Pow(x, 3), "Gi" },
+                { Pow(x, 2), "Mi" },
+                { (x), "Ki" },
+            };
+
+            var bytes = b.SizeInBytes;
+            foreach (var pair in map)
+            {
+                if (bytes > pair.Key)
+                {
+                    double bytesD = bytes;
+                    double divD = pair.Key;
+                    double numD = Math.Ceiling(bytesD / divD);
+                    var v = Convert.ToInt64(numD);
+                    return $"{v}{pair.Value}";
+                }
+            }
+
+            return $"{bytes}";
+        }
+
+        private static long Pow(long x, int v)
+        {
+            long result = 1;
+            for (var i = 0; i < v; i++) result *= x;
+            return result;
+        }
+    }
+}

Framework/KubernetesWorkflow/CrashWatcher.cs

@@ -11,6 +11,7 @@ namespace KubernetesWorkflow
         private readonly string podName;
         private readonly string recipeName;
         private readonly string k8sNamespace;
+        private ILogHandler? logHandler;
         private CancellationTokenSource cts;
         private Task? worker;
         private Exception? workerException;
@@ -26,10 +27,11 @@ namespace KubernetesWorkflow
             cts = new CancellationTokenSource();
         }
 
-        public void Start()
+        public void Start(ILogHandler logHandler)
         {
             if (worker != null) throw new InvalidOperationException();
 
+            this.logHandler = logHandler;
             cts = new CancellationTokenSource();
             worker = Task.Run(Worker);
         }
@@ -48,9 +50,7 @@ namespace KubernetesWorkflow
         public bool HasContainerCrashed()
         {
             using var client = new Kubernetes(config);
-            var result = HasContainerBeenRestarted(client);
-            if (result) DownloadCrashedContainerLogs(client);
-            return result;
+            return HasContainerBeenRestarted(client);
         }
 
         private void Worker()
@@ -83,16 +83,14 @@ namespace KubernetesWorkflow
         private bool HasContainerBeenRestarted(Kubernetes client)
         {
             var podInfo = client.ReadNamespacedPod(podName, k8sNamespace);
-            var result = podInfo.Status.ContainerStatuses.Any(c => c.RestartCount > 0);
-            if (result) log.Log("Pod crash detected for " + containerName);
-            return result;
+            return podInfo.Status.ContainerStatuses.Any(c => c.RestartCount > 0);
         }
 
         private void DownloadCrashedContainerLogs(Kubernetes client)
         {
+            log.Log("Pod crash detected for " + containerName);
             using var stream = client.ReadNamespacedPodLog(podName, k8sNamespace, recipeName, previous: true);
-            var handler = new WriteToFileLogHandler(log, "Crash detected for " + containerName);
-            handler.Log(stream);
+            logHandler!.Log(stream);
         }
     }
 }

Framework/KubernetesWorkflow/K8sCluster.cs

@@ -16,7 +16,6 @@ namespace KubernetesWorkflow
         {
             var config = GetConfig();
             UpdateHostAddress(config);
-            config.SkipTlsVerify = true; // Required for operation on Wings cluster.
             return config;
         }
 

Framework/KubernetesWorkflow/K8sController.cs

@@ -45,7 +45,7 @@ namespace KubernetesWorkflow
 
         public void WaitUntilOnline(RunningContainer container)
         {
-            WaitUntilDeploymentOnline(container);
+            WaitUntilDeploymentOnline(container.Recipe.Name);
         }
 
         public PodInfo GetPodInfo(RunningDeployment deployment)
@@ -64,14 +64,14 @@ namespace KubernetesWorkflow
             if (waitTillStopped) WaitUntilPodsForDeploymentAreOffline(startResult.Deployment);
         }
 
-        public void DownloadPodLog(RunningContainer container, ILogHandler logHandler, int? tailLines, bool? previous)
+        public void DownloadPodLog(RunningContainer container, ILogHandler logHandler, int? tailLines)
         {
             log.Debug();
 
             var podName = GetPodName(container);
             var recipeName = container.Recipe.Name;
 
-            using var stream = client.Run(c => c.ReadNamespacedPodLog(podName, K8sNamespace, recipeName, tailLines: tailLines, previous: previous));
+            using var stream = client.Run(c => c.ReadNamespacedPodLog(podName, K8sNamespace, recipeName, tailLines: tailLines));
             logHandler.Log(stream);
         }
 
@@ -115,7 +115,7 @@ namespace KubernetesWorkflow
             });
         }
 
-        public void DeleteAllNamespacesStartingWith(string prefix, bool wait)
+        public void DeleteAllNamespacesStartingWith(string prefix)
         {
             log.Debug();
 
@@ -124,28 +124,25 @@ namespace KubernetesWorkflow
 
             foreach (var ns in namespaces)
             {
-                DeleteNamespace(ns, wait);
+                DeleteNamespace(ns);
             }
         }
 
-        public void DeleteNamespace(bool wait)
+        public void DeleteNamespace()
         {
             log.Debug();
             if (IsNamespaceOnline(K8sNamespace))
             {
                 client.Run(c => c.DeleteNamespace(K8sNamespace, null, null, gracePeriodSeconds: 0));
-
-                if (wait) WaitUntilNamespaceDeleted(K8sNamespace);
             }
         }
 
-        public void DeleteNamespace(string ns, bool wait)
+        public void DeleteNamespace(string ns)
         {
             log.Debug();
             if (IsNamespaceOnline(ns))
             {
                 client.Run(c => c.DeleteNamespace(ns, null, null, gracePeriodSeconds: 0));
-                if (wait) WaitUntilNamespaceDeleted(ns);
             }
         }
 
@@ -535,7 +532,7 @@ namespace KubernetesWorkflow
             }
             if (set.Memory.SizeInBytes != 0)
             {
-                result.Add("memory", new ResourceQuantity(set.Memory.SizeInBytes.ToString()));
+                result.Add("memory", new ResourceQuantity(set.Memory.ToSuffixNotation()));
             }
             return result;
         }
@@ -708,14 +705,14 @@ namespace KubernetesWorkflow
 
         private string GetPodName(RunningContainer container)
         {
-            return GetPodForDeployment(container.RunningPod.StartResult.Deployment).Metadata.Name;
+            return GetPodForDeployment(container.RunningContainers.StartResult.Deployment).Metadata.Name;
         }
 
         private V1Pod GetPodForDeployment(RunningDeployment deployment)
         {
             return Time.Retry(() => GetPodForDeplomentInternal(deployment),
                 // We will wait up to 1 minute, k8s might be moving pods around.
-                maxTimeout: TimeSpan.FromMinutes(1),
+                maxRetries: 6,
                 retryTime: TimeSpan.FromSeconds(10),
                 description: "Find pod by label for deployment.");
         }
@@ -871,45 +868,16 @@ namespace KubernetesWorkflow
 
         private void WaitUntilNamespaceCreated() 
         {
-            WaitUntil(() => IsNamespaceOnline(K8sNamespace), nameof(WaitUntilNamespaceCreated));
+            WaitUntil(() => IsNamespaceOnline(K8sNamespace));
         }
 
-        private void WaitUntilNamespaceDeleted(string @namespace)
-        {
-            WaitUntil(() => !IsNamespaceOnline(@namespace), nameof(WaitUntilNamespaceDeleted));
-        }
-
-        private void WaitUntilDeploymentOnline(RunningContainer container)
+        private void WaitUntilDeploymentOnline(string deploymentName)
         {
             WaitUntil(() =>
             {
-                CheckForCrash(container);
-
-                var deployment = client.Run(c => c.ReadNamespacedDeployment(container.Recipe.Name, K8sNamespace));
+                var deployment = client.Run(c => c.ReadNamespacedDeployment(deploymentName, K8sNamespace));
                 return deployment?.Status.AvailableReplicas != null && deployment.Status.AvailableReplicas > 0;
-            }, nameof(WaitUntilDeploymentOnline));
-        }
-
-        private void CheckForCrash(RunningContainer container)
-        {
-            var deploymentName = container.Recipe.Name;
-            var podName = GetPodName(container);
-
-            var podInfo = client.Run(c => c.ReadNamespacedPod(podName, K8sNamespace));
-            if (podInfo == null) return;
-            if (podInfo.Status == null) return;
-            if (podInfo.Status.ContainerStatuses == null) return;
-
-            var result = podInfo.Status.ContainerStatuses.Any(c => c.RestartCount > 0);
-            if (result)
-            {
-                var msg = $"Pod crash detected for deployment {deploymentName} (pod:{podName})";
-                log.Error(msg);
-
-                DownloadPodLog(container, new WriteToFileLogHandler(log, msg), tailLines: null, previous: true);
-
-                throw new Exception(msg);
-            }
+            });
         }
 
         private void WaitUntilDeploymentOffline(string deploymentName)
@@ -919,7 +887,7 @@ namespace KubernetesWorkflow
                 var deployments = client.Run(c => c.ListNamespacedDeployment(K8sNamespace));
                 var deployment = deployments.Items.SingleOrDefault(d => d.Metadata.Name == deploymentName);
                 return deployment == null || deployment.Status.AvailableReplicas == 0;
-            }, nameof(WaitUntilDeploymentOffline));
+            });
         }
 
         private void WaitUntilPodsForDeploymentAreOffline(RunningDeployment deployment)
@@ -928,19 +896,19 @@ namespace KubernetesWorkflow
             {
                 var pods = FindPodsByLabel(deployment.PodLabel);
                 return !pods.Any();
-            }, nameof(WaitUntilPodsForDeploymentAreOffline));
+            });
         }
 
-        private void WaitUntil(Func<bool> predicate, string msg)
+        private void WaitUntil(Func<bool> predicate)
         {
             var sw = Stopwatch.Begin(log, true);
             try
             {
-                Time.WaitUntil(predicate, cluster.K8sOperationTimeout(), cluster.K8sOperationRetryDelay(), msg);
+                Time.WaitUntil(predicate, cluster.K8sOperationTimeout(), cluster.K8sOperationRetryDelay());
             }
             finally
             {
-                sw.End(msg, 1);
+                sw.End("", 1);
             }
         }
 

Framework/KubernetesWorkflow/K8sHooks.cs

@@ -5,18 +5,18 @@ namespace KubernetesWorkflow
 {
     public interface IK8sHooks
     {
-        void OnContainersStarted(RunningPod runningPod);
-        void OnContainersStopped(RunningPod runningPod);
+        void OnContainersStarted(RunningContainers runningContainers);
+        void OnContainersStopped(RunningContainers runningContainers);
         void OnContainerRecipeCreated(ContainerRecipe recipe);
     }
 
     public class DoNothingK8sHooks : IK8sHooks
     {
-        public void OnContainersStarted(RunningPod runningPod)
+        public void OnContainersStarted(RunningContainers runningContainers)
         {
         }
 
-        public void OnContainersStopped(RunningPod runningPod)
+        public void OnContainersStopped(RunningContainers runningContainers)
         {
         }
 

Framework/KubernetesWorkflow/LogHandler.cs

@@ -1,6 +1,4 @@
-using Logging;
-
-namespace KubernetesWorkflow
+namespace KubernetesWorkflow
 {
     public interface ILogHandler
     {
@@ -22,25 +20,4 @@ namespace KubernetesWorkflow
 
         protected abstract void ProcessLine(string line);
     }
-
-    public class WriteToFileLogHandler : LogHandler, ILogHandler
-    {
-        public WriteToFileLogHandler(ILog sourceLog, string description)
-        {
-            LogFile = sourceLog.CreateSubfile();
-
-            var msg = $"{description} -->> {LogFile.FullFilename}";
-            sourceLog.Log(msg);
-
-            LogFile.Write(msg);
-            LogFile.WriteRaw(description);
-        }
-
-        public LogFile LogFile { get; }
-
-        protected override void ProcessLine(string line)
-        {
-            LogFile.WriteRaw(line);
-        }
-    }
 }

Framework/KubernetesWorkflow/Recipe/ContainerRecipeFactory.cs

@@ -105,7 +105,7 @@ namespace KubernetesWorkflow.Recipe
 
         protected void AddVolume(string name, string mountPath, string? subPath = null, string? secret = null, string? hostPath = null)
         {
-            var size = 10.MB().SizeInBytes.ToString();
+            var size = 10.MB().ToSuffixNotation();
             volumeMounts.Add(new VolumeMount(name, mountPath, subPath, size, secret, hostPath));
         }
 
@@ -114,7 +114,7 @@ namespace KubernetesWorkflow.Recipe
             volumeMounts.Add(new VolumeMount(
                 $"autovolume-{Guid.NewGuid().ToString().ToLowerInvariant()}",
                 mountPath,
-                resourceQuantity: volumeSize.SizeInBytes.ToString()));
+                resourceQuantity: volumeSize.ToSuffixNotation()));
         }
 
         protected void Additional(object userData)

Framework/KubernetesWorkflow/RunningPod.cs

@@ -1,5 +1,8 @@
-using KubernetesWorkflow.Recipe;
+using k8s;
+using k8s.Models;
+using KubernetesWorkflow.Recipe;
 using KubernetesWorkflow.Types;
+using Newtonsoft.Json;
 
 namespace KubernetesWorkflow
 {

Framework/KubernetesWorkflow/StartupWorkflow.cs

@@ -12,13 +12,13 @@ namespace KubernetesWorkflow
         FutureContainers Start(int numberOfContainers, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig);
         FutureContainers Start(int numberOfContainers, ILocation location, ContainerRecipeFactory recipeFactory, StartupConfig startupConfig);
         PodInfo GetPodInfo(RunningContainer container);
-        PodInfo GetPodInfo(RunningPod pod);
+        PodInfo GetPodInfo(RunningContainers containers);
         CrashWatcher CreateCrashWatcher(RunningContainer container);
-        void Stop(RunningPod pod, bool waitTillStopped);
-        void DownloadContainerLog(RunningContainer container, ILogHandler logHandler, int? tailLines = null, bool? previous = null);
+        void Stop(RunningContainers containers, bool waitTillStopped);
+        void DownloadContainerLog(RunningContainer container, ILogHandler logHandler, int? tailLines = null);
         string ExecuteCommand(RunningContainer container, string command, params string[] args);
-        void DeleteNamespace(bool wait);
-        void DeleteNamespacesStartingWith(string namespacePrefix, bool wait);
+        void DeleteNamespace();
+        void DeleteNamespacesStartingWith(string namespacePrefix);
     }
 
     public class StartupWorkflow : IStartupWorkflow
@@ -60,7 +60,7 @@ namespace KubernetesWorkflow
                 var startResult = controller.BringOnline(recipes, location);
                 var containers = CreateContainers(startResult, recipes, startupConfig);
 
-                var rc = new RunningPod(startupConfig, startResult, containers);
+                var rc = new RunningContainers(startupConfig, startResult, containers);
                 cluster.Configuration.Hooks.OnContainersStarted(rc);
 
                 if (startResult.ExternalService != null)
@@ -71,7 +71,7 @@ namespace KubernetesWorkflow
             });
         }
 
-        public void WaitUntilOnline(RunningPod rc)
+        public void WaitUntilOnline(RunningContainers rc)
         {
             K8s(controller =>
             {
@@ -84,12 +84,12 @@ namespace KubernetesWorkflow
 
         public PodInfo GetPodInfo(RunningContainer container)
         {
-            return K8s(c => c.GetPodInfo(container.RunningPod.StartResult.Deployment));
+            return K8s(c => c.GetPodInfo(container.RunningContainers.StartResult.Deployment));
         }
 
-        public PodInfo GetPodInfo(RunningPod pod)
+        public PodInfo GetPodInfo(RunningContainers containers)
         {
-            return K8s(c => c.GetPodInfo(pod.StartResult.Deployment));
+            return K8s(c => c.GetPodInfo(containers.StartResult.Deployment));
         }
 
         public CrashWatcher CreateCrashWatcher(RunningContainer container)
@@ -97,20 +97,20 @@ namespace KubernetesWorkflow
             return K8s(c => c.CreateCrashWatcher(container));
         }
 
-        public void Stop(RunningPod runningPod, bool waitTillStopped)
+        public void Stop(RunningContainers runningContainers, bool waitTillStopped)
         {
             K8s(controller =>
             {
-                controller.Stop(runningPod.StartResult, waitTillStopped);
-                cluster.Configuration.Hooks.OnContainersStopped(runningPod);
+                controller.Stop(runningContainers.StartResult, waitTillStopped);
+                cluster.Configuration.Hooks.OnContainersStopped(runningContainers);
             });
         }
 
-        public void DownloadContainerLog(RunningContainer container, ILogHandler logHandler, int? tailLines = null, bool? previous = null)
+        public void DownloadContainerLog(RunningContainer container, ILogHandler logHandler, int? tailLines = null)
         {
             K8s(controller =>
             {
-                controller.DownloadPodLog(container, logHandler, tailLines, previous);
+                controller.DownloadPodLog(container, logHandler, tailLines);
             });
         }
 
@@ -122,19 +122,19 @@ namespace KubernetesWorkflow
             });
         }
 
-        public void DeleteNamespace(bool wait)
+        public void DeleteNamespace()
         {
             K8s(controller =>
             {
-                controller.DeleteNamespace(wait);
+                controller.DeleteNamespace();
             });
         }
 
-        public void DeleteNamespacesStartingWith(string namespacePrefix, bool wait)
+        public void DeleteNamespacesStartingWith(string namespacePrefix)
         {
             K8s(controller =>
             {
-                controller.DeleteAllNamespacesStartingWith(namespacePrefix, wait);
+                controller.DeleteAllNamespacesStartingWith(namespacePrefix);
             });
         }
 

Framework/KubernetesWorkflow/Types/FutureContainers.cs

@@ -2,19 +2,19 @@
 {
     public class FutureContainers
     {
-        private readonly RunningPod runningPod;
+        private readonly RunningContainers runningContainers;
         private readonly StartupWorkflow workflow;
 
-        public FutureContainers(RunningPod runningPod, StartupWorkflow workflow)
+        public FutureContainers(RunningContainers runningContainers, StartupWorkflow workflow)
         {
-            this.runningPod = runningPod;
+            this.runningContainers = runningContainers;
             this.workflow = workflow;
         }
 
-        public RunningPod WaitForOnline()
+        public RunningContainers WaitForOnline()
         {
-            workflow.WaitUntilOnline(runningPod);
-            return runningPod;
+            workflow.WaitUntilOnline(runningContainers);
+            return runningContainers;
         }
     }
 }

Framework/KubernetesWorkflow/Types/RunningContainer.cs

@@ -19,7 +19,7 @@ namespace KubernetesWorkflow.Types
         public ContainerAddress[] Addresses { get; }
 
         [JsonIgnore]
-        public RunningPod RunningPod { get; internal set; } = null!;
+        public RunningContainers RunningContainers { get; internal set; } = null!;
 
         public Address GetAddress(ILog log, string portTag)
         {

Framework/KubernetesWorkflow/Types/RunningContainers.cs

@@ -2,15 +2,15 @@
 
 namespace KubernetesWorkflow.Types
 {
-    public class RunningPod
+    public class RunningContainers
     {
-        public RunningPod(StartupConfig startupConfig, StartResult startResult, RunningContainer[] containers)
+        public RunningContainers(StartupConfig startupConfig, StartResult startResult, RunningContainer[] containers)
         {
             StartupConfig = startupConfig;
             StartResult = startResult;
             Containers = containers;
 
-            foreach (var c in containers) c.RunningPod = this;
+            foreach (var c in containers) c.RunningContainers = this;
         }
 
         public StartupConfig StartupConfig { get; }
@@ -20,7 +20,7 @@ namespace KubernetesWorkflow.Types
         [JsonIgnore]
         public string Name
         {
-            get { return $"'{string.Join("&", Containers.Select(c => c.Name).ToArray())}'"; }
+            get { return $"{Containers.Length}x '{Containers.First().Name}'"; }
         }
 
         public string Describe()
@@ -31,7 +31,12 @@ namespace KubernetesWorkflow.Types
 
     public static class RunningContainersExtensions
     {
-        public static string Describe(this RunningPod[] runningContainers)
+        public static RunningContainer[] Containers(this RunningContainers[] runningContainers)
+        {
+            return runningContainers.SelectMany(c => c.Containers).ToArray();
+        }
+
+        public static string Describe(this RunningContainers[] runningContainers)
         {
             return string.Join(",", runningContainers.Select(c => c.Describe()));
         }

Framework/NethereumWorkflow/BlockUtils/BlockTimeFinder.cs

@@ -20,7 +20,6 @@ namespace NethereumWorkflow.BlockUtils
 
         public BlockTimeEntry Get(ulong blockNumber)
         {
-            bounds.Initialize();
             var b = cache.Get(blockNumber);
             if (b != null) return b;
             return GetBlock(blockNumber);
@@ -46,7 +45,7 @@ namespace NethereumWorkflow.BlockUtils
 
         private ulong Log(Func<ulong> operation)
         {
-            var sw = Stopwatch.Begin(log, nameof(BlockTimeFinder), true);
+            var sw = Stopwatch.Begin(log, nameof(BlockTimeFinder));
             var result = operation();
             sw.End($"(Bounds: [{bounds.Genesis.BlockNumber}-{bounds.Current.BlockNumber}] Cache: {cache.Size})");
 

Framework/Utils/Formatter.cs

@@ -1,6 +1,4 @@
-using System.Globalization;
-
-namespace Utils
+namespace Utils
 {
     public static class Formatter
     {
@@ -12,7 +10,7 @@ namespace Utils
 
             var sizeOrder = Convert.ToInt32(Math.Floor(Math.Log(bytes, 1024)));
             var digit = Math.Round(bytes / Math.Pow(1024, sizeOrder), 1);
-            return digit.ToString(CultureInfo.InvariantCulture) + sizeSuffixes[sizeOrder];
+            return digit.ToString() + sizeSuffixes[sizeOrder];
         }
     }
 }

Framework/Utils/NumberSource.cs

@@ -2,7 +2,6 @@
 {
     public class NumberSource
     {
-        private readonly object @lock = new object();
         private int number;
 
         public NumberSource(int start)
@@ -12,12 +11,8 @@
 
         public int GetNextNumber()
         {
-            var n = -1;
-            lock (@lock)
-            {
-                n = number;
-                number++;
-            }
+            var n = number;
+            number++;
             return n;
         }
     }

Framework/Utils/Retry.cs

@@ -1,131 +0,0 @@
-namespace Utils
-{
-    public class Retry
-    {
-        private readonly string description;
-        private readonly TimeSpan maxTimeout;
-        private readonly TimeSpan sleepAfterFail;
-        private readonly Action<Failure> onFail;
-
-        public Retry(string description, TimeSpan maxTimeout, TimeSpan sleepAfterFail, Action<Failure> onFail)
-        {
-            this.description = description;
-            this.maxTimeout = maxTimeout;
-            this.sleepAfterFail = sleepAfterFail;
-            this.onFail = onFail;
-        }
-
-        public void Run(Action task)
-        {
-            var run = new RetryRun(description, task, maxTimeout, sleepAfterFail, onFail);
-            run.Run();
-        }
-
-        public T Run<T>(Func<T> task)
-        {
-            T? result = default;
-
-            var run = new RetryRun(description, () =>
-            {
-                result = task();
-            }, maxTimeout, sleepAfterFail, onFail);
-            run.Run();
-
-            return result!;
-        }
-
-        private class RetryRun
-        {
-            private readonly string description;
-            private readonly Action task;
-            private readonly TimeSpan maxTimeout;
-            private readonly TimeSpan sleepAfterFail;
-            private readonly Action<Failure> onFail;
-            private readonly DateTime start = DateTime.UtcNow;
-            private readonly List<Failure> failures = new List<Failure>();
-            private int tryNumber;
-            private DateTime tryStart;
-
-            public RetryRun(string description, Action task, TimeSpan maxTimeout, TimeSpan sleepAfterFail, Action<Failure> onFail)
-            {
-                this.description = description;
-                this.task = task;
-                this.maxTimeout = maxTimeout;
-                this.sleepAfterFail = sleepAfterFail;
-                this.onFail = onFail;
-
-                tryNumber = 0;
-                tryStart = DateTime.UtcNow;
-            }
-
-            public void Run()
-            {
-                while (true)
-                {
-                    CheckMaximums();
-
-                    tryNumber++;
-                    tryStart = DateTime.UtcNow;
-                    try
-                    {
-                        task();
-                        return;
-                    }
-                    catch (Exception ex)
-                    {
-                        var failure = CaptureFailure(ex);
-                        onFail(failure);
-                        Time.Sleep(sleepAfterFail);
-                    }
-                }
-            }
-
-            private Failure CaptureFailure(Exception ex)
-            {
-                var f = new Failure(ex, DateTime.UtcNow - tryStart, tryNumber);
-                failures.Add(f);
-                return f;
-            }
-
-            private void CheckMaximums()
-            {
-                if (Duration() > maxTimeout) Fail();
-            }
-
-            private void Fail()
-            {
-                throw new TimeoutException($"Retry '{description}' timed out after {tryNumber} tries over {Time.FormatDuration(Duration())}: {GetFailureReport}",
-                        new AggregateException(failures.Select(f => f.Exception)));
-            }
-
-            private string GetFailureReport()
-            {
-                return Environment.NewLine + string.Join(Environment.NewLine, failures.Select(f => f.Describe()));
-            }
-
-            private TimeSpan Duration()
-            {
-                return DateTime.UtcNow - start;
-            }
-        }
-    }
-
-    public class Failure
-    {
-        public Failure(Exception exception, TimeSpan duration, int tryNumber)
-        {
-            Exception = exception;
-            Duration = duration;
-            TryNumber = tryNumber;
-        }
-
-        public Exception Exception { get; }
-        public TimeSpan Duration { get; }
-        public int TryNumber { get; }
-
-        public string Describe()
-        {
-            return $"Try {TryNumber} failed after {Time.FormatDuration(Duration)} with exception '{Exception}'";
-        }
-    }
-}

Framework/Utils/Time.cs

@@ -18,12 +18,6 @@
             task.Wait();
         }
 
-        public static string FormatDuration(TimeSpan? d)
-        {
-            if (d == null) return "[NULL]";
-            return FormatDuration(d.Value);
-        }
-
         public static string FormatDuration(TimeSpan d)
         {
             var result = "";
@@ -63,70 +57,100 @@
             return result;
         }
 
-        public static void WaitUntil(Func<bool> predicate, string msg)
+        public static void WaitUntil(Func<bool> predicate)
         {
-            WaitUntil(predicate, TimeSpan.FromMinutes(1), TimeSpan.FromSeconds(1), msg);
+            WaitUntil(predicate, TimeSpan.FromMinutes(1), TimeSpan.FromSeconds(1));
         }
 
-        public static void WaitUntil(Func<bool> predicate, TimeSpan timeout, TimeSpan retryDelay, string msg)
+        public static void WaitUntil(Func<bool> predicate, TimeSpan timeout, TimeSpan retryDelay)
         {
             var start = DateTime.UtcNow;
-            var tries = 1;
             var state = predicate();
             while (!state)
             {
-                var duration = DateTime.UtcNow - start;
-                if (duration > timeout)
+                if (DateTime.UtcNow - start > timeout)
                 {
-                    throw new TimeoutException($"Operation timed out after {tries} tries over (total) {FormatDuration(duration)}. '{msg}'");
+                    throw new TimeoutException("Operation timed out.");
                 }
 
                 Sleep(retryDelay);
                 state = predicate();
-                tries++;
             }
         }
 
         public static void Retry(Action action, string description)
         {
-            Retry(action, TimeSpan.FromSeconds(30), description);
+            Retry(action, 1, description);
         }
 
         public static T Retry<T>(Func<T> action, string description)
         {
-            return Retry(action, TimeSpan.FromSeconds(30), description);
+            return Retry(action, 1, description);
         }
 
-        public static void Retry(Action action, TimeSpan maxTimeout, string description)
+        public static void Retry(Action action, int maxRetries, string description)
         {
-            Retry(action, maxTimeout, TimeSpan.FromSeconds(5), description);
+            Retry(action, maxRetries, TimeSpan.FromSeconds(5), description);
         }
 
-        public static T Retry<T>(Func<T> action, TimeSpan maxTimeout, string description)
+        public static T Retry<T>(Func<T> action, int maxRetries, string description)
         {
-            return Retry(action, maxTimeout, TimeSpan.FromSeconds(5), description);
+            return Retry(action, maxRetries, TimeSpan.FromSeconds(5), description);
         }
 
-        public static void Retry(Action action, TimeSpan maxTimeout, TimeSpan retryTime, string description)
+        public static void Retry(Action action, int maxRetries, TimeSpan retryTime, string description)
         {
-            Retry(action, maxTimeout, retryTime, description, f => { });
+            var start = DateTime.UtcNow;
+            var retries = 0;
+            var exceptions = new List<Exception>();
+            while (true)
+            {
+                if (retries > maxRetries)
+                {
+                    var duration = DateTime.UtcNow - start;
+                    throw new TimeoutException($"Retry '{description}' timed out after {maxRetries} tries over {Time.FormatDuration(duration)}.", new AggregateException(exceptions));
+                }
+
+                try
+                {
+                    action();
+                    return;
+                }
+                catch (Exception ex)
+                {
+                    exceptions.Add(ex);
+                    retries++;
+                }
+
+                Sleep(retryTime);
+            }
         }
 
-        public static T Retry<T>(Func<T> action, TimeSpan maxTimeout, TimeSpan retryTime, string description)
+        public static T Retry<T>(Func<T> action, int maxRetries, TimeSpan retryTime, string description)
         {
-            return Retry(action, maxTimeout, retryTime, description, f => { });
-        }
+            var start = DateTime.UtcNow;
+            var retries = 0;
+            var exceptions = new List<Exception>();
+            while (true)
+            {
+                if (retries > maxRetries)
+                {
+                    var duration = DateTime.UtcNow - start;
+                    throw new TimeoutException($"Retry '{description}' timed out after {maxRetries} tries over {Time.FormatDuration(duration)}.", new AggregateException(exceptions));
+                }
 
-        public static void Retry(Action action, TimeSpan maxTimeout, TimeSpan retryTime, string description, Action<Failure> onFail)
-        {
-            var r = new Retry(description, maxTimeout, retryTime, onFail);
-            r.Run(action);
-        }
+                try
+                {
+                    return action();
+                }
+                catch (Exception ex)
+                {
+                    exceptions.Add(ex);
+                    retries++;
+                }
 
-        public static T Retry<T>(Func<T> action, TimeSpan maxTimeout, TimeSpan retryTime, string description, Action<Failure> onFail)
-        {
-            var r = new Retry(description, maxTimeout, retryTime, onFail);
-            return r.Run(action);
+                Sleep(retryTime);
+            }
         }
     }
 }

ProjectPlugins/CodexContractsPlugin/CodexContractsAccess.cs

@@ -67,7 +67,7 @@ namespace CodexContractsPlugin
 
         public string MintTestTokens(EthAddress ethAddress, TestToken testTokens)
         {
-            return StartInteraction().MintTestTokens(ethAddress, testTokens.TstWei, Deployment.TokenAddress);
+            return StartInteraction().MintTestTokens(ethAddress, testTokens.Amount, Deployment.TokenAddress);
         }
 
         public TestToken GetTestTokenBalance(IHasEthAddress owner)
@@ -78,7 +78,7 @@ namespace CodexContractsPlugin
         public TestToken GetTestTokenBalance(EthAddress ethAddress)
         {
             var balance = StartInteraction().GetBalance(Deployment.TokenAddress, ethAddress.Address);
-            return balance.TstWei();
+            return balance.TestTokens();
         }
 
         public Request[] GetStorageRequests(BlockInterval blockRange)

ProjectPlugins/CodexContractsPlugin/CodexContractsStarter.cs

@@ -59,7 +59,7 @@ namespace CodexContractsPlugin
                 var logHandler = new ContractsReadyLogHandler(tools.GetLog());
                 workflow.DownloadContainerLog(container, logHandler, 100);
                 return logHandler.Found;
-            }, nameof(DeployContract));
+            });
             Log("Contracts deployed. Extracting addresses...");
 
             var extractor = new ContractsContainerInfoExtractor(tools.GetLog(), workflow, container);
@@ -71,7 +71,7 @@ namespace CodexContractsPlugin
 
             Log("Extract completed. Checking sync...");
 
-            Time.WaitUntil(() => interaction.IsSynced(marketplaceAddress, abi), nameof(DeployContract));
+            Time.WaitUntil(() => interaction.IsSynced(marketplaceAddress, abi));
 
             Log("Synced. Codex SmartContracts deployed.");
 
@@ -83,9 +83,9 @@ namespace CodexContractsPlugin
             tools.GetLog().Log(msg);
         }
 
-        private void WaitUntil(Func<bool> predicate, string msg)
+        private void WaitUntil(Func<bool> predicate)
         {
-            Time.WaitUntil(predicate, TimeSpan.FromMinutes(5), TimeSpan.FromSeconds(2), msg);
+            Time.WaitUntil(predicate, TimeSpan.FromMinutes(5), TimeSpan.FromSeconds(2));
         }
 
         private StartupConfig CreateStartupConfig(IGethNode gethNode)

ProjectPlugins/CodexContractsPlugin/ContractInteractions.cs

@@ -44,7 +44,7 @@ namespace CodexContractsPlugin
             }
         }
 
-        public string MintTestTokens(EthAddress address, BigInteger amount, string tokenAddress)
+        public string MintTestTokens(EthAddress address, decimal amount, string tokenAddress)
         {
             log.Debug($"{amount} -> {address} (token: {tokenAddress})");
             return MintTokens(address.Address, amount, tokenAddress);
@@ -85,7 +85,7 @@ namespace CodexContractsPlugin
             }
         }
 
-        private string MintTokens(string account, BigInteger amount, string tokenAddress)
+        private string MintTokens(string account, decimal amount, string tokenAddress)
         {
             log.Debug($"({tokenAddress}) {amount} --> {account}");
             if (string.IsNullOrEmpty(account)) throw new ArgumentException("Invalid arguments for MintTestTokens");
@@ -93,7 +93,7 @@ namespace CodexContractsPlugin
             var function = new MintTokensFunction
             {
                 Holder = account,
-                Amount = amount
+                Amount = amount.ToBig()
             };
 
             return gethNode.SendTransaction(tokenAddress, function);

ProjectPlugins/CodexContractsPlugin/Marketplace/README.md

@@ -1,14 +1 @@
 This code was generated using the Nethereum code generator, here: http://playground.nethereum.com
-
-1. Go to site -> Abi Code Gen.
-1. Contract name = "Marketplace".
-1. In container, get "/hardhat/artifacts/contracts/Marketplace.sol/Marketplace.json".
-1. Save only ABI section as new JSON. (top-level is a json array.)
-1. From original JSON get byte code.
-1. Put ABI JSON and byte code into site.
-1. Generate.
-1. From site generated code, copy `public partial class MarketplaceDeployment` and everything after it. (be considerate of namespace brackets!)
-1. In Marketplace/Marketplace.cs, replace content of 'namespace CodexContractsPlugin.Marketplace'.
-
-
-

ProjectPlugins/CodexContractsPlugin/TestTokenExtensions.cs

@@ -1,102 +1,45 @@
-using System.Numerics;
-
-namespace CodexContractsPlugin
+namespace CodexContractsPlugin
 {
     public class TestToken : IComparable<TestToken>
     {
-        public static BigInteger WeiFactor = new BigInteger(1000000000000000000);
-
-        public TestToken(BigInteger tstWei)
+        public TestToken(decimal amount)
         {
-            TstWei = tstWei;
-            Tst = tstWei / WeiFactor;
+            Amount = amount;
         }
 
-        public BigInteger TstWei { get; }
-        public BigInteger Tst { get; }
+        public decimal Amount { get; }
 
         public int CompareTo(TestToken? other)
         {
-            return TstWei.CompareTo(other!.TstWei);
+            return Amount.CompareTo(other!.Amount);
         }
 
         public override bool Equals(object? obj)
         {
-            return obj is TestToken token && TstWei == token.TstWei;
+            return obj is TestToken token && Amount == token.Amount;
         }
 
         public override int GetHashCode()
         {
-            return HashCode.Combine(TstWei);
+            return HashCode.Combine(Amount);
         }
 
         public override string ToString()
         {
-            var weiOnly = TstWei % WeiFactor;
-
-            var tokens = new List<string>();
-            if (Tst > 0) tokens.Add($"{Tst} TST");
-            if (weiOnly > 0) tokens.Add($"{weiOnly} TSTWEI");
-
-            return string.Join(" + ", tokens);
-        }
-
-        public static TestToken operator +(TestToken a, TestToken b)
-        {
-            return new TestToken(a.TstWei + b.TstWei);
-        }
-
-        public static bool operator <(TestToken a, TestToken b)
-        {
-            return a.TstWei < b.TstWei;
-        }
-
-        public static bool operator >(TestToken a, TestToken b)
-        {
-            return a.TstWei > b.TstWei;
-        }
-
-        public static bool operator ==(TestToken a, TestToken b)
-        {
-            return a.TstWei == b.TstWei;
-        }
-
-        public static bool operator !=(TestToken a, TestToken b)
-        {
-            return a.TstWei != b.TstWei;
+            return $"{Amount} TestTokens";
         }
     }
 
-    public static class TestTokensExtensions
+    public static class TokensIntExtensions
     {
-        public static TestToken TstWei(this int i)
+        public static TestToken TestTokens(this int i)
         {
-            return TstWei(Convert.ToDecimal(i));
+            return TestTokens(Convert.ToDecimal(i));
         }
 
-        public static TestToken TstWei(this decimal i)
-        {
-            return new TestToken(new BigInteger(i));
-        }
-
-        public static TestToken TstWei(this BigInteger i)
+        public static TestToken TestTokens(this decimal i)
         {
             return new TestToken(i);
         }
-
-        public static TestToken Tst(this int i)
-        {
-            return Tst(Convert.ToDecimal(i));
-        }
-
-        public static TestToken Tst(this decimal i)
-        {
-            return new TestToken(new BigInteger(i) * TestToken.WeiFactor);
-        }
-
-        public static TestToken Tst(this BigInteger i)
-        {
-            return new TestToken(i * TestToken.WeiFactor);
-        }
     }
 }

ProjectPlugins/CodexDiscordBotPlugin/CodexDiscordBotPlugin.cs

@@ -29,19 +29,19 @@ namespace CodexDiscordBotPlugin
         {
         }
 
-        public RunningPod Deploy(DiscordBotStartupConfig config)
+        public RunningContainers Deploy(DiscordBotStartupConfig config)
         {
             var workflow = tools.CreateWorkflow();
             return StartContainer(workflow, config);
         }
 
-        public RunningPod DeployRewarder(RewarderBotStartupConfig config)
+        public RunningContainers DeployRewarder(RewarderBotStartupConfig config)
         {
             var workflow = tools.CreateWorkflow();
             return StartRewarderContainer(workflow, config);
         }
 
-        private RunningPod StartContainer(IStartupWorkflow workflow, DiscordBotStartupConfig config)
+        private RunningContainers StartContainer(IStartupWorkflow workflow, DiscordBotStartupConfig config)
         {
             var startupConfig = new StartupConfig();
             startupConfig.NameOverride = config.Name;
@@ -49,7 +49,7 @@ namespace CodexDiscordBotPlugin
             return workflow.Start(1, new DiscordBotContainerRecipe(), startupConfig).WaitForOnline();
         }
 
-        private RunningPod StartRewarderContainer(IStartupWorkflow workflow, RewarderBotStartupConfig config)
+        private RunningContainers StartRewarderContainer(IStartupWorkflow workflow, RewarderBotStartupConfig config)
         {
             var startupConfig = new StartupConfig();
             startupConfig.Add(config);

ProjectPlugins/CodexDiscordBotPlugin/CoreInterfaceExtensions.cs

@@ -5,12 +5,12 @@ namespace CodexDiscordBotPlugin
 {
     public static class CoreInterfaceExtensions
     {
-        public static RunningPod DeployCodexDiscordBot(this CoreInterface ci, DiscordBotStartupConfig config)
+        public static RunningContainers DeployCodexDiscordBot(this CoreInterface ci, DiscordBotStartupConfig config)
         {
             return Plugin(ci).Deploy(config);
         }
 
-        public static RunningPod DeployRewarderBot(this CoreInterface ci, RewarderBotStartupConfig config)
+        public static RunningContainers DeployRewarderBot(this CoreInterface ci, RewarderBotStartupConfig config)
         {
             return Plugin(ci).DeployRewarder(config);
         }

ProjectPlugins/CodexPlugin/ApiChecker.cs

@@ -9,7 +9,7 @@ namespace CodexPlugin
     public class ApiChecker
     {
         // <INSERT-OPENAPI-YAML-HASH>
-        private const string OpenApiYamlHash = "67-76-AB-FC-54-4F-EB-81-F5-E4-F8-27-DF-82-92-41-63-A5-EA-1B-17-14-0C-BE-20-9C-B3-DF-CE-E4-AA-38";
+        private const string OpenApiYamlHash = "5A-B0-2A-AC-42-B1-A2-49-6F-9D-4E-D8-56-40-10-A6-67-F4-0D-2A-9F-E0-84-5C-EB-B8-2D-4F-D8-56-79-6C";
         private const string OpenApiFilePath = "/codex/openapi.yaml";
         private const string DisableEnvironmentVariable = "CODEXPLUGIN_DISABLE_APICHECK";
 
@@ -38,7 +38,7 @@ namespace CodexPlugin
             if (string.IsNullOrEmpty(OpenApiYamlHash)) throw new Exception("OpenAPI yaml hash was not inserted by pre-build trigger.");
         }
 
-        public void CheckCompatibility(RunningPod[] containers)
+        public void CheckCompatibility(RunningContainers[] containers)
         {
             if (checkPassed) return;
 

ProjectPlugins/CodexPlugin/CodexAccess.cs

@@ -2,29 +2,28 @@
 using Core;
 using KubernetesWorkflow;
 using KubernetesWorkflow.Types;
-using Logging;
 using Newtonsoft.Json;
 using Utils;
 
 namespace CodexPlugin
 {
-    public class CodexAccess
+    public class CodexAccess : ILogHandler
     {
-        private readonly ILog log;
         private readonly IPluginTools tools;
         private readonly Mapper mapper = new Mapper();
+        private bool hasContainerCrashed;
 
-        public CodexAccess(IPluginTools tools, RunningPod container, CrashWatcher crashWatcher)
+        public CodexAccess(IPluginTools tools, RunningContainer container, CrashWatcher crashWatcher)
         {
             this.tools = tools;
-            log = tools.GetLog();
             Container = container;
             CrashWatcher = crashWatcher;
+            hasContainerCrashed = false;
 
-            CrashWatcher.Start();
+            CrashWatcher.Start(this);
         }
 
-        public RunningPod Container { get; }
+        public RunningContainer Container { get; }
         public CrashWatcher CrashWatcher { get; }
 
         public DebugInfo GetDebugInfo()
@@ -35,23 +34,20 @@ namespace CodexPlugin
         public DebugPeer GetDebugPeer(string peerId)
         {
             // Cannot use openAPI: debug/peer endpoint is not specified there.
-            return CrashCheck(() =>
+            var endpoint = GetEndpoint();
+            var str = endpoint.HttpGetString($"debug/peer/{peerId}");
+
+            if (str.ToLowerInvariant() == "unable to find peer!")
             {
-                var endpoint = GetEndpoint();
-                var str = endpoint.HttpGetString($"debug/peer/{peerId}");
-
-                if (str.ToLowerInvariant() == "unable to find peer!")
+                return new DebugPeer
                 {
-                    return new DebugPeer
-                    {
-                        IsPeerFound = false
-                    };
-                }
+                    IsPeerFound = false
+                };
+            }
 
-                var result = endpoint.Deserialize<DebugPeer>(str);
-                result.IsPeerFound = true;
-                return result;
-            });
+            var result = endpoint.Deserialize<DebugPeer>(str);
+            result.IsPeerFound = true;
+            return result;
         }
 
         public void ConnectToPeer(string peerId, string[] peerMultiAddresses)
@@ -63,19 +59,14 @@ namespace CodexPlugin
             });
         }
 
-        public string UploadFile(FileStream fileStream, Action<Failure> onFailure)
+        public string UploadFile(FileStream fileStream)
         {
-            return OnCodex(
-                api => api.UploadAsync(fileStream),
-                CreateRetryConfig(nameof(UploadFile), onFailure));
+            return OnCodex(api => api.UploadAsync(fileStream));
         }
 
-        public Stream DownloadFile(string contentId, Action<Failure> onFailure)
+        public Stream DownloadFile(string contentId)
         {
-            var fileResponse = OnCodex(
-                api => api.DownloadNetworkAsync(contentId),
-                CreateRetryConfig(nameof(DownloadFile), onFailure));
-
+            var fileResponse = OnCodex(api => api.DownloadNetworkAsync(contentId));
             if (fileResponse.StatusCode != 200) throw new Exception("Download failed with StatusCode: " + fileResponse.StatusCode);
             return fileResponse.Stream;
         }
@@ -98,24 +89,15 @@ namespace CodexPlugin
             return OnCodex<string>(api => api.CreateStorageRequestAsync(request.ContentId.Id, body));
         }
 
-        public CodexSpace Space()
-        {
-            var space = OnCodex<Space>(api => api.SpaceAsync());
-            return mapper.Map(space);
-        }
-
         public StoragePurchase GetPurchaseStatus(string purchaseId)
         {
-            return CrashCheck(() =>
+            var endpoint = GetEndpoint();
+            return Time.Retry(() =>
             {
-                var endpoint = GetEndpoint();
-                return Time.Retry(() =>
-                {
-                    var str = endpoint.HttpGetString($"storage/purchases/{purchaseId}");
-                    if (string.IsNullOrEmpty(str)) throw new Exception("Empty response.");
-                    return JsonConvert.DeserializeObject<StoragePurchase>(str)!;
-                }, nameof(GetPurchaseStatus));
-            });
+                var str = endpoint.HttpGetString($"storage/purchases/{purchaseId}");
+                if (string.IsNullOrEmpty(str)) throw new Exception("Empty response.");
+                return JsonConvert.DeserializeObject<StoragePurchase>(str)!;
+            }, nameof(GetPurchaseStatus));
 
             // TODO: current getpurchase api does not line up with its openapi spec.
             // return mapper.Map(OnCodex(api => api.GetPurchaseAsync(purchaseId)));
@@ -132,65 +114,17 @@ namespace CodexPlugin
             return workflow.GetPodInfo(Container);
         }
 
-        public void LogDiskSpace(string msg)
-        {
-            try
-            {
-                var diskInfo = tools.CreateWorkflow().ExecuteCommand(Container.Containers.Single(), "df", "--sync");
-                Log($"{msg} - Disk info: {diskInfo}");
-            }
-            catch (Exception e)
-            {
-                Log("Failed to get disk info: " + e);
-            }
-        }
-
-        public void DeleteRepoFolder()
-        {
-            try
-            {
-                var containerNumber = Container.Containers.First().Recipe.Number;
-                var dataDir = $"datadir{containerNumber}";
-                var workflow = tools.CreateWorkflow();
-                workflow.ExecuteCommand(Container.Containers.First(), "rm", "-Rfv", $"/codex/{dataDir}/repo");
-                Log("Deleted repo folder.");
-            }
-            catch (Exception e)
-            {
-                Log("Unable to delete repo folder: " + e);
-            }
-        }
-
         private T OnCodex<T>(Func<CodexApi, Task<T>> action)
-        {
-            var result = tools.CreateHttp(CheckContainerCrashed).OnClient(client => CallCodex(client, action));
-            return result;
-        }
-
-        private T OnCodex<T>(Func<CodexApi, Task<T>> action, Retry retry)
-        {
-            var result = tools.CreateHttp(CheckContainerCrashed).OnClient(client => CallCodex(client, action), retry);
-            return result;
-        }
-
-        private T CallCodex<T>(HttpClient client, Func<CodexApi, Task<T>> action)
         {
             var address = GetAddress();
-            var api = new CodexApi(client);
-            api.BaseUrl = $"{address.Host}:{address.Port}/api/codex/v1";
-            return CrashCheck(() => Time.Wait(action(api)));
-        }
-
-        private T CrashCheck<T>(Func<T> action)
-        {
-            try
+            var result = tools.CreateHttp(CheckContainerCrashed)
+                .OnClient(client =>
             {
-                return action();
-            }
-            finally
-            {
-                CrashWatcher.HasContainerCrashed();
-            }
+                var api = new CodexApi(client);
+                api.BaseUrl = $"{address.Host}:{address.Port}/api/codex/v1";
+                return Time.Wait(action(api));
+            });
+            return result;
         }
 
         private IEndpoint GetEndpoint()
@@ -202,67 +136,31 @@ namespace CodexPlugin
 
         private Address GetAddress()
         {
-            return Container.Containers.Single().GetAddress(log, CodexContainerRecipe.ApiPortTag);
+            return Container.GetAddress(tools.GetLog(), CodexContainerRecipe.ApiPortTag);
         }
 
         private void CheckContainerCrashed(HttpClient client)
         {
-            if (CrashWatcher.HasContainerCrashed()) throw new Exception($"Container {GetName()} has crashed.");
+            if (hasContainerCrashed) throw new Exception("Container has crashed.");
         }
 
-        private Retry CreateRetryConfig(string description, Action<Failure> onFailure)
+        public void Log(Stream crashLog)
         {
-            var timeSet = tools.TimeSet;
+            var log = tools.GetLog();
+            var file = log.CreateSubfile();
+            log.Log($"Container {Container.Name} has crashed. Downloading crash log to '{file.FullFilename}'...");
+            file.Write($"Container Crash Log for {Container.Name}.");
 
-            return new Retry(description, timeSet.HttpRetryTimeout(), timeSet.HttpCallRetryDelay(), failure =>
+            using var reader = new StreamReader(crashLog);
+            var line = reader.ReadLine();
+            while (line != null)
             {
-                onFailure(failure);
-                Investigate(failure, timeSet);
-            });
-        }
-
-        private void Investigate(Failure failure, ITimeSet timeSet)
-        {
-            Log($"Retry {failure.TryNumber} took {Time.FormatDuration(failure.Duration)} and failed with '{failure.Exception}'. " +
-                $"(HTTP timeout = {Time.FormatDuration(timeSet.HttpCallTimeout())}) " +
-                $"Checking if node responds to debug/info...");
-
-            LogDiskSpace("After retry failure");
-
-            try
-            {
-                var debugInfo = GetDebugInfo();
-                if (string.IsNullOrEmpty(debugInfo.Spr))
-                {
-                    Log("Did not get value debug/info response.");
-                    Throw(failure);
-                }
-                else
-                {
-                    Log("Got valid response from debug/info.");
-                }
-            }
-            catch (Exception ex)
-            {
-                Log("Got exception from debug/info call: " + ex);
-                Throw(failure);
+                file.Write(line);
+                line = reader.ReadLine();
             }
 
-            if (failure.Duration < timeSet.HttpCallTimeout())
-            {
-                Log("Retry failed within HTTP timeout duration.");
-                Throw(failure);
-            }
-        }
-
-        private void Throw(Failure failure)
-        {
-            throw failure.Exception;
-        }
-
-        private void Log(string msg)
-        {
-            log.Log($"{GetName()} {msg}");
+            log.Log("Crash log successfully downloaded.");
+            hasContainerCrashed = true;
         }
     }
 }

ProjectPlugins/CodexPlugin/CodexContainerRecipe.cs

@@ -7,8 +7,7 @@ namespace CodexPlugin
 {
     public class CodexContainerRecipe : ContainerRecipeFactory
     {
-        private const string DefaultDockerImage = "codexstorage/nim-codex:sha-b89493e-dist-tests";
-
+        private const string DefaultDockerImage = "codexstorage/nim-codex:sha-1524803-dist-tests";
         public const string ApiPortTag = "codex_api_port";
         public const string ListenPortTag = "codex_listen_port";
         public const string MetricsPortTag = "codex_metrics_port";
@@ -119,7 +118,7 @@ namespace CodexPlugin
                 }
             }
 
-            if (!string.IsNullOrEmpty(config.NameOverride))
+            if(!string.IsNullOrEmpty(config.NameOverride))
             {
                 AddEnvVar("CODEX_NODENAME", config.NameOverride);
             }
@@ -159,7 +158,7 @@ namespace CodexPlugin
 
         private ByteSize GetVolumeCapacity(CodexStartupConfig config)
         {
-            if (config.StorageQuota != null) return config.StorageQuota.Multiply(1.2);
+            if (config.StorageQuota != null) return config.StorageQuota;
             // Default Codex quota: 8 Gb, using +20% to be safe.
             return 8.GB().Multiply(1.2);
         }

ProjectPlugins/CodexPlugin/CodexDeployment.cs

@@ -7,8 +7,8 @@ namespace CodexPlugin
     public class CodexDeployment
     {
         public CodexDeployment(CodexInstance[] codexInstances, GethDeployment gethDeployment,
-            CodexContractsDeployment codexContractsDeployment, RunningPod? prometheusContainer,
-            RunningPod? discordBotContainer, DeploymentMetadata metadata,
+            CodexContractsDeployment codexContractsDeployment, RunningContainers? prometheusContainer,
+            RunningContainers? discordBotContainer, DeploymentMetadata metadata,
             String id)
         {
             Id = id;
@@ -24,20 +24,20 @@ namespace CodexPlugin
         public CodexInstance[] CodexInstances { get; }
         public GethDeployment GethDeployment { get; }
         public CodexContractsDeployment CodexContractsDeployment { get; }
-        public RunningPod? PrometheusContainer { get; }
-        public RunningPod? DiscordBotContainer { get; }
+        public RunningContainers? PrometheusContainer { get; }
+        public RunningContainers? DiscordBotContainer { get; }
         public DeploymentMetadata Metadata { get; }
     }
 
     public class CodexInstance
     {
-        public CodexInstance(RunningPod pod, DebugInfo info)
+        public CodexInstance(RunningContainers containers, DebugInfo info)
         {
-            Pod = pod;
+            Containers = containers;
             Info = info;
         }
 
-        public RunningPod Pod { get; }
+        public RunningContainers Containers { get; }
         public DebugInfo Info { get; }
     }
 

ProjectPlugins/CodexPlugin/CodexLogLine.cs

@@ -1,105 +0,0 @@
-using System.Globalization;
-
-namespace CodexPlugin
-{
-    public class CodexLogLine
-    {
-        public static CodexLogLine? Parse(string line)
-        {
-            try
-            {
-                if (string.IsNullOrEmpty(line) ||
-                    line.Length < 34 ||
-                    line[3] != ' ' ||
-                    line[33] != ' ') return null;
-
-                line = line.Replace(Environment.NewLine, string.Empty);
-
-                var level = line.Substring(0, 3);
-                var dtLine = line.Substring(4, 23);
-
-                var firstEqualSign = line.IndexOf('=');
-                var msgStart = 34;
-                var msgEnd = line.Substring(0, firstEqualSign).LastIndexOf(' ');
-                var msg = line.Substring(msgStart, msgEnd - msgStart).Trim();
-                var attrsLine = line.Substring(msgEnd);
-
-                var attrs = SplitAttrs(attrsLine);
-
-                var format = "yyyy-MM-dd HH:mm:ss.fff";
-                var dt = DateTime.ParseExact(dtLine, format, CultureInfo.InvariantCulture, DateTimeStyles.AssumeUniversal).ToUniversalTime();
-
-                return new CodexLogLine()
-                {
-                    LogLevel = level,
-                    TimestampUtc = dt,
-                    Message = msg,
-                    Attributes = attrs
-                };
-            }
-            catch
-            {
-                return null;
-            }
-        }
-
-        public string LogLevel { get; set; } = string.Empty;
-        public DateTime TimestampUtc { get; set; }
-        public string Message { get; set; } = string.Empty;
-        public Dictionary<string, string> Attributes { get; private set; } = new Dictionary<string, string>();
-
-        /// <summary>
-        /// After too much time spent cursing at regexes, here's what I got:
-        /// Parses input string into 'key=value' pair, considerate of quoted (") values.
-        /// </summary>
-        private static Dictionary<string, string> SplitAttrs(string input)
-        {
-            input += " ";
-            var result = new Dictionary<string, string>();
-
-            var key = string.Empty;
-            var value = string.Empty;
-            var mode = 1;
-            var inQuote = false;
-
-            foreach (var c in input)
-            {
-                if (mode == 1)
-                {
-                    if (c == '=') mode = 2;
-                    else if (c == ' ')
-                    {
-                        if (string.IsNullOrEmpty(key)) continue;
-                        else
-                        {
-                            result.Add(key, string.Empty);
-                            key = string.Empty;
-                            value = string.Empty;
-                        }
-                    }
-                    else key += c;
-                }
-                else if (mode == 2)
-                {
-                    if (c == ' ' && !inQuote)
-                    {
-                        result.Add(key, value);
-                        key = string.Empty;
-                        value = string.Empty;
-                        mode = 1;
-                    }
-                    else if (c == '\"')
-                    {
-                        inQuote = !inQuote;
-                    }
-                    else
-                    {
-                        value += c;
-                    }
-                }
-            }
-
-            return result;
-        }
-    }
-}

ProjectPlugins/CodexPlugin/CodexNode.cs

@@ -15,24 +15,14 @@ namespace CodexPlugin
         DebugInfo GetDebugInfo();
         DebugPeer GetDebugPeer(string peerId);
         ContentId UploadFile(TrackedFile file);
-        ContentId UploadFile(TrackedFile file, Action<Failure> onFailure);
         TrackedFile? DownloadContent(ContentId contentId, string fileLabel = "");
-        TrackedFile? DownloadContent(ContentId contentId, Action<Failure> onFailure, string fileLabel = "");
         LocalDatasetList LocalFiles();
-        CodexSpace Space();
         void ConnectToPeer(ICodexNode node);
         DebugInfoVersion Version { get; }
         IMarketplaceAccess Marketplace { get; }
         CrashWatcher CrashWatcher { get; }
         PodInfo GetPodInfo();
         ITransferSpeeds TransferSpeeds { get; }
-
-        /// <summary>
-        /// Warning! The node is not usable after this.
-        /// TODO: Replace with delete-blocks debug call once available in Codex.
-        /// </summary>
-        void DeleteRepoFolder();
-
         void Stop(bool waitTillStopped);
     }
 
@@ -54,9 +44,7 @@ namespace CodexPlugin
             transferSpeeds = new TransferSpeeds();
         }
 
-        public RunningPod Pod { get { return CodexAccess.Container; } }
-        
-        public RunningContainer Container { get { return Pod.Containers.Single(); } }
+        public RunningContainer Container { get { return CodexAccess.Container; } }
         public CodexAccess CodexAccess { get; }
         public CrashWatcher CrashWatcher { get => CodexAccess.CrashWatcher; }
         public CodexNodeGroup Group { get; }
@@ -68,7 +56,7 @@ namespace CodexPlugin
         {
             get
             {
-                return new MetricsScrapeTarget(CodexAccess.Container.Containers.First(), CodexContainerRecipe.MetricsPortTag);
+                return new MetricsScrapeTarget(CodexAccess.Container, CodexContainerRecipe.MetricsPortTag);
             }
         }
 
@@ -83,14 +71,14 @@ namespace CodexPlugin
 
         public string GetName()
         {
-            return Container.Name;
+            return CodexAccess.Container.Name;
         }
 
         public DebugInfo GetDebugInfo()
         {
             var debugInfo = CodexAccess.GetDebugInfo();
             var known = string.Join(",", debugInfo.Table.Nodes.Select(n => n.PeerId));
-            Log($"Got DebugInfo with id: {debugInfo.Id}. This node knows: [{known}]");
+            Log($"Got DebugInfo with id: '{debugInfo.Id}'. This node knows: {known}");
             return debugInfo;
         }
 
@@ -101,20 +89,13 @@ namespace CodexPlugin
 
         public ContentId UploadFile(TrackedFile file)
         {
-            return UploadFile(file, DoNothing);
-        }
-
-        public ContentId UploadFile(TrackedFile file, Action<Failure> onFailure)
-        {
-            CodexAccess.LogDiskSpace("Before upload");
-
             using var fileStream = File.OpenRead(file.Filename);
 
             var logMessage = $"Uploading file {file.Describe()}...";
             Log(logMessage);
             var measurement = Stopwatch.Measure(tools.GetLog(), logMessage, () =>
             {
-                return CodexAccess.UploadFile(fileStream, onFailure);
+                return CodexAccess.UploadFile(fileStream);
             });
 
             var response = measurement.Value;
@@ -124,22 +105,15 @@ namespace CodexPlugin
             if (response.StartsWith(UploadFailedMessage)) FrameworkAssert.Fail("Node failed to store block.");
 
             Log($"Uploaded file. Received contentId: '{response}'.");
-            CodexAccess.LogDiskSpace("After upload");
-
             return new ContentId(response);
         }
 
         public TrackedFile? DownloadContent(ContentId contentId, string fileLabel = "")
-        {
-            return DownloadContent(contentId, DoNothing, fileLabel);
-        }
-
-        public TrackedFile? DownloadContent(ContentId contentId, Action<Failure> onFailure, string fileLabel = "")
         {
             var logMessage = $"Downloading for contentId: '{contentId.Id}'...";
             Log(logMessage);
             var file = tools.GetFileManager().CreateEmptyFile(fileLabel);
-            var measurement = Stopwatch.Measure(tools.GetLog(), logMessage, () => DownloadToFile(contentId.Id, file, onFailure));
+            var measurement = Stopwatch.Measure(tools.GetLog(), logMessage, () => DownloadToFile(contentId.Id, file));
             transferSpeeds.AddDownloadSample(file.GetFilesize(), measurement);
             Log($"Downloaded file {file.Describe()} to '{file.Filename}'.");
             return file;
@@ -150,11 +124,6 @@ namespace CodexPlugin
             return CodexAccess.LocalFiles();
         }
 
-        public CodexSpace Space()
-        {
-            return CodexAccess.Space();
-        }
-
         public void ConnectToPeer(ICodexNode node)
         {
             var peer = (CodexNode)node;
@@ -171,16 +140,13 @@ namespace CodexPlugin
             return CodexAccess.GetPodInfo();
         }
 
-        public void DeleteRepoFolder()
-        {
-            CodexAccess.DeleteRepoFolder();
-        }
-
         public void Stop(bool waitTillStopped)
         {
-            Log("Stopping...");
-            CrashWatcher.Stop();
-            Group.Stop(this, waitTillStopped);
+            if (Group.Count() > 1) throw new InvalidOperationException("Codex-nodes that are part of a group cannot be " +
+                "individually shut down. Use 'BringOffline()' on the group object to stop the group. This method is only " +
+                "available for codex-nodes in groups of 1.");
+
+            Group.BringOffline(waitTillStopped);
         }
 
         public void EnsureOnlineGetVersionResponse()
@@ -205,21 +171,19 @@ namespace CodexPlugin
             // The peer we want to connect is in a different pod.
             // We must replace the default IP with the pod IP in the multiAddress.
             var workflow = tools.CreateWorkflow();
-            var podInfo = workflow.GetPodInfo(peer.Pod);
+            var podInfo = workflow.GetPodInfo(peer.Container);
 
             return peerInfo.Addrs.Select(a => a
                 .Replace("0.0.0.0", podInfo.Ip))
                 .ToArray();
         }
 
-        private void DownloadToFile(string contentId, TrackedFile file, Action<Failure> onFailure)
+        private void DownloadToFile(string contentId, TrackedFile file)
         {
-            CodexAccess.LogDiskSpace("Before download");
-
             using var fileStream = File.OpenWrite(file.Filename);
             try
             {
-                using var downloadStream = CodexAccess.DownloadFile(contentId, onFailure);
+                using var downloadStream = CodexAccess.DownloadFile(contentId);
                 downloadStream.CopyTo(fileStream);
             }
             catch
@@ -227,17 +191,11 @@ namespace CodexPlugin
                 Log($"Failed to download file '{contentId}'.");
                 throw;
             }
-
-            CodexAccess.LogDiskSpace("After download");
         }
 
         private void Log(string msg)
         {
             tools.GetLog().Log($"{GetName()}: {msg}");
         }
-
-        private void DoNothing(Failure failure)
-        {
-        }
     }
 }

ProjectPlugins/CodexPlugin/CodexNodeFactory.cs

@@ -35,7 +35,7 @@ namespace CodexPlugin
 
         private EthAddress? GetEthAddress(CodexAccess access)
         {
-            var ethAccount = access.Container.Containers.Single().Recipe.Additionals.Get<EthAccount>();
+            var ethAccount = access.Container.Recipe.Additionals.Get<EthAccount>();
             if (ethAccount == null) return null;
             return ethAccount.EthAddress;
         }

ProjectPlugins/CodexPlugin/CodexNodeGroup.cs

@@ -15,11 +15,11 @@ namespace CodexPlugin
     {
         private readonly CodexStarter starter;
 
-        public CodexNodeGroup(CodexStarter starter, IPluginTools tools, RunningPod[] containers, ICodexNodeFactory codexNodeFactory)
+        public CodexNodeGroup(CodexStarter starter, IPluginTools tools, RunningContainers[] containers, ICodexNodeFactory codexNodeFactory)
         {
             this.starter = starter;
             Containers = containers;
-            Nodes = containers.Select(c => CreateOnlineCodexNode(c, tools, codexNodeFactory)).ToArray();
+            Nodes = containers.Containers().Select(c => CreateOnlineCodexNode(c, tools, codexNodeFactory)).ToArray();
             Version = new DebugInfoVersion();
         }
 
@@ -39,14 +39,7 @@ namespace CodexPlugin
             Containers = null!;
         }
 
-        public void Stop(CodexNode node, bool waitTillStopped)
-        {
-            starter.Stop(node.Pod, waitTillStopped);
-            Nodes = Nodes.Where(n => n != node).ToArray();
-            Containers = Containers.Where(c => c != node.Pod).ToArray();
-        }
-
-        public RunningPod[] Containers { get; private set; }
+        public RunningContainers[] Containers { get; private set; }
         public CodexNode[] Nodes { get; private set; }
         public DebugInfoVersion Version { get; private set; }
         public IMetricsScrapeTarget[] ScrapeTargets => Nodes.Select(n => n.MetricsScrapeTarget).ToArray();
@@ -81,9 +74,9 @@ namespace CodexPlugin
             Version = first;
         }
 
-        private CodexNode CreateOnlineCodexNode(RunningPod c, IPluginTools tools, ICodexNodeFactory factory)
+        private CodexNode CreateOnlineCodexNode(RunningContainer c, IPluginTools tools, ICodexNodeFactory factory)
         {
-            var watcher = factory.CreateCrashWatcher(c.Containers.Single());
+            var watcher = factory.CreateCrashWatcher(c);
             var access = new CodexAccess(tools, c, watcher);
             return factory.CreateOnlineCodexNode(access, this);
         }

ProjectPlugins/CodexPlugin/CodexPlugin.cs

@@ -32,13 +32,13 @@ namespace CodexPlugin
         {
         }
 
-        public RunningPod[] DeployCodexNodes(int numberOfNodes, Action<ICodexSetup> setup)
+        public RunningContainers[] DeployCodexNodes(int numberOfNodes, Action<ICodexSetup> setup)
         {
             var codexSetup = GetSetup(numberOfNodes, setup);
             return codexStarter.BringOnline(codexSetup);
         }
 
-        public ICodexNodeGroup WrapCodexContainers(CoreInterface coreInterface, RunningPod[] containers)
+        public ICodexNodeGroup WrapCodexContainers(CoreInterface coreInterface, RunningContainers[] containers)
         {
             containers = containers.Select(c => SerializeGate.Gate(c)).ToArray();
             return codexStarter.WrapCodexContainers(coreInterface, containers);

ProjectPlugins/CodexPlugin/CodexSetup.cs

@@ -52,7 +52,6 @@ namespace CodexPlugin
         public CodexLogLevel Libp2p { get; set; }
         public CodexLogLevel ContractClock { get; set; } = CodexLogLevel.Warn;
         public CodexLogLevel? BlockExchange { get; }
-        public CodexLogLevel JsonSerialize { get; set; } = CodexLogLevel.Warn;
     }
 
     public class CodexSetup : CodexStartupConfig, ICodexSetup
@@ -168,7 +167,7 @@ namespace CodexPlugin
         public bool IsStorageNode { get; private set; }
         public bool IsValidator { get; private set; }
         public Ether InitialEth { get; private set; } = 0.Eth();
-        public TestToken InitialTestTokens { get; private set; } = 0.Tst();
+        public TestToken InitialTestTokens { get; private set; } = 0.TestTokens();
         public EthAccount EthAccount { get; private set; } = EthAccount.GenerateNew();
 
         public IMarketplaceSetup AsStorageNode()
@@ -202,7 +201,7 @@ namespace CodexPlugin
             result += IsStorageNode ? "(storageNode)" : "()";
             result += IsValidator ? "(validator)" : "() ";
             result += $"Address: '{EthAccount.EthAddress}' ";
-            result += $"{InitialEth.Eth} / {InitialTestTokens}";
+            result += $"InitialEth/TT({InitialEth.Eth}/{InitialTestTokens.Amount})";
             result += "] ";
             return result;
         }

ProjectPlugins/CodexPlugin/CodexStarter.cs

@@ -19,7 +19,7 @@ namespace CodexPlugin
             apiChecker = new ApiChecker(pluginTools);
         }
 
-        public RunningPod[] BringOnline(CodexSetup codexSetup)
+        public RunningContainers[] BringOnline(CodexSetup codexSetup)
         {
             LogSeparator();
             Log($"Starting {codexSetup.Describe()}...");
@@ -33,15 +33,15 @@ namespace CodexPlugin
             foreach (var rc in containers)
             {
                 var podInfo = GetPodInfo(rc);
-                var podInfos = string.Join(", ", rc.Containers.Select(c => $"Container: '{c.Name}' PodLabel: '{c.RunningPod.StartResult.Deployment.PodLabel}' runs at '{podInfo.K8SNodeName}'={podInfo.Ip}"));
-                Log($"Started {codexSetup.NumberOfNodes} nodes of image '{containers.First().Containers.First().Recipe.Image}'. ({podInfos})");
+                var podInfos = string.Join(", ", rc.Containers.Select(c => $"Container: '{c.Name}' runs at '{podInfo.K8SNodeName}'={podInfo.Ip}"));
+                Log($"Started {codexSetup.NumberOfNodes} nodes of image '{containers.Containers().First().Recipe.Image}'. ({podInfos})");
             }
             LogSeparator();
 
             return containers;
         }
 
-        public ICodexNodeGroup WrapCodexContainers(CoreInterface coreInterface, RunningPod[] containers)
+        public ICodexNodeGroup WrapCodexContainers(CoreInterface coreInterface, RunningContainers[] containers)
         {
             var codexNodeFactory = new CodexNodeFactory(pluginTools);
 
@@ -65,14 +65,6 @@ namespace CodexPlugin
             Log("Stopped.");
         }
 
-        public void Stop(RunningPod pod, bool waitTillStopped)
-        {
-            Log($"Stopping node...");
-            var workflow = pluginTools.CreateWorkflow();
-            workflow.Stop(pod, waitTillStopped);
-            Log("Stopped.");
-        }
-
         public string GetCodexId()
         {
             if (versionResponse != null) return versionResponse.Version;
@@ -93,7 +85,7 @@ namespace CodexPlugin
             return startupConfig;
         }
 
-        private RunningPod[] StartCodexContainers(StartupConfig startupConfig, int numberOfNodes, ILocation location)
+        private RunningContainers[] StartCodexContainers(StartupConfig startupConfig, int numberOfNodes, ILocation location)
         {
             var futureContainers = new List<FutureContainers>();
             for (var i = 0; i < numberOfNodes; i++)
@@ -107,13 +99,13 @@ namespace CodexPlugin
                 .ToArray();
         }
 
-        private PodInfo GetPodInfo(RunningPod rc)
+        private PodInfo GetPodInfo(RunningContainers rc)
         {
             var workflow = pluginTools.CreateWorkflow();
             return workflow.GetPodInfo(rc);
         }
 
-        private CodexNodeGroup CreateCodexGroup(CoreInterface coreInterface, RunningPod[] runningContainers, CodexNodeFactory codexNodeFactory)
+        private CodexNodeGroup CreateCodexGroup(CoreInterface coreInterface, RunningContainers[] runningContainers, CodexNodeFactory codexNodeFactory)
         {
             var group = new CodexNodeGroup(this, pluginTools, runningContainers, codexNodeFactory);
 
@@ -130,10 +122,10 @@ namespace CodexPlugin
             return group;
         }
 
-        private void CodexNodesNotOnline(CoreInterface coreInterface, RunningPod[] runningContainers)
+        private void CodexNodesNotOnline(CoreInterface coreInterface, RunningContainers[] runningContainers)
         {
             Log("Codex nodes failed to start");
-            foreach (var container in runningContainers.First().Containers) coreInterface.DownloadLog(container);
+            foreach (var container in runningContainers.Containers()) coreInterface.DownloadLog(container);
         }
 
         private void LogSeparator()

ProjectPlugins/CodexPlugin/CodexStartupConfig.cs

@@ -73,18 +73,11 @@ namespace CodexPlugin
                     "contracts",
                     "clock"
                 };
-                var jsonSerializeTopics = new[]
-                {
-                    "serde",
-                    "json",
-                    "serialization"
-                };
 
                 level = $"{level};" +
                     $"{CustomTopics.DiscV5.ToString()!.ToLowerInvariant()}:{string.Join(",", discV5Topics)};" +
                     $"{CustomTopics.Libp2p.ToString()!.ToLowerInvariant()}:{string.Join(",", libp2pTopics)};" +
-                    $"{CustomTopics.ContractClock.ToString().ToLowerInvariant()}:{string.Join(",", contractClockTopics)};" +
-                    $"{CustomTopics.JsonSerialize.ToString().ToLowerInvariant()}:{string.Join(",", jsonSerializeTopics)}";
+                    $"{CustomTopics.ContractClock.ToString().ToLowerInvariant()}:{string.Join(",", contractClockTopics)}";
 
                 if (CustomTopics.BlockExchange != null)
                 {

ProjectPlugins/CodexPlugin/CodexTypes.cs

@@ -105,18 +105,4 @@ namespace CodexPlugin
             return HashCode.Combine(Id);
         }
     }
-
-    public class CodexSpace
-    {
-        public long TotalBlocks { get; set; }
-        public long QuotaMaxBytes { get; set; }
-        public long QuotaUsedBytes { get; set; }
-        public long QuotaReservedBytes { get; set; }
-        public long FreeBytes => QuotaMaxBytes - (QuotaUsedBytes + QuotaReservedBytes);
-
-        public override string ToString()
-        {
-            return JsonConvert.SerializeObject(this);
-        }
-    }
 }

ProjectPlugins/CodexPlugin/CoreInterfaceExtensions.cs

@@ -5,12 +5,12 @@ namespace CodexPlugin
 {
     public static class CoreInterfaceExtensions
     {
-        public static RunningPod[] DeployCodexNodes(this CoreInterface ci, int number, Action<ICodexSetup> setup)
+        public static RunningContainers[] DeployCodexNodes(this CoreInterface ci, int number, Action<ICodexSetup> setup)
         {
             return Plugin(ci).DeployCodexNodes(number, setup);
         }
 
-        public static ICodexNodeGroup WrapCodexContainers(this CoreInterface ci, RunningPod[] containers)
+        public static ICodexNodeGroup WrapCodexContainers(this CoreInterface ci, RunningContainers[] containers)
         {
             return Plugin(ci).WrapCodexContainers(ci, containers);
         }

ProjectPlugins/CodexPlugin/Mapper.cs

@@ -1,5 +1,4 @@
 using CodexContractsPlugin;
-using CodexOpenApi;
 using Newtonsoft.Json.Linq;
 using System.Numerics;
 using Utils;
@@ -57,78 +56,34 @@ namespace CodexPlugin
                 ProofProbability = ToDecInt(purchase.ProofProbability),
                 Reward = ToDecInt(purchase.PricePerSlotPerSecond),
                 Collateral = ToDecInt(purchase.RequiredCollateral),
-                Expiry = ToDecInt(purchase.Expiry.TotalSeconds),
+                Expiry = ToDecInt(DateTimeOffset.UtcNow.ToUnixTimeSeconds() + purchase.Expiry.TotalSeconds),
                 Nodes = Convert.ToInt32(purchase.MinRequiredNumberOfNodes),
                 Tolerance = Convert.ToInt32(purchase.NodeFailureTolerance)
             };
         }
 
-        // TODO: Fix openapi spec for this call.
-        //public StoragePurchase Map(CodexOpenApi.Purchase purchase)
-        //{
-        //    return new StoragePurchase(Map(purchase.Request))
-        //    {
-        //        State = purchase.State,
-        //        Error = purchase.Error
-        //    };
-        //}
-
-        //public StorageRequest Map(CodexOpenApi.StorageRequest request)
-        //{
-        //    return new StorageRequest(Map(request.Ask), Map(request.Content))
-        //    {
-        //        Id = request.Id,
-        //        Client = request.Client,
-        //        Expiry = TimeSpan.FromSeconds(Convert.ToInt64(request.Expiry)),
-        //        Nonce = request.Nonce
-        //    };
-        //}
-
-        //public StorageAsk Map(CodexOpenApi.StorageAsk ask)
-        //{
-        //    return new StorageAsk
-        //    {
-        //        Duration = TimeSpan.FromSeconds(Convert.ToInt64(ask.Duration)),
-        //        MaxSlotLoss = ask.MaxSlotLoss,
-        //        ProofProbability = ask.ProofProbability,
-        //        Reward = Convert.ToDecimal(ask.Reward).TstWei(),
-        //        Slots = ask.Slots,
-        //        SlotSize = new ByteSize(Convert.ToInt64(ask.SlotSize))
-        //    };
-        //}
-
-        //public StorageContent Map(CodexOpenApi.Content content)
-        //{
-        //    return new StorageContent
-        //    {
-        //        Cid = content.Cid
-        //    };
-        //}
+        public StoragePurchase Map(CodexOpenApi.Purchase purchase)
+        {
+            return new StoragePurchase
+            {
+                State = purchase.State,
+                Error = purchase.Error
+            };
+        }
 
         public StorageAvailability Map(CodexOpenApi.SalesAvailabilityREAD read)
         {
             return new StorageAvailability(
-                totalSpace: new ByteSize(Convert.ToInt64(read.TotalSize)),
+                totalSpace: new Utils.ByteSize(Convert.ToInt64(read.TotalSize)),
                 maxDuration: TimeSpan.FromSeconds(Convert.ToDouble(read.Duration)),
-                minPriceForTotalSpace: new TestToken(BigInteger.Parse(read.MinPrice)),
-                maxCollateral: new TestToken(BigInteger.Parse(read.MaxCollateral))
+                minPriceForTotalSpace: new TestToken(Convert.ToDecimal(read.MinPrice)),
+                maxCollateral: new TestToken(Convert.ToDecimal(read.MaxCollateral))
             )
             {
                 Id = read.Id
             };
         }
 
-        public CodexSpace Map(Space space)
-        {
-            return new CodexSpace
-            {
-                QuotaMaxBytes = space.QuotaMaxBytes,
-                QuotaReservedBytes = space.QuotaReservedBytes,
-                QuotaUsedBytes = space.QuotaUsedBytes,
-                TotalBlocks = space.TotalBlocks
-            };
-        }
-
         private DebugInfoVersion MapDebugInfoVersion(JObject obj)
         {
             return new DebugInfoVersion
@@ -143,7 +98,7 @@ namespace CodexPlugin
             return new DebugInfoTable
             {
                 LocalNode = MapDebugInfoTableNode(obj.GetValue("localNode")),
-                Nodes = MapDebugInfoTableNodeArray(obj.GetValue("nodes") as JArray)
+                Nodes = new DebugInfoTableNode[0]
             };
         }
 
@@ -162,16 +117,6 @@ namespace CodexPlugin
             };
         }
 
-        private DebugInfoTableNode[] MapDebugInfoTableNodeArray(JArray? nodes)
-        {
-            if (nodes == null || nodes.Count == 0)
-            {
-                return new DebugInfoTableNode[0];
-            }
-
-            return nodes.Select(MapDebugInfoTableNode).ToArray();
-        }
-
         private Manifest MapManifest(CodexOpenApi.ManifestItem manifest)
         {
             return new Manifest
@@ -220,7 +165,8 @@ namespace CodexPlugin
 
         private string ToDecInt(TestToken t)
         {
-            return t.TstWei.ToString("D");
+            var i = new BigInteger(t.Amount);
+            return i.ToString("D");
         }
     }
 }

ProjectPlugins/CodexPlugin/MarketplaceAccess.cs

@@ -38,9 +38,7 @@ namespace CodexPlugin
 
             Log($"Storage requested successfully. PurchaseId: '{response}'.");
 
-            var contract = new StoragePurchaseContract(log, codexAccess, response, purchase);
-            contract.WaitForStorageContractSubmitted();
-            return contract;
+            return new StoragePurchaseContract(log, codexAccess, response, purchase);
         }
 
         public string MakeStorageAvailable(StorageAvailability availability)
@@ -56,7 +54,7 @@ namespace CodexPlugin
 
         private void Log(string msg)
         {
-            log.Log($"{codexAccess.Container.Containers.Single().Name} {msg}");
+            log.Log($"{codexAccess.Container.Name} {msg}");
         }
     }
 
@@ -85,11 +83,8 @@ namespace CodexPlugin
     {
         private readonly ILog log;
         private readonly CodexAccess codexAccess;
-        private readonly TimeSpan gracePeriod = TimeSpan.FromSeconds(30);
-        private readonly DateTime contractPendingUtc = DateTime.UtcNow;
-        private DateTime? contractSubmittedUtc = DateTime.UtcNow;
-        private DateTime? contractStartedUtc;
-        private DateTime? contractFinishedUtc;
+        private readonly TimeSpan gracePeriod = TimeSpan.FromSeconds(10);
+        private DateTime? contractStartUtc;
 
         public StoragePurchaseContract(ILog log, CodexAccess codexAccess, string purchaseId, StoragePurchaseRequest purchase)
         {
@@ -97,48 +92,28 @@ namespace CodexPlugin
             this.codexAccess = codexAccess;
             PurchaseId = purchaseId;
             Purchase = purchase;
-
-            ContentId = new ContentId(codexAccess.GetPurchaseStatus(purchaseId).Request.Content.Cid);
         }
 
         public string PurchaseId { get; }
         public StoragePurchaseRequest Purchase { get; }
-        public ContentId ContentId { get; }
-
-        public TimeSpan? PendingToSubmitted => contractSubmittedUtc - contractPendingUtc;
-        public TimeSpan? SubmittedToStarted => contractStartedUtc - contractSubmittedUtc;
-        public TimeSpan? SubmittedToFinished => contractFinishedUtc - contractSubmittedUtc;
-
-        public void WaitForStorageContractSubmitted()
-        {
-            WaitForStorageContractState(gracePeriod, "submitted", sleep: 200);
-            contractSubmittedUtc = DateTime.UtcNow;
-            LogSubmittedDuration();
-            AssertDuration(PendingToSubmitted, gracePeriod, nameof(PendingToSubmitted));
-        }
 
         public void WaitForStorageContractStarted()
         {
             var timeout = Purchase.Expiry + gracePeriod;
 
             WaitForStorageContractState(timeout, "started");
-            contractStartedUtc = DateTime.UtcNow;
-            LogStartedDuration();
-            AssertDuration(SubmittedToStarted, timeout, nameof(SubmittedToStarted));
+            contractStartUtc = DateTime.UtcNow;
         }
 
         public void WaitForStorageContractFinished()
         {
-            if (!contractStartedUtc.HasValue)
+            if (!contractStartUtc.HasValue)
             {
                 WaitForStorageContractStarted();
             }
-            var currentContractTime = DateTime.UtcNow - contractSubmittedUtc!.Value;
+            var currentContractTime = DateTime.UtcNow - contractStartUtc!.Value;
             var timeout = (Purchase.Duration - currentContractTime) + gracePeriod;
             WaitForStorageContractState(timeout, "finished");
-            contractFinishedUtc = DateTime.UtcNow;
-            LogFinishedDuration();
-            AssertDuration(SubmittedToFinished, timeout, nameof(SubmittedToFinished));
         }
 
         public StoragePurchase GetPurchaseStatus(string purchaseId)
@@ -146,12 +121,12 @@ namespace CodexPlugin
             return codexAccess.GetPurchaseStatus(purchaseId);
         }
 
-        private void WaitForStorageContractState(TimeSpan timeout, string desiredState, int sleep = 1000)
+        private void WaitForStorageContractState(TimeSpan timeout, string desiredState)
         {
             var lastState = "";
             var waitStart = DateTime.UtcNow;
 
-            Log($"Waiting for {Time.FormatDuration(timeout)} to reach state '{desiredState}'.");
+            log.Log($"Waiting for {Time.FormatDuration(timeout)} for contract '{PurchaseId}' to reach state '{desiredState}'.");
             while (lastState != desiredState)
             {
                 var purchaseStatus = codexAccess.GetPurchaseStatus(PurchaseId);
@@ -162,7 +137,7 @@ namespace CodexPlugin
                     log.Debug("Purchase status: " + statusJson);
                 }
 
-                Thread.Sleep(sleep);
+                Thread.Sleep(1000);
 
                 if (lastState == "errored")
                 {
@@ -174,40 +149,7 @@ namespace CodexPlugin
                     FrameworkAssert.Fail($"Contract did not reach '{desiredState}' within {Time.FormatDuration(timeout)} timeout. {statusJson}");
                 }
             }
-        }
-
-        private void LogSubmittedDuration()
-        {
-            Log($"Pending to Submitted in {Time.FormatDuration(PendingToSubmitted)} " +
-                $"( < {Time.FormatDuration(gracePeriod)})");
-        }
-
-        private void LogStartedDuration()
-        {
-            Log($"Submitted to Started in {Time.FormatDuration(SubmittedToStarted)} " +
-                $"( < {Time.FormatDuration(Purchase.Expiry + gracePeriod)})");
-        }
-
-        private void LogFinishedDuration()
-        {
-            Log($"Submitted to Finished in {Time.FormatDuration(SubmittedToFinished)} " +
-                $"( < {Time.FormatDuration(Purchase.Duration + gracePeriod)})");
-        }
-
-        private void AssertDuration(TimeSpan? span, TimeSpan max, string message)
-        {
-            if (span == null) throw new ArgumentNullException(nameof(MarketplaceAccess) + ": " + message + " (IsNull)");
-            if (span.Value.TotalDays >= max.TotalSeconds)
-            {
-                throw new Exception(nameof(MarketplaceAccess) + 
-                    $": Duration out of range. Max: {Time.FormatDuration(max)} but was: {Time.FormatDuration(span.Value)} " +
-                    message);
-            }
-        }
-
-        private void Log(string msg)
-        {
-            log.Log($"[{PurchaseId}] {msg}");
+            log.Log($"Contract '{desiredState}'.");
         }
     }
 }

ProjectPlugins/CodexPlugin/MarketplaceTypes.cs

@@ -1,7 +1,5 @@
 using CodexContractsPlugin;
-using CodexOpenApi;
 using Logging;
-using System.Data;
 using Utils;
 
 namespace CodexPlugin
@@ -14,8 +12,8 @@ namespace CodexPlugin
         }
 
         public ContentId ContentId { get; set; }
-        public TestToken PricePerSlotPerSecond { get; set; } = 1.TstWei();
-        public TestToken RequiredCollateral { get; set; } = 1.TstWei();
+        public TestToken PricePerSlotPerSecond { get; set; } = 1.TestTokens();
+        public TestToken RequiredCollateral { get; set; } = 1.TestTokens();
         public uint MinRequiredNumberOfNodes { get; set; }
         public uint NodeFailureTolerance { get; set; }
         public int ProofProbability { get; set; }
@@ -39,34 +37,6 @@ namespace CodexPlugin
     {
         public string State { get; set; } = string.Empty;
         public string Error { get; set; } = string.Empty;
-        public StorageRequest Request { get; set; } = null!;
-    }
-
-    public class StorageRequest
-    {
-        public string Id { get; set; } = string.Empty;
-        public string Client { get; set; } = string.Empty;
-        public StorageAsk Ask { get; set; } = null!;
-        public StorageContent Content { get; set; } = null!;
-        public string Expiry { get; set; } = string.Empty;
-        public string Nonce { get; set; } = string.Empty;
-    }
-
-    public class StorageAsk
-    {
-        public int Slots { get; set; }
-        public string SlotSize { get; set; } = string.Empty;
-        public string Duration { get; set; } = string.Empty;
-        public string ProofProbability { get; set; } = string.Empty;
-        public string Reward { get; set; } = string.Empty;
-        public int MaxSlotLoss { get; set; }
-    }
-
-    public class StorageContent
-    {
-        public string Cid { get; set; } = string.Empty;
-        //public ErasureParameters Erasure { get; set; }
-        //public PoRParameters Por { get; set; }
     }
 
     public class StorageAvailability

ProjectPlugins/CodexPlugin/openapi.yaml

@@ -213,7 +213,8 @@ components:
           description: Number as decimal string that represents how much collateral is asked from hosts that wants to fill a slots
         expiry:
           type: string
-          description: Number as decimal string that represents expiry threshold in seconds from when the Request is submitted. When the threshold is reached and the Request does not find requested amount of nodes to host the data, the Request is voided. The number of seconds can not be higher then the Request's duration itself.
+          description: Number as decimal string that represents expiry time of the request (in unix timestamp)
+
     StorageAsk:
       type: object
       required:
@@ -289,7 +290,6 @@ components:
           description: "Root hash of the content"
         originalBytes:
           type: integer
-          format: int64
           description: "Length of original content in bytes"
         blockSize:
           type: integer
@@ -304,18 +304,14 @@ components:
         totalBlocks:
           description: "Number of blocks stored by the node"
           type: integer
-          format: int64
         quotaMaxBytes:
           type: integer
-          format: int64
           description: "Maximum storage space used by the node"
         quotaUsedBytes:
           type: integer
-          format: int64
           description: "Amount of storage space currently in use"
         quotaReservedBytes:
           type: integer
-          format: int64
           description: "Amount of storage space reserved"
 
 servers:

ProjectPlugins/GethPlugin/GethDeployment.cs

@@ -7,9 +7,9 @@ namespace GethPlugin
 {
     public class GethDeployment : IHasContainer
     {
-        public GethDeployment(RunningPod pod, Port discoveryPort, Port httpPort, Port wsPort, GethAccount account, string pubKey)
+        public GethDeployment(RunningContainers containers, Port discoveryPort, Port httpPort, Port wsPort, GethAccount account, string pubKey)
         {
-            Pod = pod;
+            Containers = containers;
             DiscoveryPort = discoveryPort;
             HttpPort = httpPort;
             WsPort = wsPort;
@@ -17,9 +17,9 @@ namespace GethPlugin
             PubKey = pubKey;
         }
 
-        public RunningPod Pod { get; }
+        public RunningContainers Containers { get; }
         [JsonIgnore]
-        public RunningContainer Container {  get { return Pod.Containers.Single(); } }
+        public RunningContainer Container {  get { return Containers.Containers.Single(); } }
         public Port DiscoveryPort { get; }
         public Port HttpPort { get; }
         public Port WsPort { get; }

ProjectPlugins/MetricsPlugin/CoreInterfaceExtensions.cs

@@ -6,24 +6,24 @@ namespace MetricsPlugin
 {
     public static class CoreInterfaceExtensions
     {
-        public static RunningPod DeployMetricsCollector(this CoreInterface ci, params IHasMetricsScrapeTarget[] scrapeTargets)
+        public static RunningContainers DeployMetricsCollector(this CoreInterface ci, params IHasMetricsScrapeTarget[] scrapeTargets)
         {
             return Plugin(ci).DeployMetricsCollector(scrapeTargets.Select(t => t.MetricsScrapeTarget).ToArray());
         }
 
-        public static RunningPod DeployMetricsCollector(this CoreInterface ci, params IMetricsScrapeTarget[] scrapeTargets)
+        public static RunningContainers DeployMetricsCollector(this CoreInterface ci, params IMetricsScrapeTarget[] scrapeTargets)
         {
             return Plugin(ci).DeployMetricsCollector(scrapeTargets);
         }
 
-        public static IMetricsAccess WrapMetricsCollector(this CoreInterface ci, RunningPod metricsPod, IHasMetricsScrapeTarget scrapeTarget)
+        public static IMetricsAccess WrapMetricsCollector(this CoreInterface ci, RunningContainers metricsContainer, IHasMetricsScrapeTarget scrapeTarget)
         {
-            return ci.WrapMetricsCollector(metricsPod, scrapeTarget.MetricsScrapeTarget);
+            return ci.WrapMetricsCollector(metricsContainer, scrapeTarget.MetricsScrapeTarget);
         }
 
-        public static IMetricsAccess WrapMetricsCollector(this CoreInterface ci, RunningPod metricsPod, IMetricsScrapeTarget scrapeTarget)
+        public static IMetricsAccess WrapMetricsCollector(this CoreInterface ci, RunningContainers metricsContainer, IMetricsScrapeTarget scrapeTarget)
         {
-            return Plugin(ci).WrapMetricsCollectorDeployment(metricsPod, scrapeTarget);
+            return Plugin(ci).WrapMetricsCollectorDeployment(metricsContainer, scrapeTarget);
         }
 
         public static IMetricsAccess[] GetMetricsFor(this CoreInterface ci, params IHasManyMetricScrapeTargets[] manyScrapeTargets)

ProjectPlugins/MetricsPlugin/MetricsPlugin.cs

@@ -31,15 +31,15 @@ namespace MetricsPlugin
         {
         }
 
-        public RunningPod DeployMetricsCollector(IMetricsScrapeTarget[] scrapeTargets)
+        public RunningContainers DeployMetricsCollector(IMetricsScrapeTarget[] scrapeTargets)
         {
             return starter.CollectMetricsFor(scrapeTargets);
         }
 
-        public IMetricsAccess WrapMetricsCollectorDeployment(RunningPod runningPod, IMetricsScrapeTarget target)
+        public IMetricsAccess WrapMetricsCollectorDeployment(RunningContainers runningContainer, IMetricsScrapeTarget target)
         {
-            runningPod = SerializeGate.Gate(runningPod);
-            return starter.CreateAccessForTarget(runningPod, target);
+            runningContainer = SerializeGate.Gate(runningContainer);
+            return starter.CreateAccessForTarget(runningContainer, target);
         }
 
         public LogFile? DownloadAllMetrics(IMetricsAccess metricsAccess, string targetName)

ProjectPlugins/MetricsPlugin/MetricsQuery.cs

@@ -1,5 +1,4 @@
 using Core;
-using IdentityModel;
 using KubernetesWorkflow.Types;
 using Logging;
 using System.Globalization;
@@ -178,41 +177,6 @@ namespace MetricsPlugin
         {
             return "[" + string.Join(',', Sets.Select(s => s.ToString())) + "]";
         }
-
-        public string AsCsv()
-        {
-            var allTimestamps = Sets.SelectMany(s => s.Values.Select(v => v.Timestamp)).Distinct().OrderDescending().ToArray();
-
-            var lines = new List<string>();
-            MakeLine(lines, e =>
-            {
-                e.Add("Metrics");
-                foreach (var ts in allTimestamps) e.Add(ts.ToEpochTime().ToString());
-            });
-
-            foreach (var set in Sets)
-            {
-                MakeLine(lines, e =>
-                {
-                    e.Add(set.Name);
-                    foreach (var ts in allTimestamps)
-                    {
-                        var value = set.Values.SingleOrDefault(v => v.Timestamp == ts);
-                        if (value == null) e.Add(" ");
-                        else e.Add(value.Value.ToString());
-                    }
-                });
-            }
-
-            return string.Join(Environment.NewLine, lines.ToArray());
-        }
-
-        private void MakeLine(List<string> lines, Action<List<string>> values)
-        {
-            var list = new List<string>();
-            values(list);
-            lines.Add(string.Join(",", list));
-        }
     }
 
     public class MetricsSet

ProjectPlugins/MetricsPlugin/PrometheusStarter.cs

@@ -16,7 +16,7 @@ namespace MetricsPlugin
             this.tools = tools;
         }
 
-        public RunningPod CollectMetricsFor(IMetricsScrapeTarget[] targets)
+        public RunningContainers CollectMetricsFor(IMetricsScrapeTarget[] targets)
         {
             if (!targets.Any()) throw new ArgumentException(nameof(targets) + " must not be empty.");
 
@@ -32,9 +32,9 @@ namespace MetricsPlugin
             return runningContainers;
         }
 
-        public MetricsAccess CreateAccessForTarget(RunningPod metricsPod, IMetricsScrapeTarget target)
+        public MetricsAccess CreateAccessForTarget(RunningContainers metricsContainer, IMetricsScrapeTarget target)
         {
-            var metricsQuery = new MetricsQuery(tools, metricsPod.Containers.Single());
+            var metricsQuery = new MetricsQuery(tools, metricsContainer.Containers.Single());
             return new MetricsAccess(metricsQuery, target);
         }
 

Tests/CodexContinuousTests/ContinuousTestRunner.cs

@@ -148,7 +148,7 @@ namespace ContinuousTests
             log.Log($"Clearing namespace '{test.CustomK8sNamespace}'...");
 
             var entryPoint = entryPointFactory.CreateEntryPoint(config.KubeConfigFile, config.DataPath, test.CustomK8sNamespace, log);
-            entryPoint.Tools.CreateWorkflow().DeleteNamespacesStartingWith(test.CustomK8sNamespace, wait: true);
+            entryPoint.Tools.CreateWorkflow().DeleteNamespacesStartingWith(test.CustomK8sNamespace);
         }
 
         private void PerformCleanup(ILog log)
@@ -157,7 +157,7 @@ namespace ContinuousTests
             log.Log("Cleaning up test namespace...");
 
             var entryPoint = entryPointFactory.CreateEntryPoint(config.KubeConfigFile, config.DataPath, config.CodexDeployment.Metadata.KubeNamespace, log);
-            entryPoint.Decommission(deleteKubernetesResources: true, deleteTrackedFiles: true, waitTillDone: true);
+            entryPoint.Decommission(deleteKubernetesResources: true, deleteTrackedFiles: true);
             log.Log("Cleanup finished.");
         }
     }

Tests/CodexContinuousTests/ElasticSearchLogDownloader.cs

@@ -49,8 +49,8 @@ namespace ContinuousTests
             var start = startUtc.ToString("o");
             var end = endUtc.ToString("o");
 
-            var containerName = container.RunningPod.StartResult.Deployment.Name;
-            var namespaceName = container.RunningPod.StartResult.Cluster.Configuration.KubernetesNamespace;
+            var containerName = container.RunningContainers.StartResult.Deployment.Name;
+            var namespaceName = container.RunningContainers.StartResult.Cluster.Configuration.KubernetesNamespace;
 
             //container_name : codex3-5 - deploymentName as stored in pod
             // pod_namespace : codex - continuous - nolimits - tests - 1

Tests/CodexContinuousTests/NodeRunner.cs

@@ -64,7 +64,7 @@ namespace ContinuousTests
             }
             finally
             {
-                entryPoint.Tools.CreateWorkflow().DeleteNamespace(wait: false);
+                entryPoint.Tools.CreateWorkflow().DeleteNamespace();
             }
         }
 

Tests/CodexContinuousTests/SingleTestRun.cs

@@ -54,8 +54,7 @@ namespace ContinuousTests
 
                     entryPoint.Decommission(
                         deleteKubernetesResources: false, // This would delete the continuous test net.
-                        deleteTrackedFiles: true,
-                        waitTillDone: false
+                        deleteTrackedFiles: true
                     );
                     runFinishedHandle.Set();
                 }
@@ -126,8 +125,8 @@ namespace ContinuousTests
             foreach (var node in nodes)
             {
                 var container = node.Container;
-                var deploymentName = container.RunningPod.StartResult.Deployment.Name;
-                var namespaceName = container.RunningPod.StartResult.Cluster.Configuration.KubernetesNamespace;
+                var deploymentName = container.RunningContainers.StartResult.Deployment.Name;
+                var namespaceName = container.RunningContainers.StartResult.Cluster.Configuration.KubernetesNamespace;
                 var openingLine =
                     $"{namespaceName} - {deploymentName} = {node.Container.Name} = {node.GetDebugInfo().Id}";
                 elasticSearchLogDownloader.Download(fixtureLog.CreateSubfile(), node.Container, effectiveStart,
@@ -296,13 +295,13 @@ namespace ContinuousTests
             return entryPoint.CreateInterface().WrapCodexContainers(containers).ToArray();
         }
 
-        private RunningPod[] SelectRandomContainers()
+        private RunningContainers[] SelectRandomContainers()
         {
             var number = handle.Test.RequiredNumberOfNodes;
-            var containers = config.CodexDeployment.CodexInstances.Select(i => i.Pod).ToList();
+            var containers = config.CodexDeployment.CodexInstances.Select(i => i.Containers).ToList();
             if (number == -1) return containers.ToArray();
 
-            var result = new RunningPod[number];
+            var result = new RunningContainers[number];
             for (var i = 0; i < number; i++)
             {
                 result[i] = containers.PickOneRandom();

Tests/CodexContinuousTests/StartupChecker.cs

@@ -43,13 +43,13 @@ namespace ContinuousTests
             var workflow = entryPoint.Tools.CreateWorkflow();
             foreach (var instance in deployment.CodexInstances)
             {
-                foreach (var container in instance.Pod.Containers)
+                foreach (var container in instance.Containers.Containers)
                 {
                     var podInfo = workflow.GetPodInfo(container);
                     log.Log($"Codex environment variables for '{container.Name}':");
                     log.Log(
-                        $"Namespace: {container.RunningPod.StartResult.Cluster.Configuration.KubernetesNamespace} - " +
-                        $"Pod name: {podInfo.Name} - Deployment name: {instance.Pod.StartResult.Deployment.Name}");
+                        $"Namespace: {container.RunningContainers.StartResult.Cluster.Configuration.KubernetesNamespace} - " +
+                        $"Pod name: {podInfo.Name} - Deployment name: {instance.Containers.StartResult.Deployment.Name}");
                     var codexVars = container.Recipe.EnvVars;
                     foreach (var vars in codexVars) log.Log(vars.ToString());
                     log.Log("");
@@ -92,7 +92,7 @@ namespace ContinuousTests
         private void CheckCodexNodes(BaseLog log, Configuration config)
         {
             var nodes = entryPoint.CreateInterface()
-                .WrapCodexContainers(config.CodexDeployment.CodexInstances.Select(i => i.Pod).ToArray());
+                .WrapCodexContainers(config.CodexDeployment.CodexInstances.Select(i => i.Containers).ToArray());
             var pass = true;
             foreach (var n in nodes)
             {

Tests/CodexLongTests/BasicTests/DownloadTests.cs

@@ -1,4 +1,3 @@
-using CodexPlugin;
 using CodexTests;
 using DistTestCore;
 using FileUtils;
@@ -8,45 +7,35 @@ using Utils;
 namespace CodexLongTests.BasicTests
 {
     [TestFixture]
-    public class DownloadTests : AutoBootstrapDistTest
+    public class DownloadTests : CodexDistTest
     {
-        [Test]
-        [Combinatorial]
+        [TestCase(3, 500)]
+        [TestCase(5, 100)]
+        [TestCase(10, 256)]
         [UseLongTimeouts]
-        public void ParallelDownload(
-            [Values(1, 3, 5)] int numberOfFiles,
-            [Values(10, 50, 100)] int filesizeMb)
+        public void ParallelDownload(int numberOfNodes, int filesizeMb)
         {
-            var host = StartCodex();
-            var client = StartCodex();
+            var group = AddCodex(numberOfNodes);
+            var host = AddCodex();
 
-            var testfiles = new List<TrackedFile>();
-            var contentIds = new List<ContentId>();
-            var downloadedFiles = new List<TrackedFile?>();
-
-            for (int i = 0; i < numberOfFiles; i++)
+            foreach (var node in group)
             {
-                testfiles.Add(GenerateTestFile(filesizeMb.MB()));
-                contentIds.Add(new ContentId());
-                downloadedFiles.Add(null);
+                host.ConnectToPeer(node);
             }
 
-            for (int i = 0; i < numberOfFiles; i++)
+            var testFile = GenerateTestFile(filesizeMb.MB());
+            var contentId = host.UploadFile(testFile);
+            var list = new List<Task<TrackedFile?>>();
+
+            foreach (var node in group)
             {
-                contentIds[i] = host.UploadFile(testfiles[i]);
+                list.Add(Task.Run(() => { return node.DownloadContent(contentId); }));
             }
 
-            var downloadTasks = new List<Task>();
-            for (int i = 0; i < numberOfFiles; i++)
+            Task.WaitAll(list.ToArray());
+            foreach (var task in list)
             {
-                downloadTasks.Add(Task.Run(() => { downloadedFiles[i] = client.DownloadContent(contentIds[i]); }));
-            }
-
-            Task.WaitAll(downloadTasks.ToArray());
-
-            for (int i = 0; i < numberOfFiles; i++)
-            {
-                testfiles[i].AssertIsEqual(downloadedFiles[i]);
+                testFile.AssertIsEqual(task.Result);
             }
         }
     }

Tests/CodexLongTests/BasicTests/LargeFileTests.cs

@@ -48,7 +48,7 @@ namespace CodexLongTests.BasicTests
 
             var expectedFile = GenerateTestFile(sizeMB);
 
-            var node = StartCodex(s => s.WithStorageQuota((size + 10).MB()));
+            var node = AddCodex(s => s.WithStorageQuota((size + 10).MB()));
 
             var uploadStart = DateTime.UtcNow;
             var cid = node.UploadFile(expectedFile);

Tests/CodexLongTests/BasicTests/TestInfraTests.cs

@@ -6,12 +6,10 @@ namespace CodexLongTests.BasicTests
 {
     public class TestInfraTests : CodexDistTest
     {
-        [Test]
-        [UseLongTimeouts]
-        [Ignore("Not supported atm")]
+        [Test, UseLongTimeouts]
         public void TestInfraShouldHave1000AddressSpacesPerPod()
         {
-            var group = StartCodex(1000, s => s.EnableMetrics());
+            var group = AddCodex(1000, s => s.EnableMetrics());
 
             var nodeIds = group.Select(n => n.GetDebugInfo().Id).ToArray();
 
@@ -19,14 +17,12 @@ namespace CodexLongTests.BasicTests
                 "Not all created nodes provided a unique id.");
         }
 
-        [Test]
-        [UseLongTimeouts]
-        [Ignore("Not supported atm")]
+        [Test, UseLongTimeouts]
         public void TestInfraSupportsManyConcurrentPods()
         {
             for (var i = 0; i < 20; i++)
             {
-                var n = StartCodex();
+                var n = AddCodex();
 
                 Assert.That(!string.IsNullOrEmpty(n.GetDebugInfo().Id));
             }

Tests/CodexLongTests/BasicTests/UploadTests.cs

@@ -8,39 +8,41 @@ using Utils;
 namespace CodexLongTests.BasicTests
 {
     [TestFixture]
-    public class UploadTests : AutoBootstrapDistTest
+    public class UploadTests : CodexDistTest
     {
-        [Test]
-        [Combinatorial] 
+        [TestCase(3, 50)]
+        [TestCase(5, 75)]
+        [TestCase(10, 25)]
         [UseLongTimeouts]
-        public void ParallelUpload(
-            [Values(1, 3, 5)] int numberOfFiles,
-            [Values(10, 50, 100)] int filesizeMb)
+        public void ParallelUpload(int numberOfNodes, int filesizeMb)
         {
-            var host = StartCodex();
-            var client = StartCodex();
+            var group = AddCodex(numberOfNodes);
+            var host = AddCodex();
+
+            foreach (var node in group)
+            {
+                host.ConnectToPeer(node);
+            }
 
             var testfiles = new List<TrackedFile>();
-            var contentIds = new List<ContentId>();
+            var contentIds = new List<Task<ContentId>>();
 
-            for (int i = 0; i < numberOfFiles; i++)
+            for (int i = 0; i < group.Count(); i++)
             {
                 testfiles.Add(GenerateTestFile(filesizeMb.MB()));
-                contentIds.Add(new ContentId());
+                var n = i;
+                contentIds.Add(Task.Run(() => { return host.UploadFile(testfiles[n]); }));
             }
-
-            var uploadTasks = new List<Task>();
-            for (int i = 0; i < numberOfFiles; i++)
+            var downloads = new List<Task<TrackedFile?>>();
+            for (int i = 0; i < group.Count(); i++)
             {
-                uploadTasks.Add(Task.Run(() => { contentIds[i] = host.UploadFile(testfiles[i]); }));
+                var n = i;
+                downloads.Add(Task.Run(() => { return group[n].DownloadContent(contentIds[n].Result); }));
             }
-
-            Task.WaitAll(uploadTasks.ToArray());
-
-            for (int i = 0; i < numberOfFiles; i++)
+            Task.WaitAll(downloads.ToArray());
+            for (int i = 0; i < group.Count(); i++)
             {
-                var downloaded = client.DownloadContent(contentIds[i]);
-                testfiles[i].AssertIsEqual(downloaded);
+                testfiles[i].AssertIsEqual(downloads[i].Result);
             }
         }
     }

Tests/CodexLongTests/DownloadConnectivityTests/LongFullyConnectedDownloadTests.cs

@@ -15,9 +15,9 @@ namespace CodexLongTests.DownloadConnectivityTests
             [Values(10, 15, 20)] int numberOfNodes,
             [Values(10, 100)] int sizeMBs)
         {
-            var nodes = StartCodex(numberOfNodes);
+            for (var i = 0; i < numberOfNodes; i++) AddCodex();
 
-            CreatePeerDownloadTestHelpers().AssertFullDownloadInterconnectivity(nodes, sizeMBs.MB());
+            CreatePeerDownloadTestHelpers().AssertFullDownloadInterconnectivity(GetAllOnlineCodexNodes(), sizeMBs.MB());
         }
     }
 }

Tests/CodexLongTests/ScalabilityTests/MultiPeerDownloadTests.cs

@@ -1,120 +0,0 @@
-using DistTestCore;
-using NUnit.Framework;
-using Utils;
-
-namespace CodexTests.ScalabilityTests
-{
-    [TestFixture]
-    public class MultiPeerDownloadTests : AutoBootstrapDistTest
-    {
-        [Test]
-        [DontDownloadLogs]
-        [UseLongTimeouts]
-        [Combinatorial]
-        public void MultiPeerDownload(
-            [Values(5, 10, 20)] int numberOfHosts,
-            [Values(100, 1000)] int fileSize
-        )
-        {
-            var hosts = StartCodex(numberOfHosts, s => s.WithLogLevel(CodexPlugin.CodexLogLevel.Trace));
-            var file = GenerateTestFile(fileSize.MB());
-            var cid = hosts[0].UploadFile(file);
-            var tailOfManifestCid = cid.Id.Substring(cid.Id.Length - 6);
-
-            var uploadLog = Ci.DownloadLog(hosts[0]);
-            var expectedNumberOfBlocks = RoundUp(fileSize.MB().SizeInBytes, 64.KB().SizeInBytes) + 1; // +1 for manifest block.
-            var blockCids = uploadLog
-                .FindLinesThatContain("Putting block into network store")
-                .Select(s =>
-                {
-                    var start = s.IndexOf("cid=") + 4;
-                    var end = s.IndexOf(" count=");
-                    var len = end - start;
-                    return s.Substring(start, len);
-                })
-                .ToArray();
-
-            Assert.That(blockCids.Length, Is.EqualTo(expectedNumberOfBlocks));
-
-            foreach (var h in hosts) h.DownloadContent(cid);
-
-            var client = StartCodex(s => s.WithLogLevel(CodexPlugin.CodexLogLevel.Trace));
-            var resultFile = client.DownloadContent(cid);
-            resultFile!.AssertIsEqual(file);
-
-            var downloadLog = Ci.DownloadLog(client);
-            var host = string.Empty;
-            var blockCidHostMap = new Dictionary<string, string>();
-            downloadLog.IterateLines(line =>
-            {
-                if (line.Contains("peer=") && line.Contains(" len="))
-                {
-                    var start = line.IndexOf("peer=") + 5;
-                    var end = line.IndexOf(" len=");
-                    var len = end - start;
-                    host = line.Substring(start, len);
-                }
-                else if (!string.IsNullOrEmpty(host) && line.Contains("Storing block with key"))
-                {
-                    var start = line.IndexOf("cid=") + 4;
-                    var end = line.IndexOf(" count=");
-                    var len = end - start;
-                    var blockCid = line.Substring(start, len);
-
-                    blockCidHostMap.Add(blockCid, host);
-                    host = string.Empty;
-                }
-            });
-
-            var totalFetched = blockCidHostMap.Count(p => !string.IsNullOrEmpty(p.Value));
-            //PrintFullMap(blockCidHostMap);
-            PrintOverview(blockCidHostMap);
-
-            Log("Expected number of blocks: " + expectedNumberOfBlocks);
-            Log("Total number of block CIDs found in dataset + manifest block: " + blockCids.Length);
-            Log("Total blocks fetched by hosts: " + totalFetched);
-            Assert.That(totalFetched, Is.EqualTo(expectedNumberOfBlocks));
-        }
-
-        private void PrintOverview(Dictionary<string, string> blockCidHostMap)
-        {
-            var overview = new Dictionary<string, int>();
-            foreach (var pair in blockCidHostMap)
-            {
-                if (!overview.ContainsKey(pair.Value)) overview.Add(pair.Value, 1);
-                else overview[pair.Value]++;
-            }
-
-            Log("Blocks fetched per host:");
-            foreach (var pair in overview)
-            {
-                Log($"Host: {pair.Key} = {pair.Value}");
-            }
-        }
-
-        private void PrintFullMap(Dictionary<string, string> blockCidHostMap)
-        {
-            Log("Per block, host it was fetched from:");
-            foreach (var pair in blockCidHostMap)
-            {
-                if (string.IsNullOrEmpty(pair.Value))
-                {
-                    Log($"block: {pair.Key} = Not seen");
-                }
-                else
-                {
-                    Log($"block: {pair.Key} = '{pair.Value}'");
-                }
-            }
-        }
-
-        private long RoundUp(long filesize, long blockSize)
-        {
-            double f = filesize;
-            double b = blockSize;
-
-            var result = Math.Ceiling(f / b);
-            return Convert.ToInt64(result);
-        }
-    }
-}

Tests/CodexLongTests/ScalabilityTests/ScalabilityTests.cs

@@ -1,132 +0,0 @@
-using CodexPlugin;
-using DistTestCore;
-using FileUtils;
-using NUnit.Framework;
-using Utils;
-
-namespace CodexTests.ScalabilityTests;
-
-[TestFixture]
-public class ScalabilityTests : CodexDistTest
-{
-    /// <summary>
-    /// We upload a file to node A, then download it with B.
-    /// Then we stop node A, and download again with node C.
-    /// </summary>
-    [Test]
-    [Combinatorial]
-    [UseLongTimeouts]
-    [DontDownloadLogs]
-    [WaitForCleanup]
-    public void ShouldMaintainFileInNetwork(
-        [Values(4, 5, 6)] int numberOfNodes, // TODO: include 10, 40, 80 and 100, not 5
-        [Values(4000, 5000, 6000, 7000, 8000, 9000, 10000)] int fileSizeInMb
-    )
-    {
-        var logLevel = CodexLogLevel.Trace;
-
-        var bootstrap = StartCodex(s => s.WithLogLevel(logLevel));
-        var nodes = StartCodex(numberOfNodes - 1, s => s
-            .WithBootstrapNode(bootstrap)
-            .WithLogLevel(logLevel)
-            .WithStorageQuota((fileSizeInMb + 50).MB())
-        ).ToList();
-
-        var uploader = nodes.PickOneRandom();
-        var downloader = nodes.PickOneRandom();
-
-        var testFile = GenerateTestFile(fileSizeInMb.MB());
-
-        LogNodeStatus(uploader);
-        var contentId = uploader.UploadFile(testFile, f => LogNodeStatus(uploader));
-        LogNodeStatus(uploader);
-
-        LogNodeStatus(downloader);
-        var downloadedFile = downloader.DownloadContent(contentId, f => LogNodeStatus(downloader));
-        LogNodeStatus(downloader);
-
-        downloadedFile!.AssertIsEqual(testFile);
-
-        uploader.DeleteRepoFolder();
-        uploader.Stop(true);
-
-        var otherDownloader = nodes.PickOneRandom();
-        downloadedFile = otherDownloader.DownloadContent(contentId);
-
-        downloadedFile!.AssertIsEqual(testFile);
-
-        downloader.DeleteRepoFolder();
-        otherDownloader.DeleteRepoFolder();
-    }
-
-    /// <summary>
-    /// We upload a file to each node, to put a more wide-spread load on the network.
-    /// Then we run the same test as ShouldMaintainFileInNetwork.
-    /// </summary>
-    [Ignore("Fix ShouldMaintainFileInNetwork for all values first")]
-    [Test]
-    [Combinatorial]
-    [UseLongTimeouts]
-    [DontDownloadLogs]
-    [WaitForCleanup]
-    public void EveryoneGetsAFile(
-        [Values(10, 40, 80, 100)] int numberOfNodes,
-        [Values(100, 1000, 5000, 10000)] int fileSizeInMb
-    )
-    {
-        var logLevel = CodexLogLevel.Info;
-
-        var bootstrap = StartCodex(s => s.WithLogLevel(logLevel));
-        var nodes = StartCodex(numberOfNodes - 1, s => s
-            .WithBootstrapNode(bootstrap)
-            .WithLogLevel(logLevel)
-            .WithStorageQuota((fileSizeInMb + 50).MB())
-        ).ToList();
-
-        var pairTasks = nodes.Select(n =>
-        {
-            return Task.Run(() =>
-            {
-                var file = GenerateTestFile(fileSizeInMb.MB());
-                var cid = n.UploadFile(file);
-                return new NodeFilePair(n, file, cid);
-            });
-        });
-
-        var pairs = pairTasks.Select(t => Time.Wait(t)).ToList();
-
-        RunDoubleDownloadTest(
-            pairs.PickOneRandom(),
-            pairs.PickOneRandom(),
-            pairs.PickOneRandom()
-        );
-    }
-
-    private void RunDoubleDownloadTest(NodeFilePair source, NodeFilePair dl1, NodeFilePair dl2)
-    {
-        var expectedFile = source.File;
-        var cid = source.Cid;
-
-        var file1 = dl1.Node.DownloadContent(cid);
-        file1!.AssertIsEqual(expectedFile);
-
-        source.Node.Stop(true);
-
-        var file2 = dl2.Node.DownloadContent(cid);
-        file2!.AssertIsEqual(expectedFile);
-    }
-
-    public class NodeFilePair
-    {
-        public NodeFilePair(ICodexNode node, TrackedFile file, ContentId cid)
-        {
-            Node = node;
-            File = file;
-            Cid = cid;
-        }
-
-        public ICodexNode Node { get; }
-        public TrackedFile File { get; }
-        public ContentId Cid { get; }
-    }
-}

Tests/CodexTests/AutoBootstrapDistTest.cs

@@ -8,7 +8,7 @@ namespace CodexTests
         [SetUp]
         public void SetUpBootstrapNode()
         {
-            BootstrapNode = StartCodex(s => s.WithName("BOOTSTRAP"));
+            BootstrapNode = AddCodex(s => s.WithName("BOOTSTRAP"));
         }
 
         [TearDown]

Tests/CodexTests/BasicTests/ContinuousSubstitute.cs

@@ -0,0 +1,298 @@
+using CodexContractsPlugin;
+using CodexPlugin;
+using GethPlugin;
+using KubernetesWorkflow.Types;
+using Logging;
+using MetricsPlugin;
+using NUnit.Framework;
+using Utils;
+
+namespace CodexTests.BasicTests
+{
+    [Ignore("Used for debugging continuous tests")]
+    [TestFixture]
+    public class ContinuousSubstitute : AutoBootstrapDistTest
+    {
+        [Test]
+        public void ContinuousTestSubstitute()
+        {
+            var geth = Ci.StartGethNode(s => s.IsMiner().WithName("geth"));
+            var contract = Ci.StartCodexContracts(geth);
+
+            var group = AddCodex(5, o => o
+                    .EnableMetrics()
+                    .EnableMarketplace(geth, contract, s => s
+                        .WithInitial(10.Eth(), 100000.TestTokens())
+                        .AsStorageNode()
+                        .AsValidator())
+                    .WithBlockTTL(TimeSpan.FromMinutes(5))
+                    .WithBlockMaintenanceInterval(TimeSpan.FromSeconds(10))
+                    .WithBlockMaintenanceNumber(100)
+                    .WithStorageQuota(1.GB()));
+
+            var nodes = group.Cast<CodexNode>().ToArray();
+
+            var rc = Ci.DeployMetricsCollector(nodes);
+
+            var availability = new StorageAvailability(
+                totalSpace: 500.MB(),
+                maxDuration: TimeSpan.FromMinutes(5),
+                minPriceForTotalSpace: 500.TestTokens(),
+                maxCollateral: 1024.TestTokens()
+            );
+
+            foreach (var node in nodes)
+            {
+                node.Marketplace.MakeStorageAvailable(availability);
+            }
+
+            var endTime = DateTime.UtcNow + TimeSpan.FromHours(10);
+            while (DateTime.UtcNow < endTime)
+            {
+                var allNodes = nodes.ToList();
+                var primary = allNodes.PickOneRandom();
+                var secondary = allNodes.PickOneRandom();
+
+                Log("Run Test");
+                PerformTest(primary, secondary, rc);
+
+                Thread.Sleep(TimeSpan.FromSeconds(5));
+            }
+        }
+
+        private void LogBytesPerMillisecond(Action action)
+        {
+            var sw = Stopwatch.Begin(GetTestLog());
+            action();
+            var duration = sw.End();
+            double totalMs = duration.TotalMilliseconds;
+            double totalBytes = fileSize.SizeInBytes;
+
+            var bytesPerMs = totalBytes / totalMs;
+            Log($"Bytes per millisecond: {bytesPerMs}");
+        }
+
+        [Test]
+        public void PeerTest()
+        {
+            var group = AddCodex(5, o => o
+                    //.EnableMetrics()
+                    //.EnableMarketplace(100000.TestTokens(), 0.Eth(), isValidator: true)
+                    .WithBlockTTL(TimeSpan.FromMinutes(2))
+                    .WithBlockMaintenanceInterval(TimeSpan.FromMinutes(2))
+                    .WithBlockMaintenanceNumber(10000)
+                    .WithBlockTTL(TimeSpan.FromMinutes(2))
+                    .WithStorageQuota(1.GB()));
+
+            var nodes = group.Cast<CodexNode>().ToArray();
+
+            var checkTime = DateTime.UtcNow + TimeSpan.FromMinutes(1);
+            var endTime = DateTime.UtcNow + TimeSpan.FromHours(10);
+            while (DateTime.UtcNow < endTime)
+            {
+                //CreatePeerConnectionTestHelpers().AssertFullyConnected(GetAllOnlineCodexNodes());
+                //CheckRoutingTables(GetAllOnlineCodexNodes());
+
+                var node = nodes.ToList().PickOneRandom();
+                var file = GenerateTestFile(50.MB());
+                node.UploadFile(file);
+
+                Thread.Sleep(20000);
+            }
+        }
+
+        private void CheckRoutingTables(IEnumerable<ICodexNode> nodes)
+        {
+            var all = nodes.ToArray();
+            var allIds = all.Select(n => n.GetDebugInfo().Table.LocalNode.NodeId).ToArray();
+
+            var errors = all.Select(n => AreAllPresent(n, allIds)).Where(s => !string.IsNullOrEmpty(s)).ToArray();
+
+            if (errors.Any())
+            {
+                Assert.Fail(string.Join(Environment.NewLine, errors));
+            }
+        }
+
+        private string AreAllPresent(ICodexNode n, string[] allIds)
+        {
+            var info = n.GetDebugInfo();
+            var known = info.Table.Nodes.Select(n => n.NodeId).ToArray();
+            var expected = allIds.Where(i => i != info.Table.LocalNode.NodeId).ToArray();
+
+            if (!expected.All(ex => known.Contains(ex)))
+            {
+                return $"Not all of '{string.Join(",", expected)}' were present in routing table: '{string.Join(",", known)}'";
+            }
+
+            return string.Empty;
+        }
+
+        private ByteSize fileSize = 80.MB();
+
+        private const string BytesStoredMetric = "codexRepostoreBytesUsed";
+
+        private void PerformTest(ICodexNode primary, ICodexNode secondary, RunningContainers rc)
+        {
+            ScopedTestFiles(() =>
+            {
+                var testFile = GenerateTestFile(fileSize);
+
+                var metrics = Ci.WrapMetricsCollector(rc, primary);
+                var beforeBytesStored = metrics.GetMetric(BytesStoredMetric);
+
+                ContentId contentId = null!;
+                LogBytesPerMillisecond(() => contentId = primary.UploadFile(testFile));
+
+                var low = fileSize.SizeInBytes;
+                var high = low * 1.2;
+                Log("looking for: " + low + " < " + high);
+
+                Time.WaitUntil(() =>
+                {
+                    var afterBytesStored = metrics.GetMetric(BytesStoredMetric);
+                    var newBytes = Convert.ToInt64(afterBytesStored.Values.Last().Value - beforeBytesStored.Values.Last().Value);
+
+                    return high > newBytes && newBytes > low;
+                }, TimeSpan.FromMinutes(1), TimeSpan.FromSeconds(2));
+
+                FileUtils.TrackedFile? downloadedFile = null;
+                LogBytesPerMillisecond(() => downloadedFile = secondary.DownloadContent(contentId));
+
+                testFile.AssertIsEqual(downloadedFile);
+            });
+        }
+
+        [Test]
+        public void HoldMyBeerTest()
+        {
+            var blockExpirationTime = TimeSpan.FromMinutes(3);
+            var group = AddCodex(3, o => o
+                    .EnableMetrics()
+                    .WithBlockTTL(blockExpirationTime)
+                    .WithBlockMaintenanceInterval(TimeSpan.FromMinutes(2))
+                    .WithBlockMaintenanceNumber(10000)
+                    .WithStorageQuota(2000.MB()));
+
+            var nodes = group.Cast<CodexNode>().ToArray();
+
+            var endTime = DateTime.UtcNow + TimeSpan.FromHours(24);
+
+            var filesize = 80.MB();
+            double codexDefaultBlockSize = 31 * 64 * 33;
+            var numberOfBlocks = Convert.ToInt64(Math.Ceiling(filesize.SizeInBytes / codexDefaultBlockSize));
+            var sizeInBytes = filesize.SizeInBytes;
+            Assert.That(numberOfBlocks, Is.EqualTo(1282));
+
+            var startTime = DateTime.UtcNow;
+            var successfulUploads = 0;
+            var successfulDownloads = 0;
+
+            while (DateTime.UtcNow < endTime)
+            {
+                foreach (var node in nodes)
+                {
+                    try
+                    {
+                        Thread.Sleep(TimeSpan.FromSeconds(5));
+
+                        ScopedTestFiles(() =>
+                        {
+                            var uploadStartTime = DateTime.UtcNow;
+                            var file = GenerateTestFile(filesize);
+                            var cid = node.UploadFile(file);
+
+                            var cidTag = cid.Id.Substring(cid.Id.Length - 6);
+                            Measure("upload-log-asserts", () =>
+                            {
+                                var uploadLog = Ci.DownloadLog(node, tailLines: 50000);
+
+                                var storeLines = uploadLog.FindLinesThatContain("Stored data", "topics=\"codex node\"");
+                                uploadLog.DeleteFile();
+
+                                var storeLine = GetLineForCidTag(storeLines, cidTag);
+                                AssertStoreLineContains(storeLine, numberOfBlocks, sizeInBytes);
+                            });
+                            successfulUploads++;
+
+                            var uploadTimeTaken = DateTime.UtcNow - uploadStartTime;
+                            if (uploadTimeTaken >= blockExpirationTime.Subtract(TimeSpan.FromSeconds(10)))
+                            {
+                                Assert.Fail("Upload took too long. Blocks already expired.");
+                            }
+
+                            var dl = node.DownloadContent(cid);
+                            file.AssertIsEqual(dl);
+
+                            Measure("download-log-asserts", () =>
+                            {
+                                var downloadLog = Ci.DownloadLog(node, tailLines: 50000);
+
+                                var sentLines = downloadLog.FindLinesThatContain("Sent bytes", "topics=\"codex restapi\"");
+                                downloadLog.DeleteFile();
+
+                                var sentLine = GetLineForCidTag(sentLines, cidTag);
+                                AssertSentLineContains(sentLine, sizeInBytes);
+                            });
+                            successfulDownloads++;
+                        });
+                    }
+                    catch
+                    {
+                        var testDuration = DateTime.UtcNow - startTime;
+                        Log("Test failed. Delaying shut-down by 30 seconds to collect metrics.");
+                        Log($"Test failed after {Time.FormatDuration(testDuration)} and {successfulUploads} successful uploads and {successfulDownloads} successful downloads");
+                        Thread.Sleep(TimeSpan.FromSeconds(30));
+                        throw;
+                    }
+                }
+
+                Thread.Sleep(TimeSpan.FromSeconds(5));
+            }
+        }
+
+        private void AssertSentLineContains(string sentLine, long sizeInBytes)
+        {
+            var tag = "bytes=";
+            var token = sentLine.Substring(sentLine.IndexOf(tag) + tag.Length);
+            var bytes = Convert.ToInt64(token);
+            Assert.AreEqual(sizeInBytes, bytes, $"Sent bytes: Number of bytes incorrect. Line: '{sentLine}'");
+        }
+
+        private void AssertStoreLineContains(string storeLine, long numberOfBlocks, long sizeInBytes)
+        {
+            var tokens = storeLine.Split(" ");
+
+            var blocksToken = GetToken(tokens, "blocks=");
+            var sizeToken = GetToken(tokens, "size=");
+            if (blocksToken == null) Assert.Fail("blockToken not found in " + storeLine);
+            if (sizeToken == null) Assert.Fail("sizeToken not found in " + storeLine);
+
+            var blocks = Convert.ToInt64(blocksToken);
+            var size = Convert.ToInt64(sizeToken?.Replace("'NByte", ""));
+
+            var lineLog = $" Line: '{storeLine}'";
+            Assert.AreEqual(numberOfBlocks, blocks, "Stored data: Number of blocks incorrect." + lineLog);
+            Assert.AreEqual(sizeInBytes, size, "Stored data: Number of blocks incorrect." + lineLog);
+        }
+
+        private string GetLineForCidTag(string[] lines, string cidTag)
+        {
+            var result = lines.SingleOrDefault(l => l.Contains(cidTag));
+            if (result == null)
+            {
+                Assert.Fail($"Failed to find '{cidTag}' in lines: '{string.Join(",", lines)}'");
+                throw new Exception();
+            }
+
+            return result;
+        }
+
+        private string? GetToken(string[] tokens, string tag)
+        {
+            var token = tokens.SingleOrDefault(t => t.StartsWith(tag));
+            if (token == null) return null;
+            return token.Substring(tag.Length);
+        }
+    }
+}

Tests/CodexTests/BasicTests/DiscordBotTests.cs

@@ -5,19 +5,18 @@ using GethPlugin;
 using NUnit.Framework;
 using Utils;
 
-namespace CodexTests.UtilityTests
+namespace CodexTests.BasicTests
 {
     [TestFixture]
     public class DiscordBotTests : AutoBootstrapDistTest
     {
         [Test]
-        [Ignore("Used for debugging bots")]
         public void BotRewardTest()
         {
             var myAccount = EthAccount.GenerateNew();
 
-            var sellerInitialBalance = 234.TstWei();
-            var buyerInitialBalance = 100000.TstWei();
+            var sellerInitialBalance = 234.TestTokens();
+            var buyerInitialBalance = 100000.TestTokens();
             var fileSize = 11.MB();
 
             var geth = Ci.StartGethNode(s => s.IsMiner().WithName("disttest-geth"));
@@ -58,7 +57,7 @@ namespace CodexTests.UtilityTests
 
             for (var i = 0; i < numberOfHosts; i++)
             {
-                var seller = StartCodex(s => s
+                var seller = AddCodex(s => s
                     .WithName("Seller")
                     .WithLogLevel(CodexLogLevel.Trace, new CodexLogCustomTopics(CodexLogLevel.Error, CodexLogLevel.Error, CodexLogLevel.Warn)
                     {
@@ -74,15 +73,15 @@ namespace CodexTests.UtilityTests
                 var availability = new StorageAvailability(
                     totalSpace: 10.GB(),
                     maxDuration: TimeSpan.FromMinutes(30),
-                    minPriceForTotalSpace: 1.TstWei(),
-                    maxCollateral: 20.TstWei()
+                    minPriceForTotalSpace: 1.TestTokens(),
+                    maxCollateral: 20.TestTokens()
                 );
                 seller.Marketplace.MakeStorageAvailable(availability);
             }
 
             var testFile = GenerateTestFile(fileSize);
 
-            var buyer = StartCodex(s => s
+            var buyer = AddCodex(s => s
                 .WithName("Buyer")
                 .EnableMarketplace(geth, contracts, m => m
                     .WithAccount(myAccount)
@@ -92,8 +91,8 @@ namespace CodexTests.UtilityTests
 
             var purchase = new StoragePurchaseRequest(contentId)
             {
-                PricePerSlotPerSecond = 2.TstWei(),
-                RequiredCollateral = 10.TstWei(),
+                PricePerSlotPerSecond = 2.TestTokens(),
+                RequiredCollateral = 10.TestTokens(),
                 MinRequiredNumberOfNodes = 5,
                 NodeFailureTolerance = 2,
                 ProofProbability = 5,

Tests/CodexTests/BasicTests/ExampleTests.cs

@@ -13,7 +13,7 @@ namespace CodexTests.BasicTests
         [Test]
         public void CodexLogExample()
         {
-            var primary = StartCodex(s => s.WithLogLevel(CodexLogLevel.Trace, new CodexLogCustomTopics(CodexLogLevel.Warn, CodexLogLevel.Warn)));
+            var primary = AddCodex(s => s.WithLogLevel(CodexLogLevel.Trace, new CodexLogCustomTopics(CodexLogLevel.Warn, CodexLogLevel.Warn)));
 
             var cid = primary.UploadFile(GenerateTestFile(5.MB()));
 
@@ -28,8 +28,8 @@ namespace CodexTests.BasicTests
         [Test]
         public void TwoMetricsExample()
         {
-            var group = StartCodex(2, s => s.EnableMetrics());
-            var group2 = StartCodex(2, s => s.EnableMetrics());
+            var group = AddCodex(2, s => s.EnableMetrics());
+            var group2 = AddCodex(2, s => s.EnableMetrics());
 
             var primary = group[0];
             var secondary = group[1];
@@ -45,9 +45,6 @@ namespace CodexTests.BasicTests
 
             metrics[0].AssertThat("libp2p_peers", Is.EqualTo(1));
             metrics[1].AssertThat("libp2p_peers", Is.EqualTo(1));
-
-            LogNodeStatus(primary, metrics[0]);
-            LogNodeStatus(primary2, metrics[1]);
         }
 
         [Test]

Tests/CodexTests/BasicTests/MarketplaceTests.cs

@@ -13,15 +13,15 @@ namespace CodexTests.BasicTests
         [Test]
         public void MarketplaceExample()
         {
-            var hostInitialBalance = 234.TstWei();
-            var clientInitialBalance = 100000.TstWei();
+            var hostInitialBalance = 234.TestTokens();
+            var clientInitialBalance = 100000.TestTokens();
             var fileSize = 10.MB();
 
             var geth = Ci.StartGethNode(s => s.IsMiner().WithName("disttest-geth"));
             var contracts = Ci.StartCodexContracts(geth);
             
             var numberOfHosts = 5;
-            var hosts = StartCodex(numberOfHosts, s => s
+            var hosts = AddCodex(numberOfHosts, s => s
                 .WithName("Host")
                 .WithLogLevel(CodexLogLevel.Trace, new CodexLogCustomTopics(CodexLogLevel.Error, CodexLogLevel.Error, CodexLogLevel.Warn)
                 {
@@ -33,7 +33,7 @@ namespace CodexTests.BasicTests
                     .AsStorageNode()
                     .AsValidator()));
 
-            var expectedHostBalance = (numberOfHosts * hostInitialBalance.TstWei).TstWei();
+            var expectedHostBalance = (numberOfHosts * hostInitialBalance.Amount).TestTokens();
             foreach (var host in hosts)
             {
                 AssertBalance(contracts, host, Is.EqualTo(expectedHostBalance));
@@ -41,15 +41,15 @@ namespace CodexTests.BasicTests
                 var availability = new StorageAvailability(
                     totalSpace: 10.GB(),
                     maxDuration: TimeSpan.FromMinutes(30),
-                    minPriceForTotalSpace: 1.TstWei(),
-                    maxCollateral: 20.TstWei()
+                    minPriceForTotalSpace: 1.TestTokens(),
+                    maxCollateral: 20.TestTokens()
                 );
                 host.Marketplace.MakeStorageAvailable(availability);
             }
 
             var testFile = GenerateTestFile(fileSize);
 
-            var client = StartCodex(s => s
+            var client = AddCodex(s => s
                 .WithName("Client")
                 .EnableMarketplace(geth, contracts, m => m
                     .WithInitial(10.Eth(), clientInitialBalance)));
@@ -60,8 +60,8 @@ namespace CodexTests.BasicTests
 
             var purchase = new StoragePurchaseRequest(contentId)
             {
-                PricePerSlotPerSecond = 2.TstWei(),
-                RequiredCollateral = 10.TstWei(),
+                PricePerSlotPerSecond = 2.TestTokens(),
+                RequiredCollateral = 10.TestTokens(),
                 MinRequiredNumberOfNodes = 5,
                 NodeFailureTolerance = 2,
                 ProofProbability = 5,
@@ -85,46 +85,6 @@ namespace CodexTests.BasicTests
             Assert.That(contracts.GetRequestState(request), Is.EqualTo(RequestState.Finished));
         }
 
-        [Test]
-        public void CanDownloadContentFromContractCid()
-        {
-            var fileSize = 10.MB();
-            var geth = Ci.StartGethNode(s => s.IsMiner().WithName("disttest-geth"));
-            var contracts = Ci.StartCodexContracts(geth);
-            var testFile = GenerateTestFile(fileSize);
-
-            var client = StartCodex(s => s
-                .WithName("Client")
-                .EnableMarketplace(geth, contracts, m => m
-                    .WithInitial(10.Eth(), 10.Tst())));
-
-            var uploadCid = client.UploadFile(testFile);
-
-            var purchase = new StoragePurchaseRequest(uploadCid)
-            {
-                PricePerSlotPerSecond = 2.TstWei(),
-                RequiredCollateral = 10.TstWei(),
-                MinRequiredNumberOfNodes = 5,
-                NodeFailureTolerance = 2,
-                ProofProbability = 5,
-                Duration = TimeSpan.FromMinutes(5),
-                Expiry = TimeSpan.FromMinutes(4)
-            };
-
-            var purchaseContract = client.Marketplace.RequestStorage(purchase);
-            var contractCid = purchaseContract.ContentId;
-            Assert.That(uploadCid.Id, Is.Not.EqualTo(contractCid.Id));
-
-            // Download both from client.
-            testFile.AssertIsEqual(client.DownloadContent(uploadCid));
-            testFile.AssertIsEqual(client.DownloadContent(contractCid));
-
-            // Download both from another node.
-            var downloader = StartCodex(s => s.WithName("Downloader"));
-            testFile.AssertIsEqual(downloader.DownloadContent(uploadCid));
-            testFile.AssertIsEqual(downloader.DownloadContent(contractCid));
-        }
-
         private void WaitForAllSlotFilledEvents(ICodexContracts contracts, StoragePurchaseRequest purchase, IGethNode geth)
         {
             Time.Retry(() =>
@@ -132,10 +92,10 @@ namespace CodexTests.BasicTests
                 var blockRange = geth.ConvertTimeRangeToBlockRange(GetTestRunTimeRange());
                 var slotFilledEvents = contracts.GetSlotFilledEvents(blockRange);
 
-                var msg = $"SlotFilledEvents: {slotFilledEvents.Length} - NumSlots: {purchase.MinRequiredNumberOfNodes}";
-                Debug(msg);
-                if (slotFilledEvents.Length != purchase.MinRequiredNumberOfNodes) throw new Exception(msg);
-            }, purchase.Expiry + TimeSpan.FromSeconds(10), TimeSpan.FromSeconds(5), "Checking SlotFilled events");
+                Log($"SlotFilledEvents: {slotFilledEvents.Length} - NumSlots: {purchase.MinRequiredNumberOfNodes}");
+
+                if (slotFilledEvents.Length != purchase.MinRequiredNumberOfNodes) throw new Exception();
+            }, Convert.ToInt32(purchase.Duration.TotalSeconds / 5) + 10, TimeSpan.FromSeconds(5), "Checking SlotFilled events");
         }
 
         private void AssertStorageRequest(Request request, StoragePurchaseRequest purchase, ICodexContracts contracts, ICodexNode buyer)

Tests/CodexTests/BasicTests/NetworkIsolationTest.cs

@@ -3,7 +3,7 @@ using DistTestCore;
 using NUnit.Framework;
 using Utils;
 
-namespace CodexTests.UtilityTests
+namespace CodexTests.BasicTests
 {
     // Warning!
     // This is a test to check network-isolation in the test-infrastructure.
@@ -19,7 +19,7 @@ namespace CodexTests.UtilityTests
         {
             node = Ci.StartCodexNode();
 
-            Time.WaitUntil(() => node == null, TimeSpan.FromMinutes(5), TimeSpan.FromSeconds(5), nameof(SetUpANodeAndWait));
+            Time.WaitUntil(() => node == null, TimeSpan.FromMinutes(5), TimeSpan.FromSeconds(5));
         }
 
         [Test]
@@ -27,7 +27,7 @@ namespace CodexTests.UtilityTests
         {
             var myNode = Ci.StartCodexNode();
 
-            Time.WaitUntil(() => node != null, TimeSpan.FromMinutes(1), TimeSpan.FromSeconds(5), nameof(ForeignNodeConnects));
+            Time.WaitUntil(() => node != null, TimeSpan.FromMinutes(1), TimeSpan.FromSeconds(5));
 
             try
             {

Tests/CodexTests/BasicTests/OneClientTests.cs

@@ -1,4 +1,5 @@
 using CodexPlugin;
+using DistTestCore;
 using NUnit.Framework;
 using Utils;
 
@@ -10,11 +11,21 @@ namespace CodexTests.BasicTests
         [Test]
         public void OneClientTest()
         {
-            var primary = StartCodex();
+            var primary = Ci.StartCodexNode();
 
             PerformOneClientTest(primary);
+        }
 
-            LogNodeStatus(primary);
+        [Test]
+        public void RestartTest()
+        {
+            var primary = Ci.StartCodexNode();
+
+            primary.Stop(waitTillStopped: true);
+
+            primary = Ci.StartCodexNode();
+
+            PerformOneClientTest(primary);
         }
 
         private void PerformOneClientTest(ICodexNode primary)

Tests/CodexTests/BasicTests/ThreeClientTest.cs

@@ -1,5 +1,4 @@
-using CodexPlugin;
-using NUnit.Framework;
+using NUnit.Framework;
 using Utils;
 
 namespace CodexTests.BasicTests
@@ -10,8 +9,8 @@ namespace CodexTests.BasicTests
         [Test]
         public void ThreeClient()
         {
-            var primary = StartCodex();
-            var secondary = StartCodex();
+            var primary = AddCodex();
+            var secondary = AddCodex();
 
             var testFile = GenerateTestFile(10.MB());
 
@@ -21,34 +20,5 @@ namespace CodexTests.BasicTests
 
             testFile.AssertIsEqual(downloadedFile);
         }
-
-        [Test]
-        public void DownloadingUnknownCidDoesNotCauseCrash()
-        {
-            var node = StartCodex(2).First();
-
-            var unknownCid = new ContentId("zDvZRwzkzHsok3Z8yMoiXE9EDBFwgr8WygB8s4ddcLzzSwwXAxLZ");
-
-            try
-            {
-                node.DownloadContent(unknownCid);
-            }
-            catch (Exception ex)
-            {
-                if (!ex.Message.StartsWith("Retry 'DownloadFile' timed out"))
-                {
-                    throw;
-                }
-            }
-
-            // Check that the node stays alive for at least another 5 minutes.
-            var start = DateTime.UtcNow;
-            while ((DateTime.UtcNow - start) < TimeSpan.FromMinutes(5))
-            {
-                Thread.Sleep(5000);
-                var info = node.GetDebugInfo();
-                Assert.That(!string.IsNullOrEmpty(info.Id));
-            }
-        }
     }
 }

Tests/CodexTests/BasicTests/TwoClientTests.cs

@@ -10,8 +10,8 @@ namespace CodexTests.BasicTests
         [Test]
         public void TwoClientTest()
         {
-            var uploader = StartCodex(s => s.WithName("Uploader"));
-            var downloader = StartCodex(s => s.WithName("Downloader").WithBootstrapNode(uploader));
+            var uploader = AddCodex(s => s.WithName("Uploader"));
+            var downloader = AddCodex(s => s.WithName("Downloader").WithBootstrapNode(uploader));
 
             PerformTwoClientTest(uploader, downloader);
         }

Tests/CodexTests/CodexDistTest.cs

@@ -6,14 +6,14 @@ using Core;
 using DistTestCore;
 using DistTestCore.Helpers;
 using DistTestCore.Logs;
-using MetricsPlugin;
-using Newtonsoft.Json;
 using NUnit.Framework.Constraints;
 
 namespace CodexTests
 {
     public class CodexDistTest : DistTest
     {
+        private readonly Dictionary<TestLifecycle, List<ICodexNode>> onlineCodexNodes = new Dictionary<TestLifecycle, List<ICodexNode>>();
+
         public CodexDistTest()
         {
             ProjectPlugin.Load<CodexPlugin.CodexPlugin>();
@@ -29,29 +29,39 @@ namespace CodexTests
             localBuilder.Build();
         }
 
-        public ICodexNode StartCodex()
+        protected override void LifecycleStart(TestLifecycle lifecycle)
         {
-            return StartCodex(s => { });
+            onlineCodexNodes.Add(lifecycle, new List<ICodexNode>());
         }
 
-        public ICodexNode StartCodex(Action<ICodexSetup> setup)
+        protected override void LifecycleStop(TestLifecycle lifecycle)
         {
-            return StartCodex(1, setup)[0];
+            onlineCodexNodes.Remove(lifecycle);
         }
 
-        public ICodexNodeGroup StartCodex(int numberOfNodes)
+        public ICodexNode AddCodex()
         {
-            return StartCodex(numberOfNodes, s => { });
+            return AddCodex(s => { });
         }
 
-        public ICodexNodeGroup StartCodex(int numberOfNodes, Action<ICodexSetup> setup)
+        public ICodexNode AddCodex(Action<ICodexSetup> setup)
+        {
+            return AddCodex(1, setup)[0];
+        }
+
+        public ICodexNodeGroup AddCodex(int numberOfNodes)
+        {
+            return AddCodex(numberOfNodes, s => { });
+        }
+
+        public ICodexNodeGroup AddCodex(int numberOfNodes, Action<ICodexSetup> setup)
         {
             var group = Ci.StartCodexNodes(numberOfNodes, s =>
             {
                 setup(s);
                 OnCodexSetup(s);
             });
-
+            onlineCodexNodes[Get()].AddRange(group);
             return group;
         }
 
@@ -65,6 +75,11 @@ namespace CodexTests
             return new PeerDownloadTestHelpers(GetTestLog(), Get().GetFileManager());
         }
 
+        public IEnumerable<ICodexNode> GetAllOnlineCodexNodes()
+        {
+            return onlineCodexNodes[Get()];
+        }
+
         public void AssertBalance(ICodexContracts contracts, ICodexNode codexNode, Constraint constraint, string msg = "")
         {
             AssertHelpers.RetryAssert(constraint, () => contracts.GetTestTokenBalance(codexNode), nameof(AssertBalance) + msg);
@@ -84,29 +99,17 @@ namespace CodexTests
             log.AssertLogDoesNotContain("ERR ");
         }
 
-        public void LogNodeStatus(ICodexNode node, IMetricsAccess? metrics = null)
-        {
-            Log("Status for " + node.GetName() + Environment.NewLine +
-                GetBasicNodeStatus(node));
-        }
-
-        private string GetBasicNodeStatus(ICodexNode node)
-        {
-            return JsonConvert.SerializeObject(node.GetDebugInfo(), Formatting.Indented) + Environment.NewLine +
-                node.Space().ToString() + Environment.NewLine;
-        }
-
-        // Disabled for now: Makes huge log files!
-        //private string GetNodeMetrics(IMetricsAccess? metrics)
-        //{
-        //    if (metrics == null) return "No metrics enabled";
-        //    var m = metrics.GetAllMetrics();
-        //    if (m == null) return "No metrics received";
-        //    return m.AsCsv();
-        //}
-
         protected virtual void OnCodexSetup(ICodexSetup setup)
         {
         }
+
+        protected override void CollectStatusLogData(TestLifecycle lifecycle, Dictionary<string, string> data)
+        {
+            var nodes = onlineCodexNodes[lifecycle];
+            var upload = nodes.Select(n => n.TransferSpeeds.GetUploadSpeed()).ToList()!.OptionalAverage();
+            var download = nodes.Select(n => n.TransferSpeeds.GetDownloadSpeed()).ToList()!.OptionalAverage();
+            if (upload != null) data.Add("avgupload", upload.ToString());
+            if (download != null) data.Add("avgdownload", download.ToString());
+        }
     }
 }

Tests/CodexTests/DownloadConnectivityTests/FullyConnectedDownloadTests.cs

@@ -1,5 +1,4 @@
 using CodexContractsPlugin;
-using CodexPlugin;
 using GethPlugin;
 using NUnit.Framework;
 using Utils;
@@ -12,9 +11,9 @@ namespace CodexTests.DownloadConnectivityTests
         [Test]
         public void MetricsDoesNotInterfereWithPeerDownload()
         {
-            var nodes = StartCodex(2, s => s.EnableMetrics());
+            AddCodex(2, s => s.EnableMetrics());
 
-            AssertAllNodesConnected(nodes);
+            AssertAllNodesConnected();
         }
 
         [Test]
@@ -22,10 +21,10 @@ namespace CodexTests.DownloadConnectivityTests
         {
             var geth = Ci.StartGethNode(s => s.IsMiner());
             var contracts = Ci.StartCodexContracts(geth);
-            var nodes = StartCodex(2, s => s.EnableMarketplace(geth, contracts, m => m
-                .WithInitial(10.Eth(), 1000.TstWei())));
+            AddCodex(2, s => s.EnableMarketplace(geth, contracts, m => m
+                .WithInitial(10.Eth(), 1000.TestTokens())));
 
-            AssertAllNodesConnected(nodes);
+            AssertAllNodesConnected();
         }
 
         [Test]
@@ -34,14 +33,14 @@ namespace CodexTests.DownloadConnectivityTests
             [Values(2, 5)] int numberOfNodes,
             [Values(1, 10)] int sizeMBs)
         {
-            var nodes = StartCodex(numberOfNodes);
+            AddCodex(numberOfNodes);
 
-            AssertAllNodesConnected(nodes, sizeMBs);
+            AssertAllNodesConnected(sizeMBs);
         }
 
-        private void AssertAllNodesConnected(IEnumerable<ICodexNode> nodes, int sizeMBs = 10)
+        private void AssertAllNodesConnected(int sizeMBs = 10)
         {
-            CreatePeerDownloadTestHelpers().AssertFullDownloadInterconnectivity(nodes, sizeMBs.MB());
+            CreatePeerDownloadTestHelpers().AssertFullDownloadInterconnectivity(GetAllOnlineCodexNodes(), sizeMBs.MB());
         }
     }
 }

Tests/CodexTests/PeerDiscoveryTests/LayeredDiscoveryTests.cs

@@ -1,5 +1,4 @@
-using CodexPlugin;
-using NUnit.Framework;
+using NUnit.Framework;
 
 namespace CodexTests.PeerDiscoveryTests
 {
@@ -9,24 +8,24 @@ namespace CodexTests.PeerDiscoveryTests
         [Test]
         public void TwoLayersTest()
         {
-            var root = StartCodex();
-            var l1Source = StartCodex(s => s.WithBootstrapNode(root));
-            var l1Node = StartCodex(s => s.WithBootstrapNode(root));
-            var l2Target = StartCodex(s => s.WithBootstrapNode(l1Node));
+            var root = AddCodex();
+            var l1Source = AddCodex(s => s.WithBootstrapNode(root));
+            var l1Node = AddCodex(s => s.WithBootstrapNode(root));
+            var l2Target = AddCodex(s => s.WithBootstrapNode(l1Node));
 
-            AssertAllNodesConnected(root, l1Source, l1Node, l2Target);
+            AssertAllNodesConnected();
         }
 
         [Test]
         public void ThreeLayersTest()
         {
-            var root = StartCodex();
-            var l1Source = StartCodex(s => s.WithBootstrapNode(root));
-            var l1Node = StartCodex(s => s.WithBootstrapNode(root));
-            var l2Node = StartCodex(s => s.WithBootstrapNode(l1Node));
-            var l3Target = StartCodex(s => s.WithBootstrapNode(l2Node));
+            var root = AddCodex();
+            var l1Source = AddCodex(s => s.WithBootstrapNode(root));
+            var l1Node = AddCodex(s => s.WithBootstrapNode(root));
+            var l2Node = AddCodex(s => s.WithBootstrapNode(l1Node));
+            var l3Target = AddCodex(s => s.WithBootstrapNode(l2Node));
 
-            AssertAllNodesConnected(root, l1Source, l1Node, l2Node, l3Target);
+            AssertAllNodesConnected();
         }
 
         [TestCase(3)]
@@ -34,22 +33,18 @@ namespace CodexTests.PeerDiscoveryTests
         [TestCase(10)]
         public void NodeChainTest(int chainLength)
         {
-            var nodes = new List<ICodexNode>();
-            var node = StartCodex();
-            nodes.Add(node);    
-
+            var node = AddCodex();
             for (var i = 1; i < chainLength; i++)
             {
-                node = StartCodex(s => s.WithBootstrapNode(node));
-                nodes.Add(node);
+                node = AddCodex(s => s.WithBootstrapNode(node));
             }
 
-            AssertAllNodesConnected(nodes.ToArray());
+            AssertAllNodesConnected();
         }
 
-        private void AssertAllNodesConnected(params ICodexNode[] nodes)
+        private void AssertAllNodesConnected()
         {
-            CreatePeerConnectionTestHelpers().AssertFullyConnected(nodes);
+            CreatePeerConnectionTestHelpers().AssertFullyConnected(GetAllOnlineCodexNodes());
         }
     }
 }

Tests/CodexTests/PeerDiscoveryTests/PeerDiscoveryTests.cs

@@ -12,7 +12,7 @@ namespace CodexTests.PeerDiscoveryTests
         public void CanReportUnknownPeerId()
         {
             var unknownId = "16Uiu2HAkv2CHWpff3dj5iuVNERAp8AGKGNgpGjPexJZHSqUstfsK";
-            var node = StartCodex();
+            var node = AddCodex();
 
             var result = node.GetDebugPeer(unknownId);
             Assert.That(result.IsPeerFound, Is.False);
@@ -21,9 +21,9 @@ namespace CodexTests.PeerDiscoveryTests
         [Test]
         public void MetricsDoesNotInterfereWithPeerDiscovery()
         {
-            var nodes = StartCodex(2, s => s.EnableMetrics());
+            AddCodex(2, s => s.EnableMetrics());
 
-            AssertAllNodesConnected(nodes);
+            AssertAllNodesConnected();
         }
 
         [Test]
@@ -31,10 +31,10 @@ namespace CodexTests.PeerDiscoveryTests
         {
             var geth = Ci.StartGethNode(s => s.IsMiner());
             var contracts = Ci.StartCodexContracts(geth);
-            var nodes = StartCodex(2, s => s.EnableMarketplace(geth, contracts, m => m
-                .WithInitial(10.Eth(), 1000.TstWei())));
+            AddCodex(2, s => s.EnableMarketplace(geth, contracts, m => m
+                .WithInitial(10.Eth(), 1000.TestTokens())));
 
-            AssertAllNodesConnected(nodes);
+            AssertAllNodesConnected();
         }
 
         [TestCase(2)]
@@ -42,15 +42,16 @@ namespace CodexTests.PeerDiscoveryTests
         [TestCase(10)]
         public void VariableNodes(int number)
         {
-            var nodes = StartCodex(number);
+            AddCodex(number);
 
-            AssertAllNodesConnected(nodes);
+            AssertAllNodesConnected();
         }
 
-        private void AssertAllNodesConnected(IEnumerable<ICodexNode> nodes)
+        private void AssertAllNodesConnected()
         {
-            CreatePeerConnectionTestHelpers().AssertFullyConnected(nodes);
-            CheckRoutingTable(nodes);
+            var allNodes = GetAllOnlineCodexNodes();
+            CreatePeerConnectionTestHelpers().AssertFullyConnected(allNodes);
+            CheckRoutingTable(allNodes);
         }
 
         private void CheckRoutingTable(IEnumerable<ICodexNode> allNodes)

Tests/CodexTests/UtilityTests/ClusterSpeedTests.cs

@@ -1,84 +0,0 @@
-using DistTestCore;
-using Logging;
-using NUnit.Framework;
-using Utils;
-
-namespace CodexTests.UtilityTests
-{
-    [TestFixture]
-    public class ClusterDiscSpeedTests : DistTest
-    {
-        private readonly Random random = new Random();
-
-        [Test]
-        [Combinatorial]
-        [Ignore("Used to measure disc io speeds in cluster.")]
-        public void DiscSpeedTest(
-            [Values(1, 10, 100, 1024, 1024 * 10, 1024 * 100, 1024 * 1024)] int bufferSizeKb
-        )
-        {
-            long targetSize = (long)(1024 * 1024 * 1024) * 2;
-            long bufferSizeBytes = (long)bufferSizeKb * 1024;
-
-            var filename = nameof(DiscSpeedTest);
-
-            Thread.Sleep(2000);
-            if (File.Exists(filename)) File.Delete(filename);
-            Thread.Sleep(2000);
-            var writeSpeed = PerformWrite(targetSize, bufferSizeBytes, filename);
-            Thread.Sleep(2000);
-            var readSpeed = PerformRead(targetSize, bufferSizeBytes, filename);
-
-            Log($"Write speed: {writeSpeed} per second.");
-            Log($"Read speed: {readSpeed} per second.");
-        }
-
-        private ByteSize PerformWrite(long targetSize, long bufferSizeBytes, string filename)
-        {
-            long bytesWritten = 0;
-            var buffer = new byte[bufferSizeBytes];
-            random.NextBytes(buffer);
-
-            var sw = Stopwatch.Begin(GetTestLog());
-            using (var stream = File.OpenWrite(filename))
-            {
-                while (bytesWritten < targetSize)
-                {
-                    long remaining = targetSize - bytesWritten;
-                    long toWrite = Math.Min(bufferSizeBytes, remaining);
-
-                    stream.Write(buffer, 0, Convert.ToInt32(toWrite));
-                    bytesWritten += toWrite;
-                }
-            }
-            var duration = sw.End("WriteTime");
-            double totalSeconds = duration.TotalSeconds;
-            double totalBytes = bytesWritten;
-            double bytesPerSecond = totalBytes / totalSeconds;
-            return new ByteSize(Convert.ToInt64(bytesPerSecond));
-        }
-
-        private ByteSize PerformRead(long targetSize, long bufferSizeBytes, string filename)
-        {
-            long bytesRead = 0;
-            var buffer = new byte[bufferSizeBytes];
-            var sw = Stopwatch.Begin(GetTestLog());
-            using (var stream = File.OpenRead(filename))
-            {
-                while (bytesRead < targetSize)
-                {
-                    long remaining = targetSize - bytesRead;
-                    long toRead = Math.Min(bufferSizeBytes, remaining);
-
-                    var r = stream.Read(buffer, 0, Convert.ToInt32(toRead));
-                    bytesRead += r;
-                }
-            }
-            var duration = sw.End("ReadTime");
-            double totalSeconds = duration.TotalSeconds;
-            double totalBytes = bytesRead;
-            double bytesPerSecond = totalBytes / totalSeconds;
-            return new ByteSize(Convert.ToInt64(bytesPerSecond));
-        }
-    }
-}

Tests/CodexTests/UtilityTests/LogHelperTests.cs

@@ -1,56 +0,0 @@
-using CodexPlugin;
-using NUnit.Framework;
-using Utils;
-
-namespace CodexTests.UtilityTests
-{
-    [TestFixture]
-    public class LogHelperTests : AutoBootstrapDistTest
-    {
-        [Test]
-        [Ignore("Used to find the most common log messages.")]
-        public void FindMostCommonLogMessages()
-        {
-            var uploader = StartCodex(s => s.WithName("uploader").WithLogLevel(CodexLogLevel.Trace));
-            var downloader = StartCodex(s => s.WithName("downloader").WithLogLevel(CodexLogLevel.Trace));
-
-            var cid = uploader.UploadFile(GenerateTestFile(100.MB()));
-
-            Thread.Sleep(1000);
-            var logStartUtc = DateTime.UtcNow;
-            Thread.Sleep(1000);
-
-            downloader.DownloadContent(cid);
-
-            var map = GetLogMap(downloader, logStartUtc).OrderByDescending(p => p.Value);
-            Log("Downloader - Receive");
-            foreach (var entry in map)
-            {
-                if (entry.Value > 9)
-                {
-                    Log($"'{entry.Key}' = {entry.Value}");
-                }
-            }
-        }
-
-        private Dictionary<string, int> GetLogMap(ICodexNode node, DateTime? startUtc = null)
-        {
-            var log = Ci.DownloadLog(node);
-            var map = new Dictionary<string, int>();
-            log.IterateLines(line =>
-            {
-                var log = CodexLogLine.Parse(line);
-                if (log == null) return;
-
-                if (startUtc.HasValue)
-                {
-                    if (log.TimestampUtc < startUtc) return;
-                }
-
-                if (map.ContainsKey(log.Message)) map[log.Message] += 1;
-                else map.Add(log.Message, 1);
-            });
-            return map;
-        }
-    }
-}

Tests/DistTestCore/Configuration.cs

@@ -24,9 +24,6 @@ namespace DistTestCore
             this.dataFilesPath = dataFilesPath;
         }
 
-        /// <summary>
-        /// Does not override [DontDownloadLogs] attribute.
-        /// </summary>
         public bool AlwaysDownloadContainerLogs { get; set; }
 
         public KubernetesWorkflow.Configuration GetK8sConfiguration(ITimeSet timeSet, string k8sNamespace)
@@ -39,7 +36,7 @@ namespace DistTestCore
             var config = new KubernetesWorkflow.Configuration(
                 kubeConfigFile: kubeConfigFile,
                 operationTimeout: timeSet.K8sOperationTimeout(),
-                retryDelay: timeSet.K8sOperationRetryDelay(),
+                retryDelay: timeSet.WaitForK8sServiceDelay(),
                 kubernetesNamespace: k8sNamespace
             );
 

Tests/DistTestCore/DistTest.cs

@@ -52,7 +52,7 @@ namespace DistTestCore
             {
                 Stopwatch.Measure(fixtureLog, "Global setup", () =>
                 {
-                    globalEntryPoint.Tools.CreateWorkflow().DeleteNamespacesStartingWith(TestNamespacePrefix, wait: true);
+                    globalEntryPoint.Tools.CreateWorkflow().DeleteNamespacesStartingWith(TestNamespacePrefix);
                 });                
             }
             catch (Exception ex)
@@ -72,8 +72,7 @@ namespace DistTestCore
             globalEntryPoint.Decommission(
                 // There shouldn't be any of either, but clean everything up regardless.
                 deleteKubernetesResources: true,
-                deleteTrackedFiles: true,
-                waitTillDone: true
+                deleteTrackedFiles: true
             );
         }
 
@@ -99,7 +98,7 @@ namespace DistTestCore
             }
             catch (Exception ex)
             {
-                fixtureLog.Error("Cleanup failed: " + ex);
+                fixtureLog.Error("Cleanup failed: " + ex.Message);
                 GlobalTestFailure.HasFailed = true;
             }
         }
@@ -186,13 +185,7 @@ namespace DistTestCore
                 lock (lifecycleLock)
                 {
                     var testNamespace = TestNamespacePrefix + Guid.NewGuid().ToString();
-                    var lifecycle = new TestLifecycle(
-                        fixtureLog.CreateTestLog(),
-                        configuration,
-                        GetTimeSet(),
-                        testNamespace,
-                        deployId,
-                        ShouldWaitForCleanup());
+                    var lifecycle = new TestLifecycle(fixtureLog.CreateTestLog(), configuration, GetTimeSet(), testNamespace, deployId);
                     lifecycles.Add(testName, lifecycle);
                     LifecycleStart(lifecycle);
                 }
@@ -215,7 +208,7 @@ namespace DistTestCore
                 IncludeLogsOnTestFailure(lifecycle);
                 LifecycleStop(lifecycle);
                 lifecycle.DeleteAllResources();
-                lifecycles.Remove(GetCurrentTestName());
+                lifecycle = null!;
             });
         }
 
@@ -242,25 +235,10 @@ namespace DistTestCore
             return new DefaultTimeSet();
         }
 
-        private bool ShouldWaitForCleanup()
-        {
-            return CurrentTestMethodHasAttribute<WaitForCleanupAttribute>();
-        }
-
         private bool ShouldUseLongTimeouts()
-        {
-            return CurrentTestMethodHasAttribute<UseLongTimeoutsAttribute>();
-        }
-
-        private bool HasDontDownloadAttribute()
-        {
-            return CurrentTestMethodHasAttribute<DontDownloadLogsAttribute>();
-        }
-
-        private bool CurrentTestMethodHasAttribute<T>() where T : PropertyAttribute
         {
             // Don't be fooled! TestContext.CurrentTest.Test allows you easy access to the attributes of the current test.
-            // But this doesn't work for tests making use of [TestCase] or [Combinatorial]. So instead, we use reflection here to figure out
+            // But this doesn't work for tests making use of [TestCase]. So instead, we use reflection here to figure out
             // if the attribute is present.
             var currentTest = TestContext.CurrentContext.Test;
             var className = currentTest.ClassName;
@@ -269,7 +247,7 @@ namespace DistTestCore
             var testClasses = testAssemblies.SelectMany(a => a.GetTypes()).Where(c => c.FullName == className).ToArray();
             var testMethods = testClasses.SelectMany(c => c.GetMethods()).Where(m => m.Name == methodName).ToArray();
 
-            return testMethods.Any(m => m.GetCustomAttribute<T>() != null);
+            return testMethods.Any(m => m.GetCustomAttribute<UseLongTimeoutsAttribute>() != null);
         }
 
         private void IncludeLogsOnTestFailure(TestLifecycle lifecycle)
@@ -290,10 +268,9 @@ namespace DistTestCore
         private bool ShouldDownloadAllLogs(TestStatus testStatus)
         {
             if (configuration.AlwaysDownloadContainerLogs) return true;
-            if (!IsDownloadingLogsEnabled()) return false;
             if (testStatus == TestStatus.Failed)
             {
-                return true;
+                return IsDownloadingLogsEnabled();
             }
 
             return false;
@@ -311,7 +288,8 @@ namespace DistTestCore
 
         private bool IsDownloadingLogsEnabled()
         {
-            return !HasDontDownloadAttribute();
+            var testProperties = TestContext.CurrentContext.Test.Properties;
+            return !testProperties.ContainsKey(DontDownloadLogsOnFailureAttribute.DontDownloadKey);
         }
     }
 

Tests/DistTestCore/DontDownloadLogsOnFailureAttribute.cs

@@ -3,11 +3,11 @@
 namespace DistTestCore
 {
     [AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
-    public class DontDownloadLogsAttribute : PropertyAttribute
+    public class DontDownloadLogsOnFailureAttribute : PropertyAttribute
     {
         public const string DontDownloadKey = "DontDownloadLogs";
 
-        public DontDownloadLogsAttribute()
+        public DontDownloadLogsOnFailureAttribute()
             : base(DontDownloadKey)
         {
         }

Tests/DistTestCore/Helpers/AssertHelpers.cs

@@ -14,7 +14,7 @@ namespace DistTestCore.Helpers
                 Time.WaitUntil(() => {
                     var c = constraint.Resolve();
                     return c.ApplyTo(actual()).IsSuccess;
-                }, "RetryAssert: " + message);
+                });
             }
             catch (TimeoutException)
             {

Tests/DistTestCore/TestLifecycle.cs

@@ -13,10 +13,10 @@ namespace DistTestCore
         private const string TestsType = "dist-tests";
         private readonly EntryPoint entryPoint;
         private readonly Dictionary<string, string> metadata; 
-        private readonly List<RunningPod> runningContainers = new();
+        private readonly List<RunningContainers> runningContainers = new();
         private readonly string deployId;
 
-        public TestLifecycle(TestLog log, Configuration configuration, ITimeSet timeSet, string testNamespace, string deployId, bool waitForCleanup)
+        public TestLifecycle(TestLog log, Configuration configuration, ITimeSet timeSet, string testNamespace, string deployId)
         {
             Log = log;
             Configuration = configuration;
@@ -27,7 +27,7 @@ namespace DistTestCore
             metadata = entryPoint.GetPluginMetadata();
             CoreInterface = entryPoint.CreateInterface();
             this.deployId = deployId;
-            WaitForCleanup = waitForCleanup;
+
             log.WriteLogTag();
         }
 
@@ -35,15 +35,13 @@ namespace DistTestCore
         public TestLog Log { get; }
         public Configuration Configuration { get; }
         public ITimeSet TimeSet { get; }
-        public bool WaitForCleanup { get; }
         public CoreInterface CoreInterface { get; }
 
         public void DeleteAllResources()
         {
             entryPoint.Decommission(
                 deleteKubernetesResources: true,
-                deleteTrackedFiles: true,
-                waitTillDone: WaitForCleanup
+                deleteTrackedFiles: true
             );
         }
 
@@ -67,12 +65,12 @@ namespace DistTestCore
             return DateTime.UtcNow - TestStart;
         }
 
-        public void OnContainersStarted(RunningPod rc)
+        public void OnContainersStarted(RunningContainers rc)
         {
             runningContainers.Add(rc);
         }
 
-        public void OnContainersStopped(RunningPod rc)
+        public void OnContainersStopped(RunningContainers rc)
         {
             runningContainers.Remove(rc);
         }
@@ -95,20 +93,13 @@ namespace DistTestCore
 
         public void DownloadAllLogs()
         {
-            try
+            foreach (var rc in runningContainers)
             {
-                foreach (var rc in runningContainers)
+                foreach (var c in rc.Containers)
                 {
-                    foreach (var c in rc.Containers)
-                    {
-                        CoreInterface.DownloadLog(c);
-                    }
+                    CoreInterface.DownloadLog(c);
                 }
             }
-            catch (Exception ex)
-            {
-                Log.Error("Exception during log download: " + ex);
-            }
         }
     }
 }

Tests/DistTestCore/WaitForCleanupAttribute.cs

@@ -1,15 +0,0 @@
-using NUnit.Framework;
-
-namespace DistTestCore
-{
-    /// <summary>
-    /// By default, test system does not wait until all resources are destroyed before starting the
-    /// next test. This saves a lot of time but it's not always what you want.
-    /// If you want to be sure the resources of your test are destroyed before the next test starts,
-    /// add this attribute to your test method.
-    /// </summary>
-    [AttributeUsage(AttributeTargets.Method, AllowMultiple = false)]
-    public class WaitForCleanupAttribute : PropertyAttribute
-    {
-    }
-}

Tests/FrameworkTests/CodexContractsPlugin/TestTokenTests.cs

@@ -1,46 +0,0 @@
-using CodexContractsPlugin;
-using NUnit.Framework;
-using System.Numerics;
-
-namespace FrameworkTests.CodexContractsPlugin
-{
-    [TestFixture]
-    public class TestTokenTests
-    {
-        private const decimal factor = 1000000000000000000m;
-
-        [Test]
-        public void RepresentsSmallAmount()
-        {
-            var t = 10.TstWei();
-
-            Assert.That(t.TstWei, Is.EqualTo(new BigInteger(10)));
-            Assert.That(t.Tst, Is.EqualTo(new BigInteger(0)));
-            Assert.That(t.ToString(), Is.EqualTo("10 TSTWEI"));
-        }
-
-        [Test]
-        public void RepresentsLargeAmount()
-        {
-            var t = 10.Tst();
-
-            var expected = new BigInteger(10 * factor);
-            Assert.That(t.TstWei, Is.EqualTo(expected));
-            Assert.That(t.Tst, Is.EqualTo(new BigInteger(10)));
-            Assert.That(t.ToString(), Is.EqualTo("10 TST"));
-        }
-
-        [Test]
-        public void RepresentsLongAmount()
-        {
-            var a = 10.Tst();
-            var b = 20.TstWei();
-            var t = a + b;
-
-            var expected = new BigInteger((10 * factor) + 20);
-            Assert.That(t.TstWei, Is.EqualTo(expected));
-            Assert.That(t.Tst, Is.EqualTo(new BigInteger(10)));
-            Assert.That(t.ToString(), Is.EqualTo("10 TST + 20 TSTWEI"));
-        }
-    }
-}

Tests/FrameworkTests/FrameworkTests.csproj

@@ -16,7 +16,6 @@
   <ItemGroup>
     <ProjectReference Include="..\..\Framework\NethereumWorkflow\NethereumWorkflow.csproj" />
     <ProjectReference Include="..\..\Framework\Utils\Utils.csproj" />
-    <ProjectReference Include="..\..\ProjectPlugins\CodexContractsPlugin\CodexContractsPlugin.csproj" />
   </ItemGroup>
 
 </Project>

Tools/BiblioTech/AdminChecker.cs

@@ -24,7 +24,7 @@ namespace BiblioTech
 
         public bool IsAdminChannel(IChannel channel)
         {
-            return channel.Id == Program.Config.AdminChannelId;
+            return channel.Name == Program.Config.AdminChannelName;
         }
 
         public ISocketMessageChannel GetAdminChannel()
@@ -45,7 +45,7 @@ namespace BiblioTech
         private void UpdateAdminIds()
         {
             lastUpdate = DateTime.UtcNow;
-            var adminRole = guild.Roles.Single(r => r.Id == Program.Config.AdminRoleId);
+            var adminRole = guild.Roles.Single(r => r.Name == Program.Config.AdminRoleName);
             adminIds = adminRole.Members.Select(m => m.Id).ToArray();
         }
     }

Tools/BiblioTech/CommandHandler.cs

@@ -22,7 +22,7 @@ namespace BiblioTech
 
         private async Task Client_Ready()
         {
-            var guild = client.Guilds.Single(g => g.Id == Program.Config.ServerId);
+            var guild = client.Guilds.Single(g => g.Name == Program.Config.ServerName);
             Program.AdminChecker.SetGuild(guild);
             Program.Log.Log($"Initializing for guild: '{guild.Name}'");
 

Tools/BiblioTech/Commands/GetBalanceCommand.cs

@@ -32,7 +32,7 @@ namespace BiblioTech.Commands
             }
 
             var eth = 0.Eth();
-            var testTokens = 0.TstWei();
+            var testTokens = 0.TestTokens();
 
             await Task.Run(() =>
             {

Tools/BiblioTech/Commands/MarketCommand.cs

@@ -1,7 +1,6 @@
 using BiblioTech.Options;
 using DiscordRewards;
 using System.Globalization;
-using Utils;
 
 namespace BiblioTech.Commands
 {
@@ -31,13 +30,7 @@ namespace BiblioTech.Commands
 
         private string[] GetInsight(MarketAverage avg)
         {
-            var timeRange = TimeSpan.FromSeconds(avg.TimeRangeSeconds);
-            var headerLine = $"[Last {Time.FormatDuration(timeRange)}] ({avg.NumberOfFinished} Contracts finished)";
-
-            if (avg.NumberOfFinished == 0)
-            {
-                return new[] { headerLine }; 
-            }
+            var headerLine = $"[{avg.Title}]";
 
             return new[]
             {