status-im
/
contracts
mirror of https://github.com/status-im/contracts.git
2
0
Fork 0
Code Issues Projects Releases Wiki Activity

more comments

This commit is contained in:
Ricardo Guilherme Schmidt 2018-03-21 23:32:56 -03:00
parent 905aff6485
commit 7b179ec04c
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
contracts/identity/Identity.sol
View File

@ -184,11 +184,11 @@ contract Identity is ERC725, ERC735 {
{ {
uint256 requiredKey = _to == address(this) ? MANAGEMENT_KEY : ACTION_KEY; uint256 requiredKey = _to == address(this) ? MANAGEMENT_KEY : ACTION_KEY;
if (minimumApprovalsByKeyPurpose[requiredKey] == 1) { if (minimumApprovalsByKeyPurpose[requiredKey] == 1) {
executionId = nonce; executionId = nonce; //(?) useless in this case
nonce++; nonce++; //(?) should increment
require(isKeyPurpose(bytes32(msg.sender), requiredKey)); require(isKeyPurpose(bytes32(msg.sender), requiredKey));
_to.call.value(_value)(_data); _to.call.value(_value)(_data); //(?) success not used
emit Executed(executionId, _to, _value, _data); emit Executed(executionId, _to, _value, _data); //no information on success
} else { } else {
executionId = _execute(_to, _value, _data); executionId = _execute(_to, _value, _data);
approve(executionId, true); approve(executionId, true);