From 7b179ec04cf9ec73b7e2772d074dc6b079de7a9c Mon Sep 17 00:00:00 2001 From: Ricardo Guilherme Schmidt <3esmit@gmail.com> Date: Wed, 21 Mar 2018 23:32:56 -0300 Subject: [PATCH] more comments --- contracts/identity/Identity.sol | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contracts/identity/Identity.sol b/contracts/identity/Identity.sol index 36eacab..be7a6c1 100644 --- a/contracts/identity/Identity.sol +++ b/contracts/identity/Identity.sol @@ -184,11 +184,11 @@ contract Identity is ERC725, ERC735 { { uint256 requiredKey = _to == address(this) ? MANAGEMENT_KEY : ACTION_KEY; if (minimumApprovalsByKeyPurpose[requiredKey] == 1) { - executionId = nonce; - nonce++; + executionId = nonce; //(?) useless in this case + nonce++; //(?) should increment require(isKeyPurpose(bytes32(msg.sender), requiredKey)); - _to.call.value(_value)(_data); - emit Executed(executionId, _to, _value, _data); + _to.call.value(_value)(_data); //(?) success not used + emit Executed(executionId, _to, _value, _data); //no information on success } else { executionId = _execute(_to, _value, _data); approve(executionId, true);