Commit Graph

234 Commits

Author SHA1 Message Date
Frank Schröder 12216583a1 New config parser, HCL support, multiple bind addrs (#3480)
* new config parser for agent

This patch implements a new config parser for the consul agent which
makes the following changes to the previous implementation:

 * add HCL support
 * all configuration fragments in tests and for default config are
   expressed as HCL fragments
 * HCL fragments can be provided on the command line so that they
   can eventually replace the command line flags.
 * HCL/JSON fragments are parsed into a temporary Config structure
   which can be merged using reflection (all values are pointers).
   The existing merge logic of overwrite for values and append
   for slices has been preserved.
 * A single builder process generates a typed runtime configuration
   for the agent.

The new implementation is more strict and fails in the builder process
if no valid runtime configuration can be generated. Therefore,
additional validations in other parts of the code should be removed.

The builder also pre-computes all required network addresses so that no
address/port magic should be required where the configuration is used
and should therefore be removed.

* Upgrade github.com/hashicorp/hcl to support int64

* improve error messages

* fix directory permission test

* Fix rtt test

* Fix ForceLeave test

* Skip performance test for now until we know what to do

* Update github.com/hashicorp/memberlist to update log prefix

* Make memberlist use the default logger

* improve config error handling

* do not fail on non-existing data-dir

* experiment with non-uniform timeouts to get a handle on stalled leader elections

* Run tests for packages separately to eliminate the spurious port conflicts

* refactor private address detection and unify approach for ipv4 and ipv6.

Fixes #2825

* do not allow unix sockets for DNS

* improve bind and advertise addr error handling

* go through builder using test coverage

* minimal update to the docs

* more coverage tests fixed

* more tests

* fix makefile

* cleanup

* fix port conflicts with external port server 'porter'

* stop test server on error

* do not run api test that change global ENV concurrently with the other tests

* Run remaining api tests concurrently

* no need for retry with the port number service

* monkey patch race condition in go-sockaddr until we understand why that fails

* monkey patch hcl decoder race condidtion until we understand why that fails

* monkey patch spurious errors in strings.EqualFold from here

* add test for hcl decoder race condition. Run with go test -parallel 128

* Increase timeout again

* cleanup

* don't log port allocations by default

* use base command arg parsing to format help output properly

* handle -dc deprecation case in Build

* switch autopilot.max_trailing_logs to int

* remove duplicate test case

* remove unused methods

* remove comments about flag/config value inconsistencies

* switch got and want around since the error message was misleading.

* Removes a stray debug log.

* Removes a stray newline in imports.

* Fixes TestACL_Version8.

* Runs go fmt.

* Adds a default case for unknown address types.

* Reoders and reformats some imports.

* Adds some comments and fixes typos.

* Reorders imports.

* add unix socket support for dns later

* drop all deprecated flags and arguments

* fix wrong field name

* remove stray node-id file

* drop unnecessary patch section in test

* drop duplicate test

* add test for LeaveOnTerm and SkipLeaveOnInt in client mode

* drop "bla" and add clarifying comment for the test

* split up tests to support enterprise/non-enterprise tests

* drop raft multiplier and derive values during build phase

* sanitize runtime config reflectively and add test

* detect invalid config fields

* fix tests with invalid config fields

* use different values for wan sanitiziation test

* drop recursor in favor of recursors

* allow dns_config.udp_answer_limit to be zero

* make sure tests run on machines with multiple ips

* Fix failing tests in a few more places by providing a bind address in the test

* Gets rid of skipped TestAgent_CheckPerformanceSettings and adds case for builder.

* Add porter to server_test.go to make tests there less flaky

* go fmt
2017-09-25 11:40:42 -07:00
Frank Schroeder 9362cbcbc2
Add support to discover public v4 and v6 addresses on AWS (#3471)
Update github.com/hashicorp/go-discover/provider/aws to support the
'addr_type' option which allows detection of private_v4, public_v4 and
public_v6 addresses.

Fixes #3471
2017-09-25 03:16:27 +02:00
James Phillips 6f1d813515
Updates vendor.json using latest vendorfmt. 2017-09-06 07:29:17 -07:00
Seth Vargo 006099be6b
Update vendor to regroup by root commands 2017-09-06 10:20:25 -04:00
James Phillips db99dc48ad
Updates vendor.json for latest vendorfmt changes. 2017-09-05 15:45:16 -07:00
James Phillips 9258506dab Adds simple rate limiting for client agent RPC calls to Consul servers. (#3440)
* Added rate limiting for agent RPC calls.
* Initializes the rate limiter based on the config.
* Adds the rate limiter into the snapshot RPC path.
* Adds unit tests for the RPC rate limiter.
* Groups the RPC limit parameters under "limits" in the config.
* Adds some documentation about the RPC limiter.
* Sends a 429 response when the rate limiter kicks in.
* Adds docs for new telemetry.
* Makes snapshot telemetry look like RPC telemetry and cleans up comments.
2017-09-01 15:02:50 -07:00
Preetha Appan 276f26ea70 Updating vendor directory for raft address provider interface changes 2017-08-30 09:57:48 -05:00
Preetha Appan 30fd0d25a5 Update raft library for windows snapshot fsync fixes. This fixes #3409 2017-08-24 16:44:05 -05:00
Frank Schroeder ad82659eed vendor: upgrade github.com/hashicorp/go-discover
Pull in improved debug logging for AWS
2017-08-23 21:23:34 +02:00
Preetha Appan c9d5e17410 Update serf to pick up fixes for fsyncing snapshots and panic when coordinates are disabled 2017-08-17 16:35:06 -05:00
Preetha Appan 0e73777ce2 Update memberlist for a deadlock fix 2017-08-15 18:07:28 -05:00
Kyle Havlovitz acd3050112
vendor: update github.com/armon/go-metrics 2017-08-08 18:29:27 -07:00
Kyle Havlovitz cf02e3bc22 Merge pull request #3369 from hashicorp/metrics-enhancements
Add support for labels/filters from go-metrics
2017-08-08 13:55:30 -07:00
Kyle Havlovitz ecaf069590
vendor: update github.com/armon/go-metrics 2017-08-08 12:33:47 -07:00
Kyle Havlovitz ce572546e5
vendor: update go-metrics 2017-08-08 01:19:30 -07:00
James Phillips 1eea530ce6
Propagates a better error message from memberlist.
Fixes #3312.
2017-08-07 16:35:57 -07:00
Preetha Appan 454b3a2a61 Pick up raft library change that fsyncs snapshot files correctly 2017-08-04 10:36:41 -05:00
Frank Schroeder 6346ac34cf
vendor: update hashicorp/go-discover to pull in hashicorp/go-discover#7 2017-08-03 21:00:37 +02:00
Frank Schroeder 2fac427cd4 agent: use github.com/hashicorp/go-discover
Replace the provider specific node discovery code
with go-discover to support AWS, Azure and GCE.

Fixes #3282
2017-08-01 11:41:43 +02:00
Frank Schroeder e7285af6cc vendor: add go-discover 2017-08-01 11:41:43 +02:00
Frank Schroeder 02ed39cb2f vendor: drop unused deps for old discover code 2017-08-01 11:41:43 +02:00
Preetha Appan b841c99b87 Govendor update go-memdb and go-immutable-radix to pick up changes for DeletePrefix 2017-07-25 17:28:43 -05:00
Frank Schroeder 748b5b1b00 agent: add dependencies for docker on windows 2017-07-19 12:03:59 +02:00
Frank Schröder a764358729 vendor: do not report appengine packages as missing (#3299) 2017-07-18 21:50:22 -07:00
Frank Schroeder 580c03fabd
vendor: remove unused dependencies from vendor.json 2017-07-19 05:25:08 +02:00
Frank Schroeder 1805b50580
build: add missing dependency for solaris/amd64 2017-07-19 05:19:17 +02:00
Frank Schroeder 2123700056
agent: replace docker check
This patch replaces the Docker client which is used
for health checks with a simplified version tailored
for that purpose.

See #3254
See #3257
Fixes #3270
2017-07-18 20:24:38 +02:00
Frank Schroeder 34df7f59ba
vendor: drop unused dependencies 2017-07-18 20:24:21 +02:00
Frank Schroeder ad9029b017 build: use vendorfmt to make vendor.json more merge friendly 2017-07-18 09:15:25 +02:00
James Phillips a6079d6cee Performs surgery on Docker deps so we can build on Solaris and Windows. (#3288) 2017-07-17 15:34:26 -07:00
James Phillips 31a7701891 Updates memberlist to pick up Lifeguard research findings. (#3287)
See https://www.hashicorp.com/blog/making-gossip-more-robust-with-lifeguard/.
2017-07-17 12:54:17 -07:00
Frank Schroeder 7b675f2710 vendor: drop unused dependencies 2017-07-15 14:35:20 -07:00
Frank Schroeder 249b73c65b
vendor: github.com/Sirupsen -> github.com/sirupsen 2017-07-14 13:07:44 -07:00
Frank Schroeder c4b62ff37f
vendor: update github.com/fsouza/go-dockerclient
Update go-dockerclient and dependant dependencies
to add fix for go-dockerclient#622.

Fixes #3254
2017-07-14 13:07:44 -07:00
Preetha Appan c4e8dfe554 Update raft library to pick up cleanup of temporary snapshot files 2017-07-11 08:22:57 -05:00
Frank Schroeder ba987a4417
vendor: update golang.org/x/sys/unix
Update golang.org/x/sys/unix to add s390 platform files

Fixes #3240
2017-07-07 13:38:44 +02:00
Frank Schroeder be782ae45e Pull in vendor updates 2017-07-07 09:22:34 +02:00
James Phillips 0e7c2f9e7f memberlist: Monkey patch memberlist to fix port 0 behavior.
https://github.com/hashicorp/memberlist/pull/128
2017-07-07 09:22:34 +02:00
Frank Schroeder 8ab88976cf serf: monkey patch data race in github.com/hashicorp/serf
https://github.com/hashicorp/serf/pull/476

This should be replaced when the patch is merged upstream
and the library is upgraded.
2017-07-07 09:22:34 +02:00
Preetha Appan 6d172b7059 Update serf to pull in disk space failure recovery changes 2017-07-06 08:58:42 -05:00
James Phillips ae1c6fd2c0 Bumps Raft library. (#3201)
This picks up the fix for https://github.com/hashicorp/raft/issues/212,
which can cause out-of-date followers to get stuck in a loop trying to
sync because they don't discard old snapshot data.

There's some incidental reordering of the vendor.json since the last
update to that file was merged by hand.
2017-06-27 18:41:00 -07:00
James Phillips 42f60b04bb Revert "discover: move instance discover code into separate package (#3144)" (#3180)
This reverts commit 26bfb2d00a.
2017-06-23 01:38:55 -07:00
James Phillips e4b11682bc Fixes broken HTTP header and method for health checks. (#3178)
* Fixes broken HTTP header and method for health checks.
* Adds a fuzz utility and test to make sure copy is complete.
2017-06-23 01:15:48 -07:00
Kyle Havlovitz da97de42be vendor: update github.com/hashicorp/memberlist (#3176) 2017-06-22 14:44:46 -07:00
Frank Schroeder da01cd112e
vendor: update github.com/hashicorp/go-discover 2017-06-22 12:46:23 +02:00
Frank Schroeder 50e11db5d8
add missing packages
Moving the discover package dependencies out removed
some packages we need.
2017-06-21 11:02:32 +02:00
Frank Schröder 26bfb2d00a discover: move instance discover code into separate package (#3144)
This patch moves the code that discovers instances from metadata
information to github.com/hashicorp/go-discover with
sub-packages for each provider.
2017-06-21 10:40:38 +02:00
Kyle Havlovitz 5d99ee80ca Add an option to disable keyring file (#3145)
Also disables keyring file in dev mode.
2017-06-15 15:24:04 -07:00
Frank Schroeder 4403db0d63
vendor: Update github.com/shirou/gopsutil
Pull in fix for data race on host.BootTime.
2017-06-02 07:51:08 +02:00
Frank Schroeder c5ba51db19
vendor: upgrade github.com/armon/go-metrics
Pull in changes to fix race condition for concurrent tests.
2017-06-01 23:52:26 +02:00
Frank Schroeder e23cd5acb6
vendor: upgrade github.com/go-ole/go-ole
This replaces the monkey patch for github.com/go-ole/go-ole/pull/144

See #3097
2017-06-01 16:05:24 +02:00
Frank Schroeder 6c0bccbc06
vendor: monkey patch github.com/go-ole/go-ole support for s390x
Remove this once https://github.com/go-ole/go-ole/pull/144 gets
merged.

Fixes #3097
2017-06-01 15:31:29 +02:00
Frank Schroeder 8051d4a1da
Revert "vendor: monkey patch github.com/go-ole/go-ole support for s390x"
This reverts commit 50fe2148a8.
2017-06-01 15:31:02 +02:00
Frank Schroeder 50fe2148a8
vendor: monkey patch github.com/go-ole/go-ole support for s390x
Remove this once https://github.com/go-ole/go-ole/pull/144 gets
merged.
2017-06-01 15:29:47 +02:00
Frank Schroeder c0680660d5
vendor: patch github.com/mitchellh/cli until help output is fixed
We need to init the flagset that cli uses to generate the help
outside of the Run method since Run isn't called anymore for
printing help.
2017-05-31 00:29:29 +02:00
Frank Schroeder d5f87a20cf
vendor: fix data race in github.com/armon/go-metrics/start.go
96 -> 42 data races
2017-05-31 00:29:25 +02:00
Frank Schroeder 3caadb37ac
vendor: update github.com/mitchellh/cli
This pulls in the patch that fixes the nil panic and the
data race in MockUi.
2017-05-31 00:29:25 +02:00
Kyle Havlovitz 62f72f104c Add settings for upshifting to encrypted gossip (#3079) 2017-05-30 08:51:37 -07:00
James Phillips 1021a62ddc
Pulls in Serf logger fix. 2017-05-25 22:02:09 -07:00
James Phillips 9aba84eb1e
Updates Serf to pick up small fixes and coordinate NaN/Inf defenses. 2017-05-25 16:16:37 -07:00
Michael Leow c770d7ef96
vendor: add github.com/Azure/azure-sdk-for-go 2017-05-24 10:15:38 +02:00
Michael Leow 21a12eb50d
vendor: add github.com/Azure/go-autorest/autorest/to 2017-05-24 10:15:38 +02:00
Michael Leow 0b407929a1
vendor: add github.com/Azure/go-autorest/autorest/validation 2017-05-24 10:15:37 +02:00
Michael Leow cbefe75b94
vendor: add github.com/Azure/go-autorest/autorest/azure 2017-05-24 10:15:37 +02:00
Michael Leow c28893f491
vendor: add github.com/Azure/go-autorest/autorest/date 2017-05-24 10:15:37 +02:00
Michael Leow 20c149873b
vendor: add github.com/Azure/go-autorest/autorest 2017-05-24 10:15:37 +02:00
Michael Leow 9d5a016494
vendor: add github.com/dgijalva/jwt-go 2017-05-24 10:15:37 +02:00
Sean Chittenden 41fe2e79cf
Update hashicorp/go-sockaddr to the latest version.
* Adds plural IP helpers (e.g. `GetPrivateIPs`, `GetPublicIPs`)
  hashicorp/go-sockaddr#11
* Adds subnet math hashicorp/go-sockaddr#8
* Fixes helper functions for dual-homed hosts hashicorp/go-sockaddr#10)
2017-05-23 16:47:17 -07:00
Frank Schroeder b36f56dc8e vendor: remove github.com/hashicorp/scada-client 2017-05-22 11:07:46 +02:00
Frank Schroeder 6eba69fbfe agent: drop atlas/scada code 2017-05-10 23:06:36 +02:00
Sean Chittenden dce9da3bb3
Add the minimal fix to restore being able to compile on Illumos.
This brings in the necessary fix to satisfy #2989 without dragging along
additional vendor updates reverted in #3019.
2017-05-09 08:41:44 -07:00
James Phillips cc96f9324c Revert "Fix the build on Illumos." 2017-05-08 20:42:12 -07:00
James Phillips 3d43031fbf
Updates vendored Raft library.
This pulls in https://github.com/hashicorp/raft/pull/207 to get
support for the new-style peers.json recovery file.
2017-05-04 13:27:33 -07:00
Sean Chittenden 35666e8a1c
Fix the build on Illumos.
Update `github.com/docker/docker/pkg/system`.
2017-04-28 17:13:20 -07:00
Frank Schroeder e4b02aca26 vendor: add github.com/pascaldekloe/goe/verify 2017-04-28 15:00:08 -07:00
Kyle Havlovitz ebef78dc71
Vendor the go-rootcerts lib for the client tls options 2017-04-14 13:46:19 -07:00
Seth Vargo 592de89191
Add pkg/errors 2017-03-23 18:41:20 -04:00
Kyle Havlovitz 390f41d8d5
Add advanced autopilot features 2017-03-22 15:25:16 -07:00
James Phillips 5dd60581f1
Updates memberlist to get NACK penalty improvements. 2017-03-17 15:28:12 -07:00
James Phillips f7c5541ed5
Updates memberlist to get new transport interface. 2017-03-16 16:57:28 -07:00
Kyle Havlovitz 07288a20a1
Tweak last_contact health logic for leader 2017-03-15 19:57:54 -07:00
James Phillips 7d4b07956e
Updates AWS Go SDK.
Needed as part of Go 1.8 transition; see https://aws.amazon.com/blogs/developer/aws-sdk-for-go-update-needed-for-go-1-8/.
2017-02-16 23:55:59 -08:00
James Phillips 1f6425124f
Updates hashicorp/go-immutable-radix to pick up leaf panic fixes.
This fixes #2724 by properly tracking leaf updates during very large
delete transactions.
2017-02-13 16:47:49 -08:00
Jeff Mitchell 44733caf5c Update unix dial functions to use DialContext with new go-cleanhttp 2017-02-10 21:11:21 -05:00
James Phillips fe3a4e87a2 Revert "Updates go-cleanhttp to get better tuning for newer Go versions." 2017-02-10 17:12:56 -08:00
James Phillips 43fa3f4d4d
Updates go-cleanhttp to get better tuning for newer Go versions. 2017-02-10 16:39:19 -08:00
James Phillips bc2a45a9de
Updates memberlist and Serf (and adds new dependencies).
This gets a number of improvements:

* Fixed a missing case where gossip would stop flowing to dead nodes for a short while.
* Uses the go-sockaddr library to look for private IP addresses, which prefers non-loopback
  private addresses over loopback ones when trying to automatically determine the advertise address.
* Properly seeds Go's random number generator using the seed library.
* Serf snapshots no longer have the executable bit set on thie file.
2017-02-08 13:56:07 -08:00
Sean Chittenden e4d6687fa2
Update `vendor/vendor.json` to reflect `shiriou/gopsutil#313` being merged. 2017-02-07 22:39:05 -08:00
Kyle Havlovitz a4cb414e58 Merge pull request #2717 from hashicorp/f-cli-rework
Begin centralizing command-line parsing
2017-02-07 21:15:06 -05:00
Sean Chittenden 7d9c9881fc
Update `shirou/gopsutil/313` to pull in lowercased `HostID`s. 2017-02-06 16:27:56 -08:00
Kyle Havlovitz e86ec5b54c
vendor: Add golang-text dependency 2017-02-06 13:52:43 -05:00
James Phillips 0797d4f92b
Updates Serf library to get relay fixes.
https://github.com/hashicorp/serf/pull/447
2017-02-06 08:57:36 -08:00
Sean Chittenden f228812746
Update github.com/shiriou/gopsutil's `vendor.json` entries.
Direct to `master` commit now that
https://github.com/shirou/gopsutil/pull/312 has been merged.
2017-02-03 22:31:51 -08:00
Sean Chittenden abceea206d
Chase an upstream `go fmt` that has been long overdue. 2017-02-03 22:31:11 -08:00
Sean Chittenden 95a8ee35d6
Remove _test.go files from shirou/gopsutil 2017-02-03 22:29:02 -08:00
Sean Chittenden ee8705f549
Add durable HostID generation for Windows.
https://github.com/shirou/gopsutil/pull/312
2017-02-02 16:11:54 -08:00
Kyle Havlovitz ed5bf524ba
Update serf deps 2017-02-01 20:57:37 -05:00
Sean Chittenden 1e5534a27a
Add missing shirou/gopsutils vendor dependencies and files that were reverted 2017-02-01 10:26:00 -08:00
Sean Chittenden 504d16fdb8 Merge branch 'master' into f-gopsutil 2017-02-01 08:44:30 -08:00
Sean Chittenden 18760e1fb5
Reintroduce the necessary vendor bits for per-node IDs
* `shirou/gopsutil`
* `shirou/w32`
2017-02-01 08:36:24 -08:00