Luke Kysow
95096e2c03
peering: retry establishing connection more quickly on certain errors ( #13938 )
...
When we receive a FailedPrecondition error, retry that more quickly
because we expect it will resolve shortly. This is particularly
important in the context of Consul servers behind a load balancer
because when establishing a connection we have to retry until we
randomly land on a leader node.
The default retry backoff goes from 2s, 4s, 8s, etc. which can result in
very long delays quite quickly. Instead, this backoff retries in 8ms
five times, then goes exponentially from there: 16ms, 32ms, ... up to a
max of 8152ms.
2022-07-29 13:04:32 -07:00
Chris S. Kim
7f2732e12c
Ensure connections are closed before WaitGroup marked as done
...
The previous ordering of defers meant the listener's connWG could fire and wake up other goroutines before the connection closed. Unsure if this caused any real bugs but this commit should make the code more correct.
2022-07-29 09:29:13 -04:00
alex
92c615c35f
Merge pull request #13952 from hashicorp/sync-more-acl
...
sync more acl enforcement
2022-07-28 12:31:02 -07:00
Dhia Ayachi
256694b603
inject gateway addons to destination clusters ( #13951 )
2022-07-28 15:17:35 -04:00
acpana
eae4e71492
sync more acl enforcement
...
sync w ent at 32756f7
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
2022-07-28 12:01:52 -07:00
alex
41f3343eac
Merge pull request #13929 from hashicorp/fix-validation
...
[sync] fix empty partitions matching
2022-07-28 10:14:49 -07:00
Evan Culver
d5bd9436d5
ci: Use correct branch name for 1.13 nightly test ( #13945 )
2022-07-28 12:49:15 -04:00
cskh
6640997fc1
fix (cli): import empty directory to kv ( #13939 )
...
* fix (cli): import empty directory to kv
- when import an empty directory like foo/, the import
command will remove the trailing /, making it a
non-directory key.
- This change fixes the bug by adding back the / if
the imported key is an directory
2022-07-28 10:54:25 -04:00
Jared Kirschner
08fcdad0f6
Merge pull request #13917 from hashicorp/docs/show-cli-cmd-options-before-general-options-2
...
docs: show CLI cmd-specific opts before general opts
2022-07-27 18:55:06 -04:00
Jared Kirschner
95c72164a4
docs: show CLI cmd-specific opts before general opts
...
Applied to all remaining CLI commands.
2022-07-27 15:50:51 -07:00
Ashwin Venkatesh
eef9edaed9
Add peer counts to emitted metrics. ( #13930 )
2022-07-27 18:34:04 -04:00
Luke Kysow
465a9801e1
Merge pull request #13924 from hashicorp/lkysow/util-metric-peering
...
peering: don't track imported services/nodes in usage
2022-07-27 14:49:55 -07:00
acpana
6033584349
use EqualPartitions
...
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
2022-07-27 14:48:30 -07:00
acpana
0351ca5136
better fix
...
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
2022-07-27 14:28:08 -07:00
Evan Culver
3f876b85d9
ci: Add nightly test workflow for 1.13, remove 1.10 ( #13927 )
...
Signed-off-by: Evan Culver <eculver@hashicorp.com>
2022-07-27 16:59:00 -04:00
acpana
8b2ef80336
sync w ent
...
Signed-off-by: acpana <8968914+acpana@users.noreply.github.com>
2022-07-27 11:41:39 -07:00
Chris S. Kim
0999e05a7d
Reduce arm64 flakes for TestConnectCA_ConfigurationSet_ChangeKeyConfig_Primary
...
There were 16 combinations of tests but 4 of them were duplicates since the default key type and bits were "ec" and 256. That entry was commented out to reduce the subtest count to 12.
testrpc.WaitForLeader was failing on arm64 environments; the cause is unknown but it might be due to the environment being flooded with parallel tests making RPC calls. The RPC polling+retry was replaced with a simpler check for leadership based on raft.
2022-07-27 13:54:34 -04:00
Chris S. Kim
8ead1caf53
Retry checks for virtual IP metadata
2022-07-27 13:54:34 -04:00
Chris S. Kim
62ed0250c3
Sort slice of ServiceNames deterministically
2022-07-27 13:54:34 -04:00
Chris S. Kim
a5fe2125e9
Remove unnecessary goroutine in flaky test
...
The watch is established in a background goroutine and the first assertion proves that the watcher is active so there is no reason for the update to happen in a racy goroutine.
Note that this does not completely remove the race condition as the first call to testGetConfigValTimeout could time out before a config is returned.
2022-07-27 13:54:34 -04:00
Luke Kysow
740d54e730
peering: don't track imported services/nodes in usage
...
Services/nodes that are imported from other peers are stored in
state. We don't want to count those as part of our own cluster's usage.
2022-07-27 09:08:51 -07:00
cskh
4e292b7b72
chore: clarify the error message: service.service must not be empty ( #13907 )
...
- when register service using catalog endpoint, the key of service
name actually should be "service". Add this information to the
error message will help user to quickly fix in the request.
2022-07-27 10:16:46 -04:00
Jared Kirschner
9080bef4a4
Merge pull request #13914 from hashicorp/docs/remove-comparisons-from-ref-docs
...
docs: remove comparative info from ref docs site
2022-07-27 02:42:41 -04:00
Jared Kirschner
bcbe9cc06d
Merge pull request #12903 from hashicorp/docs/show-cli-cmd-options-before-general-options
...
Docs: Show CLI command-specific options before general options
2022-07-27 02:18:04 -04:00
Jared Kirschner
cd562564ba
docs: show CLI cmd-specific opts before general opts
...
Applied to a single command (acl auth-method create).
2022-07-26 22:38:44 -07:00
Jared Kirschner
29c9e18bbf
docs: remove comparative info from ref docs site
2022-07-26 22:27:39 -07:00
Iryna Shustava
c34e4f35fb
docs: update helm reference docs ( #13910 )
2022-07-26 17:54:51 -06:00
cskh
59e81a728e
chore: removed unused method AddService ( #13905 )
...
- This AddService is not used anywhere.
AddServiceWithChecks is place of AddService
- Test code is updated
2022-07-26 16:54:53 -04:00
Luke Kysow
021b00e321
Remove duplicate comment
2022-07-26 10:19:49 -07:00
John Cowen
2547af7e1e
ui: Make peered intentions read-only ( #13814 )
...
* ui: Make peered intentions read-only
* Replace "" to undefined for SourcePeer so its the same as PeerName
* Fixup copypasta
* Ensure tests run with no peers
2022-07-26 17:29:37 +01:00
John Cowen
e3f05adf3b
ui: Add peering establishment to the peer listing page ( #13813 )
...
* ui: Add peering establishment to the peer listing page
* Remove this.form.reset
2022-07-26 15:36:49 +01:00
Michael Klein
a6a79d6811
ui: add deprecation worfklow addon ( #13877 )
...
* add ember-cli-deprecation-workflow
* Add deprecation workflow configuration
This will silence all deprecations by default reducing noise in the test
output significantly.
We can tackle deprecations now one by one but won't have to deal with
very verbose console logs anymore.
2022-07-26 15:01:09 +02:00
alex
437a28d18a
peering: prevent peering in same partition ( #13851 )
...
Co-authored-by: Chris S. Kim <ckim@hashicorp.com>
2022-07-25 18:00:48 -07:00
trujillo-adam
3548a396ad
Merge pull request #13897 from hashicorp/peering-metrics-docs-typo
...
fixed typo
2022-07-25 16:36:49 -07:00
Nitya Dhanushkodi
27bd895ac8
peering: remove validation that forces peering token server addresses to be an IP, allow hostname based addresses ( #13874 )
2022-07-25 16:33:47 -07:00
Jared Kirschner
5a92e439e6
Merge pull request #12045 from hashicorp/partition-cli-acl-info-and-api-crossref
...
Partitions: Include ACL Info and API cross-ref for CLI Commands
2022-07-25 19:10:55 -04:00
Luke Kysow
8c5b70d227
Rename receive to recv in tracker ( #13896 )
...
Because it's shorter
2022-07-25 16:08:03 -07:00
Iryna Shustava
a1df5ae9b7
build: add a build job to build and push UBI images to DockerHub ( #13808 )
2022-07-25 15:43:24 -07:00
Jared Kirschner
51f0a64b6b
docs: remove unnecessary partition CLI cmd info
2022-07-25 15:31:39 -07:00
Jared Kirschner
6add1039b3
docs: adjust HTTP API/CLI characteristics tables
2022-07-25 15:31:39 -07:00
Jared Kirschner
03924fdb30
docs: restructure partition API characteristics
...
The existing characteristics were restructured into a list.
The corresponding CLI command characteristic was added.
2022-07-25 15:31:38 -07:00
Jared Kirschner
903c71618a
docs: remove partition subcommand usage headings
2022-07-25 15:31:38 -07:00
Jared Kirschner
bfe79b7b34
docs: add partition command characteristics
...
Characteristics include:
- Required ACL permissions
- Corresponding HTTP API endpoint
- (Lack of) support for blocking queries and agent caching
2022-07-25 15:31:38 -07:00
Jared Kirschner
55a77c187b
docs: add partial for api/cli characteristics links
2022-07-25 15:31:38 -07:00
trujillo-adam
ec12589862
fixed typo
2022-07-25 14:32:33 -07:00
Luke Kysow
3530d3782d
peering: read endpoints can now return failing status ( #13849 )
...
Track streams that have been disconnected due to an error and
set their statuses to failing.
2022-07-25 14:27:53 -07:00
Kyle Havlovitz
93de25f87c
Merge pull request #13872 from hashicorp/remove-upstream-log
...
Remove extra logging from ingress upstream watch shutdown
2022-07-25 12:55:30 -07:00
David Yu
5867db4b0e
docs: followup on grammar and typo for latency requirements ( #13888 )
2022-07-25 12:50:11 -07:00
alex
45c3562477
docs: add peering metric doc ( #13862 )
...
Co-authored-by: Freddy <freddygv@users.noreply.github.com>
Co-authored-by: Jeff Boruszak <104028618+boruszak@users.noreply.github.com>
Co-authored-by: trujillo-adam <47586768+trujillo-adam@users.noreply.github.com>
2022-07-25 12:43:06 -07:00
Chris S. Kim
73a84f256f
Preserve PeeringState on upsert ( #13666 )
...
Fixes a bug where if the generate token is called twice, the second call upserts the zero-value (undefined) of PeeringState.
2022-07-25 14:37:56 -04:00