Commit Graph

11658 Commits

Author SHA1 Message Date
Pierre Souchay 5c7af90154
tests: added unit test to ensure watches are not re-triggered on consul reload (#7449)
This ensures no regression about https://github.com/hashicorp/consul/issues/7318
And ensure that https://github.com/hashicorp/consul/issues/7446 cannot happen anymore
2020-05-20 12:38:29 +02:00
Pierre Souchay e9d176db2a
Allow to restrict servers that can join a given Serf Consul cluster. (#7628)
Based on work done in https://github.com/hashicorp/memberlist/pull/196
this allows to restrict the IP ranges that can join a given Serf cluster
and be a member of the cluster.

Restrictions on IPs can be done separatly using 2 new differents flags
and config options to restrict IPs for LAN and WAN Serf.
2020-05-20 11:31:19 +02:00
Daniel Nephin 913549a0b3
Merge pull request #7894 from hashicorp/dnephin/add-linter-staticcheck-1
Fix some bugs/issues found by staticcheck
2020-05-19 18:44:06 -04:00
Daniel Nephin 1bbea2751f consul/state: refactor tnxService to avoid missed cases
Handling errors at the end of a log switch/case block is somewhat
brittle. This block included a couple cases where errors were ignored,
but it was not obvious the way it was written.

This change moves all error handling into each case block. There is
still potentially one case where err is ignored, which will be handled
in a follow up.
2020-05-19 16:50:14 -04:00
Daniel Nephin 9f27d61bee Remove unused var
The usage was removed in 8e22d80e35,
however it seems there may be a bug here because the cluster name
is not updated when the target changes.
2020-05-19 16:50:14 -04:00
Daniel Nephin 4f738b462b Handle error from template.Execute
Refactored the function to make the problem more obvious, by using a
guard.
2020-05-19 16:50:14 -04:00
Daniel Nephin c662f0f0de Fix a number of problems found by staticcheck
Some of these problems are minor (unused vars), but others are real bugs (ignored errors).

Co-authored-by: Matt Keeler <mkeeler@users.noreply.github.com>
2020-05-19 16:50:14 -04:00
Daniel Nephin 5c99109dd9 Remove unused var
The usage of this var was removed in b92f895c23.

Found by using staticcheck
2020-05-19 16:50:14 -04:00
R.B. Boyer 89a6492033
docs: remove todos (#7922)
Fixes #7921
2020-05-19 15:19:06 -05:00
Daniel Nephin e02ee13657
Make envoy integration tests a `go test` suite (#7842)
* test/integration: only run against 1 envoy version

These tests are slow enough that it seems unlikely that anyone is
running multiple versions locally. If someone wants to, a for loop
outside of run_test.sh should do the right thing.

Remove unused vars.

* Remove logic to iterate over test cases, run a single case

* Add a golang runner for integration tests

* Use build tags for envoy integration tests

And add junit-xml report
2020-05-19 14:00:00 -04:00
Mike Morris 1b152f9f21
ci: limit parallelism for Ember builds (#7917)
If not artificially limited by setting JOBS env var,
broccoli-babel-transpiler will attempt to parallelize across the number
of CPUs on the host VM rather than the Docker container, resulting in CI
jobs being killed due to running out of memory.
2020-05-19 13:00:35 -04:00
John Cowen 200945714a
UI Release Merge (1.8-beta-2: ui-staging merge) (#7919)
* ui: Styling fixes (#7885)

* Move cellHeight to ListCollection js file

* Fix composite row border-top-color onHover state

* Add empty health check icon to CompositeRow styling

* ui: Slightly refactor %composite-rows and reuse ConsulServiceList component (#7886)

* ui: Move individual component types into a single %composite-list plus

1. Removes all out separate CSS components (that match HTML components)
to favour not having those separate for the moemnt at least
2. Reuses <ConsulServiceList /> component for Terminating Gateways >
Linked Services

* ui: Tweak breadcrumb spacing for '/' separator

* Fix up the tests i.e. services per tab so we can call them all services

* ui: Misc discovery chain fixes (#7892)

1. Look for a default splitter before looking for a default resolver in
order to route to.
2. Delay adding svg listeners until afterRender (fixes split tooltip)
3. Make router id's consistent for highlighting default routers in when
clicking the graph

* ui: If an error occurs on the server, surface it in the notification (#7893)

* ui: Delete old unused CSS (#7909)

This commit deletes CSS that we no longer use and we definitely will not
ever use.

We also dedup all of our imports here as it turns out SASS doesn't
dedupe imports. Strangely this increases out CSS weight by ~1kb instead
of reducing but we'd rather keep things deduped as that was the
intention

* ui: Redesign - Exposed Paths (#7912)

* Add new exposed paths icons to codebase

* Redesign Exposed Paths and create copy-button hover on Composite Row

* Refactor FeedbackDialog and CopyButton

* Change this.element to use `{{ref }}` now we don't have an element

We changed this to a tagless component with an eye to moving this to a
glimmer component, without spotting that this would also remove the
`this.element` property.

This adds an equivalent using the ref modifier.

Co-authored-by: John Cowen <jcowen@hashicorp.com>

* ui: Remove box-shadow and pointer cursor from metada list hover effect (#7914)

Co-authored-by: Kenia <19161242+kaxcode@users.noreply.github.com>
2020-05-19 17:18:04 +01:00
John Cowen 3be1237e42
ui: Only save the setting that you've changed (#7918)
Originally we assumed all settings would be editable in the settings
page, but over time we've added thigns to localStorage that aren't user
settable settings. This means we shouldn't save all you localStorage
settings everything time only a single setting has been saved.

This change only changes the setting you've changed via the settings
page, meaning it will never update non-user-settable settings.
2020-05-19 16:20:27 +01:00
John Cowen 2a41708fb1
ui: Ensure datacenter is sent to the API when loading in a policy panel (#7910)
* ui: Policies don't have datacenter properties, use the URL dc instead.

* ui: Ensure policy saving proxy object is destroyed
2020-05-19 14:51:39 +01:00
John Cowen 5d5bb6cca6
ui: Ensure value is always passed to CONSUL_SSO_ENABLED (#7913)
ACLsEnabled is always set to either true or false. .SSOEnabled is only set if you are running enterprise (the same as .NamespacesEnabled). Therefore .SSOEnabled and .NamespacesEnabled require conditionals to check their existence.

In order to avoid future confusion we moved all go-template variables to use the conditional form, and added a comment to that effect.

Tests have been added to reflect this, but they only test that the template outputs what we expect, true e2e testing here would be advantageous.
2020-05-18 20:22:37 +01:00
R.B. Boyer 228284758b
docs: update the 'consul tls' command docs to match the current flags (#7911) 2020-05-18 12:01:14 -05:00
Chris Piraino 8e1e39e6eb
Update CHANGELOG.md 2020-05-18 11:30:41 -05:00
John Cowen 6588218cca
ui: Misc amends for Safari and Firefox (#7907)
1. Ensure dropdown menus function correctly in Safari
2. Ensure default grey color for buttons is not used
3. Ensure IntersectionObservers are cleaned up properly in Safari
2020-05-18 17:21:10 +01:00
Chris Piraino 249af0a094
Merge pull request #7898 from hashicorp/bug/update-gateways-on-config-entry-delete
Remove error from GatewayServices RPC when a service is not a gateway
2020-05-18 09:21:02 -05:00
Chris Piraino 9d9e23cc44 Add service id context to the proxycfg logger
This is especially useful when multiple proxies are all querying the
same Consul agent.
2020-05-18 09:08:05 -05:00
Chris Piraino 79468793f6 Do not return an error if requested service is not a gateway
This commit converts the previous error into just a Warn-level log
message. By returning an error when the requested service was not a
gateway, we did not appropriately update envoy because the cache Fetch
returned an error and thus did not propagate the update through proxycfg
and xds packages.
2020-05-18 09:08:04 -05:00
Mike Wickett fee5377081
Merge pull request #7905 from BrandonRomano/nf.update-flexible-architecture-image
website: update flexible architecture image
2020-05-15 14:07:08 -04:00
nicolelyn 209f97bfe4 website: update flexible architecture image 2020-05-15 13:49:57 -04:00
Mike Wickett 6332fd927b
Merge pull request #7895 from BrandonRomano/nf.fix-callouts-image
website: fix image size on learn callout
2020-05-15 10:13:31 -04:00
David Yu e226a21c3e
Unindenting to remove shell pre-formatting (#7890) 2020-05-14 15:04:53 -06:00
Alvin Huang 38da343790
re-enable auto cherry-picking after website launch (#7897)
* re-enable auto cherry-picking after website launch

* change to regex since we renamed docs-cherrypick to type/docs-cherrypick
2020-05-14 16:53:51 -04:00
Aleksandr Zagaevskiy a75e3d9051
Preserve ModifyIndex for unchanged entry in KVS TXN (#7832) 2020-05-14 13:25:04 -06:00
Freddy 590147c5d8
Update CHANGELOG.md 2020-05-14 13:16:08 -06:00
nicolelyn 743ad512a7 website: fix image size on learn callout 2020-05-14 15:09:15 -04:00
Brandon Romano 42353b6c65
Merge pull request #7889 from hashicorp/br.18-alert
Updates alert Banner to point to 1.8 Blog Post
2020-05-14 10:19:37 -07:00
Brandon Romano 80064f9ab4 Updates alert Banner to point to 1.8 Blog Post 2020-05-14 10:18:18 -07:00
Luke Kysow 6d472b6d60
Merge pull request #7882 from hashicorp/multi-cluster-k8s
Documentation for wan fed via mgw on k8s
2020-05-14 09:57:39 -07:00
John Cowen 2f7c4cbf86
ui: Quote service names when filtering for intentions (#7888)
* ui: Quote service names for intention filtering

* ui: return null if we ever get an error with anything else
2020-05-14 17:18:24 +01:00
Luke Kysow 5355c07bc1
Documentation for wan fed via mgw on k8s 2020-05-14 09:09:18 -07:00
Brandon Romano 07487220a5
Merge pull request #7883 from BrandonRomano/consul-website-redesign
website: Landing & Use Case Pages redesign
2020-05-14 09:04:10 -07:00
Preetha 5ce60dd5f1
Merge pull request #7887 from hashicorp/website-beta-availability
Update version.js
2020-05-14 10:52:22 -05:00
Preetha Appan 62480adf98 link to beta 2020-05-14 10:51:34 -05:00
Preetha Appan 2ae0d20147 Update version.js 2020-05-14 10:42:06 -05:00
Preetha 54b589a913
fix typo in changelog 2020-05-14 08:11:56 -05:00
Hans Hasselberg 1a01c060ae
Update CHANGELOG.md 2020-05-14 10:44:45 +02:00
Pierre Souchay cf55e81c06
tests: fix unstable test `TestAgentAntiEntropy_Checks`. (#7594)
Example of failure: https://circleci.com/gh/hashicorp/consul/153932#tests/containers/2
2020-05-14 09:54:49 +02:00
Brandon Romano ae1927b464 Remove accidental import that sneaked in rebase 2020-05-13 23:48:06 -07:00
Brandon Romano d75e1cc2e7 Revert "Temporarily switch og:image to staging env to test"
This reverts commit a71eb2170020884e701267db23fc6d5a0bc3a06b.
2020-05-13 23:45:42 -07:00
Brandon Romano cd61f741a7 Set og:title name for overriding 2020-05-13 23:45:42 -07:00
Brandon Romano 2ed1c44440 Adds og:title 2020-05-13 23:45:42 -07:00
Brandon Romano 8929428c03 Temporarily switch og:image to staging env to test 2020-05-13 23:45:42 -07:00
Brandon Romano 0dcbebfb7c Adds page specific metadata to use case pages 2020-05-13 23:45:42 -07:00
Brandon Romano 3db781ae99 Update base metadata 2020-05-13 23:45:42 -07:00
Brandon Romano 3351e65012 Further image optimizations 2020-05-13 23:45:42 -07:00
Brandon Romano 2ecf62da70 Remove raster images to CDN 2020-05-13 23:45:42 -07:00