Commit Graph

11761 Commits

Author SHA1 Message Date
R.B. Boyer 0ec3e2ebf4 gossip: Avoid issue where two unique leave events for the same node could lead to infinite rebroadcast storms (#8343)
bump serf to v0.9.3 to include fix for https://github.com/hashicorp/serf/pull/606
2020-07-21 20:49:09 +00:00
Daniel Nephin 4205fdf1d6 Merge pull request #7948 from hashicorp/dnephin/buffer-test-logs
testutil: NewLogBuffer - buffer logs until a test fails
2020-07-21 19:22:29 +00:00
Matt Keeler 4c0b520353
Update CHANGELOG.md 2020-07-21 15:09:37 -04:00
Matt Keeler 49145df770
Merge pull request #8352 from hashicorp/backport/8311 2020-07-21 15:07:54 -04:00
Matt Keeler a8d2e5a2c2
Disable background cache refresh for Connect Leaf Certs
The rationale behind removing them is that all of our own code (xDS, builtin connect proxy) use the cache notification mechanism. This ensures that the blocking fetch behind the scenes is always executing. Therefore the only way you might go to get a certificate and have to wait is when 1) the request has never been made for that cert before or 2) you are using the v1/agent/connect/ca/leaf API for retrieving the cert yourself.

In the first case, the refresh change doesn’t alter the behavior. In the second case, it can be mitigated by using blocking queries with that API which just like normal cache notification mechanism will cause the blocking fetch to be initiated and to get leaf certs as soon as needed.

If you are not using blocking queries, or Envoy/xDS, or the builtin connect proxy but are retrieving the certs yourself then the HTTP endpoint might take a little longer to respond.

This also renames the RefreshTimeout field on the register options to QueryTimeout to more accurately reflect that it is used for any type that supports blocking queries.

# Conflicts:
#	agent/cache/cache.go
2020-07-21 13:51:18 -04:00
Matt Keeler 24e11b511e
Fix issue with changing the agent token causing failure to renew the auto-encrypt certificate
The fallback method would still work but it would get into a state where it would let the certificate expire for 10s before getting a new one. And the new one used the less secure RPC endpoint.

This is also a pretty large refactoring of the auto encrypt code. I was going to write some tests around the certificate monitoring but it was going to be impossible to get a TestAgent configured in such a way that I could write a test that ran in less than an hour or two to exercise the functionality.

Moving the certificate monitoring into its own package will allow for dependency injection and in particular mocking the cache types to control how it hands back certificates and how long those certificates should live. This will allow for exercising the main loop more than would be possible with it coupled so tightly with the Agent.

# Conflicts:
#	agent/agent.go
2020-07-21 13:49:18 -04:00
Nathan Lacey 8513ad572d Add certificate disclaimer for TLS encryption (#8316)
Co-authored-by: Freddy <freddygv@users.noreply.github.com>
2020-07-21 16:39:16 +00:00
duncanKr d00b0a1fa2 ui: Table element's have vertical scrollbars (#8296)
Close #8294. Set overflow to hidden for both x and y axis. This prevents the overflow-y defaulting to auto, and creating scrollbars. Given the text overflow is set to ellipsis, this doesn't change the UI functionality.
2020-07-21 13:41:37 +00:00
Ondrej Sika 096c671cc4 ui: Fix swapped node & service checks by fixing filter-by & reject-by (#8338) 2020-07-20 23:46:27 +00:00
Joel Watson 5c2fe4d0d5 docs: Add raft_multiplier default clarification (#8339) 2020-07-20 21:51:19 +00:00
Alvin Huang 30f5600b47 add v to version pretty formatter (#8341)
* add v to version pretty formatter

* remove v from json version output
2020-07-20 21:45:57 +00:00
Daniel Nephin 65566e2c98 Merge pull request #8290 from hashicorp/dnephin/watch-decode
watch: fix script watches with single arg
2020-07-20 18:41:48 +00:00
Daniel Nephin e5cfe66b0c Merge pull request #8328 from hashicorp/dnephin/go1.14.6
ci: Use go1.14.6
2020-07-20 17:33:23 +00:00
John Cowen d0b328e272 ui: Namespaces Redesign (#8336)
* ui: Add new consul-nspace-list component

* ui: Use new consul-nspace-list component

* Fix up other components to use linkable list-collection action

* ui: Remove some dead CSS
2020-07-20 17:12:59 +00:00
John Cowen fce4311f55 ui: KV Form and List Components (#8307)
* Add components for KV form, KV list and Session form

* Pass through a @label attribute for a human label + don't require error

* Ignore transition aborted errors for if you are re-transitioning

* Make old confirmation dialog more ember-like and tagless

* Make sure data-source and data-sink supports KV and sessions

* Use new components and delete all the things

* Fix up tests

* Make list component tagless

* Add component pageobject and fixup tests from that

* Add eslint warning back in
2020-07-20 17:05:20 +00:00
John Cowen ce6481d93d ui: Add some missed spaces in component README files (#8335) 2020-07-20 16:44:12 +00:00
Alvin Huang bd08eb3d97 ci: separate install-gotestsum step into its own config (#8327) 2020-07-17 17:55:56 +00:00
John Cowen f2accb0bd1 ui: Move routes to use data-sources (#8321)
* Add uri identifiers to all data source things and make them the same

1. Add uri identitifer to data-source service
2. Make <EventSource /> and <DataSource /> as close as possible
3. Add extra `.closed` method to get a list of inactive/closed/closing
data-sources from elsewhere

* Make the connections cleanup the least worst connection when required

* Pass the uri/request id through all the things

* Better user erroring

* Make event sources close on error

* Allow <DataLoader /> data slot to be configurable

* Allow the <DataWriter /> removed state to be configurable

* Don't error if meta is undefined

* Stitch together all the repositories into the data-source/sink

* Use data.source over repositories

* Add missing  <EventSource /> components

* Fix up the views/templates

* Disable all the old route based blocking query things

* We still need the repo for the mixin for the moment

* Don't default to default, default != ''
2020-07-17 13:43:16 +00:00
John Cowen 24b87b81d5 ui: Fix sticky action popover menus (#8326)
* ui Close more-popover-menus in KV and nspaces on confirmation

* ui: Close more-popovermenus on confirmation on composite-rows
2020-07-17 13:29:41 +00:00
John Cowen 3820dca426 ui: Change some components to use willDestroyElement vs willDestroy (#8313)
* ui: Change <DataSource /> to use willDestroyElement vs willDestroy

* Change 3 more components to use willDestroyElement vs willDestroy
2020-07-17 08:51:01 +00:00
John Cowen cf9469f201 ui: Better error message checking for cross dc connect check (#8320) 2020-07-16 17:28:22 +00:00
André 927e73d8db minor: fix docstring of DNSOnlyPassing (#8318)
In runtime.go it had "duration" but it is actually a boolean.
2020-07-16 13:48:07 +00:00
Alvin Huang b3bef5a080 add back missing quote in bashenv for CI (#8317) 2020-07-15 21:22:16 +00:00
Alvin Huang dc04b510e2 remove GIT_DESCRIBE variable since we have a revision line (#8310) 2020-07-14 19:18:39 +00:00
John Cowen 3a8d36bff8 ui: Make sure the intention create form has a cancel button (#8308) 2020-07-14 17:44:33 +00:00
Matt Keeler 625055a556 Add ability for notifications when one of the agent tokens is updated (#8301)
Co-authored-by: Chris Piraino <cpiraino@hashicorp.com>
2020-07-14 13:54:38 +00:00
John Cowen 3330282887 ui: Only try and load sessions and coordinates if the node exists (#8305) 2020-07-14 13:51:45 +00:00
Iryna Shustava 1b11c4e636 sdk: Use /v1/status/leader endpoint when starting a test server (#8192)
Switch from /v1/agent/self to /v1/status/leader when checking if the test server has come up successfully in the waitForAPI function.

Previously, the test server was relying (probably not intentionally) on the default value of the acl_enforce_version_8 in the TestConfig, which was false. So if you create a test server and enabled ACLs, they would not be enforced and the server would be able to come up pretty quickly because /v1/agent/self would return a 200 status pretty much as soon as the agent is running and most likely before leader election is finished.

Now that we have removed acl_enforce_version_8 property (equivalent to being true by default) if you've created a test server with ACLs enabled, it will need to wait for leader election and for ACLs to be initialized before it'll get a successful response from the /v1/agent/self.

Note: With this change, waitForAPI function no longer requires a 200 response status from the v1/status/leader endpoint. This is because in some tests, namely TestAPI_AgentLeave, we are only running clients, and this endpoint returns a 500 status.
2020-07-13 16:50:13 +00:00
John Cowen 35fcf69914 ui: Move dc sorting to the view/template (#8297)
* ui: Move dc sorting to the view/template

* Cleanup unused coordinates service from Node repo

* Fix up integration test to not expect a sorted result
2020-07-13 13:23:29 +00:00
Freddy 89af0212d3 Add api mod support for /catalog/gateway-services (#8278) 2020-07-10 19:02:09 +00:00
John Cowen 176298979f ui: Revert ember-composable-helpers to ~4.0.0 due to faster sort-by (#8289) 2020-07-10 16:39:25 +00:00
Matt Keeler 946f7700f5
Update CHANGELOG.md 2020-07-10 10:43:52 -04:00
Matt Keeler 3ba0b03cd8 Add Revision to version CLI output and add JSON support
Also add JSON format support

# Conflicts:
#	website/pages/docs/commands/version.mdx
2020-07-10 10:43:09 -04:00
John Cowen eca8e63d29 ui: Adds definition-table class to RTT values table (#8286)
We changed our default definition list layout in
https://github.com/hashicorp/consul/pull/8117.

We replaced the default with a definition-table class but missed one
place where the old default was previously used.

This adds the definition-table class in RTT where it used to use the
default.
2020-07-10 13:27:33 +00:00
John Cowen 7fe2ac9714 ui: Lint staged no longer requires git add to be specified (#8285) 2020-07-10 13:27:10 +00:00
R.B. Boyer d44341b65f update changelog 2020-07-09 17:15:53 -05:00
R.B. Boyer 2142a697ad
[backport: 1.8.x] xds: version sniff envoy and switch regular expressions from 'regex' to 'safe_regex' on newer envoy versions (#8265)
cherry-pick of #8222 onto origin/release/1.8.x

Fixes: #8205
2020-07-09 17:04:23 -05:00
John Cowen 346df06745 ui: Dependency upgrade (#8276)
* Remove curly brackets and pass through attributes

* yarn upgrade and part manual deps upgrade of non-problematic things

* from-entries from ember-composable helpers receives an array

* PowerSelect destruction bug seems to be fixed upstream

* Ensure all policies have a default 0 date for ember-c-h upgrade

sorting no longer works correctly unless CreateTime has a value
2020-07-09 16:14:11 +00:00
Matt Keeler a67504b601
Merge pull request #8275 from hashicorp/feature/auto-config/rpc-delegate-backport 2020-07-09 11:20:27 -04:00
Matt Keeler 38251ab0e8
Pass the Config and TLS Configurator into the AutoConfig constructor
This is instead of having the AutoConfigBackend interface provide functions for retrieving them.

NOTE: the config is not reloadable. For now this is fine as we don’t look at any reloadable fields. If that changes then we should provide a way to make it reloadable.
2020-07-09 10:38:29 -04:00
Matt Keeler f06595992a
Rename (*Server).forward to (*Server).ForwardRPC
Also get rid of the preexisting shim in server.go that existed before to have this name just call the unexported one.
2020-07-09 10:38:16 -04:00
Matt Keeler 977eb725a7
Refactor AutoConfig RPC to not have a direct dependency on the Server type
Instead it has an interface which can be mocked for better unit testing that is deterministic and not prone to flakiness.

# Conflicts:
#	agent/pool/pool.go
2020-07-09 10:37:55 -04:00
John Cowen af20cb1f99 ui: Use top-level 'named index files' instead of in folder index files (#8274)
* Remove unused phrase-editor CSS

* Move index.scss files to top-level named files to make them more obvious
2020-07-09 13:51:56 +00:00
John Cowen 143975e88a ui: Replace dom-buffering components with ember-stargate Portals (#8273)
* ui: Replace dom-buffering components with ember-stargate Portals
2020-07-09 13:30:45 +00:00
John Cowen f9fd2822e9 ui: Extract and organize popover-menu and related from main-nav (#8272) 2020-07-09 13:27:24 +00:00
John Cowen 136decd2e8 ui: Enable keyboard access for the sorting dropdown menus (#8267) 2020-07-09 12:42:24 +00:00
John Cowen aa48d29191 ui: New Intention Form/List components (#8172) 2020-07-09 09:09:53 +00:00
JohnnyB 9e10a9d81e Added undocumented CONSUL_NAMESPACE to website. (#8264) 2020-07-08 14:42:22 +00:00
Kenia fa3aa25839 ui: Fix up styling for the Tags tab (#8263) 2020-07-08 13:49:00 +00:00
John Cowen 74f5a7fa7c ui: Use empty-state for our small empty states (#8262) 2020-07-08 13:36:10 +00:00