* u
(cherry picked from commit 2715ec654d)
* change placeholder for public key
(cherry picked from commit 4b3e56cd6e)
* fix link to etherscan in notification
(cherry picked from commit fdc0663041)
---------
Co-authored-by: Jakub Kotula <520927+jkbktl@users.noreply.github.com>
* add check if network is supported
(cherry picked from commit 9762c401fe)
* u
* f
* Apply suggestions from code review
Co-authored-by: Felicio Mununga <felicio@users.noreply.github.com>
---------
Co-authored-by: Jakub Kotula <520927+jkbktl@users.noreply.github.com>
This slightly adjust the remappings config to be a bit more specific as
otherwise there was an issue with verifying contracts on chain
explorers.
It also enables RPC configs for optimism.
This commit fixes a bug in the `VotingContract` where any voting room
marked as `finalized` is not considered to be an active voting room,
even though, evaluation is still ongoing.
The fix adds a check that a voting room has to be either not marked as
finalized, or, if it is, it should not be evaluated, to be considered
an active voting room.
It also adds a test that ensures the fix is working as expected.
This fixes a bug that multicall isn't available on a local node. This
commit ensures we deploy it.
It also outputs multicall addresses for Goerli and Optimism, as those
will be needed when the app is deployed to production.
Something that came up during testing:
The deployment script didn't set the directory contract in both, the
voting contract and the featured voting contract, which resulted in
functoin calls to revert because they essentially didn't exist at the
addresses referenced in those contracts.
This commit fixes it by ensuring `setDirectory()` is called for both
voting contracts.
This commit addresses the issue that, when testing the contracts on a
local node, the test (deployer) account does not have any tokens to use
the voting contracts with.
This is fixed by minting tokens as the deployer of the mock SNT
contract.
The commit also adds the expect SNT contract instance as a return value
of the deploy function, ensuring its address is rendered in stdout when
running the script.
Adding it to the returned tuple however caused a "stack too deep" error,
which is why we had to remove one value from the returned tuple.
Since the `DeploymentConfig` contract instance address is irrelevant for actual
deployments, I've removed it from `DeployContracts.run()` and added an
additional function to retrieve it within tests.
Felicio Mununga
r4bbit
Jakub Kotula
Patryk Osmaczko