There is a bunch of repeated code checking reactions which has the issue
that it can easily get out of date with what GitHub accepts. Drop the
check, and rely on GitHub returning an error.
Fixes#1554
To increase coverage, sprinkle in some asserts for attributes that were
not checked -- this uncovered a bug in Issue that two attributes were
not properly initialized to NotSet.
Clean up a few errors I missed, ignore another, and configure flake8 using
a config file to ignore certain errors. The next step would be to remove
the F* ignores.
With the Python 2.7 deadline fast approaching, modernize the codebase
making use of the modernize module to switch to using six, as well as
other upcoming features, such as absolute imports . Stop using 2to3
for Travis, yay!
See Issue #855
The class [IssueEvent](https://github.com/PyGithub/PyGithub/blob/master/github/IssueEvent.py) is missing a large number of attributes documented in the [API](https://developer.github.com/v3/issues/events/).
This is also commented about in #653 to a degree
27 of the tests 27 known event types have tests.
**Currently Tested using Issue #30**
- [x] subscribed
- [x] assigned
- [x] referenced
- [x] closed
- [x] labeled
**Currently Tested using Issue/PR #538**
- [x] merged
- [x] mentioned
- [x] review_requested
**Currently Tested using Issue/PR #857**
- [x] reopened
- [x] unassigned
- [x] unlabeled
- [x] renamed
- [x] base_ref_changed
- [x] head_ref_deleted
- [x] head_ref_restored
- [x] milestoned
- [x] demilestoned
- [x] locked
- [x] unlocked
- [x] review_dismissed
- [x] review_request_removed
- [x] marked_as_duplicate
- [x] unmarked_as_duplicate
- [x] added_to_project
- [x] moved_columns_in_project
- [x] removed_from_project
- [x] converted_note_to_issue - Note: this event is tied into Issue #866
This PR is now ready to be merged
* List reactions of issue
* Create issue reaction
* List reactions of an issue comment
* Create a reaction on an issue comment
* List reactions of a commit comment
* Create a reaction on a commit comment
* List reactions of a pull request review comment
* Create a reaction on a pull request review comment
* Delete reaction
* Renames IssueReaction to Reaction
* Fixes docstring in Reaction class
* Removes issue_url on Reaction class
* Fixes string concatenation that does not work on python 2.6
When calling pygithub for calls associated with assignees you can now simply pass a string instead of a NamedUser object. This applies to the following methods:
- issue.edit()
- repo.create_issue()
- repo.get_issues()
- repo.has_in_assignees()
- repo.has_in_collaborators()
- repo.remove_from_collaborators()
- repo.add_to_collaborators()
Huan-Cheng Chang