Test more attributes (#1526)

To increase coverage, sprinkle in some asserts for attributes that were
not checked -- this uncovered a bug in Issue that two attributes were
not properly initialized to NotSet.
This commit is contained in:
Steve Kowalik
2020-05-21 09:58:50 +10:00
committed by GitHub
parent 1dd1cf9cb1
commit 52ec366be4
3 changed files with 5 additions and 0 deletions
+2
View File
@@ -612,6 +612,7 @@ class Issue(github.GithubObject.CompletableGithubObject):
return self.number
def _initAttributes(self):
self._active_lock_reason = github.GithubObject.NotSet
self._assignee = github.GithubObject.NotSet
self._assignees = github.GithubObject.NotSet
self._body = github.GithubObject.NotSet
@@ -625,6 +626,7 @@ class Issue(github.GithubObject.CompletableGithubObject):
self._id = github.GithubObject.NotSet
self._labels = github.GithubObject.NotSet
self._labels_url = github.GithubObject.NotSet
self._locked = github.GithubObject.NotSet
self._milestone = github.GithubObject.NotSet
self._number = github.GithubObject.NotSet
self._pull_request = github.GithubObject.NotSet
+2
View File
@@ -80,6 +80,8 @@ class Issue(Framework.TestCase):
self.assertEqual(
self.issue.url, "https://api.github.com/repos/jacquev6/PyGithub/issues/28"
)
self.assertFalse(self.issue.locked)
self.assertIsNone(self.issue.active_lock_reason)
self.assertEqual(self.issue.user.login, "jacquev6")
self.assertEqual(self.issue.repository.name, "PyGithub")
self.assertEqual(
+1
View File
@@ -55,6 +55,7 @@ class RepositoryKey(Framework.TestCase):
)
self.assertEqual(self.key.created_at, datetime.datetime(2017, 2, 22, 8, 16, 23))
self.assertTrue(self.key.verified)
self.assertTrue(self.key.read_only)
self.assertEqual(
repr(self.key), 'RepositoryKey(title="PyGithub Test Key", id=21870881)'
)