mirror of
https://github.com/status-im/PyGithub.git
synced 2026-08-31 10:51:14 +00:00
Fix URL used in Team.update_team_repository method
Use of string doesn't make sense here unless you know that the `repo`
argument here means `{owner}/{repo}`, and not just `{repo}`.
If you simply pass repo name you instead get a silent failure that
returns 404:
```json
{"message":"Not Found","documentation_url":"https://docs.github.com/rest"}
```
Signed-off-by: Jakub Sokołowski <jakub@status.im>
This commit is contained in:
+2
-6
@@ -245,18 +245,14 @@ class Team(CompletableGithubObject):
|
||||
"""
|
||||
:calls: `PUT /orgs/{org}/teams/{team_slug}/repos/{owner}/{repo} <https://docs.github.com/en/rest/reference/teams#check-team-permissions-for-a-repository>`_
|
||||
"""
|
||||
assert isinstance(repo, github.Repository.Repository) or isinstance(repo, str), repo
|
||||
assert isinstance(repo, github.Repository.Repository), repo
|
||||
assert isinstance(permission, str), permission
|
||||
if isinstance(repo, github.Repository.Repository):
|
||||
repo_url_param = repo._identity
|
||||
else:
|
||||
repo_url_param = repo
|
||||
put_parameters = {
|
||||
"permission": permission,
|
||||
}
|
||||
status, _, _ = self._requester.requestJson(
|
||||
"PUT",
|
||||
f"{self.organization.url}/teams/{self.slug}/repos/{repo_url_param}",
|
||||
f"{self.organization.url}/teams/{self.slug}/repos/{repo._identity}",
|
||||
input=put_parameters,
|
||||
)
|
||||
return status == 204
|
||||
|
||||
Reference in New Issue
Block a user