mirror of
https://github.com/status-im/PyGithub.git
synced 2026-09-01 19:31:10 +00:00
Fix PR review creation. (#1184)
Do not modify the attributes of a PR when creating a review.
This commit is contained in:
committed by
Steve Kowalik
parent
8abd50e225
commit
e90cdab06d
@@ -449,7 +449,6 @@ class PullRequest(github.GithubObject.CompletableGithubObject):
|
||||
self.url + "/reviews",
|
||||
input=post_parameters
|
||||
)
|
||||
self._useAttributes(data)
|
||||
return github.PullRequestReview.PullRequestReview(self._requester, headers, data, completed=True)
|
||||
|
||||
def create_review_request(self, reviewers=github.GithubObject.NotSet, team_reviewers=github.GithubObject.NotSet):
|
||||
|
||||
@@ -50,6 +50,9 @@ class PullRequestReview(Framework.TestCase):
|
||||
# Test ability to get a single review
|
||||
self.pullreview = self.pull.get_review(28482091)
|
||||
|
||||
def testDoesNotModifyPullRequest(self):
|
||||
self.assertEqual(self.pull.id, 111649703)
|
||||
|
||||
def testDismiss(self):
|
||||
self.pullreview.dismiss("with prejudice")
|
||||
pr = self.pull.get_review(28482091)
|
||||
|
||||
Reference in New Issue
Block a user