mirror of
https://github.com/status-im/PyGithub.git
synced 2026-09-02 03:41:08 +00:00
bugfix: returning real list instead of generator
Changed reversed(content) to content[::-1] in order to return a real list and not a generator. The code in PaginatedListBase.__grow does an iteration over newElements when using `+=` and then returns them. When using a generator, newElements would be empty when they are returned.
This commit is contained in:
@@ -147,7 +147,7 @@ class PaginatedList(PaginatedListBase):
|
||||
for element in data
|
||||
]
|
||||
if self._reversed:
|
||||
return reversed(content)
|
||||
return content[::-1]
|
||||
return content
|
||||
|
||||
def __parseLinkHeader(self, headers):
|
||||
|
||||
@@ -60,6 +60,13 @@ class PaginatedList(Framework.TestCase):
|
||||
self.assertEqual(r[14].id, 166212)
|
||||
self.assertEqual(r[15].id, 166214)
|
||||
|
||||
def testReversedIterationSupportsIterator(self):
|
||||
r = self.list.reversed
|
||||
for i in r:
|
||||
self.assertEqual(i.id, 4286936)
|
||||
return
|
||||
self.fail("empty iterator")
|
||||
|
||||
def testIntIndexingInThirdPage(self):
|
||||
self.assertEqual(self.list[50].id, 3911629)
|
||||
self.assertEqual(self.list[74].id, 3605277)
|
||||
|
||||
File diff suppressed because one or more lines are too long
Reference in New Issue
Block a user