bugfix: returning real list instead of generator

Changed reversed(content) to content[::-1] in order to return
a real list and not a generator.
The code in PaginatedListBase.__grow does an iteration over
newElements when using `+=` and then returns them.
When using a generator, newElements would be empty when they are returned.
This commit is contained in:
davidbrai
2013-08-03 16:49:10 +03:00
parent 271f3f301e
commit cb03b9e7d1
3 changed files with 29 additions and 1 deletions
+1 -1
View File
@@ -147,7 +147,7 @@ class PaginatedList(PaginatedListBase):
for element in data
]
if self._reversed:
return reversed(content)
return content[::-1]
return content
def __parseLinkHeader(self, headers):
+7
View File
@@ -60,6 +60,13 @@ class PaginatedList(Framework.TestCase):
self.assertEqual(r[14].id, 166212)
self.assertEqual(r[15].id, 166214)
def testReversedIterationSupportsIterator(self):
r = self.list.reversed
for i in r:
self.assertEqual(i.id, 4286936)
return
self.fail("empty iterator")
def testIntIndexingInThirdPage(self):
self.assertEqual(self.list[50].id, 3911629)
self.assertEqual(self.list[74].id, 3605277)
File diff suppressed because one or more lines are too long