Updates to API and changes to resolve testing issues.

This commit is contained in:
Aaron Levine
2017-03-24 14:45:04 -06:00
parent 7a0fcb27b7
commit b6b127d732
7 changed files with 76 additions and 33 deletions
+3 -3
View File
@@ -38,7 +38,7 @@ import github.File
import github.IssueComment
import github.Commit
import github.PullRequestReview
import github.PullRequestReviewerRequests
import github.PullRequestReviewerRequest
class PullRequest(github.GithubObject.CompletableGithubObject):
@@ -524,13 +524,13 @@ class PullRequest(github.GithubObject.CompletableGithubObject):
headers={'Accept': 'application/vnd.github.black-cat-preview+json'}
)
def get_review_requests(self):
def get_reviewer_requests(self):
"""
:calls: `GET /repos/:owner/:repo/pulls/:number/requested_reviewers <https://developer.github.com/v3/pulls/review_requests/>`_
:rtype: :class:`github.PaginatedList.PaginatedList` of :class:`github.InspectionReviewers.InspectionReviewers`
"""
return github.PaginatedList.PaginatedList(
github.PullRequestReviewerRequests.PullRequestReviewerRequests,
github.PullRequestReviewerRequest.PullRequestReviewerRequest,
self._requester,
self.url + "/requested_reviewers",
None,
@@ -31,7 +31,7 @@ import github.GithubObject
import github.NamedUser
class PullRequestReviewerRequests(github.GithubObject.CompletableGithubObject):
class PullRequestReviewerRequest(github.GithubObject.CompletableGithubObject):
"""
This class represents Pull Request Reviewer Requests as returned for example by https://developer.github.com/v3/pulls/review_requests/
"""
+1 -1
View File
@@ -58,7 +58,7 @@ from Organization import *
from PullRequest import *
from PullRequestComment import *
from PullRequestReview import *
from PullRequestReviewRequests import *
from PullRequestReviewerRequests import *
from PullRequestFile import *
from RateLimiting import *
from Repository import *
+16 -19
View File
@@ -26,29 +26,26 @@
import Framework
import datetime
class PullRequestReview(Framework.TestCase):
def setUp(self):
Framework.TestCase.setUp(self)
# self.pullreview = self.g.get_user().get_repo("PyGithub").get_pull(538).get_review(1):
self.pullreview = self.g.get_user().get_repo("PyGithub").get_pull(538).get_reviews(self)
for ireview in self.pullreview.get_reviews():
iuser = xstr(ireview.user.login) + " (" + xstr(ireview.user.name) + ")"
istate = xstr(ireview.state)
print("* Review #{0} was {1} by User: {2}; For Commit {3}: Comment = {4}".format(ireview.id, istate, iuser, ireview.commit_id, ireview.body))
print("* HTML_URL = {0}".format(ireview.html_url))
print("* Pull Request URL = {0}".format(ireview.pull_request_url))
self.repo = self.g.get_repo("PyGithub/PyGithub")
self.pull = self.repo.get_pull(538)
# Test ability to get all reviews
self.pullreviews = self.pull.get_reviews()
# Test ability to get a single review
self.pullreview = self.pull.get_review(28482091)
def testAttributes(self):
self.assertEqual(self.pullreview.body, "Comment created by PyGithub")
self.assertEqual(self.pullreview.commit_id, "8a4f306d4b223682dd19410d4a9150636ebe4206")
self.assertEqual(self.pullreview.id, 886298)
self.assertEqual(self.pullreview.state, "src/github/Issue.py")
self.assertEqual(self.pullreview.user.login, "jacquev6")
self.assertEqual(self.pullreview.html_url, "https://github.com/jacquev6/PyGithub/pull/170#issuecomment-18637907")
self.assertEqual(self.pullreview.pull_request_url, "https://github.com/jacquev6/PyGithub/pull/170#issuecomment-18637907")
self.assertEqual(self.pullreview.id, 28482091)
self.assertEqual(self.pullreview.user.login, "jzelinskie")
self.assertEqual(self.pullreview.body, "")
self.assertEqual(self.pullreview.commit_id, "7a0fcb27b7cd6c346fc3f76216ccb6e0f4ca3bcc")
self.assertEqual(self.pullreview.state, "APPROVED")
self.assertEqual(self.pullreview.html_url, "https://github.com/PyGithub/PyGithub/pull/538#pullrequestreview-28482091")
self.assertEqual(self.pullreview.pull_request_url, "https://api.github.com/repos/PyGithub/PyGithub/pulls/538")
# test __repr__() based on this attributes
self.assertEqual(self.comment.__repr__(), 'PullRequestReview(id=886298, user=NamedUser(login="jacquev6"))')
self.assertEqual(self.pullreview.__repr__(), 'PullRequestReview(user=NamedUser(login="jzelinskie"), id=28482091)')
@@ -26,19 +26,21 @@
import Framework
import datetime
class PullRequestReviewRequests(Framework.TestCase):
class PullRequestReviewerRequests(Framework.TestCase):
def setUp(self):
Framework.TestCase.setUp(self)
self.pullreviewrequest = self.g.get_user().get_repo("PyGithub").get_pull(538).get_review_requests()
print("* Inspection #{0}, Requested from User {1}".format(self.pullreviewrequest.id, self.pullreviewrequest.login))
self.repo = self.g.get_repo("PyGithub/PyGithub")
self.pull = self.repo.get_pull(538)
self.pullreviewerrequests = self.pull.get_reviewer_requests()
self.pullreviewerrequest = self.pullreviewerrequests[0]
def testAttributes(self):
self.assertEqual(self.pullreviewrequest.id, 886298)
self.assertEqual(self.pullreviewrequest.login, "jacquev6")
self.assertEqual(self.pullreviewerrequest.id, 2930472)
self.assertEqual(self.pullreviewerrequest.login, "jayfk")
# test __repr__() based on this attributes
self.assertEqual(self.comment.__repr__(), 'PullRequestReviewRequest(id=886298, user="jacquev6"')
self.assertEqual(self.pullreviewerrequest.__repr__(), 'PullRequestReviewerRequest(login="jayfk", id=2930472)')
File diff suppressed because one or more lines are too long
File diff suppressed because one or more lines are too long