Merge pull request #479 from ben-whitney/html_url_release

add html_url to GitRelease
This commit is contained in:
Jimmy Zelinskie
2016-10-28 22:39:27 -04:00
committed by GitHub
2 changed files with 13 additions and 0 deletions
+11
View File
@@ -82,6 +82,14 @@ class GitRelease(github.GithubObject.CompletableGithubObject):
self._completeIfNotSet(self._upload_url)
return self._upload_url.value
@property
def html_url(self):
"""
:type: string
"""
self._completeIfNotSet(self._html_url)
return self._html_url.value
def delete_release(self):
headers, data = self._requester.requestJsonAndCheck(
"DELETE",
@@ -115,6 +123,7 @@ class GitRelease(github.GithubObject.CompletableGithubObject):
self._author = github.GithubObject.NotSet
self._url = github.GithubObject.NotSet
self._upload_url = github.GithubObject.NotSet
self._html_url = github.GithubObject.NotSet
def _useAttributes(self, attributes):
if "body" in attributes:
@@ -129,3 +138,5 @@ class GitRelease(github.GithubObject.CompletableGithubObject):
self._url = self._makeStringAttribute(attributes["url"])
if "upload_url" in attributes:
self._upload_url = self._makeStringAttribute(attributes["upload_url"])
if "html_url" in attributes:
self._html_url = self._makeStringAttribute(attributes["html_url"])
+2
View File
@@ -39,6 +39,7 @@ class Release(Framework.TestCase):
self.assertEqual(self.release.title, "Test")
self.assertEqual(self.release.url, "https://api.github.com/repos/edhollandAL/PyGithub/releases/1210814")
self.assertEqual(self.release.author._rawData['login'], "edhollandAL")
self.assertEqual(self.release.html_url, "https://github.com/edhollandAL/PyGithub/releases/tag/v1.25.2")
# test __repr__() based on this attributes
self.assertEqual(self.release.__repr__(), 'GitRelease(title="Test")')
@@ -66,3 +67,4 @@ class Release(Framework.TestCase):
self.assertEqual(self.release.body, "release message")
self.assertEqual(self.release.title, "release title")
self.assertEqual(self.release.author._rawData['login'], "edhollandAL")
self.assertEqual(self.release.html_url, "https://github.com/edhollandAL/PyGithub/releases/tag/v3.0.0")