Make use of issue_url in PullRequest (#755)

Clean up some of the issue methods in PullRequest to make use of the
issue_url property, rather than chopping pieces off the URL to replace
/pulls/ with /issues/.
This commit is contained in:
Steve Kowalik
2018-04-17 18:20:56 +08:00
committed by Wan Liuyang
parent 981111dbe0
commit 0dba048f5c
+4 -4
View File
@@ -355,7 +355,7 @@ class PullRequest(github.GithubObject.CompletableGithubObject):
"""
headers, data = self._requester.requestJsonAndCheck(
"GET",
"/issues/".join(self.url.rsplit("/pulls/", 1))
self.issue_url
)
return github.Issue.Issue(self._requester, headers, data, completed=True)
@@ -408,7 +408,7 @@ class PullRequest(github.GithubObject.CompletableGithubObject):
}
headers, data = self._requester.requestJsonAndCheck(
"POST",
self._parentUrl(self._parentUrl(self.url)) + "/issues/" + str(self.number) + "/comments",
self.issue_url + "/comments",
input=post_parameters
)
return github.IssueComment.IssueComment(self._requester, headers, data, completed=True)
@@ -560,7 +560,7 @@ class PullRequest(github.GithubObject.CompletableGithubObject):
assert isinstance(id, (int, long)), id
headers, data = self._requester.requestJsonAndCheck(
"GET",
self._parentUrl(self._parentUrl(self.url)) + "/issues/comments/" + str(id)
self._parentUrl(self.issue_url) + "/comments/" + str(id)
)
return github.IssueComment.IssueComment(self._requester, headers, data, completed=True)
@@ -572,7 +572,7 @@ class PullRequest(github.GithubObject.CompletableGithubObject):
return github.PaginatedList.PaginatedList(
github.IssueComment.IssueComment,
self._requester,
self._parentUrl(self._parentUrl(self.url)) + "/issues/" + str(self.number) + "/comments",
self.issue_url + "/comments",
None
)