Commit Graph

1343 Commits

Author SHA1 Message Date
Dan d63f0c2a91 Making sure we create informative messages when encountering jinja2 syntax errors. 2023-01-25 14:13:21 -05:00
Dan c35ba85605 TaskShow had a useEffect that depended on params, that dependency caused an infinite request cycle when an error occured.
The same issue was happening on the ProcessInstanceListTable, and there it was being managed by a "SafelySetErrorMessage" function in one case,
but would not be addressed in all possible cases.

Reworked error handling into a context provider (APIErrorProvider) and hook (UseApiError) and removed the "(useContext as any)(ErrorContext)[1];" that felt a little off but that never was an actual problem.
2023-01-25 10:46:56 -05:00
jasquat 809c4b055a added uniqueness constraint to spiff step details w/ burnettk 2023-01-23 11:03:17 -05:00
burnettk 1215e18287 add sum and format 2023-01-22 18:10:47 -05:00
burnettk d282f66a5c make sure that all new form field elements are not dropdowns 2023-01-22 00:36:16 -05:00
jasquat 336923b1e5 expanded functionality of the form builder 2023-01-21 20:51:11 -05:00
burnettk dd68e7556b Revert "allow updating models on staging for a bit"
This reverts commit aff7c5c9e9.
2023-01-20 20:47:00 -05:00
burnettk 3e190387db Revert "commit on save yes for now"
This reverts commit 2a55c05473.
2023-01-20 20:46:52 -05:00
burnettk b4a19f2d71 qa1 2023-01-20 20:44:01 -05:00
burnettk fd2146bd46 since accepting the github host entry programatically is no more secure 2023-01-20 19:06:59 -05:00
burnettk 2a55c05473 commit on save yes for now 2023-01-20 19:00:46 -05:00
burnettk aff7c5c9e9 allow updating models on staging for a bit 2023-01-20 18:07:29 -05:00
jasquat 79958d4ae5 allow getting the GIT SSH key from an app config so we can set it in the secrets file w/ burnettk 2023-01-20 15:43:00 -05:00
jasquat d8cf4b1287 allow specifying an ssh key for git instead of a username and password w/ burnettk 2023-01-20 15:11:23 -05:00
jasquat d1b8e314f4 updated admin user on sartography realm w/ burnettk 2023-01-20 14:09:03 -05:00
jasquat 3da4f1caa1 allow passing a realm name into start keycloak and added admin user to sartography realm 2023-01-20 13:21:52 -05:00
jasquat 3f4781c5ee find the top level process to find the task form when using subprocesses in called activities w/ burnettk danfunk 2023-01-20 12:03:29 -05:00
jasquat 4e32f3efef Merge pull request #106 from sartography/feature/improved_errors
Feature/improved errors
2023-01-19 15:41:10 -05:00
jasquat 9e3c0823fd use the correct place for keycloak w/ burnettk 2023-01-19 15:40:36 -05:00
jasquat c5aff424b6 pyl w/ burnettk 2023-01-19 15:37:55 -05:00
Kevin Burnett ff10754b88 Merge branch 'main' into feature/improved_errors 2023-01-19 12:18:02 -08:00
jasquat d54897828d ensure we have something in the logs w/ burnettk 2023-01-19 15:16:59 -05:00
jasquat 5ef4ea7b62 pyl w/ burnettk 2023-01-19 15:03:33 -05:00
jasquat b529af6142 added configs for sartography env w/ burnettk 2023-01-19 14:54:39 -05:00
Dan d44b7d5d34 pre-commit-in-ci 2023-01-19 14:00:36 -05:00
Dan cf1fcf9966 updating spiffworkflow version, and fixing the run_pyl (by removing the corft I stuck in earlier) 2023-01-19 13:55:35 -05:00
jasquat 4f12a7826e Merge commit 'f612f26dd289ad14188e56e8634f832cf513f7cb' 2023-01-19 13:44:54 -05:00
jasquat f612f26dd2 Squashed 'spiffworkflow-frontend/' changes from d012f3a2c..f099c181a
f099c181a added script to add test keycloak users and moved all keycloak stuff to keycloak directory w/ burnettk
fc2ee7bc3 show start events in logs as well and added bpmn process identifiers to log table w/ burnettk
261b992b0 upgrade certifi to fix security vulnerability
94f785c7f do not navigate away from diagram editor page if there are changes w/ burnettk
4d16ad34e added End Event to simple log view w/ burnettk
d9f9a316d only show milestones for simple log view w/ burnettk
a3195fe1b fix lint issues
ff3fd9bc3 remove jsonpath
29b1dba9a added proof of concept to validate date fields in json schema form w/ burnettk
201dbebf2 fixed cypress tests
e2bedfd94 Merge branch 'main' of github.com:sartography/spiff-arena
990ccc119 added ability to add in custom validation error messages for text input fields w/ burnettk
94f31579a Merge pull request #102 from sartography/feature/waku-fault-message
32290c21d added tasks table to process instance show page w/ burnettk
2033634e1 Merge branch 'main' into feature/waku-fault-message
f03553acf added tabs to find by id page and install pre commit libraries if they fail to run help w/ burnettk
626d9056e stop at call activity as well when getting calling subprocesses by child id w/ burnettk
bf4099345 Merge branch 'main' into feature/waku-fault-message
bdeb03c42 added detailed area to process instance show page w/ burnettk
38341a987 a little more cleanup w/ burnettk
3f0b2f9fa remove several debug print statements
b920be55c logout works now and queryparams are getting passed correctly on login now
b84276aea Merge branch 'main' into feature/waku-fault-message
19574ad36 linting
96bf60a41 remove unneeded protocol variable w/ burnettk
a552ca6e7 use the cookie from the frontend w/ burnettk
e4f354e37 this somewhat works and sets cookies w/ burnettk
1a12b7ac8 debugging cookies w/ burnettk
11efb5ec4 updated rjsf to beta.16 and updated validations from v6 to v8 w/ burnettk
d67af9719 show the error and success notifications when appropriate when editing xml for json w/ burnettk
7ac328843 only load file references when needed to avoid unnecessary xml errors w/ burnettk
4834434c7 Merge remote-tracking branch 'origin/main' into feature/add_some_xml_validations
85449e564 some updates to validate xml when uploading and saving w/ burnettk
c1f271723 Merge branch 'main' into feature/waku-fault-message
d63269bec handle subprocesses in navigation
e680734a9 call proceses through setProcesses to ensure we have up to date value and removed debug logs w/ burnettk
9ad1e0ced more debug logs w/ burnettk
172d171cb more debugging and do not watch ProcessModel with getting processes w/ burnettk
73cab1863 added in debug logging for launching call activity editor w/ burnettk
248661b6e fixed cypress config w/ burnettk
3cee57987 Add `fault_or_suspend_on_exception` and `exception_notification_addresses` to Process Model interface and create/update form.
2463e1411 actually filter by process initiator w/ burnettk
cd4fda787 highlight tasks even if they are in subprocesses of called activities w/ burnettk

git-subtree-dir: spiffworkflow-frontend
git-subtree-split: f099c181a4b434a8f86dbca2942dae6c20534970
2023-01-19 13:44:54 -05:00
jasquat be5e96199a Merge commit '1cedc2ea50ec9827437c4b87dfc6d2bd41a767b1' 2023-01-19 13:44:53 -05:00
jasquat 1cedc2ea50 Squashed 'spiffworkflow-backend/' changes from 094de3563..031713a61
031713a61 added new test users for status in keycloak w/ burnettk
da25a85b7 added script to add test keycloak users and moved all keycloak stuff to keycloak directory w/ burnettk
74c46c9b4 pin SpiffWorkflow to passing version for CI tests w/ burnettk
3bb4c893f Merge pull request #105 from sartography/feature/avoid_logs_when_call_activity_waiting
b8d664381 disabled flake8 forcing comments to avoid all of the useless comments but still enforcing the formatting of comments if they exist w/ burnettk
9be85cac6 show start events in logs as well and added bpmn process identifiers to log table w/ burnettk
ab5b1f77f downgrade spiff and upgrade some other stuff
b51e1ca59 upgrade certifi to fix security vulnerability
65b9005d4 do not allow overwriting process models and process groups w/ burnettk
70b9ce61c added End Event to simple log view w/ burnettk
1c2fe64f1 pyl w/ burnettk
56de0294a skip failing xml test on windows w/ burnettk
31944bd07 use the correct windows path separator in test file
1e070f87c favor user_input_required over waiting status for process instances w/ burnettk
9ced1b90a fixed broken test w/ burnettk
8ae6929d1 only show milestones for simple log view w/ burnettk
b98908fa3 do not resolve entities when parsing xml w/ burnettk
ecf8acaf5 do not write to logs when a task is inheriting data from the parent w/ burnettk
e81d7b8f5 updated open id url for compose ci
acf115c5f pyl
8a0982ea9 fixed cypress tests
399a6ac69 postgres does not have group_concat, and it is stricter about getting back columns when grouping
c813209c4 Merge pull request #102 from sartography/feature/waku-fault-message
7e5d4d8ce Merge pull request #101 from sartography/task_data_len
4b0ffb17c Merge branch 'main' of github.com:sartography/spiff-arena
ef55abb7a fixed broken test w/ burnettk
9608f65ef Skip refresh steps (#103)
20a48e6ef added tasks table to process instance show page w/ burnettk
f071832e0 Merge branch 'main' into feature/waku-fault-message
57249528d run_pyl changes
30132ed09 Fixed failing test
a0f9d7e39 stop at call activity as well when getting calling subprocesses by child id w/ burnettk
e4ebe4544 Getting ./bin/pyl to pass
cf0a78aef Merge branch 'main' into task_data_len
48083b164 Bump the limit to 1mb
202ba2e8c Better impl
5bf49c386 reorder imports
c53328523 import order
c67872354 unused imports
d9a9eeae8 Merge branch 'main' into feature/waku-fault-message
e98a4540c POC checking cumulative task data len
fe5258780 fixed failing test w/ burnettk
d00d28d95 added detailed area to process instance show page w/ burnettk
910311832 set the domain for the token cookies w/ burnettk
3cae7055a a little more cleanup w/ burnettk
f756453b3 remove several debug print statements
3180353bb logout works now and queryparams are getting passed correctly on login now
0ee732842 pyl
a55b14f53 Merge branch 'main' into feature/waku-fault-message
e7ab8f8b8 Cleaned up the message text
fa299f412 Precommit
999b19062 mypy
6260af4b6 use the cookie from the frontend w/ burnettk
0e50e71db this can run on localhost with cookies w/ burnettk
aa626d743 this somewhat works and sets cookies w/ burnettk
4b5d2d611 debugging cookies w/ burnettk
4f04ed716 updated get_token to actually work
b31f04a65 Removed test for email error handler. Added stub for testing system handler process
77e4e017a lint w/ burnettk
38951f4d6 only load file references when needed to avoid unnecessary xml errors w/ burnettk
018bd8d1c save a process model file after running all validations w/ burnettk
9c45eedf1 Merge remote-tracking branch 'origin/main' into feature/add_some_xml_validations
5804f058e fixed failing tests
8eb4f1ac9 some updates to validate xml when uploading and saving w/ burnettk
63aad8839 pyl
4120deddb Merge branch 'main' into feature/waku-fault-message
1181d4191 Work on System Notification handler
d5fe920af handle subprocesses in navigation
b1b694982 call proceses through setProcesses to ensure we have up to date value and removed debug logs w/ burnettk
35fb0e130 attempting to use correct ids vs paths for windows w/ burnettk
fc580cbba more debug logs w/ burnettk
874d99580 Merge pull request #96 from sartography/feature/fix_docker_script_in_ci
ab81e753c added in debug logging for launching call activity editor w/ burnettk
ff73d5b0f fixed typeguard tests w/ burnettk
4792c66a3 fixed typeguard tests w/ burnettk
b8dda8779 pyl w/ burnettk
c16b59044 fix setting the bpmn dir in start scripts w/ burnettk
b70ef1796 Update process_models_controller to include `fault_or_suspend_on_exception` and `exception_notification_addresses` for Process Model create/update
39d374341 also show skipped tasks in the simplified log w/ burnettk
94c6f4ccd some updates to test w/ burnettk
2ebb3a14c do not allow sending messages to terminated and suspended process instances w/ burnettk
4cad37bf3 pyl w/ burnettk
2f1a11cd5 actually filter by process initiator w/ burnettk
9565d8548 Merge branch 'main' of github.com:sartography/spiff-arena
f1e399c87 highlight tasks even if they are in subprocesses of called activities w/ burnettk
00049fcc5 ensure we are not accidentally using main
9e4b37e7a updated SpiffWorkflow w/ burnettk

git-subtree-dir: spiffworkflow-backend
git-subtree-split: 031713a61add3cadf7a608732134dd4f15d34668
2023-01-19 13:44:53 -05:00
Dan 8496b722fd Merges 2023-01-19 13:26:13 -05:00
Dan 38ffb10fa5 Merge commit '9d58cffa58f8178220dcc7c517cdb5b103fe4e1b' into feature/improved_errors 2023-01-19 12:37:17 -05:00
Dan 9d58cffa58 Squashed 'SpiffWorkflow/' changes from 4195453a4..1f51db962
1f51db962 Merge pull request #283 from sartography/feature/better_errors
69fb4967e Patching up some bugs and logical disconnects as I test out the errors.
cf5be0096 * Making a few more things consistent in the error messages -- so there isn't filename for validation errors, and file_name for WorkflowExceptions.  Same for line_number vs sourceline. * Assure than an error_type is consistently set on exceptions. * ValidationExceptions should not bild up a detailed error message that replicates information available within it.
440ee16c8 Responding to some excellent suggestions from Elizabeth:
655e415e1 Merge pull request #282 from subhakarks/fix-workfowspec-dump
1f6d3cf4e Explain that the error happened in a pre-script or post script.
8119abd14 Added a top level SpiffWorklowException that all exceptions inherit from.  Aside from a message string you can append information to these exceptions with "add_note", which is a new method that all exceptions have starting in python 3.11 Switched arguments to the WorkflowException, WorkflowTaskException - which now always takes a string message as the first argument, and named arguments thereafter to be consistent with all other error messages in Python. Consistently raise ValidationExceptions whenever we encounter an error anywhere during parsing of xml. The BPMN/WorkflowTaskExecException is removed, in favor of just calling a WorkflowTaskException.  There is nothing BPMN Specific in the logic, so no need for this. Consolidated error message logic so that things like "Did you mean" just get added by default if possible.  So we don't have to separately deal with that logic each time. Better Error messages for DMN (include row number as a part of the error information)
13463b5c5 fix for workflowspec dump
be26100bc Merge pull request #280 from sartography/feature/remove-unused-bpmn-attributes-and-methods
23a5c1d70 remove 'entering_* methods
4e5875ec8 remove sequence flow
5eed83ab1 Merge pull request #278 from sartography/feature/remove-old-serializer
614f1c68a remove compact serializer and references
e7e410d4a remove old serializer and references

git-subtree-dir: SpiffWorkflow
git-subtree-split: 1f51db962ccaed5810f5d0f7d76a932f056430ab
2023-01-19 12:37:17 -05:00
Dan 3c12e8ad35 Lots of adjustments from running pyl
Main change is in the ErrorDisplay.tsx to assure all error information is provided. and index.css to make it "pretty"
2023-01-19 12:36:45 -05:00
jasquat 21f7b04039 added new test users for status in keycloak w/ burnettk 2023-01-19 12:21:25 -05:00
jasquat 306676aa11 added script to add test keycloak users and moved all keycloak stuff to keycloak directory w/ burnettk 2023-01-19 12:18:05 -05:00
jasquat dd8427bd32 pin SpiffWorkflow to passing version for CI tests w/ burnettk 2023-01-19 11:10:36 -05:00
jasquat b5be1745d8 Merge pull request #105 from sartography/feature/avoid_logs_when_call_activity_waiting
do not write to logs when a task is inheriting data from the parent w…
2023-01-19 11:08:51 -05:00
jasquat e4a3029793 Merge commit 'af293a91d12771d02ea37246fb02c53b57a10c03' 2023-01-19 10:47:07 -05:00
jasquat af293a91d1 Squashed 'SpiffWorkflow/' changes from 4195453a4..1f51db962
1f51db962 Merge pull request #283 from sartography/feature/better_errors
69fb4967e Patching up some bugs and logical disconnects as I test out the errors.
cf5be0096 * Making a few more things consistent in the error messages -- so there isn't filename for validation errors, and file_name for WorkflowExceptions.  Same for line_number vs sourceline. * Assure than an error_type is consistently set on exceptions. * ValidationExceptions should not bild up a detailed error message that replicates information available within it.
440ee16c8 Responding to some excellent suggestions from Elizabeth:
655e415e1 Merge pull request #282 from subhakarks/fix-workfowspec-dump
1f6d3cf4e Explain that the error happened in a pre-script or post script.
8119abd14 Added a top level SpiffWorklowException that all exceptions inherit from.  Aside from a message string you can append information to these exceptions with "add_note", which is a new method that all exceptions have starting in python 3.11 Switched arguments to the WorkflowException, WorkflowTaskException - which now always takes a string message as the first argument, and named arguments thereafter to be consistent with all other error messages in Python. Consistently raise ValidationExceptions whenever we encounter an error anywhere during parsing of xml. The BPMN/WorkflowTaskExecException is removed, in favor of just calling a WorkflowTaskException.  There is nothing BPMN Specific in the logic, so no need for this. Consolidated error message logic so that things like "Did you mean" just get added by default if possible.  So we don't have to separately deal with that logic each time. Better Error messages for DMN (include row number as a part of the error information)
13463b5c5 fix for workflowspec dump
be26100bc Merge pull request #280 from sartography/feature/remove-unused-bpmn-attributes-and-methods
23a5c1d70 remove 'entering_* methods
4e5875ec8 remove sequence flow
5eed83ab1 Merge pull request #278 from sartography/feature/remove-old-serializer
614f1c68a remove compact serializer and references
e7e410d4a remove old serializer and references

git-subtree-dir: SpiffWorkflow
git-subtree-split: 1f51db962ccaed5810f5d0f7d76a932f056430ab
2023-01-19 10:47:07 -05:00
jasquat ed86a7f843 disabled flake8 forcing comments to avoid all of the useless comments but still enforcing the formatting of comments if they exist w/ burnettk 2023-01-19 10:41:26 -05:00
jasquat f5b77f9245 show start events in logs as well and added bpmn process identifiers to log table w/ burnettk 2023-01-19 10:06:30 -05:00
burnettk edf11f76cf downgrade spiff and upgrade some other stuff 2023-01-19 07:59:26 -05:00
burnettk cd07be3e28 upgrade certifi to fix security vulnerability 2023-01-19 07:38:57 -05:00
jasquat 7415c55ce7 do not navigate away from diagram editor page if there are changes w/ burnettk 2023-01-18 16:43:11 -05:00
jasquat 238308ca79 do not allow overwriting process models and process groups w/ burnettk 2023-01-18 14:40:03 -05:00
jasquat fa4c3d26d7 added End Event to simple log view w/ burnettk 2023-01-18 12:01:37 -05:00
jasquat 2a9f63e9b8 pyl w/ burnettk 2023-01-18 10:39:53 -05:00
jasquat c2daae0420 skip failing xml test on windows w/ burnettk 2023-01-18 10:38:43 -05:00
jasquat f3c404aa09 use the correct windows path separator in test file 2023-01-18 09:43:19 -05:00