sartography
/
spiff-arena
mirror of https://github.com/sartography/spiff-arena.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

skip failing xml test on windows w/ burnettk

This commit is contained in:
jasquat 2023-01-18 10:38:43 -05:00
parent f3c404aa09
commit c2daae0420
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
spiffworkflow-backend/tests/data/xml_with_entity/invoice.bpmn
View File

@ -1,5 +1,5 @@
<!--?xml version="1.0" ?--> <!--?xml version="1.0" ?-->
<!DOCTYPE replace [<!ENTITY ent SYSTEM "{{FULL_PATH_TO_FILE}}"> ]> <!DOCTYPE replace [<!ENTITY ent SYSTEM "file://{{FULL_PATH_TO_FILE}}"> ]>
<userInfo> <userInfo>
<firstName>John</firstName> <firstName>John</firstName>
<lastName>&ent;</lastName> <lastName>&ent;</lastName>

5
spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_spec_file_service.py
View File

@ -1,5 +1,6 @@
"""Test_message_service.""" """Test_message_service."""
import os import os
import sys
import pytest import pytest
from flask import Flask from flask import Flask
@ -238,6 +239,7 @@ class TestSpecFileService(BaseTest):
full_file_path = SpecFileService.full_file_path(process_model, "bad_xml.bpmn") full_file_path = SpecFileService.full_file_path(process_model, "bad_xml.bpmn")
assert not os.path.isfile(full_file_path) assert not os.path.isfile(full_file_path)
@pytest.mark.skipif(sys.platform == "win32", reason="tmp file path is not valid xml for windows and it doesn't matter")
def test_does_not_evaluate_entities( def test_does_not_evaluate_entities(
self, self,
app: Flask, app: Flask,
@ -249,9 +251,6 @@ class TestSpecFileService(BaseTest):
tmp_file = os.path.normpath( tmp_file = os.path.normpath(
self.get_test_data_file_full_path("file_to_inject", "xml_with_entity") self.get_test_data_file_full_path("file_to_inject", "xml_with_entity")
) )
# add the file: with the correct separator for windows
tmp_file = f"file:{os.path.sep}{tmp_file}"
file_contents = self.get_test_data_file_contents( file_contents = self.get_test_data_file_contents(
"invoice.bpmn", "xml_with_entity" "invoice.bpmn", "xml_with_entity"
) )