From c2daae0420ca343d5c5bd03f3ea51cc1f6c8a3ba Mon Sep 17 00:00:00 2001 From: jasquat Date: Wed, 18 Jan 2023 10:38:43 -0500 Subject: [PATCH] skip failing xml test on windows w/ burnettk --- .../tests/data/xml_with_entity/invoice.bpmn | 2 +- .../spiffworkflow_backend/unit/test_spec_file_service.py | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/spiffworkflow-backend/tests/data/xml_with_entity/invoice.bpmn b/spiffworkflow-backend/tests/data/xml_with_entity/invoice.bpmn index d002979e9..44216f1e3 100644 --- a/spiffworkflow-backend/tests/data/xml_with_entity/invoice.bpmn +++ b/spiffworkflow-backend/tests/data/xml_with_entity/invoice.bpmn @@ -1,5 +1,5 @@ - ]> + ]> John &ent; diff --git a/spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_spec_file_service.py b/spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_spec_file_service.py index fad5a41af..3e9201305 100644 --- a/spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_spec_file_service.py +++ b/spiffworkflow-backend/tests/spiffworkflow_backend/unit/test_spec_file_service.py @@ -1,5 +1,6 @@ """Test_message_service.""" import os +import sys import pytest from flask import Flask @@ -238,6 +239,7 @@ class TestSpecFileService(BaseTest): full_file_path = SpecFileService.full_file_path(process_model, "bad_xml.bpmn") assert not os.path.isfile(full_file_path) + @pytest.mark.skipif(sys.platform == "win32", reason="tmp file path is not valid xml for windows and it doesn't matter") def test_does_not_evaluate_entities( self, app: Flask, @@ -249,9 +251,6 @@ class TestSpecFileService(BaseTest): tmp_file = os.path.normpath( self.get_test_data_file_full_path("file_to_inject", "xml_with_entity") ) - - # add the file: with the correct separator for windows - tmp_file = f"file:{os.path.sep}{tmp_file}" file_contents = self.get_test_data_file_contents( "invoice.bpmn", "xml_with_entity" )