896ce8934b
Merge pull request #477 from sartography/bug/645_document_updated
...
An optimization prevented us from picking up a change to the document…
2022-02-28 15:57:13 -05:00
f30d6718ce
Merge pull request #478 from sartography/duplicate-menu-items-642
...
Duplicate menu items #642
2022-02-28 15:50:24 -05:00
91ed50e45e
Be sure we update the document list when new workflow documents are added.
2022-02-28 15:49:21 -05:00
2ab3df2466
Force an error during test_spec, to make sure we clean up workflows
2022-02-28 14:02:26 -05:00
ef4334b1c8
Added a catch for generic exceptions, so the `finally` clause always executes.
...
Also, raise if there is an ApiError, because some tests depend on it.
2022-02-28 14:01:19 -05:00
51a14311eb
An optimization prevented us from picking up a change to the documents associated with a study. This assures that even if scripts run side by side, the document list will get updated, but only on a change. So it's still performant. Also added a sligthly better error message to the workflow service.
2022-02-28 12:17:21 -05:00
1dfebf9f1f
Merge pull request #476 from sartography/bug/no-assignment-tasks-639
...
Fixes #639 - Pending Approvals Panel No longer displaying
2022-02-27 19:37:00 -05:00
ad17db067d
mild little performance improvement.
2022-02-27 19:32:45 -05:00
5dfb3153d1
Fixes #639 - Pending Approvals Panel No longer displaying
2022-02-27 12:21:38 -05:00
69beadd4ae
Merge branch 'master' of github.com:sartography/cr-connect-workflow
2022-02-27 11:01:50 -05:00
28e8a4b47e
Merge pull request #475 from sartography/bug/failed_validation
...
Fixing failing validation.
2022-02-27 11:01:09 -05:00
ebbb04a1af
Fixing failing validation.
2022-02-27 10:00:44 -05:00
9c098717da
Merge pull request #474 from sartography/dev
...
dev to master
2022-02-25 16:21:09 -05:00
9b004d0dc6
Merge pull request #462 from sartography/feature/delete-variable-script-584
...
Feature/delete variable script #584
2022-02-25 16:19:51 -05:00
2c427cc34c
Temporary fix for variable issue in SpiffWorkflow.
...
There is a fix coming in SpiffWorkflow
2022-02-25 15:56:13 -05:00
f2c97f80d5
Merge branch 'dev' into feature/delete-variable-script-584
...
# Conflicts:
# Pipfile.lock
2022-02-25 15:54:34 -05:00
140de7ed03
Merge pull request #473 from sartography/nonetype-displayname-error-632
...
Nonetype displayname error #632
2022-02-25 15:41:14 -05:00
ce8eca8fe1
Merge pull request #472 from sartography/dependabot/pip/celery-5.2.2
...
Bump celery from 4.4.7 to 5.2.2
2022-02-25 15:40:35 -05:00
bfcfedbffc
Test for the bug fix
2022-02-25 14:43:32 -05:00
531802f927
Make sure we don't try to get WorkflowMetadata if the spec does not exist
...
This was raising a 500 error
2022-02-25 14:41:58 -05:00
c16b63a67b
Bump celery from 4.4.7 to 5.2.2
...
Bumps [celery](https://github.com/celery/celery ) from 4.4.7 to 5.2.2.
- [Release notes](https://github.com/celery/celery/releases )
- [Changelog](https://github.com/celery/celery/blob/master/Changelog.rst )
- [Commits](https://github.com/celery/celery/compare/v4.4.7...v5.2.2 )
---
updated-dependencies:
- dependency-name: celery
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2022-02-25 17:23:52 +00:00
99a1e1c31a
Merge pull request #471 from sartography/dev
...
dev to master
2022-02-25 12:11:20 -05:00
18802d6732
Merge pull request #468 from sartography/chore/performance
...
Performance Improvements:
2022-02-25 12:10:47 -05:00
98c0687a1f
Bumping SpiffWorkflow version.
2022-02-25 10:31:03 -05:00
dd7eddb936
Merge pull request #470 from sartography/update-email-reply-address-629
...
Modify default sender for emails #629
2022-02-25 10:30:21 -05:00
b6af80f6de
Merge pull request #469 from sartography/feature/modify-spreadsheet-624
...
modify spreadsheet #624
2022-02-25 10:29:37 -05:00
5ff84d74f1
Merge pull request #464 from sartography/feature/start-workflow-602
...
Feature/start workflow #602
2022-02-25 10:28:26 -05:00
3944d00e88
Removing an unused / rogue variable.
...
Adding a logger warning for very large workflow json data.
2022-02-25 09:59:41 -05:00
10880d6354
Modify default sender for emails
2022-02-25 08:38:40 -05:00
9d2436b375
Typo calling script with keywords
2022-02-25 08:18:07 -05:00
e61ca471db
remove all the @timeit from method calls.
2022-02-24 21:06:22 -05:00
dde8873c9e
1. defer the loading of the bpmn_json when loading the workflow model. It can be stupidly larger. (see models/workflow.py)
...
2. Shave a little more time off the reset by not re-creating the whole WorkflowProcessor
cleaning up all the firsttime/sincetime statements.
2022-02-24 20:56:57 -05:00
82a90846fc
Upgrading libraries - upgrade to Flask 2.0 (previously locked at 1.1.4 because of Connexion)
2022-02-24 15:38:08 -05:00
3442655bd1
Performance Improvements:
...
1. Avoid ever re-generating the list of scripts that can be used in a script task. Terribly expensive as we call eval constantly, and it never ever changes once the app starts. (see script.py changes, and comments)
2. Cache the DocumentStatus list in the flask session, so we calculate it at most once per API Call. It's at least .25 seconds per call. (see study_sevice)
3. We called UserFileService.get_files_for_study (which runs a db query EVERY time) for every possible document type. Now we run the query once (study service line 321)
4. When returning a workflow, we looped through every single task in that workflow's navigation, and called the expensive spiff_task_to_api_task just to figure out it's proper display name. We run a much faster and more efficient method to calculate the display name naow (see workflow_service on lie 680, and 799)
5. A hellton of @timeit and sincetime() calls, that I want to leave in, to help debug any slowness on production.
2022-02-24 14:25:42 -05:00
ed0499a573
Make sure we have a workflow.
...
Raise an ApiError with the workflow_spec_id if we cannot find a workflow
2022-02-24 12:37:25 -05:00
c3f9ab28d0
Merge pull request #467 from sartography/dev
...
dev to master
2022-02-24 11:28:41 -05:00
78c9dc1b7b
Merge pull request #466 from sartography/feature/modify-spreadsheet-624
...
Feature/modify spreadsheet #624
2022-02-24 11:26:43 -05:00
c1606a20a5
Don't call an api endpoint from a script.
2022-02-24 11:14:24 -05:00
e1bd301e41
Merge branch 'dev' into feature/start-workflow-602
2022-02-24 10:36:38 -05:00
0b3187889d
We now raise an error if the spreadsheet does not exist.
...
Added test for case where the spreadsheet does not exist
2022-02-24 10:25:34 -05:00
1fe1ce2e22
Merge branch 'dev' into feature/modify-spreadsheet-624
2022-02-24 09:42:53 -05:00
33dc1f0868
Merge pull request #465 from sartography/bug/628_jinja_template_errors
...
fix to assure we produce a usable error message
2022-02-24 08:50:41 -05:00
e8617038ab
Merge pull request #461 from sartography/bug/missing-executabe-option-601
...
Bug/missing executabe option #601
2022-02-24 08:46:46 -05:00
d378078d6f
Change so that we always use the current workflow
2022-02-23 15:18:03 -05:00
679a875666
Test for new script
2022-02-23 14:30:45 -05:00
b6a39dfd25
Script to insert data into an existing (irb_document) spreadsheet.
...
Requires `upload_workflow_id`, `irb_doc_code`, `cell`, and `text` parameters.
The cell parameter should be something like 'B21'
2022-02-23 14:29:50 -05:00
23a43c0472
fix to assure we produce a usable error message
2022-02-23 11:53:24 -05:00
41d562ca26
Changed code in error message
2022-02-22 14:41:30 -05:00
1860509c1e
Fixed error message
2022-02-22 14:39:49 -05:00
2aea4bc1ae
Test for new script
2022-02-22 14:37:53 -05:00
Dan Funk
mike cullerton
alicia pritchett
dependabot[bot]