sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-23 13:18:35 +00:00
Code Issues Packages Projects Releases Wiki Activity
720 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

720 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Dan Funk
c790737bf0 The complete_template script might not grab the correct document when validating, fixed. 
Updated to latest RRT files, and passing.
 2020-06-01 12:33:58 -04:00
Dan Funk
b6bf843f6e used 'name' rather than 'value' in the lookup options during validation, causing a disconnect with how this is processed on the front end. 2020-06-01 11:00:56 -04:00
Aaron Louie
bb32bd7090
Merge pull request #91 from sartography/feature/approvals_enhancements 
Approvals enhancements
 2020-06-01 00:46:59 -04:00
Aaron Louie
7c8b7829ea Merge branch 'rrt/dev' into feature/approvals_enhancements 2020-06-01 00:41:51 -04:00
Aaron Louie
1702ab2576 Fixes decision tables that were causing failing tests 2020-06-01 00:36:25 -04:00
Aaron Louie
ea441dbff5 More updates 2020-06-01 00:28:37 -04:00
Aaron Louie
8092bbe682 Wrong file in wrong place. 2020-06-01 00:17:20 -04:00
Aaron Louie
7351dc4a43 Updates RRT workflow spec files for reals this time 2020-06-01 00:14:09 -04:00
Aaron Louie
2d5eb740ef Updates RRTworkflow spec files 2020-06-01 00:07:50 -04:00
Carlos Lopez
bec11980eb Fixing broken test by using proper FileSchema 2020-05-31 22:00:52 -06:00
Aaron Louie
311e180c65 Comments out failing test for now. Adds a placeholder test for study approvals 2020-05-31 23:16:14 -04:00
Carlos Lopez
b2e56f797b Converting ApprovalModel to Approval in order to serialize properly the result 2020-05-31 21:02:47 -06:00
Aaron Louie
cd16b984e0 Adds workflow spec title to workflow api schema 2020-05-31 22:46:56 -04:00
Aaron Louie
f0bd8d4f9e Adds approvals to study schema. Adds approvals endpoint 2020-05-31 22:46:32 -04:00
Dan Funk
9c7de39b09 This adds additional file data details to the study model as well. 2020-05-31 21:15:40 -04:00
Carlos Lopez
dd6c1d2b42 Renaming approval files 2020-05-31 18:16:42 -06:00
Carlos Lopez
2e54f07095 Adding more info to files and renaming approval waiting status 2020-05-31 17:24:23 -06:00
Carlos Lopez
26809d1470 Waiting status renaming 2020-05-31 13:35:42 -06:00
Dan Funk
2bc735a3f0 Kelly wrote a beautiful method for resetting the workflow that doesn't loose data when reset inside a parallel task, all I needed to do was use it. 
Catching TypeErrors and reporting them back to the UI so we don't 500 in a bad way (but we still 500)
 2020-05-31 13:48:00 -04:00
Dan Funk
98fb305868 Run the validation process twice, each time it is requested, first populating everything, and then a second time 
using on the required form fields.
 2020-05-30 18:43:20 -04:00
Dan Funk
1f0e8741ba Run the validation twice, once completing all of the data, and a second time, completing only the required fields. 
Also, add a helper method to reduce boiler plate code around Workflow Exceptions.
 2020-05-30 17:26:27 -04:00
Dan Funk
860c475b29 Fill out repeating sections during validation process. 
Also, when returning error messages, attempt to include the task data for the task that caused the error.
Also, when attempting to delete any file, respond with an API error explaining the issue, and log the details.
 2020-05-30 15:37:04 -04:00
Aaron Louie
3399ee285c Merge branch 'rrt/production' into rrt/dev 2020-05-29 21:41:43 -04:00
Aaron Louie
eeae3d1038 Merge branch 'dev' into rrt/production 2020-05-29 17:27:20 -04:00
Dan Funk
5046d3a669 Committed a stupid. 2020-05-29 15:20:22 -04:00
Dan Funk
d51fbe51e0 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2020-05-29 15:18:41 -04:00
Dan Funk
4e4cc7884c Better ldap searching. 2020-05-29 15:17:51 -04:00
Aaron Louie
d16defc230 Merge branch 'dev' into rrt/dev 2020-05-29 13:33:25 -04:00
Aaron Louie
5d4cba0b0a Merge branch 'dev' into rrt/production 2020-05-29 12:44:39 -04:00
Aaron Louie
f88832da52 Merge branch 'feature/approval_request_script' into dev 2020-05-29 12:13:01 -04:00
Dan Funk
079a0c1feb Moving spiff dependency to a deploy branch 2020-05-29 11:36:03 -04:00
Aaron Louie
34b812b74e Updates RRT workflow spec files 2020-05-29 10:49:47 -04:00
Aaron Louie
7e0042cfdb Merge branch 'dev' into feature/approval_request_script 2020-05-29 10:31:46 -04:00
Aaron Louie
610706d110 Merge branch 'dev' into rrt/production 2020-05-29 10:06:31 -04:00
Aaron Louie
7f2c1eb8e1 Updates Pipfile hashes 2020-05-29 10:06:11 -04:00
Aaron Louie
4fa7e04d99 Merge branch 'dev' into feature/approval_request_script 2020-05-29 09:19:26 -04:00
Aaron Louie
db9b1a4491 Merge branch 'dev' into rrt/production 2020-05-29 09:18:51 -04:00
Aaron Louie
4c51c47c5e Merge remote-tracking branch 'origin/feature/approval_request_script' into feature/approval_request_script 2020-05-29 07:50:31 -04:00
Dan Funk
09fb8ef2a9
Merge pull request #79 from sartography/feature/approval_request_script 
Feature/approval request script
 2020-05-29 05:05:36 -04:00
Dan Funk
895d2f8852 Slight change to the way the approval model is connected. 2020-05-29 05:04:18 -04:00
Dan Funk
0ba2819867 Merge branch 'dev' into feature/approval_request_script 2020-05-29 04:51:50 -04:00
Dan Funk
90d2931f6e
Merge pull request #81 from sartography/feature/file_refactor_part2 
Feature/file refactor part2
 2020-05-29 04:44:09 -04:00
Dan Funk
afb6be7c60 re-working the way the redirects function, so we pass arguments as a get parameter. Just trying to get rid of the weird lag on production. 
I noticed the validation sometimes looks ahead for files, so looking at all the tasks now, not just the ready tasks for the lookup field.
Ran into an issue with validation where a workflow model was required, so I create one and delete it.  Another refactor for another day.
 2020-05-29 04:42:48 -04:00
Dan Funk
11413838a7 Faster lookup fields. We were parsing the spec each time to get details about how to search. We're just grabbing the workflow id and task id now and building that straight into the full text search index for faster lookups. Should be peppy. 
Another speed improvement - data in the FileDataModel is deferred, and not queried until it is specifically used, as the new data structures need to use this model frequently.
 2020-05-29 01:39:39 -04:00
Dan Funk
22bdb6c760 This migration will clear out any approvals in the database. 2020-05-28 20:13:33 -04:00
Dan Funk
aea78de066 Merge remote-tracking branch 'origin/dev' into feature/file_refactor_part2 2020-05-28 20:06:32 -04:00
Dan Funk
dba41f4759 Ludicrously stupid launch in a refactor of the way all files work in the system at a time where I crave sleep and peace above all other things. 
Added a File class, that we wrap around the FileModel so the api endpoints don't change, but File no longer holds refences to versions or dates of the file_data model, we
figure this out based on a clean database structure.

The ApprovalFile is directly related to the file_data_model - so no chance that a reviewer would review the incorrect version of a file.py

Noticed that our FileType enum called "bpmn" "bpmm", hope this doesn't screw someone up.

Workflows are directly related to the data_models that create the workflow spec it needs.  So the files should always be there.  There are no more hashes, and thus no more hash errors where it can't find the files to rebuild the workflow.py

Not much to report here, other than I broke every single test in the system at one point.  So I'm super concerned about this, and will be testing it a lot before creating the pull request.
 2020-05-28 20:03:50 -04:00
Aaron Louie
04e5a476c4 Merge branch 'dev' into feature/approval_request_script 2020-05-28 17:02:21 -04:00
Aaron Louie
91dca030f6 Merge branch 'dev' into rrt/production 2020-05-28 10:43:14 -04:00
Aaron Louie
dedec02d48 Updates RRT workflow spec files 2020-05-28 10:43:03 -04:00