sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-23 21:28:32 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,986 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

1122 Commits

Author SHA1 Message Date
Dan
fb54edac1c Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct. 
Most noteable is the addition of the line on which the error occurs for script tasks.  It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
 2021-07-07 00:53:49 -04:00
mike cullerton
894377a607 Add user_uid to FileDataModel calls 2021-07-06 17:09:00 -04:00
mike cullerton
23be257db0 Add user_uid column to file_data table 2021-07-06 17:07:47 -04:00
Dan
a9805ad40c Adding some documentation for clarity. 2021-07-06 14:40:20 -04:00
Dan
cafdc4d100 Removing an unneeded modification to the database structure for lookup tables. 2021-07-06 14:02:07 -04:00
Dan
04842aa66b Undo change to 1 minute. 2021-07-06 13:13:07 -04:00
Dan
7aa4b0833c Merge remote-tracking branch 'origin/dev' into feature/documents_xls_refactor 2021-07-06 13:11:08 -04:00
Dan
1b1a994360 Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them. 
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
 2021-07-06 13:10:20 -04:00
Kelly McDonald
9803a04d6d Make a change so that anything that has a waiting event is labeled in the database as waiting, even if it is sitting around waiting on a user input task that is ready 2021-07-06 11:46:47 -04:00
Kelly McDonald
dce1d86e93 commit changes before looking at something else 2021-07-06 10:34:57 -04:00
mike cullerton
f647390e1c Added description and validate_only 2021-07-02 15:51:24 -04:00
mike cullerton
9690c69b6c added check_study method to protocol_builder service for new endpoint 2021-07-02 15:25:33 -04:00
mike cullerton
cd26654b3a Script to call new pb mock api endpoint check_study 2021-07-02 15:21:35 -04:00
mike cullerton
db44882733 When we encounter a name error running a script, look in the task data and see if there is a variable with a similar name. 
If a variable with a similar name exists, add it to the ApiError as a hint
 2021-07-01 15:38:45 -04:00
Mike Cullerton
98d641f54d
Merge branch 'dev' into partial_testing 2021-06-30 16:13:31 -04:00
NWalker4483
508ef1ff2b Readded exit_at to workflow param 2021-06-30 11:15:48 -04:00
Dan
9a32fadc2f Merge branch 'dev' into 346-waiting-task-schedule 
# Conflicts:
#	Pipfile.lock
#	crc/services/workflow_service.py
 2021-06-30 10:14:37 -04:00
Dan
a79ba22410 fixes to get the tests passing. We were missing a dependency in the Pipfile and the data_store had some invalid imports. 2021-06-30 10:06:57 -04:00
NWalker4483
2ba52a7095 Merge remote-tracking branch 'origin/HEAD' into partial_testing 2021-06-29 11:21:49 -04:00
Dan
187221537b fixing a corner case around file_data attributes. 2021-06-25 16:18:28 -04:00
Dan
628a587d97 We weren't committing to the database in the correct spot, so the delete wasn't sticking, and we were ending up with test workflows showing up in the main interface. 2021-06-23 16:39:58 -04:00
Dan Funk
48bf721b23
Merge pull request #331 from sartography/bug/356_duplicate_workflow 
Bug/356 duplicate workflow
 2021-06-22 17:42:24 -04:00
Dan
92ca506c8e Calls to eval no longer return the data, rather it will accept and return a key, allowing the front end to cache similar queries and not re-execute them. 2021-06-22 17:23:18 -04:00
Dan
61ad371680 Clean up the file api so we don't have a bunch of extra stuff in there. Just include the raw data from the document spraedsheet if it is available. 2021-06-22 15:08:08 -04:00
Dan
1f3febe2df Fix the panda warnings, which means we only support xlsx files now. 
Include the document details when reutnring a file from the file model.
Improve the validation of file form elements.
 2021-06-22 14:58:52 -04:00
NWalker4483
369b518384 Removed WorkflowService.delete_test_data() 2021-06-22 11:29:00 -04:00
Dan
07eb3f9ca8 Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously. 
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
 2021-06-18 16:41:55 -04:00
NWalker4483
4ca94b39ce Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing 2021-06-17 15:12:28 -04:00
Dan Funk
19d63e2aa2
Merge pull request #328 from sartography/restart-workflow-programmatically-347 
Restart workflow programmatically #347
 2021-06-17 10:36:46 -04:00
Dan
a4caae8d64 when validating, we need to take every step to remove the workflows we create during the validation. 2021-06-16 14:40:20 -04:00
Dan
acae6030f5 The API for evaluating python expressions should not raise an error, it can simply return a result of false, and provide an error to explain the problem. In this way the front end doesn't error out when it's running the script tasks but doesn't have enough information to get a valid response back. 
The validation should take into account that repeating sections must be evaluated in the context of the data within the repeating section, not outside of it.
 2021-06-15 16:17:15 -04:00
mike cullerton
02949dc6e2 WorkflowProcessor handles this error 2021-06-15 11:12:50 -04:00
NWalker4483
5c5b966bc4 Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing 2021-06-15 09:11:18 -04:00
mike cullerton
c8f8888c17 Script to reset workflow. Requires workflow spec name. 2021-06-14 14:51:16 -04:00
Dan
738a984dcd Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-06-11 17:21:47 -04:00
Dan
879d6e1df3 missed a critical change on the backend with the recent file updates, this assures that we properly handle repeating sections during the post process, 
and we update the file doc code in those repeating sections.
 2021-06-11 17:20:25 -04:00
Dan
7282419174 modified the tools api to return the expression and data with the result, making it easier to cash results on the front end, This should help drastically reduce the calls to the python_eval from the front end. 
The post processors for form submissions needs to take repeating sections into account, or it won't find the files it is looking for.
 2021-06-11 08:27:50 -04:00
Kelly McDonald
394906d840 Add refresh_waiting_tasks to the processor do_engine_steps so that if we have a waiting task that has met its condition prior to the scheduler running, it will go ahead and proceed 2021-06-10 08:33:24 -04:00
NWalker4483
e1a4a79b03 Added Partial Workflow spec 2021-06-09 15:21:21 -04:00
NWalker4483
2364c240b2 Error Text Changed 2021-06-09 14:54:43 -04:00
NWalker4483
338fe30984 Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing 2021-06-09 14:32:01 -04:00
NWalker4483
17077be701 exit at task 2021-06-09 12:40:38 -04:00
Kelly McDonald
5f722d675f Add a function that gets runs via a background scheduler to look for any workflows that are in a 'waiting' state - it runs the update waiting tasks and does do_engine_steps 
We have a test for the function that runs, but an assumption was made that the scheduler module has its own unit tests and we do not need to test that.

fixes #346
 2021-06-09 10:42:34 -04:00
Dan
fce9166c4a Do not require users to be admins for viewing the document directory tab. 2021-06-09 09:51:30 -04:00
Kelly McDonald
0d8d251e8e Temp save to test dev 2021-06-09 09:24:37 -04:00
Dan
286803d10b fixing a big stupid bug I created when merging all the code and making changes to the files. 2021-06-08 14:24:59 -04:00
Dan Funk
586a0f2f1a
Merge pull request #325 from sartography/feature/file_refactor 
Prefer tasks that share a parent over just the the next available tas…
 2021-06-08 11:28:23 -04:00
Dan
8d79fe9d94 Fixing failing tests, and now asserting that we only perform the post_process_form if we actually have a form. 2021-06-08 11:16:10 -04:00
Dan Funk
9c4994581d
Merge pull request #324 from sartography/modify-infinite-loop-312 
Modify infinite loop #312
 2021-06-08 10:30:13 -04:00
Dan Funk
e10b210302
Merge pull request #323 from sartography/shield-test-issue-344 
Shield test issue #344
 2021-06-08 08:59:58 -04:00