sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 13:48:30 +00:00
Code Issues Packages Projects Releases Wiki Activity
3,221 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

177 Commits

Author SHA1 Message Date
mike cullerton
6911ab7aae Fixes for failing tests after removing current_user from task data 2022-05-31 16:53:15 -04:00
Dan
62d2229379 don't delete the status messages, that would be senseless. 2022-05-16 16:42:02 -04:00
Dan
a44a278854 We were providing spurious/inaccurate warnings before because we were passing in the wrong arguments to the function. 2022-05-16 12:58:40 -04:00
mike cullerton
cb2bab33b0 Restore admin warnings 2022-05-11 16:57:39 -04:00
Dan
8d8194da45 Removing some unused code. 2022-05-10 09:42:23 -04:00
mike cullerton
67f435af2f redundant 2022-05-09 10:06:06 -04:00
mike cullerton
8cac4e2f95 Change state from enum to string 2022-05-06 17:22:11 -04:00
mike cullerton
d8ae719489 We don't need to run _update_status_of_workflow_meta any more 
But, it returned warnings to the front end for debugging

Ticket 733 was created to address this.
Fix the warnings and return them again.

This also broke the tests in test_study_status_message, so we skip them for now
 2022-05-06 14:13:02 -04:00
mike cullerton
7e2d18f026 no message 2022-05-06 08:57:01 -04:00
mike cullerton
128c516494 Reminder to delete this method after the code is migrated to WorkflowService.update_workflow_state_from_master_workflow 2022-04-29 17:45:38 -04:00
mike cullerton
cf68367085 remove unused code 
cleanup imports
 2022-04-20 11:16:07 -04:00
mike cullerton
8e6ca4c97f DocumentModel => FileModel 
document_id => file_id
 2022-04-19 14:56:34 -04:00
mike cullerton
9262a53b58 DataStoreModel.file_id => DataStoreModel.document_id 2022-04-19 07:44:31 -04:00
mike cullerton
b1dca3f212 FileModel => DocumentModel 
Remove unused imports
 2022-04-13 08:34:10 -04:00
mike cullerton
3f97de6430 from_models => from_document_model 2022-04-12 13:50:26 -04:00
Dan
e1f9dcded5 Assure we can associate the same person with a workflow under two different roles. 2022-04-04 16:01:48 -04:00
mike cullerton
dd26f8fef7 Update review types 
Remove review types 23, 24
Add review type 21
 2022-03-30 10:29:53 -04:00
mike cullerton
05c0e4f96c Put default back to False 2022-03-18 16:55:38 -04:00
Dan
e44ea6e13c merging in from dev. 2022-03-18 16:22:33 -04:00
mike cullerton
f4d6b07467 In get study, only process categories when we ask 2022-03-18 16:03:50 -04:00
Dan
a401c41b23 Setting a minimum date for which to import studies. 
Merging in code to improve performance of calculating percent complete for a study.
Assureing we have a primary investigator for the front page (another merge)
 2022-03-18 15:27:45 -04:00
Dan
b36ff02517 Merge remote-tracking branch 'origin/chore/study-progress' into staging-500-error 2022-03-18 15:07:14 -04:00
alicia pritchett
3c5a75c976 Change study progress resulting from a query 2022-03-18 14:42:03 -04:00
Dan
405c63aaef Merge remote-tracking branch 'origin/chore/study-progress' into staging-500-error 2022-03-18 12:59:31 -04:00
Dan
b7489aea43 merging in PI Name changes from Alicia's #499 PR. 2022-03-18 12:30:20 -04:00
alicia pritchett
12a0e26ee1 Include the PI name on the study model 2022-03-18 11:03:06 -04:00
Dan
ef5aca4fe4 ReviewType now comes back with the user studies, so we don't need to make an additional query to get it. 2022-03-18 09:59:10 -04:00
alicia pritchett
2ab96b16a0 Update the study model to include a progress (integer) 2022-03-17 17:20:42 -04:00
mike cullerton
15750beb10 Added a comment on why we moved the session.add(study) line 2022-03-17 15:18:49 -04:00
mike cullerton
be2b7c07ef add the new study to the session after we run update_from_protocol_builder 2022-03-17 14:29:38 -04:00
alicia pritchett
c18bc6f876 fix study service 2022-03-16 16:21:02 -04:00
alicia pritchett
5b7e71d42d meta field for categories 2022-03-16 12:49:35 -04:00
alicia pritchett
829c810807 wip 2022-03-15 13:21:58 -04:00
alicia pritchett
37d92c6a5f WIP ~ adding a category metadata object 2022-03-15 10:49:41 -04:00
Dan
483d7e858b Improved Errors - Pick up on the new task_trace information in WorkflowException and pass it on through the api. 
Also:  All script tasks should raise WorkflowTaskExecExceptions - NOT APIExceptions - this is because our scripts are executed by Spiff (not the other way around)  so the errors need to pass fluidly through spiff, and come back to use THEN we can convert them to APIErrors.  Otherwise we lose all kinds of good information about the error.
 2022-03-14 16:00:53 -04:00
Dan
4ab314c7b8 Be sure to delete the data store items when you delete a study. 2022-03-12 13:38:09 -05:00
Dan
3944d00e88 Removing an unused / rogue variable. 
Adding a logger warning for very large workflow json data.
 2022-02-25 09:59:41 -05:00
Dan
e61ca471db remove all the @timeit from method calls. 2022-02-24 21:06:22 -05:00
Dan
dde8873c9e 1. defer the loading of the bpmn_json when loading the workflow model. It can be stupidly larger. (see models/workflow.py) 
2. Shave a little more time off the reset by not re-creating the whole WorkflowProcessor

cleaning up all the firsttime/sincetime statements.
 2022-02-24 20:56:57 -05:00
Dan
3442655bd1 Performance Improvements: 
1. Avoid ever re-generating the list of scripts that can be used in a script task.  Terribly expensive as we call eval constantly, and it never ever changes once the app starts. (see script.py changes, and comments)
2. Cache the DocumentStatus list in the flask session, so we calculate it at most once per API Call.  It's at least .25 seconds per call.  (see study_sevice)
3. We called UserFileService.get_files_for_study (which runs a db query EVERY time) for every possible document type.  Now we run the query once (study service line 321)
4. When returning a workflow, we looped through every single task in that workflow's navigation, and called the expensive spiff_task_to_api_task just to figure out it's proper display name. We run a much faster and more efficient method to calculate the display name naow (see workflow_service on lie 680, and 799)
5. A hellton of @timeit and sincetime() calls, that I want to leave in, to help debug any slowness on production.
 2022-02-24 14:25:42 -05:00
Dan
3704279f20 Quick fix, assure we can reset studies. 2022-02-17 14:07:33 -05:00
Dan
3993297360 minor fixes to the study api to get things working locally when we pull down a database from testing. 2022-02-10 18:19:57 -05:00
Dan
eb7760fa55 Adding the migration - very destructive, but required for running the app. 
minor fixes - there is still some weird problems with study id and user id being null that I need to track down, but the issue is sporadic, and hard to track down.
 2022-02-10 11:50:31 -05:00
Dan
de6d7eee84 nearly all study tests work. 2022-02-09 12:03:45 -05:00
Dan
cc915ac25a refactoring the study service. 2022-02-09 08:50:00 -05:00
mike cullerton
65d6728be7 pass specs to _add_all_workflow_specs_to_study 2022-02-08 15:03:00 -05:00
Dan
2383c7d76d WIP - lots of random changes, trying to swtich over 2022-02-04 14:50:31 -05:00
Dan
4ec6e403f5 1. Created a UserFileService, so it's clear what we use when for File Services, UserFiles, SpecFiles, and ReferenceFiles each function differently. 
2. Reference Files and Spec Files are written to disk, they do not exist in the database at all.
 2022-02-02 12:59:56 -05:00
mike cullerton
68820c67cb Removed (almost) all references to WorkflowSpecDependencyFile 
(There is still a call in the lookup service, but we need to decide how to fix that)
 2022-01-19 16:12:54 -05:00
mike cullerton
9cc91f92c3 *** WIP *** 
cleanup - removing commented code
 2022-01-11 15:55:08 -05:00