5ef2905d3c
Add Jinja templating to form field help
2022-03-01 16:17:02 -05:00
896ce8934b
Merge pull request #477 from sartography/bug/645_document_updated
...
An optimization prevented us from picking up a change to the document…
2022-02-28 15:57:13 -05:00
ef4334b1c8
Added a catch for generic exceptions, so the `finally` clause always executes.
...
Also, raise if there is an ApiError, because some tests depend on it.
2022-02-28 14:01:19 -05:00
51a14311eb
An optimization prevented us from picking up a change to the documents associated with a study. This assures that even if scripts run side by side, the document list will get updated, but only on a change. So it's still performant. Also added a sligthly better error message to the workflow service.
2022-02-28 12:17:21 -05:00
5dfb3153d1
Fixes #639 - Pending Approvals Panel No longer displaying
2022-02-27 12:21:38 -05:00
ebbb04a1af
Fixing failing validation.
2022-02-27 10:00:44 -05:00
f2c97f80d5
Merge branch 'dev' into feature/delete-variable-script-584
...
# Conflicts:
# Pipfile.lock
2022-02-25 15:54:34 -05:00
e61ca471db
remove all the @timeit from method calls.
2022-02-24 21:06:22 -05:00
dde8873c9e
1. defer the loading of the bpmn_json when loading the workflow model. It can be stupidly larger. (see models/workflow.py)
...
2. Shave a little more time off the reset by not re-creating the whole WorkflowProcessor
cleaning up all the firsttime/sincetime statements.
2022-02-24 20:56:57 -05:00
3442655bd1
Performance Improvements:
...
1. Avoid ever re-generating the list of scripts that can be used in a script task. Terribly expensive as we call eval constantly, and it never ever changes once the app starts. (see script.py changes, and comments)
2. Cache the DocumentStatus list in the flask session, so we calculate it at most once per API Call. It's at least .25 seconds per call. (see study_sevice)
3. We called UserFileService.get_files_for_study (which runs a db query EVERY time) for every possible document type. Now we run the query once (study service line 321)
4. When returning a workflow, we looped through every single task in that workflow's navigation, and called the expensive spiff_task_to_api_task just to figure out it's proper display name. We run a much faster and more efficient method to calculate the display name naow (see workflow_service on lie 680, and 799)
5. A hellton of @timeit and sincetime() calls, that I want to leave in, to help debug any slowness on production.
2022-02-24 14:25:42 -05:00
23a43c0472
fix to assure we produce a usable error message
2022-02-23 11:53:24 -05:00
095856d3c7
Fixes a bug so that you can reference later fields (and they'll validate
2022-02-22 10:18:09 -05:00
65ffc37787
fixing a bug in Spiff that was preventing our tests from passing.
2022-02-21 14:30:36 -05:00
24f33ec9c9
Merge branch 'chore/variables-in-forms-550' of github.com:sartography/cr-connect-workflow into chore/variables-in-forms-550
2022-02-21 09:57:19 -05:00
bb3d3a5907
Merge remote-tracking branch 'origin/chore/variables-in-forms-550' into chore/variables-in-forms-550
2022-02-21 08:56:11 -05:00
06b9b653b2
don't overwrite the field.label during an eval. It should remain as it is, just assure that it /can/ be evaluated.
2022-02-19 17:43:12 -05:00
4f32cf753c
Merge branch 'chore/variables-in-forms-550' of github.com:sartography/cr-connect-workflow into chore/variables-in-forms-550
2022-02-18 17:20:10 -05:00
c3e52f960b
Minor stuff to help digging into validation of current workflows.
2022-02-18 17:20:04 -05:00
3b48435411
Merge branch 'master' into chore/variables-in-forms-550
2022-02-18 13:23:33 -05:00
4b92b0ee71
oops
2022-02-18 11:57:13 -05:00
a912e8ef49
validate checks/catches default value and label value
2022-02-18 11:41:07 -05:00
06dc20657b
Fixing various BPMN's for tests
2022-02-17 17:29:44 -05:00
a5acd9b07e
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-17 15:04:41 -05:00
c2c6410bbb
Assure we update the workflow model, so we don't keep reporting the error over and over again.
2022-02-17 14:12:31 -05:00
e0a8e7300c
Merge remote-tracking branch 'origin/dev' into get-erroring-workflows-574
2022-02-17 12:37:34 -05:00
08c1571803
Remove value_expression
2022-02-17 12:16:15 -05:00
5def436602
Merge branch 'dev' into get-erroring-workflows-574
2022-02-17 12:12:42 -05:00
31f724b0c3
Seed date fields correctly during validation.
...
We were seeding them with random strings.
2022-02-17 11:48:08 -05:00
8d49e2bfbb
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-17 10:32:40 -05:00
0ad9843569
Dealing with some changes in SpiffWorkflow's latest release. I think this gets all tests passing again, and behaving as expected.
2022-02-16 10:46:46 -05:00
cc6f80bea9
fixing some paths.
2022-02-15 16:25:52 -05:00
093741fa90
By default the system will start up the scheduled tasks, which is usually what you want, but in development
...
it can be kind of irritating for this stuff to be spinning up when you are trying to debug something, so just set
PROCESS_WAITING_TASKS to false in instance/config.py and voila!!
2022-02-15 14:07:09 -05:00
df3f67601c
performance improvements. and last rements of load_example_data()
2022-02-09 23:29:39 -05:00
f12c4aba52
Refactor the workflow_spec_service so it doesn't cache anything, it always reads what it needs from the file system.
2022-02-09 21:06:55 -05:00
2cc20d4b9d
really need to avoid any kind of caching in the WorkflowSpecService
2022-02-09 14:43:32 -05:00
de6d7eee84
nearly all study tests work.
2022-02-09 12:03:45 -05:00
38d64b1ffd
fixes a workflow model related test
...
yes i call a service from a service whoops
2022-02-09 11:07:09 -05:00
dc040f190e
got one more test to work.
2022-02-08 11:30:13 -05:00
4b8d193fb9
a few more tests passing
2022-02-07 14:58:25 -05:00
66906c3786
fix a couple things
2022-02-07 10:57:34 -05:00
2383c7d76d
WIP - lots of random changes, trying to swtich over
2022-02-04 14:50:31 -05:00
4ec6e403f5
1. Created a UserFileService, so it's clear what we use when for File Services, UserFiles, SpecFiles, and ReferenceFiles each function differently.
...
2. Reference Files and Spec Files are written to disk, they do not exist in the database at all.
2022-02-02 12:59:56 -05:00
c1a5032014
WIP modifying workflow service to remove value expression
2022-02-01 15:44:55 -05:00
4c00a5762f
partial commit - new spec_file_service, and new spec_file_api endpoints that use spec and file name, not file id.
...
removed worklow_sync
cleaned up file and workflow models
most of the test are broken.
2022-01-28 06:42:37 -05:00
ae86ab4790
Make erroring workflows visible
...
The `process_erroring_workflows` method is called by our scheduler in __init__.py
2022-01-25 12:18:29 -05:00
b6b9482a64
*** WIP ***
...
Incremental commit. Mainly cleaning up failing tests.
2022-01-12 13:16:09 -05:00
dc27f795c8
*** WIP ***
...
Committing because it is Friday afternoon, and my computer is acting flaky
2022-01-07 15:34:51 -05:00
86a6039dc8
*** WIP ***
...
**Many** tests are failing!
Committing so I can merge dev into this branch
2022-01-06 11:46:54 -05:00
1446302a04
A quick fix for an error we are seeing in testing.
2021-12-30 15:27:31 -05:00
a81f25f0ee
Just kidding. We should make deepcopy and put in fake data 4 valdiation
...
see above. previously i deleted this, because i didnt want unitializsed data in task data. well heres a hint. don't put it in task data. make a deep copy and hold on to that for validation pursposes
2021-12-16 14:47:04 -05:00
mike cullerton
Dan Funk
alicia pritchett