Dan
1f9bf72c59
Merge branch 'dev' into bug/navigation
2020-12-14 11:46:44 -05:00
Dan Funk
4268d0f482
Merge pull request #208 from sartography/152-workflow-spec-pull
...
152 workflow spec pull
2020-12-14 11:35:06 -05:00
Dan
bcb78de225
Merge branch 'dev' into bug/navigation
2020-12-14 11:33:51 -05:00
Dan Funk
e54404e424
Merge pull request #205 from sartography/test-email-script
...
Test email script
2020-12-14 11:28:14 -05:00
Dan
6bf24cc438
fixing some failing tests related to changes in the underlying spiffworkflow library.
2020-12-14 11:27:38 -05:00
Dan
b62a9c7074
Merge remote-tracking branch 'origin/dev' into bug/navigation
2020-12-14 10:40:21 -05:00
Dan
082dee46e0
fixing some failing tests.
2020-12-14 10:37:35 -05:00
Kelly McDonald
d8ac20b1c3
I added a second file to 'random_fact' test workflow, so another test was expecting 2 files in it after adding a new file, but there were 3 -
...
Nothing to see here - move along
2020-12-14 10:37:16 -05:00
Dan
38a6fa782d
Fixing the email script test.
2020-12-14 10:29:53 -05:00
Kelly McDonald
ee3ee9fd4a
Added tests to cover most of the use cases and code, and a bunch of stuff to make the mocks happy
2020-12-14 10:27:40 -05:00
Dan
02ea414b94
Additional fixes to Navigation to allow a nested navigation structure.
2020-12-14 10:07:19 -05:00
mike cullerton
7defc2b02f
Tests for uid in logs. Currently we test for uid in a response. This covers ApiError.
...
Currently, we don't have a test for Sentry. Unsure how to do this.
Also added a script, service and test workflow to help. (Also to learn about adding a script and service.)
2020-12-11 17:47:53 -05:00
Kelly McDonald
3a1160efac
refactored calls into a service
2020-12-11 11:41:32 -05:00
Kelly McDonald
9eea26e019
add workflow_sync test
2020-12-11 08:34:59 -05:00
mike cullerton
32c5060a31
No longer use eval on the email address. It is already parsed.
...
Tests for single and multiple emails, and email error checking.
Still need to figure out how to implement multiple emails.
2020-12-09 12:11:46 -05:00
mike cullerton
730d0ca18f
Email script now uses an email address instead of a UVA LDAP user_id.
2020-12-07 16:23:41 -05:00
Sartography
8ba1e90f9a
Test for ticket 153 to include user in error messages
2020-12-07 08:39:00 -05:00
Sartography
750a202e99
Test and BPMN files for testing email script
2020-12-06 10:22:32 -05:00
Dan
93b12a8e82
updates using new navigation from spiff workflow's navigation branch, all tests passing.
2020-12-04 17:56:12 -05:00
Dan Funk
e15130e09c
Merge pull request #203 from sartography/151-data-store-exclusive-branch-expression
...
Added the ability to use the custom functions within a decision/flow …
2020-12-01 14:44:27 -05:00
Kelly McDonald
94662c560e
Added the ability to use the custom functions within a decision/flow coming off of an exclusive join
...
Altered previous test to test this feature
2020-12-01 09:13:12 -05:00
mike cullerton
73e01b347b
Ticket #105 . Verify End Event Documentation. Added explicit call to _process_documentation at end of crc.services.workflow_service.test_spec for the end event
2020-11-24 16:51:18 -05:00
mike cullerton
a6f9e27ca3
test and bpmn files for ticket #105 (verify end event)
2020-11-24 10:47:20 -05:00
Dan Funk
b8a91a513b
Merge pull request #196 from sartography/128-data-store
...
128 data store
2020-11-18 18:55:33 -05:00
Dan
70c621fe87
fixing the bpmn to use cancel, and pulling in pudates to the spiffworkflow branch.
2020-11-18 16:39:09 -05:00
Dan
b83ab1bcd1
Move data store base into its own file.
2020-11-18 15:34:50 -05:00
mike cullerton
d198f124d7
Committing a merge from dev
2020-11-18 15:33:44 -05:00
Dan
c62b73a539
drop some of the test-only api endpints and rework the tests so they aren't needed
2020-11-18 15:04:36 -05:00
Kelly McDonald
72ade3c367
Add crosstalk test
2020-11-17 10:29:49 -05:00
Kelly McDonald
e9979efb0d
Add some tests
2020-11-17 09:33:29 -05:00
mike cullerton
a2dc3c4812
Use Cancel Event
...
New title 'New Title'
2020-11-16 09:59:22 -05:00
Kelly McDonald
9a4d167dcd
Add in api changes
2020-11-11 09:44:58 -05:00
Kelly McDonald
3ba11f5e6b
add user_data_get/set and alter test so that it ensures that we don't grab study_data stuff from the user_data calls
...
change the test to mock up the user.
2020-11-10 10:32:37 -05:00
Kelly McDonald
92595e3c42
base_test didn't 'know' about the DataStoreModel so it wasn't creating the data_store table, causing a lot of problems after the initial setup/teardown
2020-11-10 09:33:54 -05:00
Kelly McDonald
69fe55aa56
Add mostly-working elements of the data-store, compare with dev to see why db is not working after running tests
2020-11-10 08:24:17 -05:00
Kelly McDonald
245124779e
Add mostly-working elements of the data-store, compare with dev to see why db is not working after running tests
2020-11-10 08:21:46 -05:00
Kelly McDonald
e598994d34
Change the study_sponsors script so that we can actually call it :
...
var = study_info('sponsors')
to keep it more in line with other scripts that we have
2020-11-05 10:31:47 -05:00
mike cullerton
a78af4eab8
Run cancel task during interrupt. Currently this uses Signal event. We may change this to the Cancel event.
2020-11-04 14:37:53 -05:00
Kelly McDonald
8b23cdc05c
commit changes before switching branches
2020-10-09 08:46:14 -04:00
Dan Funk
b2aede2b8d
Glob on windows seems to return directories where in linux it does not, so now assuring we don't try to add files from the sub-directory.
2020-10-05 17:35:35 -04:00
Dan Funk
014a4d9757
Fixing a failing test and updating the personnel.
2020-09-02 08:24:48 -04:00
Dan Funk
b544334f45
1. Updating Personnel BPMN diagram to debug some issues.
...
2. Disabling the token timeout for now, to see if this corrects the issues Alex is having with lost work.
3. Raising more thoughtful error messages for unknown lookup options.
4. Providing better validation of default values and injecting the correct value for defaults related to enum lists of all types.
5. Bumping Spiffworkflow library which contains some better error messages and checks.
2020-09-01 15:58:50 -04:00
Dan Funk
1052dff549
Merge remote-tracking branch 'origin/dev' into feature/python_eval
2020-08-27 14:33:16 -04:00
Dan Funk
b39fd73bc0
fixing a failing test due to changes in the master bpmn for CRC
2020-08-27 14:06:03 -04:00
Dan Funk
5dacc46600
Adding some additional bpmns from Staging server to include in tests.
2020-08-27 14:00:45 -04:00
Dan Funk
53d09303d8
Validating that field properties are valid - they must exist as constants on the Task model.
...
Making all the lookup field names consistent.
Fixing the lookup service which was failing at times trying to find the correct field to use for building the lookup table.
Updating validation to check for additional fields and properties.
When connexion level errors occur, wrapping it in an API Error to be consistent.
2020-08-27 14:00:14 -04:00
Dan Funk
23fd1fbfa0
Removing a rogue file.
2020-08-25 11:15:43 -04:00
Dan Funk
d31fd47837
Merge branch 'dev' into feature/python_eval
2020-08-25 11:08:42 -04:00
Aaron Louie
8dcb598a24
Adds unit test for ProtocolBuilderService.get_sponsors
2020-08-25 11:08:13 -04:00
Dan Funk
5be35e8bab
Adding a study sponsors script to return details about study sponsors
2020-08-25 10:30:46 -04:00
Aaron Louie
182e375fdc
Adds a test for string manipulation
2020-08-21 13:46:10 -04:00
Aaron Louie
4dc98a6b6b
Injects current user into task data.
2020-08-21 13:34:37 -04:00
Dan Funk
66e49a347a
Minor tweaks to the eval endpoint, which should take both the expression and the data as one data structure.
2020-08-20 16:13:48 -04:00
Dan Funk
7f60a19d55
Merge pull request #189 from sartography/feature/documents_publishing
...
Update github routines to use branches
2020-08-17 15:52:47 -04:00
Dan Funk
8f5488d910
Don't raise an error when validating workflows that use the ldap script.
2020-08-17 15:45:37 -04:00
Dan Funk
35b1b20960
Merge remote-tracking branch 'origin/dev' into feature/documents_publishing
2020-08-17 15:19:24 -04:00
Dan Funk
d4c5e297cc
Merge remote-tracking branch 'origin/dev' into fix/delete_workflow_endpoint
2020-08-17 15:09:11 -04:00
Dan Funk
32d47c1417
Merge remote-tracking branch 'origin/dev' into fix/delete_workflow_endpoint
2020-08-17 15:08:44 -04:00
Dan Funk
c09441d019
Merge branch 'dev' into fix/delete_workflow_endpoint
2020-08-17 15:07:58 -04:00
Dan Funk
dbd0dbf608
mend
2020-08-17 14:56:24 -04:00
Dan Funk
85ad477b2b
Some minor cleanup on the study status and automatic events. I wanted to avoid having one database model automatically generating other database models as a side effect. The study service now has full responsiblity to recording study events.
...
To help in running tests, adding __init__.py methods to all the test directories.
2020-08-17 14:56:00 -04:00
Carlos Lopez
2bd906e96d
Update github routines to use branches
2020-08-14 11:04:22 -06:00
Carlos Lopez
4f05d99cf0
Fixing typo
2020-08-14 08:48:08 -06:00
Carlos Lopez
369fe4bb35
Automatic events refactoring
2020-08-14 08:36:46 -06:00
Carlos Lopez
aa010272cc
Automatic event creation in study creation
2020-08-14 08:36:10 -06:00
Dan Funk
c57ac6d302
Merge pull request #185 from sartography/feature/107_current_user_info
...
calling ldap with no argument will return information about the curre…
2020-08-14 09:18:10 -04:00
Dan Funk
08c24b7441
Merge pull request #184 from sartography/PMI_fix
...
Pmi fix
2020-08-14 09:17:58 -04:00
Dan Funk
c12e2b97f3
calling ldap with no argument will return information about the current user.
2020-08-13 21:09:52 -04:00
Dan Funk
1a963cf940
Merge branch 'dev' into PMI_fix
2020-08-13 20:49:45 -04:00
Dan Funk
29f53e763c
fixing other tests realted to lookups.
2020-08-13 20:27:51 -04:00
Dan Funk
e29134a019
fixing a few tests realted to stop words.
2020-08-13 18:35:24 -04:00
Dan Funk
32d1036041
Cleaning up the tests.
2020-08-13 18:15:10 -04:00
Dan Funk
9a5c1d7cfb
I may have finally wrapped my head around full text search in python. Now properly using an index based on simple rather than english dictionary which has far fewer stop words and stemming processes and plays much better to the type ahead search we are trying to provide.
...
Stop words are no longer excluded, so "other" is a valid search and gets a result.
2020-08-13 18:13:41 -04:00
Kelly McDonald
7bfcdd53cd
Merge branch 'dev' into cr-workflow-108
2020-08-12 10:50:19 -04:00
Kelly McDonald
c4a15be90c
Change dmn files to python standard,
...
NB: this means mostly false=>False and true=>True
We may have to decide if we want to add false and true as extensions in the python namespace.
2020-08-12 10:48:59 -04:00
Aaron Louie
9a31d591ae
Adds user uid and cascades study event in study model. Fixes migration to properly downgrade enums.
2020-08-12 10:13:23 -04:00
Carlos Lopez
79c14ad23c
Unlinking file from workflow instead of trying to delete it
2020-08-10 22:23:20 -06:00
Carlos Lopez
cef7c48be2
Adding tests
2020-08-10 21:18:41 -06:00
Kelly McDonald
623ecbae8e
Add IRB test
2020-08-07 09:59:53 -04:00
Kelly McDonald
1ab765b50b
Add test for PMI problem
2020-08-06 10:29:14 -04:00
Aaron Louie
2846bf9451
Fleshes out fake PB response, so workflows that pull from PB actually trigger validation errors
2020-08-04 15:50:29 -04:00
Carlos Lopez
50b207307a
Merge branch 'dev' into feature/update_study_status_latest
2020-07-31 14:26:24 -06:00
Carlos Lopez
4fcba113b8
Fixing tests
2020-07-31 11:49:04 -06:00
Aaron Louie
864fd0ad40
Merge branch 'dev' into feature/admin_impersonations
2020-07-31 13:28:56 -04:00
Aaron Louie
c8881cbf91
Merge branch 'dev' into feature/approvals_dashboard_prototype
2020-07-31 12:17:22 -04:00
Carlos Lopez
5d23223e51
New study status update
2020-07-30 21:03:11 -06:00
Aaron Louie
73699e66bd
Merge branch 'dev' into feature/admin_impersonations
2020-07-30 17:36:20 -04:00
Dan Funk
9704cbcb26
Modifications to the ldap scripts to bring them back in line with what Kelly is doing with the evaluation process.
2020-07-30 13:35:20 -04:00
Aaron Louie
f8944da31f
Merge branch 'dev' into feature/admin_impersonations
2020-07-30 13:01:46 -04:00
Aaron Louie
faba0f55ab
Adds AdminSession model and refactors impersonation methods to use it.
2020-07-30 12:40:53 -04:00
Dan Funk
a6ec0c92c7
Merge remote-tracking branch 'origin/dev' into cr-connect-106-augment-eval-methods
2020-07-30 11:38:47 -04:00
Dan Funk
44deee12de
Merge branch 'dev' into feature/improved_task_event_api
2020-07-30 11:28:52 -04:00
Dan Funk
37d1ba5d5a
Merge pull request #160 from sartography/feature/ldap_lookup_script
...
Ldap lookup script
2020-07-30 11:27:38 -04:00
Dan Funk
bf4d882519
Merge branch 'dev' into feature/ldap_lookup_script
2020-07-30 11:19:24 -04:00
Aaron Louie
aa0f24bd33
Fully deletes users from g in test tearDown
2020-07-30 10:40:06 -04:00
Dan Funk
31982f81ae
Merge branch 'dev' into feature/documents_publishing
...
# Conflicts:
# Pipfile.lock
2020-07-30 10:17:08 -04:00
Aaron Louie
1b0ebecbf4
Uses Flask session to store impersonation state.
2020-07-30 10:17:02 -04:00
Aaron Louie
d301e9e6fa
Adds list_users endpoint. Adds admin impersonate uid parameter to user endpoint. Adds some utility methods to user service. Refactors authentication tests.
2020-07-29 22:47:47 -04:00
Carlos Lopez
de49397549
Adjustings tests for protocol builder status changes
2020-07-29 10:51:34 -06:00
Carlos Lopez
73a6b7adf1
Fixing tests
2020-07-29 10:25:57 -06:00
Carlos Lopez
6aa21638de
Updating properly study status & fixing tests
2020-07-29 10:25:57 -06:00
Aaron Louie
f897ee3aea
Merge branch 'feature/approvals_dashboard_prototype' into feature/admin_impersonations
2020-07-29 10:32:46 -04:00
Dan Funk
0ea4c13d09
Convert protocol builder status to always be in lower case in order to better match the front end. And also fixing an issue with the multi_instance that is oddly broken suddenly, and I don't know why.
2020-07-28 17:16:48 -04:00
Aaron Louie
79adb673f2
Fixes display_name custom properties
2020-07-28 14:04:18 -04:00
Dan Funk
4d11fc04a0
dropping the "read_only" flag in favor of a "do_engine_steps" flag, which more clearly defines what is happening.
2020-07-28 13:51:29 -04:00
Dan Funk
f15626033d
Allow the workflow to be requested without making changes to the workflow - requires that you specify a read_only flag of true, otherwise it assumes that you want a fully prepared workflow with the next ready task set to run.
2020-07-28 13:33:38 -04:00
Dan Funk
300026cbc8
Expanding the task events endpoint to accept workflow and study ids as additional filters.
...
Removing events from the study endpoint, too noisy.
2020-07-28 10:16:48 -04:00
Dan Funk
0cb480801b
Provide event data on the Study api endpoint.
...
Speed up the tests a little, because that got out of hand. Need to dig into what is causing this problem.
2020-07-27 17:05:01 -04:00
Dan Funk
8d42d520a0
Adding events to the study that is returned via the api.
2020-07-27 16:32:23 -04:00
Carlos Lopez
de0fe705c3
Wrapping LOCKED task update attempt into a try-catch block for tests
2020-07-27 14:00:44 -06:00
Dan Funk
452f2c3723
Building out a user service for getting the current user, it will provide a number of functions, one of which will allow administrative users to impersonate other users in some circumstances (but will assure that we log events correctly when an impersonation occures)
2020-07-27 14:38:57 -04:00
Dan Funk
0d2cb8c1b8
Correcting an issue with the Navigation where it did not correctly handle looking back to a previous task within the workflow.
...
In some cases the session was not getting committed, leaving rogue assignments outstanding for a workflow.
2020-07-27 12:36:20 -06:00
Dan Funk
6379b26a71
Add a few more details to the workflow metadata model.
2020-07-27 12:34:25 -06:00
Kelly McDonald
cc55aed89c
Change exception name
2020-07-27 12:18:28 -04:00
Kelly McDonald
70ad3872a7
Fix several bugs, most had an issue with the bpmn document
2020-07-27 12:02:34 -04:00
Dan Funk
824582dab1
Hot fix to correct for a failing test due to updates in Spiffworkflow library,
...
and modifying the token authorization so that we can log in as different users when not in production mode.
2020-07-27 11:25:29 -04:00
Kelly McDonald
a124e13c6a
Replace all legacy style calls with new calls.
...
Still having issues where we try to eval an empty definition, not quite sure why there is a difference from what we had before. I may need to revert some of it and determine what is going on.
2020-07-24 14:33:24 -04:00
Kelly McDonald
f5ab283538
Test of adding in the ability of augmenting the workflow to include internal scripts like StudyInfo
...
This is the first waypoint on a larger effort to make all of the 'special scripts' that currently require a shebang to be just another python function.
2020-07-24 12:08:46 -04:00
Kelly McDonald
ce8d7cad16
We resolved a problem with a test with some changes to Spiff, change the correct so that it is correct.
2020-07-23 14:56:12 -04:00
Carlos Lopez
74e5e07114
Testing for all values
2020-07-23 07:41:29 -06:00
Aaron Louie
aa7437bfc4
Merge branch 'dev' into feature/approvals_dashboard_prototype
2020-07-22 13:08:32 -04:00
Dan Funk
a243c14d75
Updating to lastest spiffworkflow which uses box to support dot notation.
...
Adding a new endpoint for evaluating the results of a python expression into the tools section of the api.
2020-07-22 11:30:16 -04:00
Carlos Lopez
41cbce8e01
Updating bpmn test
2020-07-21 21:08:08 -06:00
Carlos Lopez
522f848682
Addressing feedback
2020-07-21 20:54:03 -06:00
Carlos Lopez
313770d538
Ldap lookup script
2020-07-21 20:54:03 -06:00
Dan Funk
3d9eeab502
Add a few more details to the workflow metadata model.
2020-07-21 15:18:08 -04:00
Dan Funk
d01b30debc
Building the start of an endpoint that could be used by logged in / authenticated users that will evaluate basic python functions sent in via the API.
...
The hope here is that we can process these in real time for the front end, but still do it using the same evaluation engine we use everywhere else, so
the syntax for things like hide-expressions can be properly verified during workflow validation and will be assured to work during front end rendering.
Removing any all javascript code in the BPMN models.
2020-07-21 13:57:33 -04:00
Dan Funk
6caf44544c
Merge branch 'dev' into cr-connect-92-scripting-enhancements
...
# Conflicts:
# crc/static/bpmn/ind_supplement/ind_supplement.bpmn
# tests/workflow/test_workflow_service.py
2020-07-20 13:01:23 -04:00
Dan Funk
dd0f984347
Drop backwards compatibility of scripts. While this will cause some initial pain, it's less confusing and error prone, and we are still in the development phase of the project. Were this going straight to production we would likely want to keep this backwards compatibility.
...
Don't parse on spaces if this is python code, so we avoid any errors in processing - spaces should be valid.
2020-07-20 12:26:34 -04:00
Dan Funk
06430550c8
Dropping the RRT-Data-Fix, it should have come out already, but had a failing test, so pulling it out now rather than delve into what is going wrong with obsolete code.
2020-07-20 11:39:50 -04:00
Carlos Lopez
fcb772c900
Reporting to Sentry all captured exceptions and enabling multiple environments
2020-07-19 16:40:33 -06:00
Carlos Lopez
73400ed6c7
Adding proper tests for files publishing
2020-07-17 16:59:25 -06:00
Aaron Louie
e82532aad8
Updates IND workflow spec. Fixes validation process to return lookups for enum values.
2020-07-17 11:51:21 -04:00
Kelly McDonald
de54b63e20
Process scripts with no shebang (#!) as a regular python script. If there is a shebang, we look up the class as we did before.
...
I've also made it so that it falls back if we accidentally forget to add a shebang to a study as this would be a breaking change.
With the fallback feature, it should work with unmodified bpmn documents.
2020-07-17 10:56:04 -04:00
Kelly McDonald
ab5771024e
Check in for sanity check
2020-07-17 09:24:53 -04:00
Aaron Louie
7cbafe966e
Adds form key and pool name
2020-07-16 17:59:56 -04:00
Aaron Louie
9570e19b09
Fixes failing test
2020-07-16 14:02:29 -04:00
Aaron Louie
d67105332f
Merge branch 'dev' into feature/lanes_and_roles
2020-07-16 14:00:53 -04:00
Aaron Louie
d0279a11e5
Fixes failing unit test
2020-07-15 17:44:46 -04:00
Aaron Louie
040a95281e
Updates package hashes
2020-07-15 17:09:34 -04:00
Aaron Louie
08fba1a4dc
Merge branch 'dev' into feature/dynamic_enum_list
2020-07-15 13:09:02 -04:00
Dan Funk
c7662315aa
Assure that any errors that occur during the do_engine_steps is correctly captured and returned to the end user or configurator with enough information for them to act on.
2020-07-15 11:16:35 -04:00
Dan Funk
d85ca1ce51
Whenever a workflow is loaded or updated, add events to the TaskEvent table with assignments for the next set of ready tasks, along with who should complete those tasks.
...
Add the lane information to the Task model.
Drop the foreign key constraint on the user_uid in the task log, as we might create tasks for users before they ever log into the system.
Add a new endpoint to the API called task events. It should be possible to query this and get a list of all tasks that need a users attention.
The task events returned include detailed information about the workflow and study as sub-models
Rename all the actions in event log to things that are easier to pass over the api as arguments, make this backwards compatible, updating existing names in the database via the migration.
Throughly test the navigation and task details as control of the workflow is passed between two lanes.
2020-07-14 22:16:44 -04:00
Dan Funk
9077ff3ebf
It is not possible to use task_data for an auto-complete field. It's too expensive an operation to provide that feature on the backend, and the data already fully resides on the front end anyway. Task-data can be used to populate enum fields if needed, so it can populate dropdowns, radios and checkboxes, just not auto-complete.
2020-07-14 11:38:48 -04:00
Dan Funk
a48322ef6a
Partial work on CR Connect Roles.
...
Adding checks in the API to assure the correct person is completeing a task based on the task's lane.
Adding lane to the Navigation item.
Adding a check to assure that unique user ids can be identified using task.data
Added some additional ldap entries to make testing and development easier.
Removed a big chunk of duplicate code from task_tests_api
Modified some of the helper functions to make it easier to test as specific users.
Added some additional bpmn models to the tests for testing lanes and roles.
2020-07-14 10:29:25 -04:00
Dan Funk
f83995a692
Partial work towards roles and lane support
2020-07-14 09:01:29 -04:00
Aaron Louie
07066b8a16
Looks up enum options from task data
2020-07-13 17:46:28 -04:00
Aaron Louie
3c8e1e5c37
Tests for presence of data property in enum options
2020-07-13 11:02:29 -04:00
Dan Funk
ff7c30b879
Merge pull request #138 from sartography/fix/cleanup_todos
...
Cleanup pending TODOs
2020-07-10 08:26:47 -04:00
Dan Funk
6a79fb3581
There may be multiple investigators of the same type that come back from the protocol builder, adding some tests and additional code to handle this, but still keep the list flat, currently appends a number to the investigator type when there is more than one.
2020-07-07 17:16:33 -04:00
Carlos Lopez
b4e127b3b7
Cleaning properly previous versions
2020-07-07 08:32:41 -06:00
Carlos Lopez
a302208890
Updating test for study with approvals
2020-07-07 08:32:41 -06:00
Carlos Lopez
c7b864f9c7
Cleaning up old notes
2020-07-07 08:32:20 -06:00
Dan Funk
8a66128189
Bug fixes after bumping the version of Spiffworlflow to the latest - which has fixes for sequential multi-instance.
2020-07-06 15:34:24 -04:00
Dan Funk
419c05e46c
Merge branch 'dev' into fix/more-info-in-exceptions
2020-07-06 12:51:24 -04:00
Dan Funk
a5cef8775e
* Modifying the StudyInfo script to return both "investigators" and "roles", the investigators argument will return only the current active investigators according to the protocol builder. The "roles" argument returns all possible roles - it is what "investigators" use to be.
...
* The Task.title returned to the front end will now attempt to process the "display_name" property for dot-notation syntax, making it possible to use this for multi-instance tasks,
but will work in all cases where we want he title to change based on values in the data model.
* Fixing a bug the test_study_api where it wasn't updated when we made recent changes to the different states of a study.
*
2020-07-06 12:09:21 -04:00
Carlos Lopez
817333f26e
Adding proper exception information
2020-07-02 16:10:33 -06:00
Dan Funk
93bf46354b
A last minute change to make the API a little clearer and cleaner broke some tests.
2020-06-30 11:12:28 -04:00
Dan Funk
f183e12fe5
Provides some basic tools for getting additional information about a lookup field.
...
Adds an optional 'value' parameter to the lookup endpoint so you can find a specific entry in the lookup table.
Makes sure the data attribute returned on a lookup model is a dictionary, and not a string.
Fixes a previous bug that would crop up if double spaces were used when performing a search.
2020-06-30 10:34:16 -04:00
Dan Funk
d3ce1af1ce
Provides some basic tools for getting additional information about a lookup field.
...
Adds an optional 'id' parameter to the lookup endpoint so you can find a specific entry in the lookup table.
Makes sure the data attribute returned on a lookup model is a dictionary, and not a string.
Fixes a previous bug that would crop up in double spaces were used when performing a search.
2020-06-30 10:00:22 -04:00
Aaron Louie
e650a46073
Fixes local testing bug where working directory was sometimes wrong.
2020-06-29 16:41:42 -04:00
Aaron Louie
fe61333b7b
Fixes typo
2020-06-26 12:31:15 -04:00
Aaron Louie
29b108673d
Adds failing test exposing bug with getting data for multi-instance tasks
2020-06-26 11:51:27 -04:00
Dan Funk
150117587e
Merge branch 'dev' into feature/parallel_multiinstance_tasks
2020-06-25 23:20:38 -04:00
Dan Funk
fe5a7ddce3
Merge remote-tracking branch 'origin/rrt/dev' into feature/emails-enhancement
2020-06-25 13:29:06 -04:00
Aaron Louie
be6dcc7020
Merge branch 'STG-26' into feature/parallel_multiinstance_tasks
2020-06-25 12:55:28 -04:00
Dan Funk
0ca9b9624e
Switching to STG-26 for the Spiff Library, and adding a test that demonstrates the failure Aaron ran into yesterday.
2020-06-25 12:44:34 -04:00
Carlos Lopez
5d1ae402b6
Slight refactor on data passed to template rendering
2020-06-24 22:43:44 -06:00
Carlos Lopez
a0d877e02f
Feedback from PR addressed
2020-06-24 22:23:31 -06:00
Carlos Lopez
5327b469f6
Merge branch 'rrt/dev' into feature/emails-enhancement
2020-06-24 21:46:53 -06:00
Aaron Louie
a40adeca3a
Merge branch 'dev' into STG-26
2020-06-22 19:57:43 -04:00
Carlos Lopez
91fe5f0cdd
Fixing broken test
2020-06-22 14:22:56 -06:00
Carlos Lopez
dc5ffd29d0
Refactoring shared code
2020-06-22 14:07:57 -06:00
Dan Funk
6aec15cc7c
Shifting to a different model, where the TaskEvents store ONLY the form data submitted for that task.
...
In order to allow proper deletion of tasks, we no longer merge data returned from the front end, we set it directly as the task_data.
When returning data to the front end, we take any previous form submission and merge it into the current task data, allowing users to keep their previous submissions.
There is now an "extract_form_data" method that does it's best job to calculate what form data might have changed from the front end.
2020-06-19 08:22:53 -04:00
Carlos Lopez
e6d74aaa1a
Removing extra index when parsing users info
2020-06-18 12:53:50 -06:00
Kelly McDonald
479f6d9647
STG-26
...
Do rename per conversation, continue to look for ways to implement looping in a way that is re-entrant
2020-06-18 12:01:02 -04:00
Carlos Lopez
4db815a999
Handling incoming values from processor
2020-06-17 21:11:47 -06:00
Carlos Lopez
e947f40ec7
Merge branch 'rrt/dev' into feature/emails-enhancement
2020-06-17 20:10:11 -06:00
Carlos Lopez
5ce279b663
Dropping silly pdb statement
2020-06-17 17:36:15 -06:00
Carlos Lopez
896ba6b377
Email relies now on markdown content
2020-06-17 17:00:16 -06:00
Carlos Lopez
ddf1f4640c
Re-organizing tests file structure
2020-06-17 16:10:06 -06:00
Carlos Lopez
2ce2dc73b5
Rendering proper content & organizing file structure for email tests
2020-06-17 16:09:38 -06:00
Dan Funk
3b57adb84c
Continuing a major refactor. Some important points:
...
* TaskEvents now contain the data for each event as it was when the task was completed.
* When loading a task for the front end, if the task was completed previously, we take that data, and overwrite it with the lastest data, allowing users to see previously entered values.
* Pulling in the Admin branch, as there are changes in that branch that are critical to seeing what is happening when we do this thing.
* Moved code for converting a workflow to an API ready data stricture into the Workflow service where it belongs, and out of the API.
* Hard resets just convert to using the latest spec, they don't try to keep the data from the last task. There is a better way.
* Moving to a previous task does not attept to keep the data from the last completed task.
* Added a function that will fix all the existing RRT data by adding critical data into the TaskEvent model. This can be called with from the flask command line tool.
2020-06-17 17:11:15 -04:00
Kelly McDonald
1844c93919
STG-26 - basic test case for a looping task
...
Criteria :
task.multi_instance_type == 'looping'
to terminate, use the standard endpoint for submitting form data with a query variable of terminate_loop=true
Will likely need two buttons:
"Submit and quit"
"Submit and add another"
or something similar
2020-06-17 11:35:06 -04:00
Carlos Lopez
d4a285883f
Email script
2020-06-16 18:42:36 -06:00
Dan Funk
c7d8eaff30
Merge branch 'dev' into feature/refactor_data_loading
2020-06-16 13:15:43 -04:00
Kelly McDonald
0d3105fe7e
Make changes to the workflow names so that they are placed in the correct order - I made workflows go in order of the name rather than in the order they appear in the XML to allow more control over the way the nav list is displayed.
2020-06-15 12:32:19 -04:00
Carlos Lopez
5f13b96079
More enhancements
2020-06-12 12:17:08 -06:00
Aaron Louie
e3126620b3
Eschews obfuscation
2020-06-12 14:09:08 -04:00
Aaron Louie
561e254315
Prevents non-admin users from editing each others' tasks. Fixes bug where test user uid was not being set from token. Moves complete form and get workflow API test utility methods into BaseTest.
2020-06-12 13:46:10 -04:00
Aaron Louie
691258a4fb
Fixes bug where approvals counts were off by 1. Tests CSV export and all approvals endpoints with lots of records.
2020-06-11 17:15:44 -04:00
Aaron Louie
f51e5e4e6b
Adds tests for approval counts and all approvals endpoints
2020-06-11 16:39:00 -04:00
Aaron Louie
768f14b3ac
Cleans up console logging
2020-06-11 13:42:44 -04:00
Aaron Louie
0cbbe756a3
Tests for token expiration ApiError
2020-06-11 13:42:32 -04:00
Dan Funk
4e006e2653
Clear out the g.user between tests.
2020-06-11 11:49:07 -04:00
Aaron Louie
cccff9b856
Fixes broken unit tests. But still broken.
2020-06-11 11:29:58 -04:00
Aaron Louie
1f5554d0d8
Merge branch 'rrt/dev' into feature/swagger_admin_authentication
2020-06-11 08:55:29 -04:00
Carlos Lopez
e9e805b2c9
Storing emails in database
2020-06-09 22:57:56 -06:00
Carlos Lopez
5c1c0f685e
Tests update
2020-06-08 16:17:41 -06:00
Aaron Louie
87e2379871
Merge branch 'rrt/dev' into feature/swagger_admin_authentication
2020-06-08 10:30:16 -04:00