sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-22 12:48:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
1,727 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

425 Commits

Author SHA1 Message Date
Dan
ef7ee284b2 Prefer tasks that share a parent over just the the next available task when returning the next_task in the workflow processor. 2021-05-19 16:26:16 -04:00
Mike Cullerton
668e2f4e3c
Merge pull request #313 from sartography/feature/add_file_data_store_properties_to_file 
Assure that any data store values associated with a file come back as…
 2021-05-14 16:30:35 -04:00
Dan
8e37f27399 Assure that any data store values associated with a file come back as a part of the get_study_data[documents 
] endooint.
 2021-05-14 15:52:25 -04:00
Dan Funk
4d7ce5eda9
Merge pull request #311 from sartography/deprecate-study-info-protocol-261 
Deprecate study info protocol #261
 2021-05-14 14:14:18 -04:00
Dan Funk
ade7812540
Merge pull request #310 from sartography/get-primary-workflow-301 
Get primary workflow #301
 2021-05-14 12:41:48 -04:00
Dan Funk
6a34fc0cde
Merge pull request #309 from sartography/persist-read-only-data-324 
Persist read only data #324
 2021-05-14 12:38:48 -04:00
Dan Funk
99da502912
Merge branch 'dev' into 321-Markdown-Macro 2021-05-14 12:32:41 -04:00
mike cullerton
9b24ad319b Removed the get_protocol method from study_service. 2021-05-13 16:29:34 -04:00
mike cullerton
8a6bef5af4 New service to get the primary workflow for a workflow_spec, using a workflow_spec_id. 
This is necessary because `primary` is a file parameter, not a workflow_spec parameter.

- you can ask a workflow file whether it is primary, but
- you cannot ask a workflow_spec for its primary workflow file

Now, you can use `workflow_service.get_primary_workflow(workflow_spec_id)`
 2021-05-12 13:51:51 -04:00
mike cullerton
07f3d2c2ee Allow data from read-only fields to persist in task_data 2021-05-07 14:06:53 -04:00
Dan
5a79b80f32 fixes #322, do not error out deleting files that have assocaited data stores, just remove the data store. 2021-05-05 20:21:33 -04:00
Dan
7831bef050 Don't fail the sync completely when a remote file does not exist. 2021-05-05 15:59:00 -04:00
Kelly McDonald
cbd1d01203 Add URL to the study_info('documents') script 
fixes #321 - I merged in branches that fix #320 and #297

320-add-default-for-file-data-get
297-filename-in-documents
 2021-05-05 11:30:08 -04:00
Dan Funk
8b0afa4437
Merge pull request #304 from sartography/irb-info-script-307 
Irb info script #307
 2021-05-04 11:40:52 -04:00
Dan Funk
34759a2f3d
Merge branch 'dev' into feature/performance-refactor 2021-05-04 11:30:13 -04:00
Dan Funk
d6054a9846
Merge branch 'dev' into 310-task-event-timezone 2021-05-04 11:21:36 -04:00
Dan Funk
81467d6a8d
Merge pull request #299 from sartography/297-filename-in-documents 
Add filename to files listing.
 2021-05-04 11:19:59 -04:00
mike cullerton
804926dbac Fixed problem where WorkflowService.make_test_workflow did not add a study to the workflow_model 2021-05-01 15:55:20 -04:00
mike cullerton
22b3230243 Added service get_irb_info to crc.services.protocol_builder.ProtocolBuilderService 
Added environment variable `PB_IRB_INFO_URL` for new `get_irb_info` service
 2021-05-01 15:20:47 -04:00
Dan
a719cf4bf9 When retrieving the study, only update the status of underlying workflows if specifically requested. 
Record the size of a file in the database for quick access (this helps with a frontend refactor, so it isn't downloading the file just to see it's size)
Cleaning up the timing/performance metric reporting to make it easier to read.
Fixing a bug that prevented non-admins for getting the document-directory
 2021-04-30 11:55:12 -04:00
mike cullerton
24c818bf31 Added study_id to workflow_api 2021-04-29 14:29:21 -04:00
Kelly McDonald
2b9cee6b89 Update database to include timezone and change all points where we set the time on an event to be utc time. If we get something in the database with a timezone, it will display properly on the front end, but by default everything will be put in the database in UTC 2021-04-29 10:25:28 -04:00
Kelly McDonald
cc77a9182c Add filename to files listing. 
Fixes #297
 2021-04-28 10:37:14 -04:00
Mike Cullerton
39fcab3730
Merge branch 'dev' into launch-workflow-outside-study-204 2021-04-26 10:27:32 -04:00
mike cullerton
077b68c1e2 When creating a workflow for a study, set the user_id to None 2021-04-26 08:46:19 -04:00
mike cullerton
f17a9dc0f4 Modified get_users_assigned_to_task. 
If we are running a standalone workflow, only return the current user.
 2021-04-26 08:45:08 -04:00
mike cullerton
b6f5001687 Added methods for the 2 new api endpoints 2021-04-26 08:43:14 -04:00
Dan
cf051a7d4f Merge branch 'dev' into 277-Document-pane 
# Conflicts:
#	crc/api/file.py
 2021-04-21 14:09:44 -04:00
Kelly McDonald
e2197ddab9 Changes to support the frontend data pane 
fixes #277 and requires frontend branch 277-document-pane
 2021-04-20 08:12:27 -04:00
mike cullerton
91e80d01bc Added delete_files argument to the workflow_processor reset method. 
Added code to delete the files when delete_files is True.
 2021-04-15 11:25:58 -04:00
Dan
6427a54d74 Set the correct default value on enumerations - if it is a multi-select enum (checkbox is set) then it should return a default value of an empty array, and not a dictionary. 2021-04-09 08:40:58 -04:00
Dan
dcb4e7b736 fixing an error by taking a bit of the magic out of one of Mike's regex hinting tools. I figure the hint is still good, and a little less bittle, and all the information is already there if people need to dig. 2021-04-02 17:58:27 -04:00
Kelly McDonald
116bf5e7aa Merge branch 'dev' into 263-optimize-dashboard 
# Conflicts:
#	crc/services/study_service.py
 2021-03-31 10:20:33 -04:00
Kelly McDonald
9084866015 Update error message - it may be that we should spend a bit and see if we can make the Box error 2021-03-31 10:17:08 -04:00
Kelly McDonald
60f5be1aef Check in - pending change from @cullerton 2021-03-30 12:10:49 -04:00
Dan Funk
b5d4df595f
Merge pull request #271 from sartography/master-workflow-status-messages-222 
Master workflow status messages 222
 2021-03-26 20:52:24 -04:00
Dan
ded11ddd82 fixing a code smell 2021-03-26 20:25:34 -04:00
Kelly McDonald
f1ca44a0e1 Add primitive cache on the fileservice is_review, halves the time of loading the list on the primary dashboard 2021-03-23 10:17:48 -04:00
mike cullerton
a201e49d21 The master workflow now generates a dictionary of dictionaries, rather than a dictionary of strings. 
Each entry in status is a dictionary with 'status' and 'message' keys.
We updated the StudyService._update_status_of_workflow_meta method to accommodate the master workflow changes.

Changed the order of some if statements so we move forward while we have good data, and run all the error states at the end.
Added some comments to explain the cascading if statements

We changed the names of private methods to begin with one underscore, so they work in the test environment.
Changed  some internal calls to accommodate the underscore change.
 2021-03-22 17:46:39 -04:00
mike cullerton
938079cf59 Lowered count ceiling to 100, from 1000. This significantly increased validation time, from about 3 minutes to about 10 seconds. 
Changed ApiError call to from_task, instead of from_workflow_exception.
 2021-03-17 14:52:19 -04:00
mike cullerton
529bfc34b3 We now check for an infinite loop during validation. 
This happened when testing for a Department Chair in a workflow.
Our mocked data for study_info script did not have a Department Chair
 2021-03-16 13:35:51 -04:00
mike cullerton
c05b879dd4 We want to modify the master workflow so that it returns both a status, and a message explaining the status for each workflow. 
I.e., from status = {'ids_full_submission': 'required',
                              'enter_core_info': 'disabled',
                              ...}
       to     status = {'ids_full_submission': {'status': 'required', 'message': 'required because...'},
                              'enter_core_info': {'status': 'disabled', 'message': 'disabled because...'},
                              ...}

Modified study_service.__update_status_of_workflow_meta to accommodate this change.
 2021-03-16 12:09:42 -04:00
Dan Funk
14386b8ba9
Merge pull request #264 from sartography/bug/243_complete_all 
Bug/243 complete all
 2021-03-14 12:34:55 -04:00
Dan Funk
0da07675b7
Merge pull request #258 from sartography/study-associated-email-207-223 
Study associated email 207 223
 2021-03-14 12:34:19 -04:00
Dan
6f80d816cd My privous efforts didn't take into account the fact that we use dot notation in field names. 
I've re-worked the workflow form endpoint, so that it only accepts the data that should be in the form, and ignores any other values that come back from the front end.  It seems Formly has some bugs that were introducing confusing information, and I want everything to behave consistently.
I had to re-work some of the tests, which were relying on an ability to set data through a form post without having a corresponding form to do so.
 2021-03-14 12:20:39 -04:00
Dan
15c64c862e Adding an argument to update task that will allow it to complete all remaining tasks through an "update_all" flag, 
this will allow us to remove some fairly complex logic from the front end that isn't behaving properly.
 2021-03-12 20:41:07 -05:00
Dan
1000b22a3b Don't raise errors on non-ready tasks that calculate a title, the information may not be avaiable yet. 
Also Allow autocomplete-num as a valid field property.
 2021-03-12 15:40:23 -05:00
Mike Cullerton
e7c78c8d0e
Merge branch 'dev' into study-associated-email-207-223 2021-03-11 12:38:47 -05:00
mike cullerton
e58f1dc484 Remove unused mails service 2021-03-11 11:56:18 -05:00
mike cullerton
67697b5076 Lots of changes! 
Email Script:
- The email script now accepts 3 keyword arguments; subject, recipients, and cc.
- Subject and recipients are required.
- Recipients (and cc) can be an email address or list of addresses.
- You can use the string 'associated' in place of an email address, in which case we look up the users associated with a study that have send_email set to True.
- Moved some helper methods to email_service.

Email Service:
- Added cc argument
- Added helper methods previously in email script.
- Modified get_rendered_content to accept message and data directly. Previously, we passed in the task and grabbed them from there. Now we can use the method outside a task.
 2021-03-11 11:32:21 -05:00