sartography
/
cr-connect-workflow
mirror of https://github.com/sartography/cr-connect-workflow.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Lowered count ceiling to 100, from 1000. This significantly increased validation time, from about 3 minutes to about 10 seconds. 

Changed ApiError call to from_task, instead of from_workflow_exception.
This commit is contained in:
mike cullerton 2021-03-17 14:52:19 -04:00
parent e2ba19748d
commit 938079cf59
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
crc/services/workflow_service.py
View File

@ -97,7 +97,7 @@ class WorkflowService(object):
count = 0
while not processor.bpmn_workflow.is_completed():
if count < 1000:
if count < 100: # check for infinite loop
try:
processor.bpmn_workflow.get_deep_nav_list() # Assure no errors with navigation.
processor.bpmn_workflow.do_engine_steps()
@ -124,8 +124,9 @@ class WorkflowService(object):
WorkflowService.delete_test_data()
raise ApiError.from_workflow_exception("workflow_validation_exception", str(we), we)
else:
raise ApiError.from_workflow_exception(code='validation_loop',
message=f'There appears to be an infinite loop in the validation. spec_id: {spec_id}')
raise ApiError.from_task(code='validation_loop',
message=f'There appears to be an infinite loop in the validation. Task is {task.task_spec.description}',
task=task)
WorkflowService.delete_test_data()
WorkflowService._process_documentation(processor.bpmn_workflow.last_task.parent.parent)