sartography/cr-connect-workflow
1
0
Fork 0
mirror of https://github.com/sartography/cr-connect-workflow.git synced 2025-02-24 05:38:25 +00:00
Code Issues Packages Projects Releases Wiki Activity
2,742 Commits 14 Branches 0 Tags 9 MiB
Commit Graph

807 Commits

Author SHA1 Message Date
mike cullerton
6da23dc854 Clean up error message in else clause in test_spec 2022-03-01 14:58:53 -05:00
Dan Funk
896ce8934b
Merge pull request #477 from sartography/bug/645_document_updated 
An optimization prevented us from picking up a change to the document…
 2022-02-28 15:57:13 -05:00
mike cullerton
ef4334b1c8 Added a catch for generic exceptions, so the finally clause always executes. 
Also, raise if there is an ApiError, because some tests depend on it.
 2022-02-28 14:01:19 -05:00
Dan
51a14311eb An optimization prevented us from picking up a change to the documents associated with a study. This assures that even if scripts run side by side, the document list will get updated, but only on a change. So it's still performant. Also added a sligthly better error message to the workflow service. 2022-02-28 12:17:21 -05:00
alicia pritchett
5dfb3153d1 Fixes #639 - Pending Approvals Panel No longer displaying 2022-02-27 12:21:38 -05:00
Dan
ebbb04a1af Fixing failing validation. 2022-02-27 10:00:44 -05:00
mike cullerton
f2c97f80d5 Merge branch 'dev' into feature/delete-variable-script-584 
# Conflicts:
#	Pipfile.lock
 2022-02-25 15:54:34 -05:00
Dan
3944d00e88 Removing an unused / rogue variable. 
Adding a logger warning for very large workflow json data.
 2022-02-25 09:59:41 -05:00
Dan
e61ca471db remove all the @timeit from method calls. 2022-02-24 21:06:22 -05:00
Dan
dde8873c9e 1. defer the loading of the bpmn_json when loading the workflow model. It can be stupidly larger. (see models/workflow.py) 
2. Shave a little more time off the reset by not re-creating the whole WorkflowProcessor

cleaning up all the firsttime/sincetime statements.
 2022-02-24 20:56:57 -05:00
Dan
3442655bd1 Performance Improvements: 
1. Avoid ever re-generating the list of scripts that can be used in a script task.  Terribly expensive as we call eval constantly, and it never ever changes once the app starts. (see script.py changes, and comments)
2. Cache the DocumentStatus list in the flask session, so we calculate it at most once per API Call.  It's at least .25 seconds per call.  (see study_sevice)
3. We called UserFileService.get_files_for_study (which runs a db query EVERY time) for every possible document type.  Now we run the query once (study service line 321)
4. When returning a workflow, we looped through every single task in that workflow's navigation, and called the expensive spiff_task_to_api_task just to figure out it's proper display name. We run a much faster and more efficient method to calculate the display name naow (see workflow_service on lie 680, and 799)
5. A hellton of @timeit and sincetime() calls, that I want to leave in, to help debug any slowness on production.
 2022-02-24 14:25:42 -05:00
Dan Funk
33dc1f0868
Merge pull request #465 from sartography/bug/628_jinja_template_errors 
fix to assure we produce a usable error message
 2022-02-24 08:50:41 -05:00
Dan Funk
e8617038ab
Merge pull request #461 from sartography/bug/missing-executabe-option-601 
Bug/missing executabe option #601
 2022-02-24 08:46:46 -05:00
Dan
23a43c0472 fix to assure we produce a usable error message 2022-02-23 11:53:24 -05:00
alicia pritchett
095856d3c7 Fixes a bug so that you can reference later fields (and they'll validate 2022-02-22 10:18:09 -05:00
Dan
65ffc37787 fixing a bug in Spiff that was preventing our tests from passing. 2022-02-21 14:30:36 -05:00
mike cullerton
a830657ebd raise ApiError when isExecutable tag is missing. 
Unsure how this would actually happen, since it should get set to False if box is unchecked.
 2022-02-21 10:17:01 -05:00
Dan
24f33ec9c9 Merge branch 'chore/variables-in-forms-550' of github.com:sartography/cr-connect-workflow into chore/variables-in-forms-550 2022-02-21 09:57:19 -05:00
alicia pritchett
bb3d3a5907 Merge remote-tracking branch 'origin/chore/variables-in-forms-550' into chore/variables-in-forms-550 2022-02-21 08:56:11 -05:00
Dan
06b9b653b2 don't overwrite the field.label during an eval. It should remain as it is, just assure that it /can/ be evaluated. 2022-02-19 17:43:12 -05:00
Dan
4f32cf753c Merge branch 'chore/variables-in-forms-550' of github.com:sartography/cr-connect-workflow into chore/variables-in-forms-550 2022-02-18 17:20:10 -05:00
Dan
c3e52f960b Minor stuff to help digging into validation of current workflows. 2022-02-18 17:20:04 -05:00
Dan
a7f591d2ac Merge branch 'dev' into chore/variables-in-forms-550 2022-02-18 17:19:01 -05:00
alicia pritchett
3b48435411 Merge branch 'master' into chore/variables-in-forms-550 2022-02-18 13:23:33 -05:00
alicia pritchett
4b92b0ee71 oops 2022-02-18 11:57:13 -05:00
alicia pritchett
e7c0e66f86 Merge remote-tracking branch 'origin/chore/variables-in-forms-550' into chore/variables-in-forms-550 2022-02-18 11:41:15 -05:00
alicia pritchett
a912e8ef49 validate checks/catches default value and label value 2022-02-18 11:41:07 -05:00
Dan
b90be07bca Remove these bloodly log files from the repo. 2022-02-18 11:40:10 -05:00
Dan
e91be2a54d Merge branch 'dev' into chore/variables-in-forms-550 2022-02-18 11:27:58 -05:00
Dan
635a112796 still trying to fix a rogue test. 2022-02-18 10:41:24 -05:00
Dan
6adf1107fe Trying to figure out why these files are not the same on testing. 2022-02-18 10:12:36 -05:00
alicia pritchett
06dc20657b Fixing various BPMN's for tests 2022-02-17 17:29:44 -05:00
alicia pritchett
a5acd9b07e Merge branch 'dev' into chore/variables-in-forms-550 2022-02-17 15:04:41 -05:00
Dan
c2c6410bbb Assure we update the workflow model, so we don't keep reporting the error over and over again. 2022-02-17 14:12:31 -05:00
Dan
3704279f20 Quick fix, assure we can reset studies. 2022-02-17 14:07:33 -05:00
Dan Funk
be48f86440
Merge pull request #459 from sartography/bug/619_lookup_tables 
Another re-work to fix 619 - and to assure that we aren't rebuilding …
 2022-02-17 13:15:37 -05:00
Dan
c2dbec1e3f Merge remote-tracking branch 'origin/dev' into bug/619_lookup_tables 2022-02-17 12:51:24 -05:00
Dan
e0a8e7300c Merge remote-tracking branch 'origin/dev' into get-erroring-workflows-574 2022-02-17 12:37:34 -05:00
Dan Funk
9d74ee5790
Merge pull request #458 from sartography/bug/date-field-validation-622 
Bug/date field validation #622
 2022-02-17 12:18:39 -05:00
Dan Funk
484b9a9c7c
Merge pull request #457 from sartography/feature/get-spec-script-613 
Feature/get spec script #613
 2022-02-17 12:17:12 -05:00
alicia pritchett
08c1571803 Remove value_expression 2022-02-17 12:16:15 -05:00
Dan Funk
b91372171c
Merge pull request #454 from sartography/git-integration-fixes-596 
Git integration fixes #596
 2022-02-17 12:15:13 -05:00
Dan Funk
5def436602
Merge branch 'dev' into get-erroring-workflows-574 2022-02-17 12:12:42 -05:00
Dan
b72ecb8375 Another re-work to fix 619 - and to assure that we aren't rebuilding the lookup tables too frequently. 2022-02-17 11:59:48 -05:00
mike cullerton
31f724b0c3 Seed date fields correctly during validation. 
We were seeding them with random strings.
 2022-02-17 11:48:08 -05:00
Dan
f2b6008e5f Fixes 619 - look up models were being built incorrectly, and repeatedly, and sometimes bombed out all together. 
bonus: resond with a valid error message when an invalid task_id is requested (don't just 500)
 2022-02-17 11:04:50 -05:00
alicia pritchett
b0c723f021 Merge remote-tracking branch 'origin/feature/get-spec-script-613' into chore/variables-in-forms-550 2022-02-17 10:35:06 -05:00
alicia pritchett
8d49e2bfbb Merge branch 'dev' into chore/variables-in-forms-550 2022-02-17 10:32:40 -05:00
mike cullerton
7885481b84 Ignore hidden files 2022-02-16 15:55:42 -05:00
Dan
0ad9843569 Dealing with some changes in SpiffWorkflow's latest release. I think this gets all tests passing again, and behaving as expected. 2022-02-16 10:46:46 -05:00