61504664d4
Merge pull request #346 from sartography/bug/346_timer_fails_to_send_email
...
fixes #346 , allow emails to fire in scheduled events
2021-07-22 13:40:12 -04:00
52ce171a8a
Merge pull request #344 from sartography/ldap-issues-394
...
Ldap issues #394
2021-07-22 13:39:29 -04:00
7369c7615e
Merge pull request #341 from sartography/no-reset-db-385
...
Trying to keep humans from accidentally resetting the database #385
2021-07-22 13:35:35 -04:00
2009a794ea
We were depending on an active http request existing in order to fire emails, using that request to determine the front end url. We have the frontend url in our config file, and we don't have a request object when running scheduled tasks, so I just use our configuration setting instead.
2021-07-22 13:25:06 -04:00
6b51fc7c06
Added a test with uppercase UID
...
Modified the script test to expect an empty dictionary now, instead of raising an error
2021-07-22 10:47:25 -04:00
8df1145471
Modify the LDAP service to only use lowercase UIDs.
...
UVA always returns the UID as lowercase.
This caused a postgres unique value problem for us.
2021-07-22 10:46:09 -04:00
428802b9d0
Modify LDAP script so that it doesn't raise an error when we don't get a record back from LDAP.
...
We now return an empty dictionary
2021-07-22 10:44:41 -04:00
dd67a5e650
Never set the date to datetime.utcnow() on DateTime fields. We want this to fall back on the func.now() method and allow the database to set the time on insert.
2021-07-12 15:58:32 -04:00
4fb8321675
Trying to keep humans from accidentally resetting the database
2021-07-12 15:00:32 -04:00
1f0b881b92
Hot patch, merging two heads.
2021-07-12 11:14:31 -04:00
522ca9d164
Merge pull request #340 from sartography/bug/better_errors_on_scheduled_tasks
...
Assure we log reasonably clear errors when executing scheduled tasks …
2021-07-12 10:13:02 -04:00
d1bf370a39
Merge pull request #339 from sartography/restrict-loaded-studies-374
...
Restrict loaded studies #374
2021-07-12 10:11:34 -04:00
7070761089
Merge pull request #338 from sartography/document-spreadsheet-name-380
...
Document spreadsheet name #380
2021-07-12 10:11:16 -04:00
f982745d32
fixing a failing test, don't assume the study and workflow ids will always be 1.
2021-07-12 10:00:39 -04:00
1916c4ff54
Assure we log reasonably clear errors when executing scheduled tasks in the background, so that sentry can pick them up and they can be addressed effectively.
2021-07-12 09:43:12 -04:00
69974e89fd
Added 2 simple tests for filtering by REVIEW_TYPE
2021-07-09 11:39:30 -04:00
682b010f6f
Added mocked study_details with an invalid REVIEW_TYPE
...
This is used to test StudyService.get_studies_for_user
StudyService.get_studies_for_user should now filter on REVIEW_TYPE
2021-07-09 11:38:45 -04:00
445d3e5f0b
Added mocked pb study_details since we now check whether a study has valid REVIEW_TYPEs
2021-07-09 10:41:46 -04:00
95c710768e
Fixed test to reflect adding REVIEW_TYPE to mocked study_details PB data
2021-07-09 10:40:18 -04:00
841bbe73ef
Added REVIEW_TYPE to the mocked PB data
2021-07-09 10:38:41 -04:00
690c059335
get_studies_for_user is no longer a static method
2021-07-09 10:37:57 -04:00
dad2de9f0c
get_user_studies now checks study_details['REVIEW_TYPE'] before displaying a study.
...
This corresponds to REVIEWTYPENAME being `Full Committee`, `Expedited`, `Non-UVA IRB Full Board`, or `Non-UVA IRB Expedited`
2021-07-09 10:37:25 -04:00
05ba28b67b
Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into dev
2021-07-07 14:33:17 -04:00
1c9db16bff
Migration to change filename from `irb_documents` to `documents` in the database
2021-07-07 13:27:57 -04:00
f1a15ef8e9
Fix the test
2021-07-07 12:54:16 -04:00
d6f9b013f7
Change `irb_documents` to `documents`
2021-07-07 12:54:03 -04:00
23180908c8
Undo change. Wrong branch
2021-07-07 12:43:51 -04:00
c39e08972d
Change irb_documents to documents
2021-07-07 12:42:01 -04:00
8374ae3fde
Merge pull request #332 from sartography/add-name-error-hint-8
...
Add name error hint #8
2021-07-07 11:35:45 -04:00
3c52453c26
Merge branch 'dev' into add-name-error-hint-8
2021-07-07 11:35:24 -04:00
bef35e4bec
Upgrading Spiffworkflow, just incorporating some additional tests.
2021-07-07 11:34:33 -04:00
2ed436327f
Merge pull request #333 from sartography/check-study-script-273
...
Check study script #273
2021-07-07 11:28:32 -04:00
db9b228735
Merge pull request #334 from sartography/WaitingEventsHotPatch
...
Make a change so that anything that has a waiting event is labeled in…
2021-07-07 11:27:10 -04:00
8cb7cbc0ad
Merge pull request #337 from sartography/add-by-user-61
...
Add by user #61
2021-07-07 11:25:45 -04:00
2a45f2fcda
Merge branch 'dev' into add-name-error-hint-8
2021-07-07 11:24:00 -04:00
b0cf74fa3d
Merge branch 'dev' into add-by-user-61
...
# Conflicts:
# tests/files/test_files_api.py
2021-07-07 10:46:50 -04:00
ac19c3e3c6
Add users first
2021-07-07 10:33:30 -04:00
5c229477d3
Merge pull request #336 from sartography/feature/better_errors
...
Feature/better errors
2021-07-07 10:30:41 -04:00
621c11fe24
Add test for user_uid
2021-07-07 09:39:01 -04:00
c11b5cfb29
Add user_uid to api output
2021-07-07 08:18:02 -04:00
fb54edac1c
Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct.
...
Most noteable is the addition of the line on which the error occurs for script tasks. It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
2021-07-07 00:53:49 -04:00
894377a607
Add user_uid to FileDataModel calls
2021-07-06 17:09:00 -04:00
23be257db0
Add user_uid column to file_data table
2021-07-06 17:07:47 -04:00
a9805ad40c
Adding some documentation for clarity.
2021-07-06 14:40:20 -04:00
cafdc4d100
Removing an unneeded modification to the database structure for lookup tables.
2021-07-06 14:02:07 -04:00
04842aa66b
Undo change to 1 minute.
2021-07-06 13:13:07 -04:00
7aa4b0833c
Merge remote-tracking branch 'origin/dev' into feature/documents_xls_refactor
2021-07-06 13:11:08 -04:00
1b1a994360
Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them.
...
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
2021-07-06 13:10:20 -04:00
9803a04d6d
Make a change so that anything that has a waiting event is labeled in the database as waiting, even if it is sitting around waiting on a user input task that is ready
2021-07-06 11:46:47 -04:00
8145ff9025
Tests for calling the script
2021-07-02 16:14:19 -04:00
Dan Funk
mike cullerton
Mike Cullerton
Kelly McDonald