5e54c90b47
"Reset" should not mean "re-start". Calling the reset_workflow script will now set the workflow to an "unstarted" state with no outstanding tasks, no json-state structure stored. The workflow is not yet running.
...
Also:
* Assured that arguments are consistent (we always seem to use workflow_spec_id, so I made sure we use that consistently.
* Don't require named parameters - so it's cool to call it like: reset_workflow('my_workflow_id')
* Task Actions (ie create, assign, etc...) are now an enumeration in the models, and not static variables on Workflow Service, so we can reference them consistently from anywhere.
* Removed some repetitive code
* Always try to validate as much as possible in the scripts to save folks time debugging.
*
2022-04-15 15:36:23 -04:00
0072f4ecea
Merge pull request #517 from sartography/another-data-store-bug
...
Another data_store bug
2022-04-14 16:02:51 -04:00
ae67c8985a
forgot the workflow
2022-04-14 15:50:12 -04:00
a21aea3348
Fixed a bug where we tried to delete a record that did not exist
2022-04-14 15:37:05 -04:00
e036d65ec6
Merge pull request #515 from sartography/data-store-bug-fix-709
...
Data store bug fix #709
2022-04-14 11:35:17 -04:00
6c1fcc5cee
Make sure we don't delete records when value is set to False
2022-04-13 18:10:35 -04:00
ea657cbbc2
Change value from string 'None' to value None to test deleting data_stores.
...
This as a work around, because the form field is set to string for other uses
2022-04-13 18:09:18 -04:00
19da7ecd7e
Fix test workflows to use new data_store scripts
2022-04-13 18:07:13 -04:00
be24b598b8
Fix call to set_data_common - no longer have workflow_spec_id, add type of data set
2022-04-13 18:03:23 -04:00
076eb8747f
Finish bug fix for deleting data_stores when value is None or empty string
...
Cleanup:
- Make sure workflow_spec_id has a value
- Change extra if conditionals to elif conditionals
2022-04-13 18:01:52 -04:00
72f9ac33d0
Consolidate data_store scripts
2022-04-13 17:57:22 -04:00
e87fae0004
*** WIP ***
...
Modify delete test to check for both None and empty string
2022-04-13 13:52:20 -04:00
721907bf52
Modify test workflow to use new data_store_set script instead of separate study_data_set, user_data_set, and file_data_set scripts
2022-04-13 13:51:25 -04:00
916daf002c
Clean up parameters for set_data_common
...
Use key, value instead of args[0], args[1]
2022-04-13 13:48:35 -04:00
8df20977c3
Missing a valid user name and password for git.
2022-04-12 15:01:10 -04:00
b455b73c7b
Don't freak out if there are not files to delete.
2022-04-12 14:43:34 -04:00
bf898993c4
Merge pull request #514 from sartography/get-irb-info-issue-702
...
Get irb info issue #702
2022-04-12 08:14:14 -04:00
41f190d3f5
Merge pull request #513 from sartography/delete-data-store-700
...
Delete data store #700
2022-04-12 08:11:16 -04:00
138dfc220d
Tests expect 1 record now
...
Add test for error state when study is not yet uploaded
2022-04-07 14:40:47 -04:00
ed49ebcc23
Fix mock data to only return 1 record
...
Add mock record for error state when study is not yet uploaded
2022-04-07 14:39:39 -04:00
e9ea95d1d7
The IRB Info API endpoint can return a dictionary--if the study is **not** yet uploaded, or a list with 1 dictionary if the study **is** uploaded
2022-04-07 14:38:32 -04:00
da7c0a50ae
Workflows for new tests
2022-04-05 18:17:54 -04:00
946e74118f
Test updating records
...
Test deleting records when setting with empty value
Test deleting 'extra' records
2022-04-05 18:17:31 -04:00
d04b447c8c
Update data stores, rather than creating new ones
...
Delete 'extra' data stores
2022-04-05 18:15:58 -04:00
3c418f7611
Rename workflow/test_workflow_data_store_validation to test_data_store_service
2022-04-05 11:35:41 -04:00
6694dc6cb3
Merge pull request #510 from sartography/git-error-filenotfound-690
...
Git error filenotfound #690
2022-04-04 16:53:36 -04:00
095105e3e6
Merge pull request #508 from sartography/validation-with-data-store-396
...
Validation with data store #396
2022-04-04 16:51:57 -04:00
65da5a34ce
Merge pull request #512 from sartography/bug/same_uid_different_roles
...
Study Associates Bug
2022-04-04 16:23:00 -04:00
e1f9dcded5
Assure we can associate the same person with a workflow under two different roles.
2022-04-04 16:01:48 -04:00
0b4caae19f
Merge pull request #511 from sartography/review-type-updates-692
...
Review type updates #692
2022-03-30 10:49:25 -04:00
51c6871d06
Update mock data to use new valid review type
2022-03-30 10:30:27 -04:00
dd26f8fef7
Update review types
...
Remove review types 23, 24
Add review type 21
2022-03-30 10:29:53 -04:00
70e8f6b35e
Fix typo in test: delete -> remove
2022-03-29 12:34:05 -04:00
689aa54d50
Modified tests to work with the bug fix
2022-03-29 09:49:29 -04:00
ae66934bf9
Fix bug where we tried to add files to the index that were removed from the repo
2022-03-29 09:49:05 -04:00
9ec1514267
Merge pull request #509 from sartography/chore/zip-file-update-688
...
Chore/zip file update #688
2022-03-29 09:41:32 -04:00
6ff0cdbb9d
Merge pull request #507 from sartography/bug/validating_data_security
...
Bug/validating data security #684
2022-03-29 09:41:02 -04:00
ee3217de62
Test for new feature
2022-03-28 11:59:53 -04:00
f92f9d64ea
Allow users to pass a `doc_code` to get_zipped_files script
2022-03-28 11:59:10 -04:00
6b93d605d4
Test for new validation_data_store.
...
We set 3 `real` data_store values in the DB
The workflow sets 3 validation_data_store values
We assert that the correct values are returned.
We also assert that we get correct default values back if we pass in bad keys
2022-03-25 10:06:03 -04:00
4abdc4920f
There was a problem if validate_study_id was 0 (zero). It evaluated to False
2022-03-25 10:04:05 -04:00
5229cf457e
Modify scripts to use the changes in data_store_service validate methods
...
Make sure we return values in the validate methods
Minor cleanup
2022-03-25 10:03:12 -04:00
8c88de35cd
Modify get_validate_common and set_validate_common methods to use the temporary validate_data_store list
...
In get_validate_common, we first look in validate_data_store, then in the real data_store. This allows us the flexibility to use temp values for current workflow or real values set by previous workflows.
Also, lots of cleanup:
- we didn't use the dictionary returned by the set_data_common method, so removed it and only return the value we set.
- this allowed us to delete the `overwritten` method and some other code.
- renamed some variables to better represent what we are doing
2022-03-25 10:01:31 -04:00
5bf114b605
Initialize `validation_data_store` as empty list
2022-03-25 09:50:31 -04:00
b884ce4c3a
Remove debug print statement
2022-03-23 16:49:58 -04:00
51fa494d03
Assert we evaluate the hidden property correctly during validation.
2022-03-23 16:49:35 -04:00
94abd7eebf
*** WIP ***
...
Add a temporary data store for validation
2022-03-23 15:15:01 -04:00
7dfb0bbba9
assure we can use the right data when determining if a field is hidden.
2022-03-23 14:25:29 -04:00
244fced84d
Merge pull request #506 from sartography/chore/unchecked-checkbox-default-671
...
Unchecked checkbox default #671
2022-03-23 10:59:47 -04:00
147f9a8176
Merge pull request #503 from sartography/dependabot/pip/deploy/waitress-2.1.1
...
Bump waitress from 1.4.4 to 2.1.1 in /deploy
2022-03-23 10:57:09 -04:00
Dan
mike cullerton
Mike Cullerton