Commit Graph

137 Commits

Author SHA1 Message Date
Dan 548c35a4a3 Merge branch 'dev' into varchar-category-id-483 2021-10-07 11:35:10 -04:00
mike cullerton da894219c5 Changes to tests after removing `name` column from `workflow_spec` and `workflow_spec_category` tables. 2021-10-05 14:20:03 -04:00
Dan b02731df17 Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates)
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.

remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
2021-10-04 15:07:47 -04:00
Dan Funk f898d6f502
Merge pull request #385 from sartography/ids-approval-validation-478
Ids approval validation #478
2021-09-30 13:59:26 -04:00
Dan Funk 0353161402
Merge branch 'dev' into feature/381_validate_field_types 2021-09-30 13:19:36 -04:00
mike cullerton 2067c7226a Better test. Actually grab data explicitly from the list in Element Documentation 2021-09-30 12:54:03 -04:00
mike cullerton 7676e230e5 Test and bpmn for enum checkbox 2021-09-30 12:10:47 -04:00
Dan 8e00f16eaa Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea" 2021-09-29 11:43:08 -04:00
mike cullerton fb9c3e96ac Test and mocked status data for adding master workflow into validation.
Make sure we see ApiError for disabled workflow spec
2021-09-24 11:08:54 -04:00
mike cullerton 9aadaac0df Test to make sure we do not set a category_id for library workflow specs 2021-09-13 16:16:05 -04:00
mike cullerton 5ddff1d1be Merge branch 'dev' into add-reorder-api-endpoints-444 2021-09-09 13:10:54 -04:00
mike cullerton a35d122a03 Tests for case where we have bad display_order numbers.
I.e., 0, 1, 1, 1
2021-09-08 11:18:06 -04:00
mike cullerton e6a2b9d642 New test and BPMN for changes 2021-08-31 16:18:29 -04:00
mike cullerton 86583aa2d6 Be explicit about loading sample data
Add category_id when checking order
2021-08-31 12:19:45 -04:00
mike cullerton cfd8f3fe74 Test for reordering remaining spec categories after delete 2021-08-30 15:21:42 -04:00
mike cullerton e317b59bfe Test for reordering workflow specs upon deletion 2021-08-30 14:57:16 -04:00
mike cullerton c99080845b renamed a test 2021-08-30 13:56:27 -04:00
mike cullerton dfe967d578 Tests for reordering categories 2021-08-30 13:56:13 -04:00
mike cullerton d43eb4d6f8 Tests for workflow spec reordering 2021-08-30 12:35:57 -04:00
mike cullerton 543fc1fb4a Start of tests for new reorder API endpoint
Modified example_data to include a display_order for example spec
2021-08-27 13:04:11 -04:00
mike cullerton cd3d17862a Add task_spec_name to a bunch of tests 2021-08-26 10:43:28 -04:00
nilez b9d4f6c436 assertEquals -> assertEqual 2021-08-16 10:18:29 -04:00
mike cullerton e0096ebc8e Test and BPMN to make sure we don't process when field is hidden, but do process when field is not hidden 2021-08-11 16:44:45 -04:00
Kelly McDonald 25319a0e6a Make changes to alembic process - fix test for new API 2021-08-02 08:59:24 -04:00
mike cullerton 097dd9f9a3 Included the failing test, with self.assertRaises
Reworded some of the comments
2021-07-28 11:22:45 -04:00
Kelly McDonald 217e61eed3 next_task returns the next available task, except when the task is completed when it returns the EndEvent -
The problem was that it was returning the first EndEvent it found, not the last one. This caused a problem when we had a CallActivity which has its own EndEvent.

Fixes #399
2021-07-27 09:19:08 -04:00
mike cullerton 2c892560ad Failing test for Call Activity End Events - Ticket 399 2021-07-26 12:12:01 -04:00
Dan 2a45f2fcda Merge branch 'dev' into add-name-error-hint-8 2021-07-07 11:24:00 -04:00
Dan fb54edac1c Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct.
Most noteable is the addition of the line on which the error occurs for script tasks.  It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
2021-07-07 00:53:49 -04:00
mike cullerton 2a43230121 Test and workflow for the new name error hint code 2021-07-01 15:39:25 -04:00
Dan Funk 19d63e2aa2
Merge pull request #328 from sartography/restart-workflow-programmatically-347
Restart workflow programmatically #347
2021-06-17 10:36:46 -04:00
Dan a4caae8d64 when validating, we need to take every step to remove the workflows we create during the validation. 2021-06-16 14:40:20 -04:00
mike cullerton 94e730d04e Test script validation 2021-06-15 11:15:31 -04:00
mike cullerton addf1cab5b Added tests for failing conditions 2021-06-15 10:30:18 -04:00
mike cullerton 9e20025f33 Test and workflow for reset_workflow 2021-06-15 08:37:42 -04:00
mike cullerton 9dc5871848 Added mocked PB data for tests using study_info script. 2021-06-07 10:08:44 -04:00
mike cullerton 37ba46fb8f These tests now require PB Mock because of the validate_study_id changes 2021-06-03 14:30:00 -04:00
Dan ef7ee284b2 Prefer tasks that share a parent over just the the next available task when returning the next_task in the workflow processor. 2021-05-19 16:26:16 -04:00
Dan Funk ade7812540
Merge pull request #310 from sartography/get-primary-workflow-301
Get primary workflow #301
2021-05-14 12:41:48 -04:00
mike cullerton 4c8ea14435 Fixed test - changed the method name 2021-05-12 14:07:54 -04:00
mike cullerton 8f8d9d30e4 Added test for get_primary_workflow 2021-05-12 13:52:18 -04:00
mike cullerton 67321ecd97 Test and workflow for persisting read-only data 2021-05-07 14:07:19 -04:00
mike cullerton 09d8c8bcba added missing test for update_workflow_spec_category 2021-04-26 12:57:08 -04:00
mike cullerton 0aa3e8f586 added missing test for add_workflow_spec_category 2021-04-26 12:41:50 -04:00
mike cullerton b73c2ff1cb Added missing test for `get_workflow_from_workflow_spec` 2021-04-26 12:00:06 -04:00
Mike Cullerton 39fcab3730
Merge branch 'dev' into launch-workflow-outside-study-204 2021-04-26 10:27:32 -04:00
mike cullerton 7cca559747 Fixed issue where we were passing in a workflow_api instead of a workflow when completing a form in tests. 2021-04-26 08:58:09 -04:00
mike cullerton c002ef1e76 Added test for new api endpoint to get all standalone workflow_specs.
Modified test_add_new_workflow_specification to include new standalone argument
2021-04-26 08:56:21 -04:00
mike cullerton 2d4a68da6d Added test for deleting files on restart. 2021-04-15 11:30:17 -04:00
Dan 6427a54d74 Set the correct default value on enumerations - if it is a multi-select enum (checkbox is set) then it should return a default value of an empty array, and not a dictionary. 2021-04-09 08:40:58 -04:00