Commit Graph

2122 Commits

Author SHA1 Message Date
Dan 548c35a4a3 Merge branch 'dev' into varchar-category-id-483 2021-10-07 11:35:10 -04:00
Dan Funk 77bd649b3b
Merge pull request #389 from sartography/bug/474_navigation_to_prevous_task
Bug/474 navigation to prevous task
2021-10-07 11:16:43 -04:00
Dan Funk 208ca92fb2
Merge pull request #388 from sartography/bug/472_date_time
fixes 472 - a bug with the datetime validation
2021-10-07 11:13:53 -04:00
mike cullerton 10abf51f70 Added workflow_spec_id to WorkflowMetadata model, because the id is the workflow id, not the workflow_spec id.
Then, we use workflow_spec_id in StudyService when looking for workflow status.
2021-10-07 10:02:13 -04:00
Dan c36a76a8bc Merge branch 'varchar-category-id-483' of github.com:sartography/cr-connect-workflow into varchar-category-id-483 2021-10-06 15:27:35 -04:00
Dan 4068fbbc08 Migration to fix the names of the workflow specs. 2021-10-06 15:27:26 -04:00
alicia pritchett ea4e382f06 Fixing some tests 2021-10-06 15:24:58 -04:00
alicia pritchett 7b6beae9c1 fixes frontend bailing out
workflow id is workflow id
2021-10-06 14:33:09 -04:00
Dan Funk 017ab45311
Merge pull request #387 from sartography/email-from-field-475
Email from field #475
2021-10-06 13:42:27 -04:00
Dan 84680ea846 Fixing multiple issues that came out of Study Info, as we debugged issue #474 related to navigating back to a previous task.
There was a problem with the python script engine as well that wasn't handling the de-serialize properly and didn't correctly pick back up on the script engine, and the renaming of methods in PythonScriptEngine created some conflicts with the way we override functions.
We were not handling ldap looks up efficiently, and this was also breaking in Study Info.

Finally we had a bug in SpiffWorkflow that did not allow us to reset back to the previous task in some cases where nested call activities happen far later in the process and are currently active when the reset is created.
2021-10-06 12:17:57 -04:00
mike cullerton da894219c5 Changes to tests after removing `name` column from `workflow_spec` and `workflow_spec_category` tables. 2021-10-05 14:20:03 -04:00
mike cullerton 572ca1db6b Fixes for backend code after removing `name` column from `workflow_spec` and `workflow_spec_category` tables 2021-10-05 14:17:41 -04:00
mike cullerton fb660182aa Testing setup changes 2021-10-05 13:36:53 -04:00
mike cullerton fcf538ca92 remove `name` column from workflow_spec and workflow_spec_category 2021-10-05 13:10:36 -04:00
Dan b02731df17 Add some additional checks in the workflow service so we assure the data we are creating during validation can be serialized and deserialized just as it would be through the API. (Was hanging us up on dates)
Assure that if we generate a default value for a date in the task data, it is stored as an ISO String.

remove any unserializable data from the task_data when an error is encountered, rather than just dropping all the task_data. This case seems to happen a lot and it leaves us with nothing to go on.
2021-10-04 15:07:47 -04:00
Dan 448b7b2773 respect proxy configurations. 2021-10-01 15:35:22 -04:00
Dan c3995bfc3e Another try at getting the url correct. This paired with an additional setting on the server maybe. 2021-10-01 14:25:00 -04:00
mike cullerton 7357fe7507 test for new From field 2021-10-01 14:02:56 -04:00
mike cullerton 0ef33aae00 Change default From field for emails to uvacrconnect@virginia.edu 2021-10-01 14:02:37 -04:00
Dan 50dae23c42 Finally have alembic configured so we can see orrors when things aren't working! 2021-10-01 13:00:41 -04:00
Dan 5924ee48f4 One more try at getting the currect url. 2021-09-30 16:56:27 -04:00
Dan Funk 03c7a5eee2
Merge pull request #386 from sartography/top-level-validation-460
Bug fix for top level validation #460
2021-09-30 16:20:27 -04:00
mike cullerton 5bf7bf3e2e Bug fix for adding master workflow to validation
We now check that a workflow is in the status dictionary before looking up its status.
2021-09-30 15:48:57 -04:00
Dan Funk f898d6f502
Merge pull request #385 from sartography/ids-approval-validation-478
Ids approval validation #478
2021-09-30 13:59:26 -04:00
Dan Funk 6b5a55df4c
Merge pull request #383 from sartography/feature/476_file_url
URL for files
2021-09-30 13:47:37 -04:00
Dan Funk fbfb241c0b
Merge pull request #382 from sartography/feature/381_validate_field_types
fixes #381 Assure that the field type provided is supported.  Catches errors suc…
2021-09-30 13:46:40 -04:00
Dan Funk 615d0e7f89
Merge pull request #384 from sartography/chore/admin-cat-456
Admin flag on category + migration + updated test
2021-09-30 13:37:09 -04:00
Dan Funk 0353161402
Merge branch 'dev' into feature/381_validate_field_types 2021-09-30 13:19:36 -04:00
Dan Funk 1251202244
Merge pull request #379 from sartography/top-level-validation-460
Top level validation #460
2021-09-30 13:11:03 -04:00
mike cullerton 2067c7226a Better test. Actually grab data explicitly from the list in Element Documentation 2021-09-30 12:54:03 -04:00
mike cullerton 0202b409e1 My checkbox test was in a bad place. Moved it into each of the 2 blocks. 2021-09-30 12:34:46 -04:00
mike cullerton 7676e230e5 Test and bpmn for enum checkbox 2021-09-30 12:10:47 -04:00
mike cullerton ba2741818d Added the Testing url as example data so we don't have to look it up and type it every time. 2021-09-30 11:36:39 -04:00
mike cullerton 73cd729cac Checkbox enums need to return a list. 2021-09-30 11:35:13 -04:00
Dan e002ffd363 Fixing a broken test. 2021-09-30 10:30:58 -04:00
alicia pritchett d5d4496cd0 Admin flag on category + migration + updated test 2021-09-29 16:53:59 -04:00
Dan 8a4a53f028 Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea" 2021-09-29 14:05:45 -04:00
Dan 8e00f16eaa Assure that the field type provided is supported. Catches errors such as adding a custom field type of 'text_area' rather than "textarea" 2021-09-29 11:43:08 -04:00
Dan d0c819dd5f sync was failing because it tried to add the libraries before adding the spec the libraries connect to. 2021-09-29 10:21:24 -04:00
Dan 92b9fea08d fixing a stupid mistake that made all the people I care about suffer yesterday afternoon. 2021-09-29 10:06:17 -04:00
Dan cd35c7bcfe Bumping Spiffworkflow, fixes #470 2021-09-28 13:21:56 -04:00
mike cullerton fb9c3e96ac Test and mocked status data for adding master workflow into validation.
Make sure we see ApiError for disabled workflow spec
2021-09-24 11:08:54 -04:00
mike cullerton ef5a0a7e45 Check whether a workflow spec is disabled by the master workflow before validating.
Return the master workflow message to the user
2021-09-24 11:05:33 -04:00
Dan edb4d5abe2 bumping spiffworkflow to add support pytz. 2021-09-23 13:33:56 -04:00
Dan Funk e4add14193
Merge pull request #378 from sartography/bug/246_user_ldap_refactor
Bug/246 user ldap refactor
2021-09-22 15:31:34 -04:00
Dan Funk 48d979dd5a
Merge pull request #377 from sartography/study-info-mislabeled-464
Study info mislabeled #464
2021-09-22 15:31:23 -04:00
Dan Funk deff293fff
Merge pull request #376 from sartography/bug/468_missing_file_date
fixes #448 - Missing  file date
2021-09-22 15:29:32 -04:00
Dan Funk e672d46dd0
Merge pull request #375 from sartography/study-info-adds-463
Study info adds #463
2021-09-22 15:28:40 -04:00
Dan Funk 9605bd3c1b
Merge pull request #374 from sartography/zip-documents-379
Zip documents #379
2021-09-22 15:26:23 -04:00
Dan 19104303de Refactor of the way we store and return details about users - All the details about a user, or individual associated with a study is returned within in an Ldap model. I've removed duplication between these models. This required some cleanup of the tests, and a migration that will drop the user details. 2021-09-22 13:16:25 -04:00