1466 Commits

Author SHA1 Message Date
Dan Funk
349c3d657a
Merge branch 'dev' into 201-changes-to-in-progress 2021-02-22 18:17:59 -05:00
Dan Funk
53fa49e668
Merge pull request #243 from sartography/183-remove-study-approval-code
Remove Approvals per ticket 183
2021-02-22 18:12:02 -05:00
Dan
17941ba7fc Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-02-22 11:37:22 -05:00
Dan
099e22ca85 update readme with details on how to trasnfer bpmn configuration from one system to another. 2021-02-22 11:37:16 -05:00
Kelly McDonald
4fa0f9720a Allow frontend to honor 'view as' and fix problem with tests 2021-02-18 11:25:17 -05:00
Kelly McDonald
8c309e9a41 Add user display name to the response for task events 2021-02-18 08:44:44 -05:00
Kelly McDonald
6fbaecf9b2 Change selection to include task events that are for someone else, but are on a study I own. 2021-02-18 08:09:13 -05:00
Dan Funk
f0a921d46d
Merge pull request #242 from sartography/allow-period-in-field-id-199
Allow period in field id 199
2021-02-17 15:08:53 -05:00
Kelly McDonald
93f29e86d8 Merge branch 'dev' into STG-181_frontend-ux-model-changes 2021-02-17 07:49:05 -05:00
Dan
ff8a44a7b1 Make sure we always have a current user, even if the very first task is a script task. 2021-02-16 12:42:59 -05:00
Kelly McDonald
e54a6956df Make a change in the case that we have no task_events at all. 2021-02-16 11:10:40 -05:00
Kelly McDonald
118cf62172 Merge remote-tracking branch 'origin/dev' into STG-181_frontend-ux-model-changes 2021-02-16 10:07:34 -05:00
Kelly McDonald
97a3a3bf45 Make sure alembic version is added 2021-02-16 09:06:03 -05:00
Kelly McDonald
003bf2f9b9 Remove Approvals per ticket 183 2021-02-16 09:05:29 -05:00
Kelly McDonald
3b1dc70558 Add comment for later ticket 2021-02-16 08:44:41 -05:00
mike cullerton
c40af1d7df Modified workflow to add form field with period in the id. 2021-02-15 16:36:36 -05:00
mike cullerton
446bff9c8c Modified test for missing default value on hidden and required fields to check for task_id and task_name 2021-02-15 16:28:51 -05:00
mike cullerton
34700568ee Added a test for allowing periods in field ids 2021-02-15 16:28:21 -05:00
mike cullerton
ed6218028c We now allow periods in field ids.
Also, added task_id and task_name to the ApiError for missing default value on hidden and required fields
2021-02-15 16:27:56 -05:00
Dan
62fdb38e59 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-02-12 09:50:55 -05:00
Dan
c44e784eb2 Fixing a bug with the user model. 2021-02-12 09:48:41 -05:00
Nile Walker
ab3453a70e
Update user.py 2021-02-12 09:43:30 -05:00
Dan Funk
35773ebc29
Merge pull request #240 from sartography/weird-email-error
The email script was failing validation because of missing parameters…
2021-02-12 09:31:52 -05:00
Nile Walker
7eeb491dfa User str decode Removed 2021-02-12 09:30:18 -05:00
mike cullerton
d8bd203139 The email script was failing validation because of missing parameters in scripts.email.do_task_validate_only.
I added a test in tests.test_email_script to make sure we get the default email_address.
I also found and fixed a bug in workflow_service.populate_form_with_random_data where we would overwrite default_values with random text because of a missing continue.
(We don't want to continue if we have repeating fields though.)
2021-02-11 15:36:12 -05:00
Dan
044b82cb25 Maybe a faster, more dependeable dockerfile? 2021-02-11 12:44:34 -05:00
Dan
d0f30c4f9c Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-02-11 11:45:00 -05:00
Dan
d08f2ce837 Moving to quay.io, no longer need to run the deploy section for travis, as this is handled within quay. 2021-02-11 11:44:46 -05:00
Dan Funk
fe4e737596
Merge pull request #238 from sartography/value-expression-failing-shield-test-194
We now allow value_expression to evaluate to an empty string ("") so …
2021-02-11 11:25:09 -05:00
Dan Funk
df0cfc755b
Merge pull request #237 from sartography/get-study-from-model-error-191
We now test whether we have a valid StudyModel when getting a study b…
2021-02-11 11:23:59 -05:00
Dan Funk
40639bbd03
Merge pull request #236 from sartography/trap-non-api-errors-187
New error handler for non Api errors. Ticket 187
2021-02-11 11:22:48 -05:00
Dan Funk
df25b83958
Merge pull request #235 from sartography/index-error-for-enums-186
Index error for enums 186
2021-02-11 11:21:50 -05:00
Dan Funk
10b9c7b892
Merge pull request #234 from sartography/hidden-and-required-fields-185
Hidden and required fields 185
2021-02-11 11:20:35 -05:00
Dan
f7337f4e54 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-02-11 11:17:56 -05:00
Dan
2ada9f6f42 Private Ldap settings 2021-02-11 11:17:21 -05:00
mike cullerton
39e874504f We now allow value_expression to evaluate to an empty string ("") so that we *do not* set a default value for enums in some cases.
This was causing an error because "" was not an option for the enum.
2021-02-10 14:35:58 -05:00
Kelly McDonald
da0af14724 Changes to enable front-end changes
Added a human readable name to created user

added last updated task time and name,

added is_review on the workflow which is triggered by a swimlane with a name present.

Notably - it does NOT update or change any of the performance concerns that we were having with this.
2021-02-10 11:58:19 -05:00
mike cullerton
777cfbdecd We now test whether we have a valid StudyModel when getting a study by study model.
We raise an ApiError if the model is None or empty.
2021-02-09 17:37:55 -05:00
mike cullerton
3e32cdedc4 New error handler for non Api errors. Ticket 187 2021-02-09 16:35:57 -05:00
mike cullerton
11177b4296 Test, workflow, and empty spreadsheet for the new code. The workflow references the spreadsheet, which has no rows. 2021-02-08 15:12:11 -05:00
mike cullerton
b42b843f7d It was possible for an enum field lookup to return an empty list. This meant there were no options for the list.
We now test for this and raise an error.
2021-02-08 15:10:53 -05:00
mike cullerton
eb504465f6 Test and workflow for new code.
We test 2 things.
 - If a field can be hidden and required, it must have a default value or value_expression
 - If a field is hidden and required, make sure we use the default value
2021-02-08 10:20:05 -05:00
mike cullerton
e87e7b5b8b Form fields that can be hidden and required must now have a default value or value_expression.
Also, if a field is hidden but not required, it should not produce a value.
2021-02-08 10:18:41 -05:00
Dan Funk
329146237e
Merge pull request #232 from sartography/boolean-default-values-175
Boolean default values 175
2021-02-03 16:34:54 -05:00
Dan Funk
effd11f947
Merge pull request #231 from sartography/cancellations-137
Cancellations 137
2021-02-03 16:31:18 -05:00
Dan Funk
2d01b92a50
Merge pull request #230 from sartography/pretty-emails-160
Pretty emails 160
2021-02-03 16:20:38 -05:00
Dan Funk
1eba20f420
Merge pull request #229 from sartography/workflow-spec-order-74
Workflow spec order 74
2021-02-03 16:18:34 -05:00
mike cullerton
1247744463 Test and workflow for new code. 2021-02-03 09:50:37 -05:00
mike cullerton
b090e31e00 This fixes 2 issues with setting boolean defaults
- If the default was False, we failed an early test and returned None. We now only return None if default is None
 - We have a better test for deciding if the default value we return should be True or False. We used to return True if the value was the string 'false'.
2021-02-03 09:50:16 -05:00
mike cullerton
6f7abc0a97 Added tests to test_workflow_restart to make sure we call cancel_notify events when appropriate. 2021-01-29 14:48:35 -05:00