Commit Graph

2408 Commits

Author SHA1 Message Date
Dan b12e178288 Fixing a failing test. 2021-11-17 14:12:15 -05:00
Dan 7b02f46403 During validation, options were not being handled correctly for certain types of lookups. 2021-11-17 13:38:41 -05:00
Dan 5e97953c19 Merge branch 'dev' into xls-xlsx-issue-540 2021-11-16 15:59:06 -05:00
Dan 8e2e3519f6 fixes to our tests related to updates in SpiffWorkflow 2021-11-16 15:57:37 -05:00
Dan 3569c82e80 fixing additional tests 2021-11-16 15:46:02 -05:00
mike cullerton 99d0035b41 Merge branch 'dev' into xls-xlsx-issue-540 2021-11-16 12:33:32 -05:00
mike cullerton cb77db26a3 Minor edit, for clarity 2021-11-16 12:05:20 -05:00
mike cullerton df0800f071 New test and xls file for failing test 2021-11-16 11:57:24 -05:00
mike cullerton 9f18484ebb Grab exception when reading older xls spreadsheet into pandas
Renamed `xls` variable to `xlsx`, so it makes more sense
Added a hint to error_service for validation
2021-11-16 11:54:31 -05:00
Dan c25d173606 Set the default level of logging to be INFO, not DEBUG, we don't want everyone elses debug information. 2021-11-15 13:39:42 -05:00
Dan ca5e984915 Merge branch 'dev' of github.com:sartography/cr-connect-workflow into dev 2021-11-11 13:47:43 -05:00
Dan 8cabdd1f96 Bumping to new release of SpiffWorkflow. 2021-11-11 13:47:35 -05:00
Dan Funk 8c166bd029
Merge pull request #423 from sartography/test-protocol-builder-519
Test protocol builder #519
2021-11-11 11:49:57 -05:00
Dan f4f3842059 Fixing a stupid mistake. 2021-11-11 11:45:35 -05:00
Dan 197b75c6bf Quickfix - validation was failing if we had a date object in the task data, but this isn't really a problem. We now use the same JSON serializer as flask does, when doing validations, to better verify behavior with the front end. 2021-11-11 11:18:58 -05:00
mike cullerton c7147274f0 Resolving issues from code review 2021-11-10 17:43:34 -05:00
mike cullerton 0e8c4580ed Moved to instance/config 2021-11-10 17:18:33 -05:00
mike cullerton a8b7cd8bba Merge branch 'dev' into test-protocol-builder-519 2021-11-10 16:32:34 -05:00
Dan Funk 037692f42b
Merge pull request #422 from sartography/chore/group-repeating-validation-536
Fixes #536 - Group + Repeating property validation
2021-11-10 15:28:04 -05:00
Dan Funk e764bf937d
Merge pull request #421 from sartography/bug/validation_of_enum_label_failing_in_sub_workflows
Validation was failing for enum_label() expressions when called withi…
2021-11-10 15:26:03 -05:00
Dan Funk 81f8aed68b
Merge pull request #420 from sartography/drop-tasklog-on-delete
Delete Task log model when deleting a study
2021-11-10 15:20:11 -05:00
Dan Funk 56dc34a209
Merge pull request #414 from sartography/chore/view-as-382
remove email script test line about UTC stuff
2021-11-10 15:18:41 -05:00
Dan Funk 84f364ce37
Merge branch 'dev' into chore/view-as-382 2021-11-10 15:16:20 -05:00
alicia pritchett accdd281fa Fixes #536 - Group + Repeating property validation
For now, we should not allow both group and repeat properties on a field together.
2021-11-09 13:21:44 -05:00
mike cullerton 748c80964f Don't need the `.strip('/')` for the UVA urls 2021-11-09 13:09:01 -05:00
mike cullerton 5cf742d955 remove unused import 2021-11-09 13:07:01 -05:00
mike cullerton d584e735ec Possible way to switch between real and mock PB 2021-11-09 13:03:41 -05:00
Dan d1eae3c15a Validation was failing for enum_label() expressions when called within a sub-process. Possible (but unlikely) that this would occur outside validation. 2021-11-09 12:55:06 -05:00
alicia pritchett cd889c5b67 test that you can't be someone not in ldap 2021-11-09 11:08:55 -05:00
alicia pritchett 024a63b725 new and improved test 2021-11-09 11:05:04 -05:00
alicia pritchett aa1ba59bb1 Delete Task log model when deleting a study
just a minor fix
2021-11-09 10:42:47 -05:00
mike cullerton fe502ad306 Added easy way to switch back and forth between PB urls 2021-11-09 10:29:23 -05:00
mike cullerton b193f56f35 Minor cleanup for readability. 2021-11-08 10:13:07 -05:00
mike cullerton ed5689c1b9 Fixed `test_info_script_documents` to use a mocked call to required_docs.
Fixed `test_get_required_docs` to use new required_docs syntax
study_details now in a list, so we look at the first item in the list
2021-11-08 10:00:19 -05:00
mike cullerton 4e13ea6704 Fixing test mocks
- study_details returned in a list
- added `Q_COMPLETE` and `HSRNUMBER` to user_studies
- `required_docs` totally different from what we had
2021-11-08 09:55:06 -05:00
mike cullerton 6f09b0d7dd Added comment to _is_valid_study.
Fixed get_required_docs. The data returned for get_required_dcs from UVA PB was *very* different than what we had.
2021-11-05 14:37:41 -04:00
mike cullerton d186b24de3 UVA PB returns the info in a list. We want the dictionary in the list 2021-11-05 14:26:21 -04:00
mike cullerton 271d4da5ff Merge branch 'dev' into test-protocol-builder-519 2021-11-05 10:29:20 -04:00
mike cullerton 6d548c2a74 *** WIP ***
Committing to work on another ticket
There are TODOs in study_service
2021-11-05 09:59:14 -04:00
Dan 9376d3deaf Don't error out trying to send an error about invalid review types. 2021-11-04 13:32:57 -04:00
Dan Funk 3a36a48b88
Merge pull request #418 from sartography/convert-timestamp-499
Added ordered arguments to the get_localtime script #499
2021-11-03 14:28:57 -04:00
Dan Funk aeaacaf21f
Merge pull request #417 from sartography/email-data-script-487
get_email_data bug #487
2021-11-03 14:27:30 -04:00
mike cullerton b03e596dcf One thing at a time; remove HSRNUMBER for now 2021-11-03 12:58:03 -04:00
mike cullerton 9c8ae36ba3 UVA IRB passes back `Q_COMPLETE` and `HSRNUMBER` 2021-11-03 12:40:43 -04:00
mike cullerton 7f163285c3 Test w/Alex's ID 2021-11-03 11:56:07 -04:00
mike cullerton 8be9a1968b configure logging 2021-11-03 11:21:39 -04:00
mike cullerton 50d4159168 info log didn't show up. Maybe debug? 2021-11-03 10:36:27 -04:00
mike cullerton 8b6c8f9518 Logging to troubleshoot API call 2021-11-03 10:14:11 -04:00
mike cullerton 1f9c80d70d Added ordered arguments to the get_localtime script
Modified the workflow so the first task is a form with booleans that allows me to test all the permutations.
Modified tests to cover all the permutations for calling the script
2021-11-03 08:36:24 -04:00
mike cullerton e22a9e7173 Cleanup, and added comments about the 2 sets of URLs 2021-11-02 15:32:43 -04:00