Dan
1916c4ff54
Assure we log reasonably clear errors when executing scheduled tasks in the background, so that sentry can pick them up and they can be addressed effectively.
2021-07-12 09:43:12 -04:00
Dan
bef35e4bec
Upgrading Spiffworkflow, just incorporating some additional tests.
2021-07-07 11:34:33 -04:00
Dan Funk
2ed436327f
Merge pull request #333 from sartography/check-study-script-273
...
Check study script #273
2021-07-07 11:28:32 -04:00
Dan Funk
db9b228735
Merge pull request #334 from sartography/WaitingEventsHotPatch
...
Make a change so that anything that has a waiting event is labeled in…
2021-07-07 11:27:10 -04:00
Dan Funk
8cb7cbc0ad
Merge pull request #337 from sartography/add-by-user-61
...
Add by user #61
2021-07-07 11:25:45 -04:00
mike cullerton
b0cf74fa3d
Merge branch 'dev' into add-by-user-61
...
# Conflicts:
# tests/files/test_files_api.py
2021-07-07 10:46:50 -04:00
mike cullerton
ac19c3e3c6
Add users first
2021-07-07 10:33:30 -04:00
Dan Funk
5c229477d3
Merge pull request #336 from sartography/feature/better_errors
...
Feature/better errors
2021-07-07 10:30:41 -04:00
mike cullerton
621c11fe24
Add test for user_uid
2021-07-07 09:39:01 -04:00
mike cullerton
c11b5cfb29
Add user_uid to api output
2021-07-07 08:18:02 -04:00
Dan
fb54edac1c
Adding additional details to error messages, and cleaning up the cruft around these messages to keep them clear and succinct.
...
Most noteable is the addition of the line on which the error occurs for script tasks. It will report the line number and pass back the content of
the line that failed.
The validator only returns the first error it encounters, as it's clear that all we ever get right now is two of the same error.
Did a lot of work between this and spiffworkflow to remove all the places where we obfuscate or drop details as we converted between workflowExceptions and APIExceptions.
Dropped the python levenshtein dependency, in favor of just rolling a simple one ourselves in Spiffworkflow.
2021-07-07 00:53:49 -04:00
mike cullerton
894377a607
Add user_uid to FileDataModel calls
2021-07-06 17:09:00 -04:00
mike cullerton
23be257db0
Add user_uid column to file_data table
2021-07-06 17:07:47 -04:00
Dan
a9805ad40c
Adding some documentation for clarity.
2021-07-06 14:40:20 -04:00
Dan
cafdc4d100
Removing an unneeded modification to the database structure for lookup tables.
2021-07-06 14:02:07 -04:00
Dan
04842aa66b
Undo change to 1 minute.
2021-07-06 13:13:07 -04:00
Dan
7aa4b0833c
Merge remote-tracking branch 'origin/dev' into feature/documents_xls_refactor
2021-07-06 13:11:08 -04:00
Dan
1b1a994360
Refactoring Reference files to use the lookup table, rather than parsing the results directly out of the spreadsheet, or attempting to cache them.
...
Adding a DocumentService to clean up the FileService, and get Documents well seperated, as it seems likely be pulled out or seperated in the future, there is now a Documents api file as well, for the same reason.
Some other minor changes are just fixing white space to assure our code is linting correctly.
I removed _create_study_workflow_approvals from the base test, as we don't use approvals like this anymore.
2021-07-06 13:10:20 -04:00
Kelly McDonald
9803a04d6d
Make a change so that anything that has a waiting event is labeled in the database as waiting, even if it is sitting around waiting on a user input task that is ready
2021-07-06 11:46:47 -04:00
mike cullerton
8145ff9025
Tests for calling the script
2021-07-02 16:14:19 -04:00
mike cullerton
f647390e1c
Added description and validate_only
2021-07-02 15:51:24 -04:00
mike cullerton
2cb2874a49
Added test and json data for new check_study pb mock api endpoint
2021-07-02 15:26:39 -04:00
mike cullerton
9690c69b6c
added check_study method to protocol_builder service for new endpoint
2021-07-02 15:25:33 -04:00
mike cullerton
cd26654b3a
Script to call new pb mock api endpoint `check_study`
2021-07-02 15:21:35 -04:00
Mike Cullerton
7406bf7da1
Merge pull request #330 from sartography/partial_testing
...
Partial testing
2021-07-02 10:27:41 -04:00
Nile Walker
a27073fd7e
Delete settings.json
2021-07-02 09:53:53 -04:00
Nile Walker
6e07d9d1cb
Delete launch.json
2021-07-02 09:53:46 -04:00
Mike Cullerton
98d641f54d
Merge branch 'dev' into partial_testing
2021-06-30 16:13:31 -04:00
Mike Cullerton
fafa79a07d
Merge pull request #326 from sartography/346-waiting-task-schedule
...
346 waiting task schedule
2021-06-30 11:41:34 -04:00
NWalker4483
508ef1ff2b
Readded exit_at to workflow param
2021-06-30 11:15:48 -04:00
Dan
9a32fadc2f
Merge branch 'dev' into 346-waiting-task-schedule
...
# Conflicts:
# Pipfile.lock
# crc/services/workflow_service.py
2021-06-30 10:14:37 -04:00
Dan
a79ba22410
fixes to get the tests passing. We were missing a dependency in the Pipfile and the data_store had some invalid imports.
2021-06-30 10:06:57 -04:00
NWalker4483
2ba52a7095
Merge remote-tracking branch 'origin/HEAD' into partial_testing
2021-06-29 11:21:49 -04:00
Dan
187221537b
fixing a corner case around file_data attributes.
2021-06-25 16:18:28 -04:00
Dan
628a587d97
We weren't committing to the database in the correct spot, so the delete wasn't sticking, and we were ending up with test workflows showing up in the main interface.
2021-06-23 16:39:58 -04:00
Dan Funk
e4140dec9f
Merge pull request #321 from sartography/dependabot/pip/deploy/urllib3-1.26.5
...
Bump urllib3 from 1.26.4 to 1.26.5 in /deploy
2021-06-22 18:07:50 -04:00
dependabot[bot]
b2b213ff5d
Bump urllib3 from 1.26.4 to 1.26.5 in /deploy
...
Bumps [urllib3](https://github.com/urllib3/urllib3 ) from 1.26.4 to 1.26.5.
- [Release notes](https://github.com/urllib3/urllib3/releases )
- [Changelog](https://github.com/urllib3/urllib3/blob/main/CHANGES.rst )
- [Commits](https://github.com/urllib3/urllib3/compare/1.26.4...1.26.5 )
---
updated-dependencies:
- dependency-name: urllib3
dependency-type: direct:production
...
Signed-off-by: dependabot[bot] <support@github.com>
2021-06-22 21:43:13 +00:00
Dan Funk
48bf721b23
Merge pull request #331 from sartography/bug/356_duplicate_workflow
...
Bug/356 duplicate workflow
2021-06-22 17:42:24 -04:00
Dan
92ca506c8e
Calls to eval no longer return the data, rather it will accept and return a key, allowing the front end to cache similar queries and not re-execute them.
2021-06-22 17:23:18 -04:00
Dan
61ad371680
Clean up the file api so we don't have a bunch of extra stuff in there. Just include the raw data from the document spraedsheet if it is available.
2021-06-22 15:08:08 -04:00
Dan
1f3febe2df
Fix the panda warnings, which means we only support xlsx files now.
...
Include the document details when reutnring a file from the file model.
Improve the validation of file form elements.
2021-06-22 14:58:52 -04:00
NWalker4483
369b518384
Removed WorkflowService.delete_test_data()
2021-06-22 11:29:00 -04:00
Dan
0722a4bf13
Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously.
...
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
2021-06-18 17:00:10 -04:00
Dan
07eb3f9ca8
Moving metrics into SpiffWorkflow so we can run the performance metrics deeply across both systems simultaniously.
...
Upgrading libraries.
Fixing deprication issue with Pandas and numpy.
We can only process xlsx files now, plain oldschool xls is fully removed.
2021-06-18 16:41:55 -04:00
NWalker4483
4ca94b39ce
Merge branch 'dev' of https://github.com/sartography/cr-connect-workflow into partial_testing
2021-06-17 15:12:28 -04:00
Dan Funk
19d63e2aa2
Merge pull request #328 from sartography/restart-workflow-programmatically-347
...
Restart workflow programmatically #347
2021-06-17 10:36:46 -04:00
Dan Funk
f2ec620794
Merge pull request #329 from sartography/bug/356_duplicate_workflow
...
delete workflow after validating
2021-06-17 10:27:47 -04:00
Dan
a4caae8d64
when validating, we need to take every step to remove the workflows we create during the validation.
2021-06-16 14:40:20 -04:00
Dan
acae6030f5
The API for evaluating python expressions should not raise an error, it can simply return a result of false, and provide an error to explain the problem. In this way the front end doesn't error out when it's running the script tasks but doesn't have enough information to get a valid response back.
...
The validation should take into account that repeating sections must be evaluated in the context of the data within the repeating section, not outside of it.
2021-06-15 16:17:15 -04:00
mike cullerton
94e730d04e
Test script validation
2021-06-15 11:15:31 -04:00