alicia pritchett
5dfb3153d1
Fixes #639 - Pending Approvals Panel No longer displaying
2022-02-27 12:21:38 -05:00
Dan
ebbb04a1af
Fixing failing validation.
2022-02-27 10:00:44 -05:00
Dan Funk
9b004d0dc6
Merge pull request #462 from sartography/feature/delete-variable-script-584
...
Feature/delete variable script #584
2022-02-25 16:19:51 -05:00
mike cullerton
f2c97f80d5
Merge branch 'dev' into feature/delete-variable-script-584
...
# Conflicts:
# Pipfile.lock
2022-02-25 15:54:34 -05:00
Dan Funk
140de7ed03
Merge pull request #473 from sartography/nonetype-displayname-error-632
...
Nonetype displayname error #632
2022-02-25 15:41:14 -05:00
mike cullerton
531802f927
Make sure we don't try to get WorkflowMetadata if the spec does not exist
...
This was raising a 500 error
2022-02-25 14:41:58 -05:00
Dan Funk
18802d6732
Merge pull request #468 from sartography/chore/performance
...
Performance Improvements:
2022-02-25 12:10:47 -05:00
Dan Funk
b6af80f6de
Merge pull request #469 from sartography/feature/modify-spreadsheet-624
...
modify spreadsheet #624
2022-02-25 10:29:37 -05:00
Dan Funk
5ff84d74f1
Merge pull request #464 from sartography/feature/start-workflow-602
...
Feature/start workflow #602
2022-02-25 10:28:26 -05:00
Dan
3944d00e88
Removing an unused / rogue variable.
...
Adding a logger warning for very large workflow json data.
2022-02-25 09:59:41 -05:00
mike cullerton
9d2436b375
Typo calling script with keywords
2022-02-25 08:18:07 -05:00
Dan
e61ca471db
remove all the @timeit from method calls.
2022-02-24 21:06:22 -05:00
Dan
dde8873c9e
1. defer the loading of the bpmn_json when loading the workflow model. It can be stupidly larger. (see models/workflow.py)
...
2. Shave a little more time off the reset by not re-creating the whole WorkflowProcessor
cleaning up all the firsttime/sincetime statements.
2022-02-24 20:56:57 -05:00
Dan
3442655bd1
Performance Improvements:
...
1. Avoid ever re-generating the list of scripts that can be used in a script task. Terribly expensive as we call eval constantly, and it never ever changes once the app starts. (see script.py changes, and comments)
2. Cache the DocumentStatus list in the flask session, so we calculate it at most once per API Call. It's at least .25 seconds per call. (see study_sevice)
3. We called UserFileService.get_files_for_study (which runs a db query EVERY time) for every possible document type. Now we run the query once (study service line 321)
4. When returning a workflow, we looped through every single task in that workflow's navigation, and called the expensive spiff_task_to_api_task just to figure out it's proper display name. We run a much faster and more efficient method to calculate the display name naow (see workflow_service on lie 680, and 799)
5. A hellton of @timeit and sincetime() calls, that I want to leave in, to help debug any slowness on production.
2022-02-24 14:25:42 -05:00
mike cullerton
ed0499a573
Make sure we have a workflow.
...
Raise an ApiError with the workflow_spec_id if we cannot find a workflow
2022-02-24 12:37:25 -05:00
mike cullerton
c1606a20a5
Don't call an api endpoint from a script.
2022-02-24 11:14:24 -05:00
mike cullerton
e1bd301e41
Merge branch 'dev' into feature/start-workflow-602
2022-02-24 10:36:38 -05:00
mike cullerton
0b3187889d
We now raise an error if the spreadsheet does not exist.
...
Added test for case where the spreadsheet does not exist
2022-02-24 10:25:34 -05:00
mike cullerton
1fe1ce2e22
Merge branch 'dev' into feature/modify-spreadsheet-624
2022-02-24 09:42:53 -05:00
Dan Funk
33dc1f0868
Merge pull request #465 from sartography/bug/628_jinja_template_errors
...
fix to assure we produce a usable error message
2022-02-24 08:50:41 -05:00
Dan Funk
e8617038ab
Merge pull request #461 from sartography/bug/missing-executabe-option-601
...
Bug/missing executabe option #601
2022-02-24 08:46:46 -05:00
mike cullerton
d378078d6f
Change so that we always use the current workflow
2022-02-23 15:18:03 -05:00
mike cullerton
b6a39dfd25
Script to insert data into an existing (irb_document) spreadsheet.
...
Requires `upload_workflow_id`, `irb_doc_code`, `cell`, and `text` parameters.
The cell parameter should be something like 'B21'
2022-02-23 14:29:50 -05:00
Dan
23a43c0472
fix to assure we produce a usable error message
2022-02-23 11:53:24 -05:00
mike cullerton
41d562ca26
Changed code in error message
2022-02-22 14:41:30 -05:00
mike cullerton
1860509c1e
Fixed error message
2022-02-22 14:39:49 -05:00
mike cullerton
a9326d29e2
Script to start workflow programmatically.
...
Requires a workflow_spec_id to restart
2022-02-22 14:37:12 -05:00
alicia pritchett
095856d3c7
Fixes a bug so that you can reference later fields (and they'll validate
2022-02-22 10:18:09 -05:00
Dan
65ffc37787
fixing a bug in Spiff that was preventing our tests from passing.
2022-02-21 14:30:36 -05:00
mike cullerton
b20ccf02ae
Fix test class names
2022-02-21 12:56:04 -05:00
mike cullerton
8c66a35f36
Script to delete variables from task data
2022-02-21 12:55:03 -05:00
mike cullerton
a830657ebd
raise ApiError when isExecutable tag is missing.
...
Unsure how this would actually happen, since it should get set to False if box is unchecked.
2022-02-21 10:17:01 -05:00
Dan
24f33ec9c9
Merge branch 'chore/variables-in-forms-550' of github.com:sartography/cr-connect-workflow into chore/variables-in-forms-550
2022-02-21 09:57:19 -05:00
alicia pritchett
bb3d3a5907
Merge remote-tracking branch 'origin/chore/variables-in-forms-550' into chore/variables-in-forms-550
2022-02-21 08:56:11 -05:00
Dan
06b9b653b2
don't overwrite the field.label during an eval. It should remain as it is, just assure that it /can/ be evaluated.
2022-02-19 17:43:12 -05:00
Dan
4f32cf753c
Merge branch 'chore/variables-in-forms-550' of github.com:sartography/cr-connect-workflow into chore/variables-in-forms-550
2022-02-18 17:20:10 -05:00
Dan
c3e52f960b
Minor stuff to help digging into validation of current workflows.
2022-02-18 17:20:04 -05:00
Dan
a7f591d2ac
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-18 17:19:01 -05:00
alicia pritchett
3b48435411
Merge branch 'master' into chore/variables-in-forms-550
2022-02-18 13:23:33 -05:00
alicia pritchett
4b92b0ee71
oops
2022-02-18 11:57:13 -05:00
alicia pritchett
e7c0e66f86
Merge remote-tracking branch 'origin/chore/variables-in-forms-550' into chore/variables-in-forms-550
2022-02-18 11:41:15 -05:00
alicia pritchett
a912e8ef49
validate checks/catches default value and label value
2022-02-18 11:41:07 -05:00
Dan
779ac38513
Fix validate-all
2022-02-18 11:40:58 -05:00
Dan
b90be07bca
Remove these bloodly log files from the repo.
2022-02-18 11:40:10 -05:00
Dan
e91be2a54d
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-18 11:27:58 -05:00
Dan
635a112796
still trying to fix a rogue test.
2022-02-18 10:41:24 -05:00
Dan
6adf1107fe
Trying to figure out why these files are not the same on testing.
2022-02-18 10:12:36 -05:00
alicia pritchett
06dc20657b
Fixing various BPMN's for tests
2022-02-17 17:29:44 -05:00
alicia pritchett
a5acd9b07e
Merge branch 'dev' into chore/variables-in-forms-550
2022-02-17 15:04:41 -05:00
Dan
c2c6410bbb
Assure we update the workflow model, so we don't keep reporting the error over and over again.
2022-02-17 14:12:31 -05:00
